Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 02:45 PM, Michael Niedermayer wrote: On Wed, Jan 06, 2016 at 10:26:08AM +, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: You're welcome to fix this issue on the MPlayer side, since it seems you've done that before. If there were a fourcc (or codec_tag) "SMI " t

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 10:26:08AM +, Carl Eugen Hoyos wrote: > Mats Peterson ffmpeg.org> writes: > > > You're welcome to fix this issue on the MPlayer side, > > since it seems you've done that before. > > If there were a fourcc (or codec_tag) "SMI " this > would be trivial to fix in MPlay

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:53 AM, Mats Peterson wrote: FFmpeg still writes broken mkv files, for the record. It doesn't include the palette, if any, in the stsd atom. But that's a later issue, one that I'm currently not concerned about since I use mkvmerge to remux. To be perfectly clear, the private dat

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 12:22 PM, Mats Peterson wrote: order to procuce a working Matroska file from a QuickTime file. Produce, not procuce. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:53 AM, Mats Peterson wrote: FFmpeg still writes broken mkv files, for the record. It doesn't include the palette, if any, in the stsd atom. But that's a later issue, one that I'm currently not concerned about since I use mkvmerge to remux. That's just one of the QuickTime to M

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:26 AM, Carl Eugen Hoyos wrote: But this codec_tag does not exist, FFmpeg used to write broken mkv files that contained only part of the stsd atom. FFmpeg still writes broken mkv files, for the record. It doesn't include the palette, if any, in the stsd atom. But that's a later

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:32 AM, wm4 wrote: Uh. You know, they accept patches, just like FFmpeg. You don't say. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread wm4
On Wed, 6 Jan 2016 11:20:25 +0100 Mats Peterson wrote: > On 01/06/2016 11:16 AM, Mats Peterson wrote: > > On 01/06/2016 11:12 AM, Mats Peterson wrote: > >> On 01/06/2016 11:06 AM, Carl Eugen Hoyos wrote: > >>> Mats Peterson ffmpeg.org> writes: > >>> > >>> [...] > >>> > >>> The patch is ok, t

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:26 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: You're welcome to fix this issue on the MPlayer side, since it seems you've done that before. If there were a fourcc (or codec_tag) "SMI " this would be trivial to fix in MPlayer. But this codec_tag does not ex

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > You're welcome to fix this issue on the MPlayer side, > since it seems you've done that before. If there were a fourcc (or codec_tag) "SMI " this would be trivial to fix in MPlayer. But this codec_tag does not exist, FFmpeg used to write broken mkv files th

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:16 AM, Mats Peterson wrote: On 01/06/2016 11:12 AM, Mats Peterson wrote: On 01/06/2016 11:06 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: [...] The patch is ok, the commit message not: This is not related to MPlayer but old lavf producing broken files. The c

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:12 AM, Mats Peterson wrote: On 01/06/2016 11:06 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: [...] The patch is ok, the commit message not: This is not related to MPlayer but old lavf producing broken files. The codec_tag SMI does not exist, SVQ3 should be ex

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:06 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: [...] The patch is ok, the commit message not: This is not related to MPlayer but old lavf producing broken files. The codec_tag SMI does not exist, SVQ3 should be exported. Carl Eugen _

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: [...] The patch is ok, the commit message not: This is not related to MPlayer but old lavf producing broken files. The codec_tag SMI does not exist, SVQ3 should be exported. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 10:53 AM, Paul B Mahol wrote: Yes, fix broken MPlayer instead. Me? :) Hardly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 10:41 AM, wm4 wrote: On Wed, 6 Jan 2016 04:33:16 +0100 Mats Peterson wrote: At least in this case, MPlayer seems to look at the codec tag rather than the codec ID in order to determine the codec. Therefore, the 'fourcc' variable needs to be set to 'SVQ3' as well, which is later c

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Paul B Mahol
On 1/6/16, wm4 wrote: > On Wed, 6 Jan 2016 04:33:16 +0100 > Mats Peterson wrote: > >> At least in this case, MPlayer seems to look at the codec tag rather >> than the codec ID in order to determine the codec. Therefore, the >> 'fourcc' variable needs to be set to 'SVQ3' as well, which is later >>

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread wm4
On Wed, 6 Jan 2016 04:33:16 +0100 Mats Peterson wrote: > At least in this case, MPlayer seems to look at the codec tag rather > than the codec ID in order to determine the codec. Therefore, the > 'fourcc' variable needs to be set to 'SVQ3' as well, which is later > copied to st->codec->codec_tag