Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-20 Thread Douglas Marsh
On 2017-10-19 20:08, Douglas Marsh wrote: On 2017-10-18 12:23, Dave Rice wrote: [...] Updated. From 1e5ff78fec9b13eccac9a96acc358bbfd6a7015d Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Wed, 18 Oct 2017 15:21:46 -0400 Subject: [PATCH] libavdevice/decklink: 32 bit audio

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-19 Thread Douglas Marsh
On 2017-10-19 20:08, Douglas Marsh wrote: Is that a commit (1e5ff78fec9b13eccac9a96acc358bbfd6a7015d) I should check out on my Decklink and try or is there another one I should try? Will try to get to testing it this weekend. Nevermind I found this: * commit

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-19 Thread Douglas Marsh
On 2017-10-18 12:23, Dave Rice wrote: [...] Updated. From 1e5ff78fec9b13eccac9a96acc358bbfd6a7015d Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Wed, 18 Oct 2017 15:21:46 -0400 Subject: [PATCH] libavdevice/decklink: 32 bit audio support Is that a commit

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-18 Thread Marton Balint
On Wed, 18 Oct 2017, Dave Rice wrote: On Oct 18, 2017, at 3:07 PM, Marton Balint wrote: On Mon, 16 Oct 2017, Dave Rice wrote: Hi, I tested this with my Ultrastudio Express and confirmed that I'm getting higher bit depth recordings with the abitscope filter. This patch

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-18 Thread Dave Rice
> On Oct 18, 2017, at 3:07 PM, Marton Balint wrote: > > On Mon, 16 Oct 2017, Dave Rice wrote: > >> Hi, >> >> I tested this with my Ultrastudio Express and confirmed that I'm getting >> higher bit depth recordings with the abitscope filter. This patch adds an >> option to get

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-18 Thread Marton Balint
On Mon, 16 Oct 2017, Dave Rice wrote: Hi, I tested this with my Ultrastudio Express and confirmed that I'm getting higher bit depth recordings with the abitscope filter. This patch adds an option to get 32 bit audio as an input with the decklink device (beforehand only 16 bit audio was

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-18 Thread Dave Rice
> On Oct 17, 2017, at 3:30 PM, Douglas Marsh wrote: > > On 2017-10-17 09:10, Dave Rice wrote: > -audio_depth .D.. audio bitdepth (from 0 to 1) (default 16bits) 16bits .D.. > >>> Hmm, first patch might be enough. >>

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Douglas Marsh
On 2017-10-17 09:10, Dave Rice wrote: -audio_depth .D.. audio bitdepth (from 0 to 1) (default 16bits) 16bits .D.. Hmm, first patch might be enough. Sounds good to me. Unless anyone prefers "-audio_depth thirtytwo" :-D Dave Rice Yeah

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Douglas Marsh
On 2017-10-17 06:22, Dave Rice wrote: I don't see there to be an AV_OPT_TYPE_ENUM. Could you point out how this works from an example? Alternatively since the decklink sdk only supports 2 bit depths (16 and 32), I could use a boolean here if that makes more sense. Dave Rice I am unsure about

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Dave Rice
> On Oct 17, 2017, at 11:48 AM, Paul B Mahol wrote: > > On 10/17/17, Moritz Barsnick wrote: >> On Tue, Oct 17, 2017 at 11:12:46 -0400, Dave Rice wrote: >> >>> Thanks for pointing me in the right direction. I am attaching an >>> updated patch below; however,

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Paul B Mahol
On 10/17/17, Moritz Barsnick wrote: > On Tue, Oct 17, 2017 at 11:12:46 -0400, Dave Rice wrote: > >> Thanks for pointing me in the right direction. I am attaching an >> updated patch below; however, after removing my 16/32 and using the >> enumeration method (with the patch

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Moritz Barsnick
On Tue, Oct 17, 2017 at 11:12:46 -0400, Dave Rice wrote: > Thanks for pointing me in the right direction. I am attaching an > updated patch below; however, after removing my 16/32 and using the > enumeration method (with the patch below), it accepts any value > between AUDIO_BITDEPTH_LOWEST and

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Dave Rice
Hi Moritz, > On Oct 17, 2017, at 10:40 AM, Moritz Barsnick wrote: > > On Tue, Oct 17, 2017 at 09:22:27 -0400, Dave Rice wrote: --- a/libavdevice/decklink_dec_c.c +++ b/libavdevice/decklink_dec_c.c @@ -72,6 +72,7 @@ static const AVOption options[] = { {

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Moritz Barsnick
On Tue, Oct 17, 2017 at 09:22:27 -0400, Dave Rice wrote: > >> --- a/libavdevice/decklink_dec_c.c > >> +++ b/libavdevice/decklink_dec_c.c > >> @@ -72,6 +72,7 @@ static const AVOption options[] = { > >> { "wallclock", NULL, 0, > >> AV_OPT_TYPE_CONST,

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Dave Rice
Hi Paul, > On Oct 16, 2017, at 3:56 PM, Paul B Mahol wrote: > > On 10/16/17, Dave Rice > wrote: >> Hi, >> >> I tested this with my Ultrastudio Express and confirmed that I'm getting >> higher bit depth recordings with the abitscope

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-16 Thread Paul B Mahol
On 10/16/17, Dave Rice wrote: > Hi, > > I tested this with my Ultrastudio Express and confirmed that I'm getting > higher bit depth recordings with the abitscope filter. This patch adds an > option to get 32 bit audio as an input with the decklink device (beforehand > only 16