Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-14 Thread Ganesh Ajjanagadde
On Wed, Jan 13, 2016 at 10:48 AM, Ganesh Ajjanagadde wrote: > On Wed, Jan 13, 2016 at 4:05 AM, wm4 wrote: >> On Tue, 12 Jan 2016 10:07:08 -0500 >> Ganesh Ajjanagadde wrote: [...] > > > I apply them only when I am convinced universally of their value, and > no one objects to it. Yes, even you wm4

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-13 Thread Ganesh Ajjanagadde
On Wed, Jan 13, 2016 at 1:14 PM, wm4 wrote: > On Wed, 13 Jan 2016 10:48:01 -0500 > Ganesh Ajjanagadde wrote: > >> On Wed, Jan 13, 2016 at 4:05 AM, wm4 wrote: >> > On Tue, 12 Jan 2016 10:07:08 -0500 >> > Ganesh Ajjanagadde wrote: >> > >> >> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje >>

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-13 Thread wm4
On Wed, 13 Jan 2016 10:48:01 -0500 Ganesh Ajjanagadde wrote: > On Wed, Jan 13, 2016 at 4:05 AM, wm4 wrote: > > On Tue, 12 Jan 2016 10:07:08 -0500 > > Ganesh Ajjanagadde wrote: > > > >> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje > >> wrote: > >> > Hi, > >> > > >> > On Tue, Jan 12, 2

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-13 Thread Ganesh Ajjanagadde
On Wed, Jan 13, 2016 at 4:05 AM, wm4 wrote: > On Tue, 12 Jan 2016 10:07:08 -0500 > Ganesh Ajjanagadde wrote: > >> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje wrote: >> > Hi, >> > >> > On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde >> > wrote: >> > >> >> On Tue, Jan 12, 2016 at 4:38 A

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-13 Thread wm4
On Tue, 12 Jan 2016 10:07:08 -0500 Ganesh Ajjanagadde wrote: > On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde > > wrote: > > > >> On Tue, Jan 12, 2016 at 4:38 AM, wm4 wrote: > >> > This makes no sense. Even if fc

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Reynaldo H. Verdejo Pinochet
Hi Ganesh Somehow I'm missing your ffserver patches on this thread, had to check them on gmame. Probably something odd with my local filters. Commenting offline for the time being: 09/13 Its OK but actually introduces the error (- }) you fix on 10/13... clean up accordingly 11, 12 & 13 LGTM Be

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Ganesh Ajjanagadde
On Tue, Jan 12, 2016 at 1:18 PM, Paul B Mahol wrote: > On 1/12/16, Ganesh Ajjanagadde wrote: >> On Tue, Jan 12, 2016 at 10:29 AM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde >>> wrote: >>> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Paul B Mahol
On 1/12/16, Ganesh Ajjanagadde wrote: > On Tue, Jan 12, 2016 at 10:29 AM, Ronald S. Bultje > wrote: >> Hi, >> >> On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde >> wrote: >> >>> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje >>> wrote: >>> > Hi, >>> > >>> > On Tue, Jan 12, 2016 at 7:52

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Ganesh Ajjanagadde
On Tue, Jan 12, 2016 at 10:29 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde > wrote: > >> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde >> > wrote: >> > >> >> On Tue

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Ronald S. Bultje
Hi, On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde wrote: > On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde > > wrote: > > > >> On Tue, Jan 12, 2016 at 4:38 AM, wm4 wrote: > >> > This makes no sense. Even if

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Ganesh Ajjanagadde
On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde > wrote: > >> On Tue, Jan 12, 2016 at 4:38 AM, wm4 wrote: >> > This makes no sense. Even if fclose() should fail for >> > whatever obscure reasons there might be, reading alread

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Ronald S. Bultje
Hi, On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde wrote: > On Tue, Jan 12, 2016 at 4:38 AM, wm4 wrote: > > This makes no sense. Even if fclose() should fail for > > whatever obscure reasons there might be, reading already worked > > without errors, and thus closing failure has no meaning

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread Ganesh Ajjanagadde
On Tue, Jan 12, 2016 at 4:38 AM, wm4 wrote: > On Mon, 11 Jan 2016 23:25:02 -0500 > Ganesh Ajjanagadde wrote: > >> Some preliminary work has already been done on fclose checking. This >> completes >> the work, modulo a few exceptions: > > 1. Printing warnings is completely useless unless maybe in

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-12 Thread wm4
On Mon, 11 Jan 2016 23:25:02 -0500 Ganesh Ajjanagadde wrote: > Some preliminary work has already been done on fclose checking. This completes > the work, modulo a few exceptions: 1. Printing warnings is completely useless unless maybe in ffmpeg.c interactive usage (if the user has good eyes). Fo

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

2016-01-11 Thread Ganesh Ajjanagadde
On Mon, Jan 11, 2016 at 11:25 PM, Ganesh Ajjanagadde wrote: [...] > > In the case of ffserver, some nearby improvements were done. Most serious was > the > build failure on non Linux machines. This was a completely bogus one; an error made while rebasing/squashing stuff. Sorry for the noise. Ame