Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Mon, Feb 05, 2018 at 12:27:20AM +0100, Michael Niedermayer wrote: > On Sun, Feb 04, 2018 at 04:07:26PM +0100, Aurelien Jacobs wrote: > > On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote: > > > On 20 January 2018 at 17:26, Aurelien Jacobs wrote: > > > > >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Sun, Feb 04, 2018 at 04:07:26PM +0100, Aurelien Jacobs wrote: > On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote: > > On 20 January 2018 at 17:26, Aurelien Jacobs wrote: > > > > > On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote: > > > >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote: > On 20 January 2018 at 17:26, Aurelien Jacobs wrote: > > > On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote: > > > 2018-01-14 14:06 GMT+01:00 Aurelien Jacobs : > > > > > > >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 20 January 2018 at 17:26, Aurelien Jacobs wrote: > On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote: > > 2018-01-14 14:06 GMT+01:00 Aurelien Jacobs : > > > > > Well, here is an updated patch which uses codec tags for the decoder > and > > >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 20 January 2018 at 17:25, Aurelien Jacobs wrote: > On Sun, Jan 14, 2018 at 05:19:12PM +, Rostislav Pehlivanov wrote: > > On 14 January 2018 at 13:06, Aurelien Jacobs wrote: > > > > > On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Sun, Jan 14, 2018 at 10:54:34PM +0100, Carl Eugen Hoyos wrote: > 2018-01-14 14:06 GMT+01:00 Aurelien Jacobs : > > > Well, here is an updated patch which uses codec tags for the decoder and > > profile for the encoder. > > Sorry but I object to this patch: > We should not

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Sun, Jan 14, 2018 at 05:19:12PM +, Rostislav Pehlivanov wrote: > On 14 January 2018 at 13:06, Aurelien Jacobs wrote: > > > On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote: > > > On 9 January 2018 at 14:07, Rostislav Pehlivanov >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-14 14:06 GMT+01:00 Aurelien Jacobs : > Well, here is an updated patch which uses codec tags for the decoder and > profile for the encoder. Sorry but I object to this patch: We should not invent codec_tags. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 14 January 2018 at 13:06, Aurelien Jacobs wrote: > On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote: > > On 9 January 2018 at 14:07, Rostislav Pehlivanov > > wrote: > > > > > > > > > > > On 9 January 2018 at 09:00, Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Tue, Jan 09, 2018 at 02:21:02PM +, Rostislav Pehlivanov wrote: > On 9 January 2018 at 14:07, Rostislav Pehlivanov > wrote: > > > > > > > On 9 January 2018 at 09:00, Hendrik Leppkes wrote: > > > >> On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Tue, Jan 9, 2018 at 3:21 PM, Rostislav Pehlivanov wrote: > On 9 January 2018 at 14:07, Rostislav Pehlivanov > wrote: > >> >> >> On 9 January 2018 at 09:00, Hendrik Leppkes wrote: >> >>> On Tue, Jan 9, 2018 at 9:33 AM, Hendrik

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 9 January 2018 at 14:07, Rostislav Pehlivanov wrote: > > > On 9 January 2018 at 09:00, Hendrik Leppkes wrote: > >> On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes >> wrote: >> > On Tue, Jan 9, 2018 at 5:07 AM, Rostislav

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 9 January 2018 at 09:00, Hendrik Leppkes wrote: > On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes > wrote: > > On Tue, Jan 9, 2018 at 5:07 AM, Rostislav Pehlivanov > > wrote: > >> > >>> Anyway, all this discussion is moot as

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Tue, Jan 9, 2018 at 9:33 AM, Hendrik Leppkes wrote: > On Tue, Jan 9, 2018 at 5:07 AM, Rostislav Pehlivanov > wrote: >> >>> Anyway, all this discussion is moot as Hendrik pointed out that profile >>> can't be set outside of lavc to determine a decoder

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Tue, Jan 9, 2018 at 5:07 AM, Rostislav Pehlivanov wrote: > >> Anyway, all this discussion is moot as Hendrik pointed out that profile >> can't be set outside of lavc to determine a decoder behavior. >> > > What, based on a comment in lavc? Comments there describe the api

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-09 5:07 GMT+01:00 Rostislav Pehlivanov : > On 9 January 2018 at 01:21, Aurelien Jacobs wrote: >> So what ? It won't increase binary bloat unless we ever reach more >> than 2^32 codecs. >> And regarding public API bloat, the 2 options are: >> 1)

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 9 January 2018 at 01:21, Aurelien Jacobs wrote: > On Mon, Jan 08, 2018 at 12:38:19AM +, Rostislav Pehlivanov wrote: > > On 7 January 2018 at 22:54, Aurelien Jacobs wrote: > > > > > On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote: >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Mon, Jan 08, 2018 at 12:38:19AM +, Rostislav Pehlivanov wrote: > On 7 January 2018 at 22:54, Aurelien Jacobs wrote: > > > On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote: > > > On 6 January 2018 at 16:48, Aurelien Jacobs wrote: > >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Mon, Jan 08, 2018 at 01:27:16PM +0100, Carl Eugen Hoyos wrote: > 2018-01-08 11:32 GMT+01:00 Hendrik Leppkes : > > On Mon, Jan 8, 2018 at 1:38 AM, Rostislav Pehlivanov > > wrote: > >> > >> That's okay - for encoding switch the profile depending on both

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-08 13:37 GMT+01:00 Hendrik Leppkes : > On Mon, Jan 8, 2018 at 1:27 PM, Carl Eugen Hoyos wrote: >> 2018-01-08 11:32 GMT+01:00 Hendrik Leppkes : >>> On Mon, Jan 8, 2018 at 1:38 AM, Rostislav Pehlivanov >>>

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Mon, Jan 8, 2018 at 1:27 PM, Carl Eugen Hoyos wrote: > 2018-01-08 11:32 GMT+01:00 Hendrik Leppkes : >> On Mon, Jan 8, 2018 at 1:38 AM, Rostislav Pehlivanov >> wrote: >>> >>> That's okay - for encoding switch the profile depending

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-01-08 11:32 GMT+01:00 Hendrik Leppkes : > On Mon, Jan 8, 2018 at 1:38 AM, Rostislav Pehlivanov > wrote: >> >> That's okay - for encoding switch the profile depending on both the >> avctx->profile setting and the samplerate and list all supported >>

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Mon, Jan 8, 2018 at 1:38 AM, Rostislav Pehlivanov wrote: > > That's okay - for encoding switch the profile depending on both the > avctx->profile setting and the samplerate and list all supported > samplerates for all profiles in the AVCodec structure. We do something >

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Mon, 8 Jan 2018 00:38:19 +, Rostislav Pehlivanov wrote: > > > No, don't add a new codec ID for what is very obviously a profile. > > Anyway, I do understand how I could use a profile instead of a new codec > > ID, but I really don't understand what advantage it would

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 7 January 2018 at 22:54, Aurelien Jacobs wrote: > On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote: > > On 6 January 2018 at 16:48, Aurelien Jacobs wrote: > > > > > --- > > > Changelog | 2 +- > > > configure

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On Sun, Jan 07, 2018 at 05:23:24PM +, Rostislav Pehlivanov wrote: > On 6 January 2018 at 16:48, Aurelien Jacobs wrote: > > > --- > > Changelog | 2 +- > > configure | 2 + > > libavcodec/Makefile | 2 + > > libavcodec/allcodecs.c |

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

On 6 January 2018 at 16:48, Aurelien Jacobs wrote: > --- > Changelog | 2 +- > configure | 2 + > libavcodec/Makefile | 2 + > libavcodec/allcodecs.c | 1 + > libavcodec/aptx.c | 352 ++ >