>Look at spdif in wav.
Indeed, I missed that, spdif and s337m are very similar technically, and it
means I have to rework my patch for the integration of s337m in wavdec, but I
still do not catch why another demuxer should be created : spdifdec.c is
actually quite similar to the existing
Am Do., 8. Aug. 2019 um 14:18 Uhr schrieb Gaullier Nicolas
:
>
> >> +int avpriv_s337m_probe_stream(void *avc, AVIOContext *pb, AVStream **st,
> >> int size);
> > This is to the best of my knowledge not acceptable (to have a public
> > function for a particular
> > format), instead create a new
>> +int avpriv_s337m_probe_stream(void *avc, AVIOContext *pb, AVStream **st,
>> int size);
>Sorry for not commenting earlier:
You're welcome, a few days is not that much, particularly in the middle of the
summer!
>This is to the best of my knowledge not acceptable (to have a public function
>Ah, so it's time and not phase? Renaming the #defines to make that clearer
>would be nice. Other than that, this isn't a huge issue
I assume the start of the packet to be synched with the start of "a" video
frame, I think there is no use case where pcm and video are not synced, at
least when
tor 2019-08-08 klockan 10:28 + skrev Gaullier Nicolas:
> > > +if (pos < size - 9 && pos >=
> > > S337M_PROBE_GUARDBAND_MIN_BYTES)
> > I think this 9 should be an 11 or 12..
> Indeed, thank you, my mistake.
>
> > This isn't quite what I meant by turning it into an integer test :)
> >
Am Di., 6. Aug. 2019 um 17:08 Uhr schrieb Nicolas Gaullier
:
>
> ---
> libavformat/s337m.c | 64
> -
> libavformat/s337m.h | 64
> +
> 2 files changed, 117 insertions(+), 11 deletions(-)
>
>> +if (pos < size - 9 && pos >= S337M_PROBE_GUARDBAND_MIN_BYTES)
>I think this 9 should be an 11 or 12..
Indeed, thank you, my mistake.
>This isn't quite what I meant by turning it into an integer test :) this will
>likely just be rounded to zero. I meant that things could likely be
tis 2019-08-06 klockan 17:08 +0200 skrev Nicolas Gaullier:
> +int avpriv_s337m_probe_stream(void *avc, AVIOContext *pb, AVStream **st, int
> size)
> +{
> +if ( size >= S337M_MIN_OFFSET &&
> +((*st)->codecpar->codec_id == AV_CODEC_ID_PCM_S16LE ||
> (*st)->codecpar->codec_id ==
