Re: [FFmpeg-devel] Fix ctts_index calculation

On Fri, Feb 09, 2018 at 02:51:25PM -0800, Sasi Inguva wrote: > The new patch looks good to me. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics:

Re: [FFmpeg-devel] Fix ctts_index calculation

The new patch looks good to me. On Fri, Feb 9, 2018 at 1:34 PM, Xiaohan Wang (王消寒) wrote: > I uploaded a new patch. Is this what you meant? > > I am confused with the code though. In the case *ctts_index == ctts_count, > this while loop will do nothing. Is this what we

Re: [FFmpeg-devel] Fix ctts_index calculation

On Fri, Feb 9, 2018 at 1:34 PM, Xiaohan Wang (王消寒) wrote: > I uploaded a new patch. Is this what you meant? > > I am confused with the code though. In the case *ctts_index == ctts_count, > The problem is when *ctts_index == (ctts_count -1) . if ( (ctts_count- 1) <

Re: [FFmpeg-devel] Fix ctts_index calculation

I uploaded a new patch. Is this what you meant? I am confused with the code though. In the case *ctts_index == ctts_count, this while loop will do nothing. Is this what we want? Also, the "wrong" |ctts_index| will be available outside of this function. How do we make sure it won't cause trouble

Re: [FFmpeg-devel] Fix ctts_index calculation

> > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 5adba52e08..f0bd3e3623 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -3148,7 +3148,7 @@ static int find_prev_closest_index(AVStream *st, > *ctts_index = 0; > *ctts_sample = 0; > for

Re: [FFmpeg-devel] Fix ctts_index calculation

On Fri, Feb 02, 2018 at 05:55:38PM -0800, Xiaohan Wang (王消寒) wrote: > > mov.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 87157b4053de0e044e78db72ef13e8058075c235 > 0001-Fix-ctts_index-calculation.patch > From bb376fd2de5da5f9ecdef41621a579252b899d7d Mon Sep 17 00:00:00 2001