[FFmpeg-devel] [PATCH] avutil/opt.c: fix bug when parsing option
fix these strange behavior: -af flanger=delay=10 [OK] -af flanger=delay=1e1 [OK] -af flanger=delay=1e+1 [Error] -af flanger=delay=0.1 [OK] -af flanger=delay=1e-1 [Error] thank's --- libavutil/opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 505e010..8e9802f 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -219,7 +219,7 @@ static int set_string_number(void *obj, void *target_obj, const AVOption *o, con buf[i++] = *val; } -for (; i sizeof(buf) - 1 val[i] val[i] != '+' val[i] != '-'; i++) +for (; i sizeof(buf) - 1 val[i] (o-type != AV_OPT_TYPE_FLAGS || val[i] != '+' val[i] != '-'); i++) buf[i] = val[i]; buf[i] = 0; -- 1.8.3.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] new webpage design patches
On Sat, 19 Jul 2014 18:16:42 -0800 Lou Logan l...@lrcd.com wrote: On Tue, Jul 15, 2014, at 12:10 AM, Clément Bœsch wrote: - should we restore the hall of shame page, or maybe simply add a Violations linking to a specific query in our trac? I prefer a link to the trac violations. Or no link at all for less clutter. At least one or two responsible authors who gave a shit, or who made honest mistakes, have found their ticket in trac and cleared things up, IIRC. i vote for no shame page unless someone volunteers to keep it updated and deal with authors who come in for help. the last shame page in my opinion turned into a disaster when some developers would not negotiate with authors to try to bring them into compliance. when we had the author on the trac, willing to make changes, an ffmpeg developer would say no, you aren't allowed to distribute ffmpeg at all right now. so the shame author would get tired of that and walk away. fixing nothing. No dedicated shame page is needed. It's a maintenance burden. It is ignored by general users. Its effectiveness is debatable. It makes the project look whiney. fully agree. although it brought attention to some problems, i think it also made us the 'bad guys' to a lot of users of those shamed softwares. libav's shame page is still up, and is completely broken due to libav's bug tracker move and lack of any developers working on it. http://libav.org/shame.html -compn ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] new webpage design patches
On Mon, Jul 21, 2014 at 2:25 PM, compn te...@mi.rr.com wrote: On Sun, 20 Jul 2014 09:20:30 -0800 Lou Logan l...@lrcd.com wrote: On Sat, Jul 19, 2014, at 11:49 PM, Clément Bœsch wrote: libx264 is not always available and not that much common (it requires special permissions), and the avi to mp4 is IMO not that much common: it's not going to improve quality, while mp4 to avi has the benefit of creating videos compatible with old devices, which sounds like a more common use case. I'll disagree with these points from what I've seen from what users tend to be doing and what they are using. But it's a nit. More importantly, the link to John's builds is wrong. Under Linux Static Builds, the link to 64-bit with kernel 2.6.32 and above should be http://johnvansickle.com/ffmpeg/ i can fix this, unless someone beats me to it. Also, the old # anchors have changed. For example, I provided many links to download.html#LinuxBuilds for users on various help resources, but that has changed to download.html#build-linux. We can either revert to the old names, provide a dummy link using the old names, forget about the old names and do nothing, or maybe do some redirection magic. probably revert the name/urls back. i dont think the names are set in stone ? i'd like to see an example so i dont break things further though. I'll fix those two ASAP. I hope the anchors from the download page are the only ones that changed. I don't even remember renaming them. -- db0 - Deby Barbara Lepage http://db0.fr/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avutil/opt.c: fix bug when parsing option
On Mon, Jul 21, 2014 at 02:31:41AM -0700, Muhammad Faiz wrote: fix these strange behavior: -af flanger=delay=10 [OK] -af flanger=delay=1e1 [OK] -af flanger=delay=1e+1 [Error] -af flanger=delay=0.1 [OK] -af flanger=delay=1e-1 [Error] thank's --- libavutil/opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: This patch has a strange side effect. With it gst-libav1.0 (version 1.3.2) gets compiled incorrectly so that when the plugin is loaded by gstreamer it segfaults: ERROR: Caught a segmentation fault while loading plugin file: Please provide a backtrace. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection
On 22.07.2014 02:12, Andreas Cadhalpun wrote:
On 21.07.2014 23:18, Carl Eugen Hoyos wrote:
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes:
This patch has a strange side effect. With it gst-libav1.0
(version 1.3.2) gets compiled incorrectly so that when the
plugin is loaded by gstreamer it segfaults:
ERROR: Caught a segmentation fault while loading plugin file:
Please provide a backtrace.
Attached.
The problem is that in_plugin-long_name is a null pointer.
Attached patch fixes the problem.
Best regards,
Andreas
From 316c472c4d5502743890daa344fbd51aaca5a561 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun andreas.cadhal...@googlemail.com
Date: Tue, 22 Jul 2014 03:32:03 +0200
Subject: [PATCH] libavformat/img2dec.c: Add a long_name to the piped image
demuxers
This fixes segfaults in gst-libav1.0 compiled against FFmpeg 2.3.
---
libavformat/img2dec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
index cda4996..f978007 100644
--- a/libavformat/img2dec.c
+++ b/libavformat/img2dec.c
@@ -666,6 +666,7 @@ static const AVClass imgname ## _class = {\
};\
AVInputFormat ff_image_ ## imgname ## _pipe_demuxer = {\
.name = AV_STRINGIFY(imgname) _pipe,\
+.long_name = NULL_IF_CONFIG_SMALL(piped AV_STRINGIFY(imgname) sequence),\
.priv_data_size = sizeof(VideoDemuxData),\
.read_probe = imgname ## _probe,\
.read_header= ff_img_read_header,\
--
2.0.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection
On Tue, Jul 22, 2014 at 03:34:45AM +0200, Andreas Cadhalpun wrote: On 22.07.2014 02:12, Andreas Cadhalpun wrote: On 21.07.2014 23:18, Carl Eugen Hoyos wrote: Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: This patch has a strange side effect. With it gst-libav1.0 (version 1.3.2) gets compiled incorrectly so that when the plugin is loaded by gstreamer it segfaults: ERROR: Caught a segmentation fault while loading plugin file: Please provide a backtrace. Attached. The problem is that in_plugin-long_name is a null pointer. Attached patch fixes the problem. Best regards, Andreas img2dec.c |1 + 1 file changed, 1 insertion(+) 81880958a8d49da4585ac278c867059912b1b421 libavformat-img2dec.c:Addalong_nametothepipedimagedemuxers.patch From 316c472c4d5502743890daa344fbd51aaca5a561 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun andreas.cadhal...@googlemail.com Date: Tue, 22 Jul 2014 03:32:03 +0200 Subject: [PATCH] libavformat/img2dec.c: Add a long_name to the piped image demuxers This fixes segfaults in gst-libav1.0 compiled against FFmpeg 2.3. applied, also locally backported to release/2.3 having a long name is better than not having one ... but note, long_name can be NULL that is perfectly legal and is the case with --enable-small [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
