Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

2017-01-26 Thread Ronald S. Bultje
Hi, On Wed, Jan 25, 2017 at 8:56 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 26.01.2017 02:26, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Jan 25, 2017 at 8:20 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > >> On 07.01.2017 13:44, Ronald

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 06:43:45AM +0100, wm4 wrote: > On Thu, 26 Jan 2017 03:20:02 +0100 > Michael Niedermayer wrote: > > > On Thu, Jan 26, 2017 at 02:58:07AM +0100, Andreas Cadhalpun wrote: > > > On 26.01.2017 02:29, Ronald S. Bultje wrote: > > > > On Wed, Jan 25, 2017 at

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread Paul Arzelier
You're right, I made a patch for libavformat/utils.c instead. I modified a bit Ben's version and kept only the "spec-compliant flac files do not support ID3 tags" warning, I hope it's okay with you. Paul Le 26/01/2017 à 11:24, wm4 a écrit : On Thu, 26 Jan 2017 11:08:45 +0100 Paul Arzelier

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 12:55:15 +0100 Paul Arzelier wrote: > From a3dc6068fb06722aacea56365f948afdb8df841f Mon Sep 17 00:00:00 2001 > From: Paul Arzelier > Date: Thu, 26 Jan 2017 12:51:33 +0100 > Subject: [PATCH] Ignore ID3 tags if other tags are

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 13:32:08 +0100 Paul Arzelier wrote: > From d84648e1990ad3a12462dfb76990dc7036f5f082 Mon Sep 17 00:00:00 2001 > From: Polochon-street > Date: Thu, 26 Jan 2017 13:25:22 +0100 > Subject: [PATCH] Ignore ID3 tags if other tags are

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread Paul Arzelier
Alright, attached is the last version (I hope!) Paul Le 26/01/2017 à 13:43, wm4 a écrit : On Thu, 26 Jan 2017 13:32:08 +0100 Paul Arzelier wrote: From d84648e1990ad3a12462dfb76990dc7036f5f082 Mon Sep 17 00:00:00 2001 From: Polochon-street

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 14:29:21 +0100 Paul Arzelier wrote: > From d84648e1990ad3a12462dfb76990dc7036f5f082 Mon Sep 17 00:00:00 2001 > From: Polochon-street > Date: Thu, 26 Jan 2017 13:25:22 +0100 > Subject: [PATCH] Ignore ID3 tags if other tags are

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread Paul Arzelier
Ah, missed the leaked, sorry. Regarding the explode message, I kept it because of this message http://ffmpeg.org/pipermail/ffmpeg-devel/2015-February/168250.html . Maybe it is not that relevant anymore though, because we're talking about all existing codecs there, and not only FLAC (which

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2017-01-26 Thread Massimo Battistel
> > > Ive reupped the current versions of each seperated patch for comment > ___ > > Hi, could this patch fix issue #5783? (https://trac.ffmpeg.org/ticket/5783) Thanks, MB ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] lavc/mjpegdec: hint next marker position in ff_mjpeg_find_marker

2017-01-26 Thread Matthieu Bouron
Speeds up next marker search when a SOS marker is found. ff_mjpeg_find_marker goes from 54% to 30% under perf record ffmpeg -i sample_2992x4000.jpg --- libavcodec/mjpegdec.c | 31 +-- libavcodec/mjpegdec.h | 2 +- libavcodec/mxpegdec.c | 5 +++-- 3 files changed, 29

Re: [FFmpeg-devel] GSoC 2017

2017-01-26 Thread Pedro Arthur
Hi all, I can be a backup mentor if needed. 2017-01-25 10:15 GMT-02:00 Thilo Borgmann : > Am 25.01.17 um 06:14 schrieb Umair Khan: > > On Wed, Jan 25, 2017 at 7:45 AM, Michael Niedermayer > wrote: > >> > >> On Mon, Jan 23, 2017 at 03:39:09PM +0100,

Re: [FFmpeg-devel] [PATCH] HTTP: optimize forward seek performance

2017-01-26 Thread Joel Cunningham
Michael, Thanks for the review and testing! New patch included, see comments below > > this segfaults with many fuzzed files > backtrace looks like this: > > #0 0x7fffb368 in ?? () > #1 0x005f9280 in avio_seek (s=0x7fffb278, offset=31, whence=0) > at

Re: [FFmpeg-devel] [PATCH]lavf/mov: Export vendor metadata

2017-01-26 Thread Carl Eugen Hoyos
2017-01-26 9:26 GMT+01:00 wm4 : > On Thu, 26 Jan 2017 09:16:00 +0100 > Carl Eugen Hoyos wrote: > >> 2017-01-26 9:07 GMT+01:00 wm4 : >> >> >> >> > Any metadata you export can and will get copied to a new file when >> >> >> >

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: fix compilation of testprogs when networking is disabled

2017-01-26 Thread Michael Niedermayer
On Wed, Jan 25, 2017 at 03:05:55PM +0100, Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > libavformat/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) probably ok thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] lavf/matroskaenc.c: Free dyn bufs in mkv_free. Fixes memory leaks when muxing fails.

2017-01-26 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/matroskaenc.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index f731b678b9..88f6c647b9 100644 --- a/libavformat/matroskaenc.c +++

Re: [FFmpeg-devel] [PATCH] tcp: set socket buffer sizes before listen/connect/accept

2017-01-26 Thread Michael Niedermayer
On Wed, Jan 25, 2017 at 09:06:36AM -0600, Joel Cunningham wrote: > Ping! Anyone have a chance to look at this issue/patch? > > Thanks, patch applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his

Re: [FFmpeg-devel] [PATCH] fate: add SCC test

2017-01-26 Thread Michael Niedermayer
On Wed, Jan 25, 2017 at 10:30:06PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > tests/fate/subtitles.mak | 3 + > tests/ref/fate/sub-scc | 519 > +++ > 2 files changed, 522 insertions(+) > create mode 100644

Re: [FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 02:14:09AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/boadec.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] GSoC 2017

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 03:34:24PM -0200, Pedro Arthur wrote: > Hi all, > I can be a backup mentor if needed. we need more (backup) mentors, so yes, i think its needed also if you want to be mentor for a swscale related project i would support that idea [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] libavformat patch that brute-forces aax encryption

2017-01-26 Thread Carl Eugen Hoyos
2017-01-25 3:48 GMT+01:00 William Shipley : > Is there any interest in including this upstream? Please send your patch to this mailing list. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] libavformat patch that brute-forces aax encryption

2017-01-26 Thread wm4
On Tue, 24 Jan 2017 19:48:00 -0700 William Shipley wrote: > I made a small modification of libavformat that bruteforces the 4-byte code > used in audible encrypted files. It automatically runs if an aax is passed > (always encrypted) without the code provided. Previously,

Re: [FFmpeg-devel] [PATCH 6/9] pvfdec: prevent overflow during block alignment calculation

2017-01-26 Thread Paul B Mahol
On 1/26/17, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/pvfdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > lgtm ___

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-26 Thread Paul B Mahol
On 1/26/17, wm4 wrote: > On Thu, 26 Jan 2017 03:20:02 +0100 > Michael Niedermayer wrote: > >> On Thu, Jan 26, 2017 at 02:58:07AM +0100, Andreas Cadhalpun wrote: >> > On 26.01.2017 02:29, Ronald S. Bultje wrote: >> > > On Wed, Jan 25, 2017 at 8:12 PM,

Re: [FFmpeg-devel] [PATCH]lavf/mov: Export vendor metadata

2017-01-26 Thread Carl Eugen Hoyos
2017-01-26 9:07 GMT+01:00 wm4 : >> >> > Any metadata you export can and will get copied to a new file when >> >> > remuxing, therefor exporting arbitrary info that isn't actual stream >> >> > metadata tags in metadata is problematic - it carries over to the >> >> >

Re: [FFmpeg-devel] [PATCH]lavf/mov: Export vendor metadata

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 08:26:02 +0100 Carl Eugen Hoyos wrote: > 2017-01-26 6:24 GMT+01:00 wm4 : > > On Thu, 26 Jan 2017 00:35:17 +0100 > > Carl Eugen Hoyos wrote: > > > >> 2017-01-26 0:19 GMT+01:00 Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH]lavf/mov: Ignore avio_skip() return value

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 08:25:15 +0100 Carl Eugen Hoyos wrote: > 2017-01-26 6:27 GMT+01:00 wm4 : > > On Thu, 26 Jan 2017 00:34:20 +0100 > > Carl Eugen Hoyos wrote: > > > >> From 694daed9222e50d6245bf5d041e82523ee869451 Mon Sep 17

Re: [FFmpeg-devel] [PATCH]lavf/mov: Export vendor metadata

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 09:16:00 +0100 Carl Eugen Hoyos wrote: > 2017-01-26 9:07 GMT+01:00 wm4 : > > >> >> > Any metadata you export can and will get copied to a new file when > >> >> > remuxing, therefor exporting arbitrary info that isn't actual stream >

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread Paul Arzelier
Oops, I don't know what went wrong, but now it seems to work. I've attached the working patched, sorry! Le 26/01/2017 à 02:12, Michael Niedermayer a écrit : On Wed, Jan 25, 2017 at 08:33:53PM +0100, Paul Arzelier wrote: Hi all, Would it be possible to continue the discussion began there ?

Re: [FFmpeg-devel] [PATCH] HTTP: optimize forward seek performance

2017-01-26 Thread Joel Cunningham
Attached is a git format-patch file 0001-HTTP-improve-performance-by-reducing-forward-seeks.patch Description: Binary data > On Jan 26, 2017, at 6:52 PM, Michael Niedermayer wrote: > > On Thu, Jan 26, 2017 at 10:44:33AM -0600, Joel Cunningham wrote: >> Michael, >> >>

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread wm4
On Fri, 27 Jan 2017 03:03:03 +0100 Michael Niedermayer wrote: > On Thu, Jan 26, 2017 at 02:29:21PM +0100, Paul Arzelier wrote: > > Alright, attached is the last version (I hope!) > > > > Paul > > > > > > Le 26/01/2017 à 13:43, wm4 a écrit : > > >On Thu, 26 Jan 2017

Re: [FFmpeg-devel] [PATCH]lavf/mov: Export vendor metadata

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 18:06:39 +0100 Carl Eugen Hoyos wrote: > 2017-01-26 9:26 GMT+01:00 wm4 : > > On Thu, 26 Jan 2017 09:16:00 +0100 > > Carl Eugen Hoyos wrote: > > > >> 2017-01-26 9:07 GMT+01:00 wm4 : > >>

Re: [FFmpeg-devel] [PATCH]lavf/mov: Export vendor metadata

2017-01-26 Thread Carl Eugen Hoyos
2017-01-27 7:04 GMT+01:00 wm4 : > On Thu, 26 Jan 2017 18:06:39 +0100 > Carl Eugen Hoyos wrote: > >> 2017-01-26 9:26 GMT+01:00 wm4 : >> > On Thu, 26 Jan 2017 09:16:00 +0100 >> > Carl Eugen Hoyos wrote: >> > >>

Re: [FFmpeg-devel] [PATCH]lavf/mov: Export vendor metadata

2017-01-26 Thread wm4
On Fri, 27 Jan 2017 08:26:26 +0100 Carl Eugen Hoyos wrote: > 2017-01-27 7:04 GMT+01:00 wm4 : > > On Thu, 26 Jan 2017 18:06:39 +0100 > > Carl Eugen Hoyos wrote: > > > >> 2017-01-26 9:26 GMT+01:00 wm4 : > >>

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread wm4
On Thu, 26 Jan 2017 11:08:45 +0100 Paul Arzelier wrote: > From bb5dc73c42ad2e0bffd7e38fac18c6f01ec05ab3 Mon Sep 17 00:00:00 2001 > From: Paul Arzelier > Date: Thu, 26 Jan 2017 11:04:44 +0100 > Subject: [PATCH] Fixed behavior when id3 tags were found

[FFmpeg-devel] [PATCH] doc/muxers: remove confusing example for segment muxer option clocktime_wrap_duration

2017-01-26 Thread Marton Balint
Detecting a leap second depends on a lot of things, segment time, segment offset, system leap second implementation, the removed part is a huge simplification which can be misleading, so it is best to remove it. Signed-off-by: Marton Balint --- doc/muxers.texi | 3 --- 1 file

Re: [FFmpeg-devel] [PATCH] lavc/mjpegdec: hint next marker position in ff_mjpeg_find_marker

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 05:47:51PM +0100, Matthieu Bouron wrote: > Speeds up next marker search when a SOS marker is found. > > ff_mjpeg_find_marker goes from 54% to 30% under perf record ffmpeg -i > sample_2992x4000.jpg > --- > libavcodec/mjpegdec.c | 31 +-- >

Re: [FFmpeg-devel] GSoC 2017

2017-01-26 Thread Mayank Agarwal
Hi, I am interested in joining one of the projects. Regards Mayank On Thu, Jan 26, 2017 at 11:04 PM, Pedro Arthur wrote: > Hi all, > I can be a backup mentor if needed. > > 2017-01-25 10:15 GMT-02:00 Thilo Borgmann : > > > Am 25.01.17 um 06:14

Re: [FFmpeg-devel] [PATCH 5/9] nistspheredec: prevent overflow during block alignment calculation

2017-01-26 Thread Marton Balint
On Thu, 26 Jan 2017, Michael Niedermayer wrote: On Thu, Jan 26, 2017 at 03:52:04AM +0100, Marton Balint wrote: On Thu, 26 Jan 2017, Michael Niedermayer wrote: On Thu, Jan 26, 2017 at 02:58:07AM +0100, Andreas Cadhalpun wrote: On 26.01.2017 02:29, Ronald S. Bultje wrote: On Wed, Jan 25,

Re: [FFmpeg-devel] [PATCH] Ignore duplicate ID3 tags if vorbis tags exist

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 02:29:21PM +0100, Paul Arzelier wrote: > Alright, attached is the last version (I hope!) > > Paul > > > Le 26/01/2017 à 13:43, wm4 a écrit : > >On Thu, 26 Jan 2017 13:32:08 +0100 > >Paul Arzelier wrote: > > > >> From

Re: [FFmpeg-devel] [PATCH 2/9] electronicarts: prevent overflow during block alignment calculation

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 02:11:31AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/electronicarts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [FFmpeg-devel, PATCHv5] avformat: parse iTunes gapless information

2017-01-26 Thread Christopher Snowhill
Let's try this again. I can't believe I missed all those things you mentioned. It's almost as if I didn't actually proofread my patch before sending it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat: parse iTunes gapless information

2017-01-26 Thread Christopher Snowhill
Signed-off-by: Christopher Snowhill --- libavformat/mp3dec.c | 77 +++- 1 file changed, 76 insertions(+), 1 deletion(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 099ca57..b895e37 100644 ---

Re: [FFmpeg-devel] [PATCH] HTTP: optimize forward seek performance

2017-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2017 at 10:44:33AM -0600, Joel Cunningham wrote: > Michael, > > Thanks for the review and testing! New patch included, see comments below > > > > > this segfaults with many fuzzed files > > backtrace looks like this: > > > > #0 0x7fffb368 in ?? () > > #1