Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Fri, Nov 10, 2017 at 12:18:07AM +0100, Aurelien Jacobs wrote: [...] > > > Also, allowing this but not the mixed statements and declarations means > > > this is a style decision and not a technical one anymore. > > Allowing limiting the scope of a variable to a loop seems like a > technical

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread nablet developer
On 10-Nov-17 03:35, Nicolas George wrote: Can you explain the logic of the implementation? I have a hard time understanding why you call the tcp protocol from here after forcing it to call back here. Regards, the idea is to avoid code duplication as much as possible, and try to re-use

Re: [FFmpeg-devel] [PATCH 04/11] avutil: add alignment needed for AVX-512

2017-11-09 Thread James Almer
On 11/9/2017 8:58 AM, James Darnley wrote: > --- > This patch gained the alignmnet increase in mem.c > > libavutil/mem.c | 2 +- > libavutil/x86/cpu.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavutil/mem.c b/libavutil/mem.c > index 6ad409daf4..cdf539306f

Re: [FFmpeg-devel] [PATCH 03/11] avutil: detect when AVX-512 is available

2017-11-09 Thread James Almer
On 11/9/2017 8:58 AM, James Darnley wrote: > --- > I've changed this patch slightly because I discovered that it would cause an > illegal instruction exception on much older processors (probably all without > AVX). I was running xgetbv() almost uncontitionally. Now it is a little more > like

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread pkv.stream
Le 10/11/2017 à 1:12 AM, Michael Niedermayer a écrit : On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-09 Thread Carl Eugen Hoyos
2017-11-09 1:19 GMT+01:00 Colin NG : > - Add a function to handle the base URL Processing described in section 5.6.5 > of IEC_23009-1. > > - Fix for downloading content with byte range selection This sounds as if the patch should be split in two. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH 02/11] avutil: add AVX-512 flags

2017-11-09 Thread James Almer
On 11/9/2017 8:58 AM, James Darnley wrote: > --- > libavutil/cpu.c | 6 +- > libavutil/cpu.h | 1 + > libavutil/tests/cpu.c | 1 + > libavutil/x86/cpu.h | 2 ++ > 4 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavutil/cpu.c b/libavutil/cpu.c > index

Re: [FFmpeg-devel] [PATCH 01/11] configure: test whether x86 assembler supports AVX-512

2017-11-09 Thread James Almer
On 11/9/2017 8:58 AM, James Darnley wrote: > --- > configure | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/configure b/configure > index f396abda5b..146a87324c 100755 > --- a/configure > +++ b/configure > @@ -406,6 +406,7 @@ Optimization options (experts only): >

Re: [FFmpeg-devel] [PATCH 05/11] avcodec: add stride alignment needed for AVX-512

2017-11-09 Thread James Almer
On 11/9/2017 8:58 AM, James Darnley wrote: > --- > configure | 2 ++ > libavcodec/internal.h | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 146a87324c..fce8030d91 100755 > --- a/configure > +++ b/configure > @@ -1886,6

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 22:48, Aurelien Jacobs wrote: > On Thu, Nov 09, 2017 at 02:32:44PM +, Rostislav Pehlivanov wrote: > > On 9 November 2017 at 13:37, Aurelien Jacobs wrote: > > > > > On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 09:37:33PM +0100, pkv.stream wrote: > Hi Michael, > > >> ffmpeg_opt.c | 11 ++- > >> 1 file changed, 10 insertions(+), 1 deletion(-) > >>2af07f4366efdfaf1018bb2ea29be672befe0823 > >>0001-ffmpeg-fix-channel_layout-bug-on-non-default-layout.patch > >> From

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-09 Thread Sasi Inguva
Partially fixes t/6699. --- libavformat/mov.c | 32 +++--- tests/fate/mov.mak| 4 tests/ref/fate/mov-elst-ends-betn-b-and-i | 33 +++ 3 files changed, 58 insertions(+), 11 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-09 Thread Sasi Inguva
Sorry, about this. i had uncommitted changes. Attaching the patch. On Thu, Nov 9, 2017 at 12:22 PM, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 04:13:46PM -0800, Sasi Inguva wrote: > > Partially fixes t/6699. > > --- > > libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] lavu/timecode: clarify error msg for timecode_rate

2017-11-09 Thread Michael Niedermayer
On Sun, Nov 05, 2017 at 09:40:41PM +0530, Gyan Doshi wrote: > Prompted by an issue reported at StackExchange, patch changes error > message for timecode_rate values below 1. > > The user-supplied value for timecode_rate in drawtext is rounded > to nearest integer. So, a supplied value of 0.49 or

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-09 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote: > Please find the merged patch in attachement. > > Thanks > > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol a écrit : > > > On 11/8/17, Marc-Antoine ARNAUD wrote: > > > This patch

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: > On 11/9/2017 2:46 PM, Clément Bœsch wrote: > > On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: > >> Signed-off-by: Rostislav Pehlivanov > >> --- > >> doc/developer.texi | 3 +++ > >> 1 file

Re: [FFmpeg-devel] [PATCH] h264dec: h264_select_output_frame() - fill correctly has_b_frames based on the level

2017-11-09 Thread Hendrik Leppkes
On Thu, Nov 9, 2017 at 9:38 PM, Jaroslav Kysela wrote: > The current code does not handle correctly the situation when > sps->num_reoder_frames > was set using the level. The incorrect has_b_frames results in the wrong DTS > guess and > malformed output (wrong 'Non-monotonous

Re: [FFmpeg-devel] [PATCH] avformat/img2enc: add frame_pts option for make output filename

2017-11-09 Thread Steven Liu
2017-10-31 23:47 GMT+08:00 Steven Liu : > when use frame_pts option, the output image name can be set with PTS > of current frame. > > Signed-off-by: Steven Liu > --- > doc/muxers.texi | 9 + > libavformat/img2enc.c | 7 +++ > 2 files

[FFmpeg-devel] [PATCH] h264dec: h264_select_output_frame() - fill correctly has_b_frames based on the level

2017-11-09 Thread Jaroslav Kysela
The current code does not handle correctly the situation when sps->num_reoder_frames was set using the level. The incorrect has_b_frames results in the wrong DTS guess and malformed output (wrong 'Non-monotonous DTS' fixup). sps->num_reorder_frames is set in the function

[FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-09 Thread Colin NG
- Add a function to handle the base URL Processing described in section 5.6.5 of IEC_23009-1. - Fix for downloading content with byte range selection diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index f63f1ff..19ef6f8 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak of rep_dest->parent null

2017-11-09 Thread Steven Liu
2017-11-09 16:28 GMT+08:00 Carl Eugen Hoyos : > Hi! > >> Am 09.11.2017 um 00:52 schrieb Steven Liu : >> >> fix ticket id: #6820 > > I find the commit message misleading. > >> use the current DASHContext for the rep_dest > > This may be better imo. Pushed

Re: [FFmpeg-devel] [PATCH]lavf/dashdec: Fix several memleaks

2017-11-09 Thread Steven Liu
2017-11-10 2:55 GMT+08:00 Michael Niedermayer : > On Wed, Nov 08, 2017 at 10:46:27PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes several memleaks found testing ticket #6820 (I >> cannot reproduce the crash). >> >> Please comment, Carl Eugen > >>

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 02:32:44PM +, Rostislav Pehlivanov wrote: > On 9 November 2017 at 13:37, Aurelien Jacobs wrote: > > > On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote: > > > On 8 November 2017 at 22:41, Aurelien Jacobs wrote: >

Re: [FFmpeg-devel] [PATCH] examples/vaapi_encode: Add a VA-API encode example.

2017-11-09 Thread Mark Thompson
On 06/11/17 06:56, Jun Zhao wrote: > From d16f766363d9ecc240b0f8e025c2a8f91ea4775e Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Mon, 6 Nov 2017 14:45:27 +0800 > Subject: [PATCH] examples/vaapi_encode: Add a VA-API encode example. > > add a VA-API encode example, only

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread pkv.stream
Hi Michael, ffmpeg_opt.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) 2af07f4366efdfaf1018bb2ea29be672befe0823 0001-ffmpeg-fix-channel_layout-bug-on-non-default-layout.patch From 4ec55dc88923108132307b41300a1abddf32e6f7 Mon Sep 17 00:00:00 2001 From: pkviet

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread Nicolas George
Le nonidi 19 brumaire, an CCXXVI, Nablet Developer a écrit : > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed > > Signed-off-by: Nablet Developer > --- > configure | 10 ++ > libavformat/Makefile| 1 + > libavformat/opensrt.c

Re: [FFmpeg-devel] [PATCH 2/3] avformat/tcp: use generic socket API

2017-11-09 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 04:31:31PM +0700, Nablet Developer wrote: > this allows to implement other protocols which use > API similar to BSD sockets (e.g. Haivision SRT) > > Signed-off-by: Nablet Developer > --- > libavformat/tcp.c | 118 >

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread James Almer
On 11/9/2017 5:08 PM, Clément Bœsch wrote: > On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: > [...] >>> - this require a Changelog entry as it has a technical impact (which could >>> be considered negligible). >> >> No, Changelog is not for this kind of change. >> > > Sorry, I

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-09 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 04:13:46PM -0800, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 > --- > tests/fate/mov.mak| 4 > tests/ref/fate/mov-elst-ends-betn-b-and-i | 31

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: [...] > > - this require a Changelog entry as it has a technical impact (which could > > be considered negligible). > > No, Changelog is not for this kind of change. > Sorry, I should have elaborated: I meant to document in the

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread James Almer
On 11/9/2017 2:46 PM, Clément Bœsch wrote: > On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: >> Signed-off-by: Rostislav Pehlivanov >> --- >> doc/developer.texi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/doc/developer.texi

Re: [FFmpeg-devel] [PATCH 08/11] avcodec/v210enc: add AVX-512 10-bit line pack function

2017-11-09 Thread Martin Vignali
2017-11-09 12:58 GMT+01:00 James Darnley : > --- > libavcodec/x86/v210enc.asm| 5 + > libavcodec/x86/v210enc_init.c | 7 +++ > 2 files changed, 12 insertions(+) > > diff --git a/libavcodec/x86/v210enc.asm b/libavcodec/x86/v210enc.asm > index 965f2bea3c..5068af27f8

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/blockdsp: roll-up x86asm preprocessor loop

2017-11-09 Thread Martin Vignali
2017-11-09 12:58 GMT+01:00 James Darnley : > From: James Darnley > > --- > libavcodec/x86/blockdsp.asm | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/x86/blockdsp.asm b/libavcodec/x86/blockdsp.asm > index

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-11-09 Thread Michael Niedermayer
On Thu, Oct 05, 2017 at 12:37:13AM +0200, pkv.stream wrote: > Le 04/10/2017 à 11:18 PM, Moritz Barsnick a écrit : > >On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: > >> if (!ost->stream_copy) { > >>-char *sample_fmt = NULL; > >>+ > >>+ char *sample_fmt = NULL; >

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/lossless_videodsp: add AVX-512 version of add_bytes

2017-11-09 Thread Martin Vignali
2017-11-09 12:58 GMT+01:00 James Darnley : > --- > libavcodec/x86/lossless_videodsp.asm| 5 + > libavcodec/x86/lossless_videodsp_init.c | 5 + > 2 files changed, 10 insertions(+) > > diff --git a/libavcodec/x86/lossless_videodsp.asm >

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/lossless_videodsp: add AVX-512 version of add_bytes

2017-11-09 Thread Martin Vignali
2017-11-09 20:37 GMT+01:00 Martin Vignali : > > > 2017-11-09 12:58 GMT+01:00 James Darnley : > >> --- >> libavcodec/x86/lossless_videodsp.asm| 5 + >> libavcodec/x86/lossless_videodsp_init.c | 5 + >> 2 files changed, 10 insertions(+) >> >>

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/blockdsp: add AVX-512 version of clear_block(s)

2017-11-09 Thread Martin Vignali
2017-11-09 12:58 GMT+01:00 James Darnley : > From: James Darnley > > Also adjust alignment requirements where nessecary. > --- > Whether this patch is committed or not the change to 4xm.c should be > picked to > master because the alignment is wrong for

Re: [FFmpeg-devel] [PATCH] lavu/timecode: clarify error msg for timecode_rate

2017-11-09 Thread Gyan Doshi
Ping. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-09 Thread Thomas Köppe
Thank you, I'll package this up as a patch and send it as a separate mail. On 9 November 2017 at 11:52, Teresa Johnson wrote: > I implemented this change to add a new macro. I tried to find the > variables used in MANGLE and change those to use the new >

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx265: switch to ff_alloc_packet2

2017-11-09 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 01:51:30PM +, Derek Buitenhuis wrote: > On 11/9/2017 12:39 AM, Jun Zhao wrote: > > From 5afdf252b3bb6f8c7a276c2a8bde8f4a95d170e4 Mon Sep 17 00:00:00 2001 > > From: Jun Zhao > > Date: Wed, 8 Nov 2017 21:04:51 +0800 > > Subject: [PATCH 2/2]

Re: [FFmpeg-devel] [PATCH 1/2] lavc/libkvazaar: switch to ff_alloc_packet2

2017-11-09 Thread Michael Niedermayer
On Thu, Nov 09, 2017 at 10:27:50AM +0200, Arttu Ylä-Outinen wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet

Re: [FFmpeg-devel] [PATCH]lavf/dashdec: Fix several memleaks

2017-11-09 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 10:46:27PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes several memleaks found testing ticket #6820 (I > cannot reproduce the crash). > > Please comment, Carl Eugen > dashdec.c | 22 +- > 1 file changed, 13 insertions(+), 9

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-09 Thread Teresa Johnson
I implemented this change to add a new macro. I tried to find the variables used in MANGLE and change those to use the new DECLARE_ASM_ALIGNED, and the build succeeds with these changes. New changes are in cl/172133815. Teresa On Wed, Nov 1, 2017 at 7:25 AM, Teresa Johnson

Re: [FFmpeg-devel] [PATCH] configure, fftools/Makefile: Copy .pdb files to bindir for MSVC builds for make install

2017-11-09 Thread Aaron Levinson
Ping On 10/31/2017 11:05 AM, Aaron Levinson wrote: When ffmpeg is built using MSVC, symbols are stored separately from executables and libraries in .pdb files. However, unlike with gcc-based builds, when make install is invoked, symbols, in the form of .pdb files, which are important for

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

2017-11-09 Thread James Almer
On 11/9/2017 2:07 AM, Aaron Levinson wrote: > On 11/8/2017 7:20 PM, James Almer wrote: >> Should fix ticket #6822 >> >> Signed-off-by: James Almer >> --- >>   libavdevice/decklink_dec.cpp | 8 >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] configure: fix the non pkg-config libmfx check

2017-11-09 Thread James Almer
On 11/9/2017 2:51 PM, James Almer wrote: > On 11/9/2017 2:31 PM, James Almer wrote: >> Based on a patch by Aaron Levinson. >> >> Signed-off-by: James Almer >> --- >> Untested >> >> configure | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 1/9] lavfi/paletteuse: check get_color return value

2017-11-09 Thread Clément Bœsch
On Wed, Nov 08, 2017 at 07:17:45PM +0100, Timo Rothenpieler wrote: > Fixes CID #1420396 > --- > libavfilter/vf_paletteuse.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c > index ed80ab04d5..1980907e70 100644

Re: [FFmpeg-devel] [PATCH] configure: fix the non pkg-config libmfx check

2017-11-09 Thread James Almer
On 11/9/2017 2:31 PM, James Almer wrote: > Based on a patch by Aaron Levinson. > > Signed-off-by: James Almer > --- > Untested > > configure | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index f396abda5b..7dd540bad3

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451 100644 >

[FFmpeg-devel] [PATCH] configure: fix the non pkg-config libmfx check

2017-11-09 Thread James Almer
Based on a patch by Aaron Levinson. Signed-off-by: James Almer --- Untested configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index f396abda5b..7dd540bad3 100755 --- a/configure +++ b/configure @@ -2772,6 +2772,7 @@

Re: [FFmpeg-devel] [PATCH] lavc: reset codec on receiving packet after EOF in compat_decode

2017-11-09 Thread James Cowgill
Hi, On 09/11/17 14:02, Hendrik Leppkes wrote: > On Thu, Nov 9, 2017 at 1:21 PM, James Cowgill wrote: >> In commit 061a0c14bb57 ("decode: restructure the core decoding code"), the >> deprecated avcodec_decode_* APIs were reworked so that they called into the >> new

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 13:37, Aurelien Jacobs wrote: > On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote: > > On 8 November 2017 at 22:41, Aurelien Jacobs wrote: > > > > > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote:

Re: [FFmpeg-devel] [PATCH] lavc: reset codec on receiving packet after EOF in compat_decode

2017-11-09 Thread Nicolas George
Le nonidi 19 brumaire, an CCXXVI, Derek Buitenhuis a écrit : > Is it more sensible to actually return an error here? Otherwise it's just > enabling > future incorrect code; API users tend to ignore stderr warnings. I guess an > argument > could be made both ways. Actually, if the use of the API

Re: [FFmpeg-devel] [PATCH] lavc: reset codec on receiving packet after EOF in compat_decode

2017-11-09 Thread Derek Buitenhuis
On 11/9/2017 12:21 PM, James Cowgill wrote: > +if (avci->draining_done && pkt && pkt->size != 0) { > +av_log(avctx, AV_LOG_WARNING, "Got unexpected packet after EOF\n"); > +avcodec_flush_buffers(avctx); > +} Is it more sensible to actually return an error here? Otherwise

Re: [FFmpeg-devel] [PATCH] lavc: reset codec on receiving packet after EOF in compat_decode

2017-11-09 Thread Hendrik Leppkes
On Thu, Nov 9, 2017 at 1:21 PM, James Cowgill wrote: > In commit 061a0c14bb57 ("decode: restructure the core decoding code"), the > deprecated avcodec_decode_* APIs were reworked so that they called into the > new avcodec_send_packet / avcodec_receive_frame API. This had the

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Derek Buitenhuis
On 11/9/2017 1:23 PM, Rostislav Pehlivanov wrote: >> For now, and only because you looked at the code. But the current code >> does not follow the documentation, so it is really a fix. >> >> > That type of fix is called a correction. It's a fix. Relying on internal implementation knowledge is a

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx265: switch to ff_alloc_packet2

2017-11-09 Thread Derek Buitenhuis
On 11/9/2017 12:39 AM, Jun Zhao wrote: > From 5afdf252b3bb6f8c7a276c2a8bde8f4a95d170e4 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Wed, 8 Nov 2017 21:04:51 +0800 > Subject: [PATCH 2/2] lavc/libx265: switch to ff_alloc_packet2 > > ff_alloc_packet have been deprecated,

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread James Almer
On 11/9/2017 10:37 AM, Aurelien Jacobs wrote: > On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote: >> On 8 November 2017 at 22:41, Aurelien Jacobs wrote: >> >>> On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: On Wed, Nov 08, 2017 at

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 03:22:21AM +0100, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 11:41:16PM +0100, Aurelien Jacobs wrote: > > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > > > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: > > > [...] > > >

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 12:52:34AM +, Rostislav Pehlivanov wrote: > On 8 November 2017 at 22:41, Aurelien Jacobs wrote: > > > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > > > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: > > >

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 13:15, Nicolas George wrote: > Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > > Its not really a fix since bprint can't return non-ENOMEM. All were > copied > > For now, and only because you looked at the code. But the current code >

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Nicolas George
Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > Its not really a fix since bprint can't return non-ENOMEM. All were copied For now, and only because you looked at the code. But the current code does not follow the documentation, so it is really a fix. > from one place in the

Re: [FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 08:49, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavcodec/pngdec.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 08:01, pkv.stream wrote: > Le 09/11/2017 à 4:43 AM, Rostislav Pehlivanov a écrit : > >> On 18 October 2017 at 11:05, pkv.stream wrote: >> >> Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : >>> >>> On 2 October 2017 at

Re: [FFmpeg-devel] [FFmpeg-cvslog] aacenc: support extended channel layouts using PCEs

2017-11-09 Thread Rostislav Pehlivanov
On 9 November 2017 at 09:37, Kv Pham wrote: > Le 9 nov. 2017 10:12 AM, "Nicolas George" a écrit : > > Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > > ffmpeg | branch: master | Rostislav Pehlivanov | > Mon Oct 3

[FFmpeg-devel] [PATCH] lavc: reset codec on receiving packet after EOF in compat_decode

2017-11-09 Thread James Cowgill
In commit 061a0c14bb57 ("decode: restructure the core decoding code"), the deprecated avcodec_decode_* APIs were reworked so that they called into the new avcodec_send_packet / avcodec_receive_frame API. This had the side effect of prohibiting sending new packets containing data after a drain

Re: [FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread Kv Pham
Le 9 nov. 2017 10:32 AM, "Nablet Developer" a écrit : protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- configure | 10 ++ libavformat/Makefile| 1 + libavformat/opensrt.c |

[FFmpeg-devel] [PATCH 05/11] avcodec: add stride alignment needed for AVX-512

2017-11-09 Thread James Darnley
--- configure | 2 ++ libavcodec/internal.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 146a87324c..fce8030d91 100755 --- a/configure +++ b/configure @@ -1886,6 +1886,7 @@ ARCH_FEATURES=" local_aligned simd_align_16

[FFmpeg-devel] [PATCH 08/11] avcodec/v210enc: add AVX-512 10-bit line pack function

2017-11-09 Thread James Darnley
--- libavcodec/x86/v210enc.asm| 5 + libavcodec/x86/v210enc_init.c | 7 +++ 2 files changed, 12 insertions(+) diff --git a/libavcodec/x86/v210enc.asm b/libavcodec/x86/v210enc.asm index 965f2bea3c..5068af27f8 100644 --- a/libavcodec/x86/v210enc.asm +++ b/libavcodec/x86/v210enc.asm @@

[FFmpeg-devel] [PATCH 09/11] avcodec/blockdsp: roll-up x86asm preprocessor loop

2017-11-09 Thread James Darnley
From: James Darnley --- libavcodec/x86/blockdsp.asm | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/x86/blockdsp.asm b/libavcodec/x86/blockdsp.asm index 9d203df8f5..9d0e8a3242 100644 --- a/libavcodec/x86/blockdsp.asm +++

[FFmpeg-devel] [PATCH 02/11] avutil: add AVX-512 flags

2017-11-09 Thread James Darnley
--- libavutil/cpu.c | 6 +- libavutil/cpu.h | 1 + libavutil/tests/cpu.c | 1 + libavutil/x86/cpu.h | 2 ++ 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index c8401b8258..6548cc3042 100644 --- a/libavutil/cpu.c +++

[FFmpeg-devel] [PATCH 03/11] avutil: detect when AVX-512 is available

2017-11-09 Thread James Darnley
--- I've changed this patch slightly because I discovered that it would cause an illegal instruction exception on much older processors (probably all without AVX). I was running xgetbv() almost uncontitionally. Now it is a little more like what is the in x264 patch. libavutil/x86/cpu.c | 12

[FFmpeg-devel] [PATCH 07/11] checkasm: support for AVX-512 functions

2017-11-09 Thread James Darnley
--- tests/checkasm/checkasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index b8b0e32dbd..9fb1438bdb 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -192,6 +192,7 @@ static const struct { { "FMA3",

[FFmpeg-devel] [PATCH 10/11] avcodec/blockdsp: add AVX-512 version of clear_block(s)

2017-11-09 Thread James Darnley
From: James Darnley Also adjust alignment requirements where nessecary. --- Whether this patch is committed or not the change to 4xm.c should be picked to master because the alignment is wrong for the AVX version of this function. I assume it hasn't been noticed yet

[FFmpeg-devel] [PATCH 06/11] x86inc: AVX-512 support

2017-11-09 Thread James Darnley
From: Henrik Gramner AVX-512 consists of a plethora of different extensions, but in order to keep things a bit more manageable we group together the following extensions under a single baseline cpu flag which should cover SKL-X and future CPUs: * AVX-512 Foundation (F) *

[FFmpeg-devel] [PATCH 11/11] avcodec/lossless_videodsp: add AVX-512 version of add_bytes

2017-11-09 Thread James Darnley
--- libavcodec/x86/lossless_videodsp.asm| 5 + libavcodec/x86/lossless_videodsp_init.c | 5 + 2 files changed, 10 insertions(+) diff --git a/libavcodec/x86/lossless_videodsp.asm b/libavcodec/x86/lossless_videodsp.asm index ba4d4f0153..5649348f86 100644 ---

[FFmpeg-devel] [PATCH 04/11] avutil: add alignment needed for AVX-512

2017-11-09 Thread James Darnley
--- This patch gained the alignmnet increase in mem.c libavutil/mem.c | 2 +- libavutil/x86/cpu.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/mem.c b/libavutil/mem.c index 6ad409daf4..cdf539306f 100644 --- a/libavutil/mem.c +++ b/libavutil/mem.c @@ -61,7

[FFmpeg-devel] [PATCH 01/11] configure: test whether x86 assembler supports AVX-512

2017-11-09 Thread James Darnley
--- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index f396abda5b..146a87324c 100755 --- a/configure +++ b/configure @@ -406,6 +406,7 @@ Optimization options (experts only): --disable-fma3 disable FMA3 optimizations --disable-fma4

[FFmpeg-devel] [PATCH 00/11] AVX-512 support (v.2)

2017-11-09 Thread James Darnley
A few changes from last time. A couple of the patches have notes on them. I've dropped the patch which added Nasm's smartalign feature which was causing problems building rv34dsp.asm. I don't know why. Eventually I try to look at it again. I've also added 3 functions that acutally use ZMM

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-09 Thread Marc-Antoine ARNAUD
Please find the merged patch in attachement. Thanks Le mer. 8 nov. 2017 à 17:12, Paul B Mahol a écrit : > On 11/8/17, Marc-Antoine ARNAUD wrote: > > This patch will fix the stride issue. > > Is it valid for you ? > > > > Does it required to

[FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc non-uni hz and vt mc msa functions

2017-11-09 Thread kaustubh.raste
From: Kaustubh Raste Use mask buffer. Signed-off-by: Kaustubh Raste --- libavcodec/mips/hevcdsp_msa.c | 541 - 1 file changed, 312 insertions(+), 229 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add skip option

2017-11-09 Thread Nicolas George
Le nonidi 19 brumaire, an CCXXVI, Paul B Mahol a écrit : > ping Please, it has not yet been 48 hours. I cannot promise to have time to look at it carefully enough before Sunday. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [FFmpeg-cvslog] aacenc: support extended channel layouts using PCEs

2017-11-09 Thread Kv Pham
Le 9 nov. 2017 10:12 AM, "Nicolas George" a écrit : Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > ffmpeg | branch: master | Rostislav Pehlivanov | Mon Oct 3 19:53:11 2016 +0100| [fbf295e2bd4d48d7a0a094ed5afce2fa5b6cf35a] | committer:

[FFmpeg-devel] [PATCH 2/3] avformat/tcp: use generic socket API

2017-11-09 Thread Nablet Developer
this allows to implement other protocols which use API similar to BSD sockets (e.g. Haivision SRT) Signed-off-by: Nablet Developer --- libavformat/tcp.c | 118 +++--- libavformat/tcp.h | 59 +++ 2 files

[FFmpeg-devel] [PATCH 3/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread Nablet Developer
protocol requires libsrt (https://github.com/Haivision/srt) to be installed Signed-off-by: Nablet Developer --- configure | 10 ++ libavformat/Makefile| 1 + libavformat/opensrt.c | 418

[FFmpeg-devel] [PATCH 1/3] avformat/network: allow to specify custom socket API

2017-11-09 Thread Nablet Developer
Signed-off-by: Nablet Developer --- libavformat/network.c | 196 -- libavformat/network.h | 34 + 2 files changed, 161 insertions(+), 69 deletions(-) diff --git a/libavformat/network.c b/libavformat/network.c index

[FFmpeg-devel] [PATCH 0/3] avformat/opensrt: add Haivision Open SRT protocol

2017-11-09 Thread Nablet Developer
the following patches implement Haivision SRT protocol. name OpenSRT is used to distinguish it from SRT subtitles. patches avoid copy-paste and associated maintanance burden by re-using existing code as much as possible (more specifically, tcp.c and network.c). network.c now allows to use other

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: add skip option

2017-11-09 Thread Paul B Mahol
On 11/7/17, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 5 + > libavfilter/vf_tile.c | 53 > ++- > 2 files changed, 49 insertions(+), 9 deletions(-) > ping

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak of rep_dest->parent null

2017-11-09 Thread 刘歧
> 在 2017年11月9日,16:28,Carl Eugen Hoyos 写道: > > Hi! > >> Am 09.11.2017 um 00:52 schrieb Steven Liu : >> >> fix ticket id: #6820 > > I find the commit message misleading. > >> use the current DASHContext for the rep_dest > > This may be better imo.

Re: [FFmpeg-devel] [FFmpeg-cvslog] aacenc: support extended channel layouts using PCEs

2017-11-09 Thread Nicolas George
Le nonidi 19 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > ffmpeg | branch: master | Rostislav Pehlivanov | Mon > Oct 3 19:53:11 2016 +0100| [fbf295e2bd4d48d7a0a094ed5afce2fa5b6cf35a] | > committer: Rostislav Pehlivanov > > aacenc: support extended channel layouts

[FFmpeg-devel] [PATCH] lavc/pngdec: fix av_bprint_finalize() usage.

2017-11-09 Thread Nicolas George
Signed-off-by: Nicolas George --- libavcodec/pngdec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 20707f0ae5..1d72f9542a 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak of rep_dest->parent null

2017-11-09 Thread Carl Eugen Hoyos
Hi! > Am 09.11.2017 um 00:52 schrieb Steven Liu : > > fix ticket id: #6820 I find the commit message misleading. > use the current DASHContext for the rep_dest This may be better imo. Thank you, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] lavc/libkvazaar: switch to ff_alloc_packet2

2017-11-09 Thread Arttu Ylä-Outinen
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-09 Thread pkv.stream
Le 09/11/2017 à 4:43 AM, Rostislav Pehlivanov a écrit : On 18 October 2017 at 11:05, pkv.stream wrote: Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : On 2 October 2017 at 18:43, pkv.stream wrote: Le 02/10/2017 à 7:23 PM, Michael