Re: [FFmpeg-devel] [PATCH] avformat/isom.h: use usnigned types in MOVStsc

2019-02-02 Thread Michael Niedermayer
On Fri, Feb 01, 2019 at 06:16:59PM -0800, chcunningham wrote: > Unsigned types match the isobmff spec. > --- > libavformat/isom.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavformat/isom.h b/libavformat/isom.h > index e629663949..8e0d8355b3 100644 > --- a/li

Re: [FFmpeg-devel] [PATCH] avformat/mov: validate chunk_count vs stsc_data

2019-02-02 Thread Michael Niedermayer
On Fri, Feb 01, 2019 at 06:25:19PM -0800, chcunningham wrote: > Bad content may contain stsc boxes with a first_chunk index that > exceeds stco.entries (chunk_count). > > mov_get_stsc_samples now checks for this and returns 0 when > values are invalid. > --- > libavformat/mov.c | 4 ++-- > 1 file

[FFmpeg-devel] [PATCH 1/2] add libaribb24 ARIB STD-B24 caption decoder

2019-02-02 Thread Jan Ekström
* Outputs ASS lines with basic coloring and font scaling for each given region. * Sets the default style to the resolution of the subtitle plane (for example, 960x540 / 36pt font for profile A). * Has options to: * Disable ruby text (which is coded as regions which have half-height text i

[FFmpeg-devel] [PATCH 2/2] lavf/mpegts: add reading of ARIB data coding descriptor

2019-02-02 Thread Jan Ekström
This enables us to read the data coding type utilized for a specific private data stream, of which we currently are interested in ARIB caption streams. The component tag limitations are according to ARIB TR-B14, and the component IDs are defined in ARIB STD-B10. --- libavformat/mpegts.c | 47 +++

[FFmpeg-devel] [PATCH 0/2] ARIB STD-B24 caption decoding using libaribb24

2019-02-02 Thread Jan Ekström
A decoder wrapper for the libaribb24 library found in various distributions and currently utilized by VLC. Requires GPLv3 with the current most recent release, but as the current library master is LGPLv3, any newer releases will require only LGPLv3. If the library is not found in your distributio

Re: [FFmpeg-devel] [PATCH 0/2] ARIB STD-B24 caption decoding using libaribb24

2019-02-02 Thread Carl Eugen Hoyos
2019-02-02 14:31 GMT+01:00, Jan Ekström : > I will proceed to making a FATE test You cannot add fate tests for external libraries. Is there no chance of adding the aribb24 code to FFmpeg? The library looks small although it also contains an mpegts parser iiuc. I'd really like to avoid the telet

Re: [FFmpeg-devel] [PATCH 0/2] ARIB STD-B24 caption decoding using libaribb24

2019-02-02 Thread Jan Ekström
On Sat, Feb 2, 2019 at 3:55 PM Carl Eugen Hoyos wrote: > > 2019-02-02 14:31 GMT+01:00, Jan Ekström : > > > I will proceed to making a FATE test > > You cannot add fate tests for external libraries. > Ouch. I was asked by Clement to make one which is why I wanted to do it. Possibly he didn't under

[FFmpeg-devel] [PATCH] avcodec/libx264: support BGRA pixel format

2019-02-02 Thread Thomas Volkert
From: Thomas Volkert --- libavcodec/libx264.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index a3493f393d..dd51fdc6dc 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -158,6 +158,9 @@ static int e

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: support BGRA pixel format

2019-02-02 Thread Carl Eugen Hoyos
2019-02-02 16:05 GMT+01:00, Thomas Volkert : > From: Thomas Volkert > > --- > libavcodec/libx264.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index a3493f393d..dd51fdc6dc 100644 > --- a/libavcodec/libx264.

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: support BGRA pixel format

2019-02-02 Thread Jan Ekström
On Sat, Feb 2, 2019 at 5:14 PM Carl Eugen Hoyos wrote: > > 2019-02-02 16:05 GMT+01:00, Thomas Volkert : > > From: Thomas Volkert > > > > --- > > libavcodec/libx264.c | 15 --- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/libavcodec/libx264.c b/libavcodec/l

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: support BGRA pixel format

2019-02-02 Thread Carl Eugen Hoyos
2019-02-02 16:18 GMT+01:00, Jan Ekström : > On Sat, Feb 2, 2019 at 5:14 PM Carl Eugen Hoyos wrote: >> >> 2019-02-02 16:05 GMT+01:00, Thomas Volkert : >> > From: Thomas Volkert >> > >> > --- >> > libavcodec/libx264.c | 15 --- >> > 1 file changed, 8 insertions(+), 7 deletions(-) >> >

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: support BGRA pixel format

2019-02-02 Thread Thomas Volkert
On 02.02.2019 16:14, Carl Eugen Hoyos wrote: > 2019-02-02 16:05 GMT+01:00, Thomas Volkert : >> From: Thomas Volkert >> >> --- >> libavcodec/libx264.c | 15 --- >> 1 file changed, 8 insertions(+), 7 deletions(-) >> >> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c >> index a3

Re: [FFmpeg-devel] [PATCH] lavf/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-02 Thread Marton Balint
On Sat, 2 Feb 2019, Charles Liu wrote: Binary searching would hang if the fragment items do NOT have timestamp for the specified stream. For example, a fmp4 consists of separated 'moof' boxes for each track, and separated 'sidx' for each segment, but no 'mfra' box. Then every fragment item

Re: [FFmpeg-devel] [PATCH 2/2] lavf/mpegts: add reading of ARIB data coding descriptor

2019-02-02 Thread Marton Balint
On Sat, 2 Feb 2019, Jan Ekström wrote: This enables us to read the data coding type utilized for a specific private data stream, of which we currently are interested in ARIB caption streams. The component tag limitations are according to ARIB TR-B14, and the component IDs are defined in ARIB

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: support BGRA pixel format

2019-02-02 Thread Thomas Volkert
On 02.02.2019 16:18, Jan Ekström wrote: > On Sat, Feb 2, 2019 at 5:14 PM Carl Eugen Hoyos wrote: >> 2019-02-02 16:05 GMT+01:00, Thomas Volkert : >>> From: Thomas Volkert >>> >>> --- >>> libavcodec/libx264.c | 15 --- >>> 1 file changed, 8 insertions(+), 7 deletions(-) >>> >>> diff --

Re: [FFmpeg-devel] [PATCH 2/2] lavf/mpegts: add reading of ARIB data coding descriptor

2019-02-02 Thread Jan Ekström
On Sat, Feb 2, 2019 at 6:13 PM Marton Balint wrote: > > > > On Sat, 2 Feb 2019, Jan Ekström wrote: > > > This enables us to read the data coding type utilized for > > a specific private data stream, of which we currently are > > interested in ARIB caption streams. > > > > The component tag limitat

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mips: [loongson] optimize put_hevc_qpel_uni_hv_8 with mmi.

2019-02-02 Thread Michael Niedermayer
On Fri, Feb 01, 2019 at 02:04:59PM +0800, Shiyou Yin wrote: > Optimize put_hevc_qpel_uni_hv_8 with mmi in the case > width=4/8/12/16/24/32/48/64. > This optimization improved HEVC decoding performance 2.7%(2.24x to 2.30x, > tested on loongson 3A3000). > --- > libavcodec/mips/hevcdsp_init_mips.c

[FFmpeg-devel] RTMPS Patch

2019-02-02 Thread Chen Fisher
Hello all, I've submitted a patch more than a week ago and it hasn't been reviewed yet. I see a lot of patches without someone reviewing them and I was wondering what is the process and how do I get my patch to be reviewed? I have several others in the pipeline... https://patchwork.ffmpeg.org/pat

[FFmpeg-devel] [PATCH 2/3] avcodec/mpeg4_unpack_bframes_bsf: Use avpriv_find_start_code

2019-02-02 Thread Andreas Rheinhardt
instead of an ad-hoc function to search for start codes in order to remove code duplication and to improve performance. Improved performance of finding startcodes from 52606 decicycles to 9543 decicycles based upon 262144 runs for a 1 Mb/s MPEG4 video. Signed-off-by: Andreas Rheinhardt --- liba

[FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4_unpack_bframes_bsf: Improve DivX userdata check

2019-02-02 Thread Andreas Rheinhardt
The earlier version didn't really check that the 'p' of a "p\0" is actually part of a DivX user_data section, instead it treated the first "p\0" after the start of a user_data section as end of a DivX user_data section if it is close enough to the beginning of the user_data section; it actually nee

[FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4videodec: Fix nonsense warning

2019-02-02 Thread Andreas Rheinhardt
Since db772308941a2a338c7809f90d347219a6a93074 parsing of mpeg4-extradata lead to a "Failed to parse extradata" warning, because ff_mpeg4_decode_picture_header returns AVERROR_INVALIDDATA in case that no VOP was found. This patch changes the return value back to -1 in case no error occured and no V

Re: [FFmpeg-devel] RTMPS Patch

2019-02-02 Thread Marton Balint
On Sat, 2 Feb 2019, Chen Fisher wrote: Hello all, I've submitted a patch more than a week ago and it hasn't been reviewed yet. I see a lot of patches without someone reviewing them and I was wondering what is the process and how do I get my patch to be reviewed? I have several others in the p

[FFmpeg-devel] [PATCH 2/2 v2] lavf/mpegts: add reading of ARIB data coding descriptor

2019-02-02 Thread Jan Ekström
This enables us to read the data coding type utilized for a specific private data stream, of which we currently are interested in ARIB caption streams. The component tag limitations are according to ARIB TR-B14, and the component IDs are defined in ARIB STD-B10. --- libavformat/mpegts.c | 44 +++