Re: [FFmpeg-devel] [PATCH] avformat/mov: set AVFMT_SEEK_TO_PTS flag

2019-05-02 Thread Gyan
On 03-05-2019 10:01 AM, Gyan wrote: On 03-05-2019 03:00 AM, Hendrik Leppkes wrote: On Thu, May 2, 2019 at 7:42 PM Sasi Inguva wrote: Looks good to me. We were already doing PTS based seeking in MOV demuxer (although it's not perfect). There are several problems with the MOV approach

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-02 Thread Jeyapal, Karthick
On Sun, Apr 28, 2019 at 4:02 PM Marton Balint wrote: > Hi All, > > There has been discussion on the mailing list several times about the > inclusion of support for closed source components (codecs, formats, > filters, etc) in the main ffmpeg codebase. > > Also the removal of libNDI happened

Re: [FFmpeg-devel] [PATCH] avformat/mov: set AVFMT_SEEK_TO_PTS flag

2019-05-02 Thread Gyan
On 03-05-2019 03:00 AM, Hendrik Leppkes wrote: On Thu, May 2, 2019 at 7:42 PM Sasi Inguva wrote: Looks good to me. We were already doing PTS based seeking in MOV demuxer (although it's not perfect). There are several problems with the MOV approach however. You cannot look at

Re: [FFmpeg-devel] [PATCH] lavfi: add gblur_opencl filter

2019-05-02 Thread Dylan Fernando
On Thu, May 2, 2019 at 11:27 PM Paul B Mahol wrote: > On 5/2/19, Dylan Fernando wrote: > > On Tue, 30 Apr 2019 at 11:45 pm, Paul B Mahol wrote: > > > >> On 4/30/19, Dylan Fernando wrote: > >> > > >> > Anyone have any feedback? > >> > >> If I'm not mistaken there is already one available. > >>

Re: [FFmpeg-devel] [PATCH] avformat/mov: set AVFMT_SEEK_TO_PTS flag

2019-05-02 Thread Hendrik Leppkes
On Thu, May 2, 2019 at 7:42 PM Sasi Inguva wrote: > > Looks good to me. We were already doing PTS based seeking in MOV demuxer > (although it's not perfect). > There are several problems with the MOV approach however. You cannot look at AVStream->index_entries, take a timestamp of such an index,

Re: [FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

2019-05-02 Thread Panagiotis Malakoudis
OK, here it is again, attached. Στις Πέμ, 2 Μαΐ 2019 στις 9:56 μ.μ., ο/η Carl Eugen Hoyos έγραψε: > > Am Do., 2. Mai 2019 um 20:52 Uhr schrieb Panagiotis Malakoudis > : > > > > > On Thu, May 02, 2019 at 08:13:10PM +0300, Panagiotis Malakoudis wrote: > > > > > --- libavformat/mpegts.c 2019-04-30

[FFmpeg-devel] [PATCH 2/2] avformat/webm_chunk: Check header filename length

2019-05-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/webm_chunk.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 561ec152e7..e2fbd8be1d 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_chunk.c @@

Re: [FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

2019-05-02 Thread Panagiotis Malakoudis
> On Thu, May 02, 2019 at 08:13:10PM +0300, Panagiotis Malakoudis wrote: > > When outputing to mpegts format, using -copyts option makes program > > fail after the oveflow of mpegts PCR happens at around 26 hours and 30 > > minutes. When not using -copyts, only a warning is reported. > > In order

Re: [FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

2019-05-02 Thread Carl Eugen Hoyos
Am Do., 2. Mai 2019 um 20:52 Uhr schrieb Panagiotis Malakoudis : > > > On Thu, May 02, 2019 at 08:13:10PM +0300, Panagiotis Malakoudis wrote: > > > --- libavformat/mpegts.c 2019-04-30 16:11:49.0 +0300 > > > +++ libavformat/mpegts.c 2019-04-30 18:55:12.736428766 +0300 > > > > doesnt apply

[FFmpeg-devel] [PATCH 1/2] avformat/webm_chunk: Fix argument length of get_chunk_filename()

2019-05-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/webm_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 2c99753b5b..561ec152e7 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_chunk.c @@ -84,7 +84,7

Re: [FFmpeg-devel] [PATCH 1/3] lavf/webm_chunk: Respect buffer size

2019-05-02 Thread Michael Niedermayer
On Sat, Apr 20, 2019 at 12:03:14AM +0200, Andreas Rheinhardt wrote: > The last argument of av_strlcpy is supposed to contain the size of the > destination buffer, but it was filled with the size of the source > string, effectively negating its very purpose. > > Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH v8] lavf/flv: Add XV (Xunlei Video) Support. fixes ticket #3720

2019-05-02 Thread Shivam Goyal
The patch fixes ticket #3720. Add Xunlei video support. Suggestions are appreciated. Thank you Shivam GoyalFrom 0f0d87b499c1e91bf2b6265a61e964c1a16da8de Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Thu, 2 May 2019 23:27:24 +0530 Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support.

Re: [FFmpeg-devel] [PATCH] avformat/mov: set AVFMT_SEEK_TO_PTS flag

2019-05-02 Thread Sasi Inguva
Looks good to me. We were already doing PTS based seeking in MOV demuxer (although it's not perfect). On Thu, May 2, 2019 at 3:23 AM Gyan wrote: > > FATE passes. Checked that transcoded output remains the same whereas in > copy mode, seek to a video KF using ffmpeg cli returns the desired KF >

Re: [FFmpeg-devel] [PATCH] avcodec/cinepak: Add missing const qualifier

2019-05-02 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, May 02, 2019 at 06:27:22AM +0200, Andreas Rheinhardt wrote: >> Has been forgotten in b606493717db6424d693e1a944f51171e9e72905. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/cinepak.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > fixed

Re: [FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

2019-05-02 Thread Michael Niedermayer
On Thu, May 02, 2019 at 08:13:10PM +0300, Panagiotis Malakoudis wrote: > When outputing to mpegts format, using -copyts option makes program > fail after the oveflow of mpegts PCR happens at around 26 hours and 30 > minutes. When not using -copyts, only a warning is reported. > In order to

Re: [FFmpeg-devel] [PATCH] avcodec/cinepak: Add missing const qualifier

2019-05-02 Thread Michael Niedermayer
On Thu, May 02, 2019 at 06:27:22AM +0200, Andreas Rheinhardt wrote: > Has been forgotten in b606493717db6424d693e1a944f51171e9e72905. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cinepak.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) fixed as someone on IRC pinged about

[FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

2019-05-02 Thread Panagiotis Malakoudis
When outputing to mpegts format, using -copyts option makes program fail after the oveflow of mpegts PCR happens at around 26 hours and 30 minutes. When not using -copyts, only a warning is reported. In order to reproduce the issue, you first have to create a 27 hour mpegts video. I have described

Re: [FFmpeg-devel] [PATCH 3/5] doc/general.texi: remove note about regressed AviSynth+ header

2019-05-02 Thread Stephen Hutchinson
On 3/30/2019 7:39 PM, Stephen Hutchinson wrote: I've uploaded the amended 1st patch and added a 6th to deal with the issues I encountered when testing the 'build FFmpeg with MSVC' route.  Since git send-email (or Gmail) screwed up the threading when I sent these the first time, this is the

Re: [FFmpeg-devel] [PATCH] doc/general.texi: add note about 32-bit GCC builds of AviSynth+

2019-05-02 Thread Stephen Hutchinson
On 3/31/2019 8:12 PM, Stephen Hutchinson wrote: --- The text has been updated to reflect that 32-bit builds of FFmpeg in general don't default to AviSynth+GCC compatibility. doc/general.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/general.texi

Re: [FFmpeg-devel] [PATCH 1/3] lavf/webm_chunk: Respect buffer size

2019-05-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The last argument of av_strlcpy is supposed to contain the size of the > destination buffer, but it was filled with the size of the source > string, effectively negating its very purpose. > > Signed-off-by: Andreas Rheinhardt > --- > As the author information in my previous

Re: [FFmpeg-devel] [PATCH] lavfi: add gblur_opencl filter

2019-05-02 Thread Paul B Mahol
On 5/2/19, Dylan Fernando wrote: > On Tue, 30 Apr 2019 at 11:45 pm, Paul B Mahol wrote: > >> On 4/30/19, Dylan Fernando wrote: >> > >> > Anyone have any feedback? >> >> If I'm not mistaken there is already one available. >> ___ >> ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] lavfi: add gblur_opencl filter

2019-05-02 Thread Dylan Fernando
On Tue, 30 Apr 2019 at 11:45 pm, Paul B Mahol wrote: > On 4/30/19, Dylan Fernando wrote: > > > > Anyone have any feedback? > > If I'm not mistaken there is already one available. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-02 Thread Carl Eugen Hoyos
Am Do., 2. Mai 2019 um 12:30 Uhr schrieb Timo Rothenpieler : > > On 28/04/2019 22:02, Marton Balint wrote: > > 1) Should libNDI support be removed from the ffmpeg codebase? > > No What do you suggest instead? Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-05-02 Thread Shivam Goyal
On 02-05-2019 16:16, Moritz Barsnick wrote: > On Thu, May 02, 2019 at 10:33:41 +0530, shi...@iitk.ac.in wrote: > > A minor nitpick (which the person pushing will/should notice): > >> #define LIBAVFORMAT_VERSION_MAJOR 58 >> -#define LIBAVFORMAT_VERSION_MINOR 27 >> +#define

Re: [FFmpeg-devel] [PATCH v2] avcodec: add realtime bitstream filter

2019-05-02 Thread Gyan
On 02-05-2019 04:12 PM, Moritz Barsnick wrote: On Wed, May 01, 2019 at 12:03:41 -0300, James Almer wrote: +if (pkt->pts != AV_NOPTS_VALUE) { +int64_t pts = av_rescale_q(pkt->pts, bsf->time_base_in, AV_TIME_BASE_Q) / ctx->speed; +int64_t now = av_gettime_relative(); +

Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-05-02 Thread Moritz Barsnick
On Thu, May 02, 2019 at 10:33:41 +0530, shi...@iitk.ac.in wrote: A minor nitpick (which the person pushing will/should notice): > #define LIBAVFORMAT_VERSION_MAJOR 58 > -#define LIBAVFORMAT_VERSION_MINOR 27 > +#define LIBAVFORMAT_VERSION_MINOR 28 > #define LIBAVFORMAT_VERSION_MICRO 103

Re: [FFmpeg-devel] [PATCH v2] avcodec: add realtime bitstream filter

2019-05-02 Thread Moritz Barsnick
On Wed, May 01, 2019 at 12:03:41 -0300, James Almer wrote: > > +if (pkt->pts != AV_NOPTS_VALUE) { > > +int64_t pts = av_rescale_q(pkt->pts, bsf->time_base_in, > > AV_TIME_BASE_Q) / ctx->speed; > > +int64_t now = av_gettime_relative(); > > +int64_t sleep = pts - now +

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-02 Thread Timo Rothenpieler
On 28/04/2019 22:02, Marton Balint wrote: Hi All, There has been discussion on the mailing list several times about the inclusion of support for closed source components (codecs, formats, filters, etc) in the main ffmpeg codebase. Also the removal of libNDI happened without general

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-05-02 Thread Gyan
On 02-05-2019 03:23 PM, Nicolas George wrote: Gyan (12019-04-28): b) ffmpeg will call avformat_write_header for the output, which will likely fail because of the aforementioned codec parameter issues. Are you sure? It looks to me like avformat_write_header() does not perform checks by

[FFmpeg-devel] [PATCH] avformat/mov: set AVFMT_SEEK_TO_PTS flag

2019-05-02 Thread Gyan
FATE passes. Checked that transcoded output remains the same whereas in copy mode, seek to a video KF using ffmpeg cli returns the desired KF and not the earlier KF, as happens at present. Gyan From 029a75fe27e576cd0d04c8bdd0707d7903250bac Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date:

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-05-02 Thread Nicolas George
Gyan (12019-04-28): > b) ffmpeg will call avformat_write_header for the output, which will likely > fail because of the aforementioned codec parameter issues. Are you sure? It looks to me like avformat_write_header() does not perform checks by itself, and null does not either. > The pipeline for

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-02 Thread Nicolas George
Marton Balint (12019-04-28): > 1) Should libNDI support be removed from the ffmpeg codebase? Yes. > 2) Should patches using closed source libraries which are not considered > "System Libraries" according to the GPL be rejected? Yes to that too, even though the vote was withdrawn pending

Re: [FFmpeg-devel] [PATCH v2] avfilter/f_realtime: add option to scale speed

2019-05-02 Thread Nicolas George
Moritz Barsnick (12019-05-01): > --- > doc/filters.texi | 8 > libavfilter/f_realtime.c | 7 +-- > 2 files changed, 13 insertions(+), 2 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH V5 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-05-02 Thread avih
> It seems awk is unconditionally required already. However I wanted to > say that it's a very nice dep to have While it's possibly nicer than other deps to have, it's still better to use it IMHO only when it adds some value, like simpler code, better performance, compliance with some things,

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mediacodecdec: try to receive a frame after signaling EOF to the codec

2019-05-02 Thread Matthieu Bouron
On Wed, Apr 24, 2019 at 09:59:28AM +0200, Matthieu Bouron wrote: > Avoids returning EAGAIN after signaling EOF to the codec in > ff_mediacodec_dec_send() so we can try to receive a frame before > returning in mediacodec_receive_frame(). > > This helps avoiding an extra round-trip between

Re: [FFmpeg-devel] [PATCH v7] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720

2019-05-02 Thread shivgo
On 2019-05-02 11:22, Gyan wrote: > On 02-05-2019 10:33 AM, shi...@iitk.ac.in wrote: > >> lavf/flv: Add XV (Xunlei Video) Support. >> The patch fixes ticket #3720. >> It would just skip the first packet, which stores the decrypted data and >> moves on the next packet. >> Also, Thank you Moritz