Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand index

> -Original Message- > From: ffmpeg-devel On Behalf Of Carl > Eugen Hoyos > Sent: 2020年6月16日 18:57 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand > index > > > > > Am 16.06.2020 um 10:18 schrieb Guo, Yejun

Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand index

On Wed, Jun 10, 2020 at 10:04 PM Guo Yejun wrote: > > it fixed the issue in https://trac.ffmpeg.org/ticket/8716 > > Signed-off-by: Guo Yejun > --- > libavfilter/dnn/dnn_backend_native.c | 6 +- > libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 7 ++- >

Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand index

> -Original Message- > From: ffmpeg-devel On Behalf Of > myp...@gmail.com > Sent: 2020年6月16日 14:18 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand > index > > On Wed, Jun 10, 2020 at 10:04 PM Guo Yejun

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

mån 2020-06-15 klockan 21:45 +0200 skrev Marton Balint: > > On Mon, 15 Jun 2020, Tomas Härdin wrote: > > > sön 2020-06-14 klockan 20:19 +0200 skrev Marton Balint: > > > On Sun, 14 Jun 2020, Michael Niedermayer wrote: > > > > > > > Alternatively we could free the already allocated element > > >

Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

Fu, Linjie (12020-06-12): > IIRC, the global header in extra data is optional in codec level. Where did you take that? The way I understand it, people who design codec will decide if they use global extradata or not, but if they decide to, it is necessary to decode the data. Otherwise, it would

[FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Calculate average bitrate for adaptation sets in static manifest

If stream's bitrate is not specified: - for static manifest: an average bitrate will be calculated and used, - for dynamic manifest: first segment's bitrate will be calculated and used, as before, for bandwidth setting in adaptation sets. For dynamic manifest --- libavformat/dashenc.c | 28

[FFmpeg-devel] [PATCH v5 3/3] fate: add yuv420p10 and yuv422p10 tests for overlay filter

From: Limin Wang Signed-off-by: Limin Wang --- tested on x86_64, x86_32, qemu mips 32bit tests/fate/filter-video.mak | 8 tests/filtergraphs/overlay_yuv420p10| 5 + tests/filtergraphs/overlay_yuv422p10| 5 + tests/ref/fate/filter-overlay_yuv420p10 | 8

Re: [FFmpeg-devel] [PATCH 2/7] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

Paul B Mahol (12020-06-12): > How so? Its purely random. +ret = ff_inlink_peek_samples(inlink, s->win_size, ); +ret = ff_inlink_peek_samples(inlink, s->window_size, ); They seem constant in both cases. Can you elaborate about this randomness? -- Nicolas George

Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native: check operand index

> Am 16.06.2020 um 10:18 schrieb Guo, Yejun : > > I personally like to always add '{}' to avoid possible mistakes when we > change code in the future. Some coding styles also recommend this method. > > I checked at http://ffmpeg.org/developer.html#Coding-Rules and do not find an > explicit

[FFmpeg-devel] [PATCH] area changed: hevc_amf set default gops_per_idr 1

Previously gops_per_idr default 60 would make amd gpu encoding hevc has erratic seek bar behaviour as descripted in this ticket: https://trac.ffmpeg.org/ticket/7272 --- libavcodec/amfenc_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH v3 0/7] adpcm_ima_apm encoder + apm muxer

On Fri, 12 Jun 2020 11:46:08 + "Zane van Iperen" wrote: > > Add support for encoding adpcm_ima_apm and muxing to apm. > > If possible, I would like to get this functionality into the 4.3 > release. > Ping 2. Also, I noticed that patches 3 and 4 should probably be swapped. Zane

[FFmpeg-devel] [PATCH] area changed: hevc_amf set default gops_per_idr 1

Previously gops_per_idr default 60 would make amd gpu encoding hevc has erratic seek bar behaviour as descripted in this ticket: https://trac.ffmpeg.org/ticket/7272 --- libavcodec/amfenc_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

> From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Tuesday, June 16, 2020 21:40 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and > recreate encoder instance if resolution changes > > Fu, Linjie

Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

> From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Tuesday, June 16, 2020 18:55 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and > recreate encoder instance if resolution changes > > Fu, Linjie

Re: [FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: flush and recreate encoder instance if resolution changes

Fu, Linjie (12020-06-16): > Chapter 2.3 Parameter Sets in < High Efficiency Video Coding (HEVC) > Algorithms and Architectures> [1]: That is ONE codec. Not all of them. > Indeed, the definition in spec is just the conformance, and how an encoder is > implemented in Libavcodec (and external

[FFmpeg-devel] [PATCH 1/2] Revert "avformat/dashenc: use AVStream timebase when computing missing bitrate"

This reverts commit 2a9ffd89fcb09bd69b2130da039ad2caba79cf33 as duration is always in AV_TIME_BASE units --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 3e587acdff..05deb5c1b5 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Calculate average bitrate for adaptation sets in static manifest

> > +av_log(s, AV_LOG_INFO, "segment_bitrate: %"PRId64", > os->first_segment_bit_rate: %i, os->average_bit_rate: %f\n", > +segment_bitrate, os->first_segment_bit_rate, > os->average_bit_rate); > Just found this redundant av_log. Will fix if the overall solution is

Re: [FFmpeg-devel] [PATCH] area changed: hevc_amf set default gops_per_idr 1

Am Di., 16. Juni 2020 um 16:10 Uhr schrieb Lu Jiao : > > Previously gops_per_idr default 60 would make amd gpu encoding hevc > has erratic seek bar behaviour as descripted in this ticket: > https://trac.ffmpeg.org/ticket/7272 Is this patch working around a defect in FFmpeg (that the

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Calculate average bitrate for adaptation sets in static manifest

On 6/16/20 6:02 PM, Przemysław Sobala wrote: > If stream's bitrate is not specified: > - for static manifest: an average bitrate will be calculated and used, > - for dynamic manifest: first segment's bitrate will be calculated and used, > as before, > for bandwidth setting in adaptation sets. >

[FFmpeg-devel] [PATCH 3/5] avcodec/aacdectab: add mapping for 22.2

Utilizes the newly added 22.2 channel layout for channel_layout 13. --- libavcodec/aacdectab.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdectab.h b/libavcodec/aacdectab.h index baf51a74bf..c54a3eb943 100644 ---

[FFmpeg-devel] [PATCH 0/5] 22.2 channel layout support for AAC decoding

Now that we actually have sample(s) for channel_config 13, it was possible to see at which various points the AAC decoder fails attempting to parse the bit stream. I have not yet found or generated a channel layout test sample so I could fully validate the channel map output by the AAC decoder,

[FFmpeg-devel] [PATCH 1/5] avutil/channel_layout: add 22.2 layout

Requires some extraneous top side and bottom front channels to be defined. According to STD-B59v2, the defined channel layout is: - FL - FR - FC - LFE1 - BL - BR - FLc - FRc - BC - LFE2 - SiL - SiR - TpFL - TpFR - TpFC - TpC - TpBL - TpBR - TpSiL - TpSiR - TpBC - BtFC - BtFL - BtFR ---

[FFmpeg-devel] [PATCH 2/5] avcodec/mpeg4audio: add newer channel_coding mappings

Additionally, add comments regarding their definitions. Based on ARIB STD-B32, which bases on 14496-3:2009 and 14496-3:2009/AMD4. --- libavcodec/mpeg4audio.c | 17 +++-- libavcodec/mpeg4audio.h | 2 +- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/5] avcodec/aacdec_template: add support for 22.2 / channel_config 13

--- libavcodec/aacdec_template.c | 53 +++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index 0590e77d75..0be0ad6566 100644 --- a/libavcodec/aacdec_template.c +++

Re: [FFmpeg-devel] [PATCH] area changed: hevc_amf set default gops_per_idr 1

I think it is desirable as AMD HEVC encoder frequency of IDR frames is needed to be 1 to indicate key frames used in seek , and it is not defect in ffmpeg decoder. Jiao lu From: Carl Eugen Hoyos Sent: 2020年6月17日 0:21 To: FFmpeg development discussions and

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: Error out on duplicated utf16 strings

On Tue, Jun 16, 2020 at 02:05:04PM +0200, Tomas Härdin wrote: > mån 2020-06-15 klockan 21:45 +0200 skrev Marton Balint: > > > > On Mon, 15 Jun 2020, Tomas Härdin wrote: > > > > > sön 2020-06-14 klockan 20:19 +0200 skrev Marton Balint: > > > > On Sun, 14 Jun 2020, Michael Niedermayer wrote: > > >

[FFmpeg-devel] [PATCH 4/5] avcodec/aacdec_template: mark second LFE element as LFE2

We now have the capability to do this. --- libavcodec/aacdec_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index a473e1bad7..0590e77d75 100644 --- a/libavcodec/aacdec_template.c +++