Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-04 Thread Carl Eugen Hoyos
Kieran Kunhya kierank at obe.tv writes: In general you should not be probing if there are descriptors because the descriptors are designed to make the codec detection unambiguous. I thought it should be exactly the other way around if the probing returns a sufficiently high score:

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-04 Thread Carl Eugen Hoyos
Kieran Kunhya kierank at obe.tv writes: In general you should not be probing if there are descriptors because the descriptors are designed to make the codec detection unambiguous. I thought it should be exactly the other way around if the probing returns a sufficiently high score:

Re: [FFmpeg-devel] [PATCH] Add SUP (raw BluRay PGS subtitle) muxer

2014-09-04 Thread Hendrik Leppkes
On Fri, Aug 29, 2014 at 12:31 PM, Petri Hintukainen phint...@gmail.com wrote: From: Petri Hintukainen phint...@users.sourceforge.net Fixes ticket #2208 --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/supenc.c | 61

Re: [FFmpeg-devel] [PATCH] avdevice/x11grab: fix error handling in pixel formats

2014-09-04 Thread Benoit Fouet
Hi, - Mail original - Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavdevice/x11grab.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavdevice/x11grab.c b/libavdevice/x11grab.c index 120f754..e0d1dfa 100644 --- a/libavdevice/x11grab.c

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Michael Niedermayer
Hi Reinhard On Wed, Sep 03, 2014 at 11:33:48PM -0400, Reinhard Tartler wrote: On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Sep 03, 2014 at 08:22:43PM -0400, Reinhard Tartler wrote: On Wed, Sep 3, 2014 at 9:39 AM, Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] [PATCH] avdevice/x11grab: fix error handling in pixel formats

2014-09-04 Thread Michael Niedermayer
On Thu, Sep 04, 2014 at 10:27:34AM +0200, Benoit Fouet wrote: Hi, - Mail original - Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavdevice/x11grab.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavdevice/x11grab.c

Re: [FFmpeg-devel] [PATCH 1/1] libavdevice/v4l2: fix descriptors leak on error paths

2014-09-04 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 03:46:03PM +0400, xe-l...@yandex.ru wrote: From: Dmitry Volyntsev xeioexcept...@gmail.com Signed-off-by: Dmitry Volytnsev xeioexcept...@gmail.com applied thanks to all [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay

Re: [FFmpeg-devel] [PATCH] doc/filters.texi: remove incorrect duration syntax

2014-09-04 Thread Stefano Sabatini
On date Thursday 2014-09-04 01:17:16 -0700, Mark Harris encoded: The actual duration syntax with optional hours can be found in the ffmpeg-utils doc, but mention only seconds for filter options because : is an option separator (at least on the command line). But you can escape : or you could

[FFmpeg-devel] [PATCH]refine the flv tagtype read for check as spec

2014-09-04 Thread Steven Liu
from the flv spec, the flvtag define the tagtype as one byte, the spec desc is: Reserved UB[2] Reserved for FMS, should be 0 FilterUB[1] Indicates if packets are filtered. 0 = No pre-processing required. 1 = Pre-processing (such as decryption) of the packet is

Re: [FFmpeg-devel] [PATCH] Add SUP (raw BluRay PGS subtitle) muxer

2014-09-04 Thread Petri Hintukainen
On to, 2014-09-04 at 10:19 +0200, Hendrik Leppkes wrote: On Fri, Aug 29, 2014 at 12:31 PM, Petri Hintukainen phint...@gmail.com wrote: From: Petri Hintukainen phint...@users.sourceforge.net Fixes ticket #2208 --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 +

Re: [FFmpeg-devel] [PATCH v2] ffprobe: Add bits_per_component to stream output

2014-09-04 Thread Tobias Rapp
Previous patch did contain an obsolete line in function av_get_bits_per_component. New patch file attached. Regards, Tobias From 2271a50358e9d464dd53ed9936581e11b28e5940 Mon Sep 17 00:00:00 2001 From: Tobias Rapp t.r...@noa-audio.com Date: Thu, 4 Sep 2014 14:47:14 +0200 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH]refine the flv tagtype read for check as spec

2014-09-04 Thread Michael Niedermayer
On Thu, Sep 04, 2014 at 08:23:19PM +0800, Steven Liu wrote: from the flv spec, the flvtag define the tagtype as one byte, the spec desc is: Reserved UB[2] Reserved for FMS, should be 0 FilterUB[1] Indicates if packets are filtered. 0 = No pre-processing required.

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-09-04 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 07:30:49PM +0200, Michael Niedermayer wrote: On Thu, Aug 28, 2014 at 01:28:18PM +0200, Andreas Cadhalpun wrote: On 28.08.2014 04:36, Michael Niedermayer wrote: On Wed, Aug 27, 2014 at 05:21:18PM -0800, Lou Logan wrote: On Tue, 26 Aug 2014 13:41:42 +0200, Michael

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread wm4
On Wed, 3 Sep 2014 23:33:48 -0400 Reinhard Tartler siret...@gmail.com wrote: On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Sep 03, 2014 at 08:22:43PM -0400, Reinhard Tartler wrote: On Wed, Sep 3, 2014 at 9:39 AM, Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

2014-09-04 Thread Michael Niedermayer
On Thu, Sep 04, 2014 at 03:36:03PM +0200, Michael Niedermayer wrote: On Wed, Sep 03, 2014 at 07:30:49PM +0200, Michael Niedermayer wrote: On Thu, Aug 28, 2014 at 01:28:18PM +0200, Andreas Cadhalpun wrote: On 28.08.2014 04:36, Michael Niedermayer wrote: On Wed, Aug 27, 2014 at 05:21:18PM

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-04 Thread Roger Pack
Do you have some instructions on how to get the headers to make this download work? Any links to some device to exercise the code, like on amazon [cheaper better LOL]. On Tue, Sep 2, 2014 at 3:26 AM, Deti Fliegl d...@fliegl.de wrote: On 30.08.14 01:22, Michael Niedermayer wrote: moving code

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Michael Niedermayer
On Thu, Sep 04, 2014 at 03:53:55PM +0200, wm4 wrote: On Wed, 3 Sep 2014 23:33:48 -0400 Reinhard Tartler siret...@gmail.com wrote: On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Sep 03, 2014 at 08:22:43PM -0400, Reinhard Tartler wrote: On Wed, Sep

Re: [FFmpeg-devel] [PATCH v3] ffprobe: Add bits_per_component to stream output

2014-09-04 Thread Tobias Rapp
On 04.09.2014 15:38, Dave Rice wrote: Attached patch adds bits_per_component (bit depth) output for video streams. Adding an element to the ffprobe output requires a change to ffprobe.xsd as well. Indeed. Attached patch version 3 now includes the update to ffprobe.xsd. Regards, Tobias From

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-04 Thread Deron
On 9/4/14 8:06 AM, Roger Pack wrote: Do you have some instructions on how to get the headers to make this download work? Any links to some device to exercise the code, like on amazon [cheaper better LOL]. The DeckLink headers/sdk/libraries can be found at blackmagicdesign.com. The last copy I

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Derek Buitenhuis
On 9/4/2014 4:33 AM, Reinhard Tartler wrote: So the promise given in https://lists.libav.org/pipermail/libav-devel/2012-February/020712.html doesn't hold anymore? Any chance to make you reconsider reviving the standalone libpostproc.git? Guilty party here. I kinda just neglected it because

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread wm4
On Thu, 4 Sep 2014 16:30:14 +0200 Michael Niedermayer michae...@gmx.at wrote: On Thu, Sep 04, 2014 at 03:53:55PM +0200, wm4 wrote: On Wed, 3 Sep 2014 23:33:48 -0400 Reinhard Tartler siret...@gmail.com wrote: On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

2014-09-04 Thread wm4
On Thu, 04 Sep 2014 10:07:19 +0200 Jörg Krause jkra...@posteo.de wrote: On 09/03/2014 08:12 PM, Michael Niedermayer wrote: On Wed, Sep 03, 2014 at 11:53:39AM +0200, Jörg Krause wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test

Re: [FFmpeg-devel] [PATCH v3] ffprobe: Add bits_per_component to stream output

2014-09-04 Thread wm4
On Thu, 04 Sep 2014 16:31:45 +0200 Tobias Rapp t.r...@noa-audio.com wrote: From 4a2290540ae0761c6ea2a5f12326ad8dd1257e57 Mon Sep 17 00:00:00 2001 From: Tobias Rapp t.r...@noa-audio.com Date: Thu, 4 Sep 2014 16:25:22 +0200 Subject: [PATCH] ffprobe: Add bits_per_component to stream output

Re: [FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

2014-09-04 Thread wm4
On Thu, 4 Sep 2014 17:27:48 +0200 Hendrik Leppkes h.lepp...@gmail.com wrote: On Wed, Sep 3, 2014 at 11:53 AM, Jörg Krause jkra...@posteo.de wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Michael Niedermayer
On Thu, Sep 04, 2014 at 05:23:12PM +0200, wm4 wrote: On Thu, 4 Sep 2014 16:30:14 +0200 Michael Niedermayer michae...@gmx.at wrote: On Thu, Sep 04, 2014 at 03:53:55PM +0200, wm4 wrote: On Wed, 3 Sep 2014 23:33:48 -0400 Reinhard Tartler siret...@gmail.com wrote: [...] Iam not saying

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-04 Thread Dave Rice
On Sep 4, 2014, at 10:44 AM, Deron de...@pagestream.org wrote: On 9/4/14 8:06 AM, Roger Pack wrote: Do you have some instructions on how to get the headers to make this download work? Any links to some device to exercise the code, like on amazon [cheaper better LOL]. The DeckLink

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: add ff_hevc_transform_add32_8_avx2

2014-09-04 Thread Michael Niedermayer
On Sun, Aug 31, 2014 at 11:46:13PM -0300, James Almer wrote: ~20% faster than AVX. Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/hevc_res_add.asm | 31 +++ libavcodec/x86/hevcdsp.h| 2 ++ libavcodec/x86/hevcdsp_init.c | 2 ++ 3

Re: [FFmpeg-devel] [PATCH] doc/filters.texi: remove incorrect duration syntax

2014-09-04 Thread Mark Harris
Stefano Sabatini wrote: What about: Specify time for starting to apply the fade effect. Default is 0. The value must be specified as a time duration, see @ref{date syntax,,the Date section in the ffmpeg-utils(1) manual,ffmpeg-utils}. Same below. Ok, I am sending a new patch, replacing

[FFmpeg-devel] [PATCH] doc/filters.texi: fix time duration references

2014-09-04 Thread Mark Harris
Make time duration references consistent, using @ref links, and eliminate incorrect syntax [-]HH[:MM[:SS[.m...]]]. --- doc/filters.texi | 68 1 file changed, 29 insertions(+), 39 deletions(-) diff --git a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH] SSE2 version of vf_idet's filter_line()

2014-09-04 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 02:04:43PM -0700, Pascal Massimino wrote: Clément On Wed, Sep 3, 2014 at 12:37 PM, Clément Bœsch u...@pkh.me wrote: On Wed, Sep 03, 2014 at 07:05:48PM +0200, Pascal Massimino wrote: [...] +punpcklbw m3, m_zero +punpckhbw m4, m_zero + +

[FFmpeg-devel] [PATCH v2 4/6] avformat/realtextdec: UTF-16 support

2014-09-04 Thread wm4
Also remove ff_smil_extract_next_chunk - this was the last user of it. --- No changes. --- libavformat/realtextdec.c | 17 ++--- libavformat/subtitles.c | 9 - libavformat/subtitles.h | 5 - 3 files changed, 10 insertions(+), 21 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 3/6] avformat/samidec: UTF-16 support

2014-09-04 Thread wm4
ff_smil_extract_next_chunk() is still used by RealText. --- No changes. --- libavformat/samidec.c | 17 ++--- libavformat/subtitles.c | 15 --- libavformat/subtitles.h | 5 + 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/libavformat/samidec.c

[FFmpeg-devel] [PATCH v2 1/6] avformat/assdec: UTF-16 support

2014-09-04 Thread wm4
Use the UTF-16 BOM to detect UTF-16 encoding. Convert the file contents to UTF-8 on the fly using FFTextReader, which acts as converting wrapper around AVIOContext. It also can work on a static buffer, needed for format probing. The FFTextReader wrapper now also takes care of skipping the UTF-8

[FFmpeg-devel] [PATCH v2 2/6] avformat/srtdec: UTF-16 support

2014-09-04 Thread wm4
--- ff_subtitles_read_line() now returns an error if a 0 byte is encountered. This is faster and could be considered more correct. It also handles UTF recode errors better. --- libavformat/srtdec.c| 25 +--- libavformat/subtitles.c | 51

[FFmpeg-devel] [PATCH v2 6/6] avformat/subtitles: guess UTF-16 if no BOM present

2014-09-04 Thread wm4
--- Follows reimar's suggestion for detecting UTF-16. If the detection goes wrong, probing the format won't succeed, so this should not break anything. I didn't use ffio_ensure_seekback), because this apparently reallocates the buffer - which we certainly don't want, because the probe API doesn't

[FFmpeg-devel] [PATCH v2 5/6] avformat/srtdec: speed up probing

2014-09-04 Thread wm4
--- As suggested by ubitux. Note that the change to ff_subtitles_read_line() already cuts down the probing time a lot, so maybe this is not needed. --- libavformat/srtdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/srtdec.c b/libavformat/srtdec.c index b63d344..f5f3933

Re: [FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

2014-09-04 Thread Jörg Krause
On 09/04/2014 05:27 PM, Hendrik Leppkes wrote: On Wed, Sep 3, 2014 at 11:53 AM, Jörg Krause jkra...@posteo.de wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of

[FFmpeg-devel] [PATCH 0/6] Miscellaneous x86inc patches

2014-09-04 Thread James Darnley
There was quite a difference building up between FFmpeg's x86inc.asm file and x264's so I spent a little time merging some of the easy patches into our copy. I have also included Anton's patch which adds a little checking on instructions used and whether they are supported by the instruction set

[FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2014-09-04 Thread James Darnley
From: Anton Mitrofanov bugmas...@narod.ru --- libavutil/x86/x86inc.asm | 581 +++--- 1 files changed, 295 insertions(+), 286 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 1cfb055..87f3af7 100644 ---

[FFmpeg-devel] [PATCH 4/6] lavu/x86/x86inc: deprecate INIT_AVX

2014-09-04 Thread James Darnley
The same can be done with INIT_XMM avx --- libavutil/x86/x86inc.asm |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 65a23d8..c028c0b 100644 --- a/libavutil/x86/x86inc.asm +++ b/libavutil/x86/x86inc.asm @@

[FFmpeg-devel] [PATCH 6/6] x86inc: Make INIT_CPUFLAGS support an arbitrary number of cpuflags

2014-09-04 Thread James Darnley
From: Henrik Gramner hen...@gramner.com Previously there was a limit of two cpuflags. --- libavutil/x86/x86inc.asm | 41 ++--- 1 files changed, 22 insertions(+), 19 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index

Re: [FFmpeg-devel] [PATCH] avutil/md5: workaround clang 3.5 #20849

2014-09-04 Thread James Darnley
On 2014-09-05 00:31, Michael Niedermayer wrote: This avoids several failures on fate.ffmpeg.org, and thus makes real bugs easier to spot A good reason. +volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 Perhaps add a FIXME to the comment so

Re: [FFmpeg-devel] [PATCH 3/6] lavc/x86/v210: give cpuflag to INIT macro

2014-09-04 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:13:35AM +0200, James Darnley wrote: This lets the cglobal macro automatically append a suffix to the function name. This means that INIT_XMM avx must be used rather than INIT_AVX. --- libavcodec/x86/v210.asm | 22 -- 1 files changed, 12

Re: [FFmpeg-devel] [PATCH] avutil/md5: workaround clang 3.5 #20849

2014-09-04 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:36:29AM +0200, James Darnley wrote: On 2014-09-05 00:31, Michael Niedermayer wrote: This avoids several failures on fate.ffmpeg.org, and thus makes real bugs easier to spot A good reason. +volatile uint8_t in[1000]; // volatile to workaround

Re: [FFmpeg-devel] [PATCH 1/6] x264asm: warn when inappropriate instruction used in function with specified cpuflags

2014-09-04 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:49:10AM +0200, James Darnley wrote: On 2014-09-05 00:13, James Darnley wrote: From: Anton Mitrofanov bugmas...@narod.ru --- libavutil/x86/x86inc.asm | 581 +++--- 1 files changed, 295 insertions(+), 286

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: add ff_hevc_transform_add32_8_avx2

2014-09-04 Thread James Almer
On 04/09/14 5:18 PM, Michael Niedermayer wrote: On Sun, Aug 31, 2014 at 11:46:13PM -0300, James Almer wrote: ~20% faster than AVX. Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/hevc_res_add.asm | 31 +++ libavcodec/x86/hevcdsp.h| 2 ++

Re: [FFmpeg-devel] [PATCH 5/6] x86inc: free up variable name n in global namespace

2014-09-04 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:13:37AM +0200, James Darnley wrote: From: Loren Merritt pengv...@akuvian.org --- libavutil/x86/x86inc.asm | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Reinhard Tartler
On Thu, Sep 4, 2014 at 7:27 AM, Michael Niedermayer michae...@gmx.at wrote: Hi Reinhard On Wed, Sep 03, 2014 at 11:33:48PM -0400, Reinhard Tartler wrote: On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Sep 03, 2014 at 08:22:43PM -0400, Reinhard Tartler

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Reinhard Tartler
On Thu, Sep 4, 2014 at 11:23 AM, wm4 nfx...@googlemail.com wrote: And in general, it's a good idea to move optional libraries out of ffmpeg.git. (In fact, ffmpeg.git should be split into several git repos, one for each lib.) That idea seems very interesting to me. If coordinated and

Re: [FFmpeg-devel] [PATCH 2/6] x86inc: Make ym# behave the same way as xm#

2014-09-04 Thread Michael Niedermayer
On Fri, Sep 05, 2014 at 12:13:34AM +0200, James Darnley wrote: From: Henrik Gramner hen...@gramner.com This makes more sense for future implementations of templates with zmm registers. --- libavutil/x86/x86inc.asm |8 1 files changed, 4 insertions(+), 4 deletions(-) applied

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Michael Niedermayer
On Thu, Sep 04, 2014 at 07:42:00PM -0400, Reinhard Tartler wrote: On Thu, Sep 4, 2014 at 7:27 AM, Michael Niedermayer michae...@gmx.at wrote: Hi Reinhard On Wed, Sep 03, 2014 at 11:33:48PM -0400, Reinhard Tartler wrote: On Wed, Sep 3, 2014 at 9:34 PM, Michael Niedermayer michae...@gmx.at

Re: [FFmpeg-devel] patch for x32 for libpostproc

2014-09-04 Thread Reinhard Tartler
On Thu, Sep 4, 2014 at 9:32 PM, Michael Niedermayer michae...@gmx.at wrote: At the end of the day, I need a source tarball that contains maintained sources of a stand-alone libpostproc. I don't care too much how it is created, as long as it doesn't result in code-duplication with existing

Re: [FFmpeg-devel] [PATCH] add silenceremove filter

2014-09-04 Thread Michael Niedermayer
On Mon, Sep 01, 2014 at 10:34:34AM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 69 ++ libavfilter/Makefile | 1 + libavfilter/af_silenceremove.c | 480 +