Re: [FFmpeg-devel] [PATCH] lavc/pthread_slice: release entries

2015-02-24 Thread Christophe Gisquet
Hi, 2015-02-05 16:53 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: when running fate-hevc under valgrind + memory poisoning, I ran into this issue when running with THREAD_TYPE=slice and THREADS1. pthread is not my forte at all, and I'm not sure I'm handling the thread/...

[FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-24 Thread arwa arif
Hello, I have written a very primitive code for porting FFT domain filter. It accepts only gray8 format images. The output should be a grayscale image, but the ouput image is coming out to be a black and white image. Also, I am getting confused when to do the vertical pass. After taking irdft of

Re: [FFmpeg-devel] [PATCH]Silence warnings when compiling avfoundation

2015-02-24 Thread Thilo Borgmann
Am 23.02.15 um 19:46 schrieb Carl Eugen Hoyos: Thilo Borgmann thilo.borgmann at mail.de writes: For the second, what is that patch needed for? It is meant to fix warnings when compiling avfoundation for ios, see for example:

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-02-24 Thread tim nicholson
On 21/02/15 01:34, Dave Rice wrote: Hi Robert, Kevin, On Feb 20, 2015, at 9:56 AM, Robert Krüger krue...@lesspain.de wrote: Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : On Fri, Feb 20, 2015 at 1:30 PM, Robert Krüger krue...@lesspain.de javascript:; wrote: if I read the code

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-24 Thread Kevin Wheatley
On Fri, Feb 20, 2015 at 5:51 PM, Michael Niedermayer michae...@gmx.at wrote: theres some code that memcpies extradata into vos_data and that is skiped if TAG_IS_AVCI(trk-tag), try to also skip this for DNxHD Michael, thanks for the pointer, there are actually two points in the code that

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 11:41:02AM +0100, Carl Eugen Hoyos wrote: On Monday 23 February 2015 02:02:42 pm Clément Bœsch wrote: On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote: On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: +int width =

Re: [FFmpeg-devel] [PATCH] lavc/pthread_slice: release entries

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 10:14:27AM +0100, Christophe Gisquet wrote: Hi, 2015-02-05 16:53 GMT+01:00 Christophe Gisquet christophe.gisq...@gmail.com: when running fate-hevc under valgrind + memory poisoning, I ran into this issue when running with THREAD_TYPE=slice and THREADS1. pthread

Re: [FFmpeg-devel] [PATCH]Silence warnings when compiling avfoundation

2015-02-24 Thread Carl Eugen Hoyos
Thilo Borgmann thilo.borgmann at mail.de writes: You just misread me, I know what the first patch is for - which is what you just wrote. However, my question was about reason for the second #define patch. My comment was only about the second patch. Is the second patch ok? Carl Eugen

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-24 Thread Carl Eugen Hoyos
On Monday 23 February 2015 02:02:42 pm Clément Bœsch wrote: On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote: On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: +int width = av_pix_fmt_desc_get(frame-format)-flags AV_PIX_FMT_FLAG_PLANAR ? +

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 08:00:07AM +, tim nicholson wrote: On 21/02/15 01:34, Dave Rice wrote: Hi Robert, Kevin, On Feb 20, 2015, at 9:56 AM, Robert Krüger krue...@lesspain.de wrote: Am Freitag, 20. Februar 2015 schrieb Kevin Wheatley : On Fri, Feb 20, 2015 at 1:30 PM, Robert

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 02:27:01PM +0530, arwa arif wrote: Hello, I have written a very primitive code for porting FFT domain filter. It accepts only gray8 format images. The output should be a grayscale image, but the ouput image is coming out to be a black and white image. Also, I am

[FFmpeg-devel] [PATCH] doc/filters.texi: Added reference link to video size syntax description

2015-02-24 Thread Tobias Rapp
Attached patch updates the filter option documentation text to link to ffmpeg-utils documentation for video size syntax description. From 3c73ad81f31eedde3ed7f500af1ed23a5458652b Mon Sep 17 00:00:00 2001 From: Tobias Rapp t.r...@noa-audio.com Date: Tue, 24 Feb 2015 13:14:07 +0100 Subject: [PATCH]

[FFmpeg-devel] [PATCH] avformat/dss: set packet duration

2015-02-24 Thread Michael Niedermayer
Value taken from the decoder implementation Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/dss.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dss.c b/libavformat/dss.c index 85cd26a..12a4034 100644 --- a/libavformat/dss.c +++

[FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Derek Buitenhuis
Some formats require this, such as v210. The consensus seems to be to write it by default. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- This is a silent behavior change, and I have updated the API doc accordingly. --- doc/APIchanges| 3 +++ libavformat/movenc.c | 2 +-

[FFmpeg-devel] Interpretation of duration field in AVI super index chunk

2015-02-24 Thread Tobias Rapp
Hi, I am currently trying to interpret the index data of HuffYuv/PCM AVI files written by FFmpeg. If the file is larger than 2GiB an AVIX RIFF chunk is added for each 2GiB-block, each of these blocks gets an OpenDML chunk index ix00 and an OpenDML super index chunk indx is written for each

Re: [FFmpeg-devel] [PATCH][RFC] mov: Write colr atom by default

2015-02-24 Thread Derek Buitenhuis
On 2/24/2015 2:49 PM, Clément Bœsch wrote: Well, unfortunately this breaks the API. I'd just add the flag to the default values. People who set flags are supposed to use a + as a prefix so that won't be a problem. Right. - Derek ___ ffmpeg-devel

Re: [FFmpeg-devel] Gaining access to a encoder context in avformat?

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 10:10:21AM +, Kevin Wheatley wrote: On Fri, Feb 20, 2015 at 5:51 PM, Michael Niedermayer michae...@gmx.at wrote: theres some code that memcpies extradata into vos_data and that is skiped if TAG_IS_AVCI(trk-tag), try to also skip this for DNxHD Michael,

[FFmpeg-devel] [PATCH][RFC] mov: Write colr atom by default

2015-02-24 Thread Derek Buitenhuis
Several formats require the colr atom, and the consensus seems to be to write it by default. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- Changing the flag as I do here is one approach. Comments needed. --- libavformat/movenc.c | 4 ++-- libavformat/movenc.h | 2 +-

[FFmpeg-devel] [PATCH 1/3] avformat/dss: correct sample rate

2015-02-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/dss.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dss.c b/libavformat/dss.c index 66a30aa..76538d77 100644 --- a/libavformat/dss.c +++ b/libavformat/dss.c @@ -143,7 +143,7 @@ static int

[FFmpeg-devel] [PATCH 3/3] avformat/dss: implement seeking

2015-02-24 Thread Michael Niedermayer
This assumes CBR (which is true for all samples i have) Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/dss.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/libavformat/dss.c b/libavformat/dss.c index c595982..72c7e1a 100644 ---

[FFmpeg-devel] [PATCH 2/3] avformat/dss: set bitrate

2015-02-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/dss.c |8 1 file changed, 8 insertions(+) diff --git a/libavformat/dss.c b/libavformat/dss.c index 76538d77..c595982 100644 --- a/libavformat/dss.c +++ b/libavformat/dss.c @@ -54,6 +54,8 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] doc/filters.texi: Added reference link to video size syntax description

2015-02-24 Thread Stefano Sabatini
On date Tuesday 2015-02-24 13:23:56 +0100, Tobias Rapp encoded: Attached patch updates the filter option documentation text to link to ffmpeg-utils documentation for video size syntax description. From 3c73ad81f31eedde3ed7f500af1ed23a5458652b Mon Sep 17 00:00:00 2001 From: Tobias Rapp

Re: [FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Robert Krüger
On Tue, Feb 24, 2015 at 6:34 PM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Feb 24, 2015 at 03:11:44PM +, Derek Buitenhuis wrote: Some formats require this, such as v210. The consensus seems to be to write it by default. Signed-off-by: Derek Buitenhuis

[FFmpeg-devel] [PATCH] avformat/movenc: add STSD termination when FIEL/COLR/PASP is used

2015-02-24 Thread Michael Niedermayer
Only add it when in MOV mode, its in the QT spec This matches libquicktime See: 0216 11:49 Kevin Wheatley ( 38K) [FFmpeg-devel] [PATCH] avformat: Outputting DNxHD into .mov containers 'corrupts' following atoms until end of stsd See: libquicktime/src/stsdtable.c Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avformat: Outputting DNxHD into .mov containers 'corrupts' following atoms until end of stsd

2015-02-24 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 07:00:48PM +0100, Michael Niedermayer wrote: On Fri, Feb 20, 2015 at 04:04:52PM +, Kevin Wheatley wrote: On Fri, Feb 20, 2015 at 11:36 AM, Michael Niedermayer michae...@gmx.at wrote: applied the case for DNxHD, for the more general case, please explain which

Re: [FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 03:11:44PM +, Derek Buitenhuis wrote: Some formats require this, such as v210. The consensus seems to be to write it by default. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- This is a silent behavior change, and I have updated the API doc

Re: [FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Derek Buitenhuis
On 2/24/2015 5:46 PM, Robert Krüger wrote: is this correct for all mov, mp4, 3gp, psp, ... ? or should it be writteb by default only for some of them ? Good point, but this raises the whole ugly question of the least crappy way of setting a default for only one format in the monster that is

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-24 Thread arwa arif
On Tue, Feb 24, 2015 at 4:12 PM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Feb 24, 2015 at 02:27:01PM +0530, arwa arif wrote: Hello, I have written a very primitive code for porting FFT domain filter. It accepts only gray8 format images. The output should be a grayscale image,

Re: [FFmpeg-devel] [PATCH]Accept startcode 001 when remuxing H264 into mpegts

2015-02-24 Thread Carl Eugen Hoyos
On Tuesday 09 April 2013 03:21:33 pm Carl Eugen Hoyos wrote: Hi! Attached patch fixes remuxing of h264 into mpeg-ts for some wtv input files. Updated patch attached, WMP and QT play such samples. Fixes ticket #4324. Please comment, Carl Eugen diff --git a/libavformat/mpegtsenc.c

[FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-24 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- I decided to go the configure route since other features (cmov, clz) also do it , but if prefered this could instead be done with a new intmath.h header in the x86/ folder containing something like #if defined(__GNUC__) defined(__POPCNT__)

Re: [FFmpeg-devel] [PATCH]Accept startcode 001 when remuxing H264 into mpegts

2015-02-24 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 12:05:27AM +0100, Carl Eugen Hoyos wrote: On Tuesday 09 April 2013 03:21:33 pm Carl Eugen Hoyos wrote: Hi! Attached patch fixes remuxing of h264 into mpeg-ts for some wtv input files. Updated patch attached, WMP and QT play such samples. Fixes ticket #4324.