Re: [FFmpeg-devel] [PATCH] [PATCH] lavfi: add inverse telecine filter

2015-03-13 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 03:20:47AM +0530, Himangi Saraogi wrote: > This is an exact inverse of the telecine filter unlike previously existing > pullup and fieldmatch ones. > > The algorithm was briefly discussed with Carl. The algorithm is not completely > tested, though I do have a some sample su

Re: [FFmpeg-devel] [PATCH] ac3dec_fixed: always use the USE_FIXED=1 variant of the AC3DecodeContext

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 11:27:22PM +0100, Andreas Cadhalpun wrote: > Hi, > > On 13.03.2015 22:46, Christophe Gisquet wrote: > > 2015-03-13 22:28 GMT+01:00 Andreas Cadhalpun > > : > >> -int ff_eac3_parse_header(AC3DecodeContext *s); > >> +static int ff_eac3_parse_header(AC3DecodeContext *s); > >

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Mark Reid
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 94 +--- 2 files changed, 91 insertions(+), 4 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index d9e17c6..71a4084 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -4

[FFmpeg-devel] [PATCH v2] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Mark Reid
changes since v1: * replaced nonportable strlcat with snprintf Mark Reid (1): libavformat/mxfdec: export user comments metadata libavformat/mxf.h| 1 + libavformat/mxfdec.c | 94 +--- 2 files changed, 91 insertions(+), 4 deletions(-) -- 2.

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf->body_partition_offset is not NULL before using it

2015-03-13 Thread Mark Reid
On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 13.03.2015 11:59, Tomas Härdin wrote: > > On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: > >> This fixes a crash, when trying to mux h264 into mxf_opatom. > >> > >> Signed-off-by: Andrea

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Mark Reid
On Fri, Mar 13, 2015 at 3:57 AM, Tomas Härdin wrote: > On Fri, 2015-03-06 at 13:24 -0800, Mark Reid wrote: > > +static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size) > > +{ > > +MXFTaggedValue *tagged_value = arg; > > +uint8_t key[17]; > > + > > +if (size <= 17) > >

Re: [FFmpeg-devel] [PATCH] ac3dec_fixed: always use the USE_FIXED=1 variant of the AC3DecodeContext

2015-03-13 Thread Andreas Cadhalpun
Hi, On 13.03.2015 22:46, Christophe Gisquet wrote: > 2015-03-13 22:28 GMT+01:00 Andreas Cadhalpun > : >> -int ff_eac3_parse_header(AC3DecodeContext *s); >> +static int ff_eac3_parse_header(AC3DecodeContext *s); > > It's somewhat cosmetics, but if these functions become static, they > would bette

Re: [FFmpeg-devel] [PATCH] ac3dec_fixed: always use the USE_FIXED=1 variant of the AC3DecodeContext

2015-03-13 Thread Christophe Gisquet
Hi, 2015-03-13 22:28 GMT+01:00 Andreas Cadhalpun : > -int ff_eac3_parse_header(AC3DecodeContext *s); > +static int ff_eac3_parse_header(AC3DecodeContext *s); It's somewhat cosmetics, but if these functions become static, they would better drop the ff_ prefix. > -float accum = 0.0f; >

[FFmpeg-devel] [PATCH] ac3dec_fixed: always use the USE_FIXED=1 variant of the AC3DecodeContext

2015-03-13 Thread Andreas Cadhalpun
The AC3DecodeContext has a float (USE_FIXED=0) and an integer (USE_FIXED=1) variant, both of which can be present in the same binary. This is not only very confusing, but it also breaks horribly, when one variant is used by code expecting the other. This currently happens, because eac3dec.c is onl

Re: [FFmpeg-devel] [PATCH] lavfi: Add support to process_command in vf_eq.c

2015-03-13 Thread arwa arif
On Fri, Mar 13, 2015 at 9:50 PM, Stefano Sabatini wrote: > On date Friday 2015-03-13 11:46:42 +0530, Arwa Arif encoded: > > I have added the variable options. I have not done the refactoring part > yet. > > > From 00052c1bbe5fe87d86fcff6f5e810290468d0251 Mon Sep 17 00:00:00 2001 > > From: Arwa Ar

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-13 Thread Ronald S. Bultje
Hi, On Fri, Mar 13, 2015 at 3:19 PM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > Hi, > > 2015-03-13 14:34 GMT+01:00 Michael Niedermayer : > >> They will not be used in any real world scenario. > > > > well it could be usefull in debuging in same cases > > especially if all mmx cod

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-13 Thread Christophe Gisquet
Hi, 2015-03-13 14:34 GMT+01:00 Michael Niedermayer : >> They will not be used in any real world scenario. > > well it could be usefull in debuging in same cases > especially if all mmx code is disabled on x86_64, for any single > function its not too likely I believe fate and proper bug reports a

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 01:48:48PM -0500, Jeremy Luce wrote: > I'll fix the breaks and resubmit. > > I don't see the keyboard interaction documented anywhere but in the > source code. Where would be the desired location for this info? somewhere hmm, in the ffmpeg docs, doc/ffmpeg.texi seems the o

Re: [FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote: > --- > libavfilter/vf_eq.c | 56 > ++--- > 1 file changed, 15 insertions(+), 41 deletions(-) i would be more in favor of a function than a macro but LGTM either way, macros are hard

Re: [FFmpeg-devel] [FFMpeg-Devel] [PATCH 2/7] Moved templated c postprocessing routines into seperate file

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 02:15:09PM -0400, Tucker DiNapoli wrote: > Currently different versions of the postprocessing routines are > generated from a template. Ultimately I intend to remove this by > replacing the inline assembly with seperate yasm files. The c routines > will still be needed, so t

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Fri, Mar 13, 2015 at 3:06 PM, Michael Niedermayer wrote: > On Fri, Mar 13, 2015 at 02:34:08PM -0300, Claudio Freire wrote: >> On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic >> wrote: >> >> btw, i use the qemu from https://github.com/ssvb/QEMU.git >> >> for mips as it at least years ago suppo

Re: [FFmpeg-devel] [FFMpeg-Devel] [PATCH 4/7] Replaced BLOCK_HEIGHT macro with block_height and block_width variables

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 02:15:11PM -0400, Tucker DiNapoli wrote: > This change is to allow support for different sized blocks, which will > be necessary for sse and avx. My plan is for the code to still act on > 8x8 blocks, but to process multiple 8x8 blocks in parallel when using > sse/avx. > ---

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
I'll fix the breaks and resubmit. I don't see the keyboard interaction documented anywhere but in the source code. Where would be the desired location for this info? Jeremy On Fri, Mar 13, 2015 at 1:02 PM, Michael Niedermayer wrote: > On Wed, Mar 11, 2015 at 08:34:39AM -0500, Jeremy Luce wrote:

Re: [FFmpeg-devel] [FFMpeg-Devel] [PATCH 1/7] Moved postprocessing routines from postprocess.c to seperate file

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 02:15:08PM -0400, Tucker DiNapoli wrote: > This is a somewhat large patchset, mostly because I've tried to break each > patch down into the smallest set of changes I could. On my machine (x86_64 > linux, with AVX2), everything compiles after each patch. Whenever I configure

Re: [FFmpeg-devel] [FFMpeg-Devel] [PATCH 3/7] Fixed copyright on postprocess_c.c

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 02:15:10PM -0400, Tucker DiNapoli wrote: > Also made it an error to try and generate C postprocessing routines from > postprocess_template.c > --- > libpostproc/postprocess_c.c| 41 > +++--- > libpostproc/postprocess_template.c | 4

[FFmpeg-devel] [PATCH] lavf/segment: [WIP] add support to segmentation expression

2015-03-13 Thread Stefano Sabatini
TODO: add documentation, add support to chapters. --- libavformat/segment.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index b65a2eb..794504a 100644 --- a/libavformat/segment.c +++ b/libavfo

Re: [FFmpeg-devel] [PATCH] avformat/http: support auto reconnect

2015-03-13 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 11:39:55AM +0800, Zhang Rui wrote: > --- > libavformat/http.c | 32 +++- > 1 file changed, 27 insertions(+), 5 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is

[FFmpeg-devel] [PATCH 3/4] libavdevice/avfoundation: add capture_screen_mouse_clicks option

2015-03-13 Thread matthieu . bouron
From: Matthieu Bouron Support mouse clicks capture while recording a screen on OSX >= 10.7. --- libavdevice/avfoundation.m | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index e574518..8112229 100644 --- a/libavdevice/

[FFmpeg-devel] [PATCH 4/4] libavdevice/avfoundation: use pts/dts provided by the CMSampleBuffer API

2015-03-13 Thread matthieu . bouron
From: Matthieu Bouron --- libavdevice/avfoundation.m | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index 8112229..5bcd6a4 100644 --- a/libavdevice/avfoundation.m +++ b/libavdevice/avfoundation.m

[FFmpeg-devel] [FFMpeg-Devel] [PATCH 7/7] Added asm implmentations of some deinterlace functions

2015-03-13 Thread Tucker DiNapoli
I also added a makefile which assembles this file into libpostproc. I haven't yet modified the c code to use these functions yet. --- libpostproc/x86/Makefile| 1 + libpostproc/x86/deinterlace.asm | 167 2 files changed, 168 insertions(+) create

[FFmpeg-devel] [FFMpeg-Devel] [PATCH 3/7] Fixed copyright on postprocess_c.c

2015-03-13 Thread Tucker DiNapoli
Also made it an error to try and generate C postprocessing routines from postprocess_template.c --- libpostproc/postprocess_c.c| 41 +++--- libpostproc/postprocess_template.c | 4 +--- 2 files changed, 21 insertions(+), 24 deletions(-) diff --git a/libpost

[FFmpeg-devel] [FFMpeg-Devel] [PATCH 4/7] Replaced BLOCK_HEIGHT macro with block_height and block_width variables

2015-03-13 Thread Tucker DiNapoli
This change is to allow support for different sized blocks, which will be necessary for sse and avx. My plan is for the code to still act on 8x8 blocks, but to process multiple 8x8 blocks in parallel when using sse/avx. --- libpostproc/postprocess.c | 3 --- libpostproc/postprocess_c.c

[FFmpeg-devel] [FFMpeg-Devel] [PATCH 5/7] created x86 directory in libpostproc for standalone asm files

2015-03-13 Thread Tucker DiNapoli
I also put one file into the directory, which just defines the layout of the structs used in libpostproc using the struc and endstruc macros. --- libpostproc/x86/PPContext.asm | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 libpostproc/x86/PPC

[FFmpeg-devel] [FFMpeg-Devel] [PATCH 2/7] Moved templated c postprocessing routines into seperate file

2015-03-13 Thread Tucker DiNapoli
Currently different versions of the postprocessing routines are generated from a template. Ultimately I intend to remove this by replacing the inline assembly with seperate yasm files. The c routines will still be needed, so they need to be moved to a seperate file. The routines were added to the f

[FFmpeg-devel] [FFMpeg-Devel] [PATCH 1/7] Moved postprocessing routines from postprocess.c to seperate file

2015-03-13 Thread Tucker DiNapoli
This is a somewhat large patchset, mostly because I've tried to break each patch down into the smallest set of changes I could. On my machine (x86_64 linux, with AVX2), everything compiles after each patch. Whenever I configure ffmpeg libpostproc is always disabled and I have to manually change con

[FFmpeg-devel] [PATCH 1/4] libavdevice/avfoundation: add framerate and video size options

2015-03-13 Thread matthieu . bouron
From: Matthieu Bouron Support framerate ands video size options on AVCaptureDevices for OSX >= 10.7 and iOS >= 7.0. For screen captures, only the framerate option is taken into account. --- libavdevice/avfoundation.m | 103 + 1 file changed, 103 inser

[FFmpeg-devel] [PATCH 2/4] libavdevice/avfoundation: add capture_screen_cursor option

2015-03-13 Thread matthieu . bouron
From: Matthieu Bouron Add support for cursor capturing while recording a screen for OSX >= 10.8. --- libavdevice/avfoundation.m | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index 41fe9c3..e574518 100644 --- a/lib

[FFmpeg-devel] [FFMpeg-Devel] [PATCH 6/7] Added asm file with some useful macros

2015-03-13 Thread Tucker DiNapoli
--- libpostproc/x86/PPUtil.asm | 116 + 1 file changed, 116 insertions(+) create mode 100644 libpostproc/x86/PPUtil.asm diff --git a/libpostproc/x86/PPUtil.asm b/libpostproc/x86/PPUtil.asm new file mode 100644 index 000..090ee18 --- /dev/null +++ b

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 02:34:08PM -0300, Claudio Freire wrote: > On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic > wrote: > >> btw, i use the qemu from https://github.com/ssvb/QEMU.git > >> for mips as it at least years ago supported more extensions, i > >> would have guessed these where merged

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 08:34:39AM -0500, Jeremy Luce wrote: > Resubmitting with [PATCH] tag and unified diff. > > Adds functionality to pause transcoding with 'p' key and upause with 'u' > key over stdin. Pauses in the main transcode loop as well as the > input_thread loop. [...] > @@ -3346,7 +3

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic wrote: >> btw, i use the qemu from https://github.com/ssvb/QEMU.git >> for mips as it at least years ago supported more extensions, i >> would have guessed these where merged into main qemu but as you list >> all the disables in the wiki, maybe i wa

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Fri, Mar 13, 2015 at 2:34 PM, Claudio Freire wrote: > On Fri, Mar 13, 2015 at 12:39 PM, Nedeljko Babic > wrote: >>> btw, i use the qemu from https://github.com/ssvb/QEMU.git >>> for mips as it at least years ago supported more extensions, i >>> would have guessed these where merged into main q

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
In my case it would be used by a multi-platform application that does on-the-fly transcoding. It would be nice if this behavior was platform agnostic (there's no ctrl-z equivalent in Windows that I know of). Doing this with OS-specific keys or at the thread level in the application code is less tha

Re: [FFmpeg-devel] [PATCH] lavfi: Add support to process_command in vf_eq.c

2015-03-13 Thread Stefano Sabatini
On date Friday 2015-03-13 11:46:42 +0530, Arwa Arif encoded: > I have added the variable options. I have not done the refactoring part yet. > From 00052c1bbe5fe87d86fcff6f5e810290468d0251 Mon Sep 17 00:00:00 2001 > From: Arwa Arif > Date: Fri, 13 Mar 2015 11:37:40 +0530 > Subject: [PATCH] Add var

[FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-13 Thread Stefano Sabatini
--- libavfilter/vf_eq.c | 56 ++--- 1 file changed, 15 insertions(+), 41 deletions(-) diff --git a/libavfilter/vf_eq.c b/libavfilter/vf_eq.c index 980e9ca..e1aa206 100644 --- a/libavfilter/vf_eq.c +++ b/libavfilter/vf_eq.c @@ -282,48 +282,22 @@ stat

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 08:34:48AM -0500, Jeremy Luce wrote: > It's been a couple days, so I wanted to follow up. Would someone mind > providing some feedback on this? Thanks! what is the advantage of this compared to simply stoping the process? like by hiting ctrl-z ? [...] -- Michael GnuP

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Nedeljko Babic
> btw, i use the qemu from https://github.com/ssvb/QEMU.git > for mips as it at least years ago supported more extensions, i > would have guessed these where merged into main qemu but as you list > all the disables in the wiki, maybe i was guessing wrong I can confirm that main qemu supports both

Re: [FFmpeg-devel] [PATCH 2/2] avformat/flvdec: re enable flv_data_packet() and use AVMEDIA_TYPE_SUBTITLE

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 01:49:39PM +0100, Andreas Cadhalpun wrote: > On 21.01.2015 00:10, Michael Niedermayer wrote: > > Found-by: kurosu > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/flvdec.c | 15 +-- > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > > di

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
It's been a couple days, so I wanted to follow up. Would someone mind providing some feedback on this? Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-13 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 01:06:23PM -0300, James Almer wrote: > On 11/03/15 11:29 AM, Christophe Gisquet wrote: > > Hi, > > > > 2015-03-11 15:20 GMT+01:00 Michael Niedermayer : > >> personally iam in favor of more things being tested, but iam fine > >> with either > > > > I'll see what the opinion

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread compn
On Fri, 13 Mar 2015 10:11:47 +0100 wm4 wrote: > Nice warning, but why do we accept this in the first place? This looks > so very wrong. suggestions are welcome. 1) refuse all "invalid" files 2) duplicate all riff/isom lists 3) do this instead maybe people use old software or run into crashes i

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf->body_partition_offset is not NULL before using it

2015-03-13 Thread Andreas Cadhalpun
On 13.03.2015 11:59, Tomas Härdin wrote: > On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: >> This fixes a crash, when trying to mux h264 into mxf_opatom. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/mxfenc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/flvdec: re enable flv_data_packet() and use AVMEDIA_TYPE_SUBTITLE

2015-03-13 Thread Andreas Cadhalpun
On 21.01.2015 00:10, Michael Niedermayer wrote: > Found-by: kurosu > Signed-off-by: Michael Niedermayer > --- > libavformat/flvdec.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c > index 572268f..f98cb97 100

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 12:36:58PM +0100, Michael Niedermayer wrote: > On Fri, Mar 13, 2015 at 12:30:30PM +0100, Michael Niedermayer wrote: > > On Fri, Mar 13, 2015 at 04:42:36AM -0300, Claudio Freire wrote: > > > On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire > > > wrote: > > > > On Tue, Mar 1

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 12:30:30PM +0100, Michael Niedermayer wrote: > On Fri, Mar 13, 2015 at 04:42:36AM -0300, Claudio Freire wrote: > > On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire > > wrote: > > > On Tue, Mar 10, 2015 at 8:05 AM, Michael Niedermayer > > > wrote: > > >>> I cannot test my

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Michael Niedermayer
On Fri, Mar 13, 2015 at 04:42:36AM -0300, Claudio Freire wrote: > On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire > wrote: > > On Tue, Mar 10, 2015 at 8:05 AM, Michael Niedermayer > > wrote: > >>> I cannot test myself yet (cannot build against mips, it will > >>> probably take me a long while

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf->body_partition_offset is not NULL before using it

2015-03-13 Thread Tomas Härdin
On Thu, 2015-03-12 at 17:48 +0100, Andreas Cadhalpun wrote: > This fixes a crash, when trying to mux h264 into mxf_opatom. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/mxfenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfenc.c b/libavforma

Re: [FFmpeg-devel] [PATCH] libavformat/mxfdec: export user comments metadata

2015-03-13 Thread Tomas Härdin
On Fri, 2015-03-06 at 13:24 -0800, Mark Reid wrote: > +static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size) > +{ > +MXFTaggedValue *tagged_value = arg; > +uint8_t key[17]; > + > +if (size <= 17) > +return 0; > + > +avio_read(pb, key, 17); Really Avid, 17

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > > +if (!st->codec->codec_id) { > > +st->codec->codec_id = ff_codec_get_id(ff_codec_movvideo_tags, > > + tag1); > > +if (st->codec->codec_id) > > +av_log(s, AV_LOG_WARNING, "mov tag found in

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread wm4
On Fri, 13 Mar 2015 02:46:32 +0100 Carl Eugen Hoyos wrote: > diff --git a/libavformat/avidec.c b/libavformat/avidec.c > index 5c9443a..00f0037 100644 > --- a/libavformat/avidec.c > +++ b/libavformat/avidec.c > @@ -36,6 +36,7 @@ > #include "riff.h" > #include "libavcodec/bytestream.h" > #includ

Re: [FFmpeg-devel] [PATCH]Do not list mov codecs in riff.c

2015-03-13 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > avidec.c |7 +++ > > riff.c |3 --- > > 2 files changed, 7 insertions(+), 3 deletions(-) > > 7c301d00fc64be53584b4f6a2f54461bb85447e7 patchproresavi.diff > > diff --git a/libavformat/avidec.c b/libavformat/avidec.c > > index 5c9443a..00f0037

[FFmpeg-devel] ismindex and multiple audio streams

2015-03-13 Thread Martin Bene
Hi, at the moment the ismindex program included in the ffmpeg tools folder supports multiple audio streams only as separate quality levels; there is another use that isn't supported however: generating alternative audio streams, for example for streams in multiple languages. I'm wondering how

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-13 Thread Claudio Freire
On Tue, Mar 10, 2015 at 10:08 AM, Claudio Freire wrote: > On Tue, Mar 10, 2015 at 8:05 AM, Michael Niedermayer wrote: >>> I cannot test myself yet (cannot build against mips, it will >>> probably take me a long while before I can set up qemu for that), but >>> the patch should bring both implemen