Re: [FFmpeg-devel] [PATCH 1/6] avcodec/apng: Remove threading support

2015-06-02 Thread Donny Yang
On 3 June 2015 at 04:15, Ronald S. Bultje wrote: > Hi, > > On Tue, Jun 2, 2015 at 1:42 PM, Donny Yang wrote: > > > On 3 June 2015 at 03:31, Paul B Mahol wrote: > > > > > Dana 2. 6. 2015. 17:49 osoba "Donny Yang" napisala je: > > > > > > > > Each frame depends on the previous frame any way, and

Re: [FFmpeg-devel] [PATCH] swresample: Add swr_get_out_samples()

2015-06-02 Thread Pavel Koshevoy
On 6/2/15 16:22, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libswresample/resample.c| 17 + libswresample/swresample.c | 30 ++ libswresample/swresample.h | 14 ++ libswresampl

[FFmpeg-devel] [PATCH 1/1] swresample/dither: check memory allocation

2015-06-02 Thread Ganesh Ajjanagadde
check memory allocation in swri_get_dither() Signed-off-by: Ganesh Ajjanagadde --- libswresample/dither.c | 5 - libswresample/swresample.c | 3 ++- libswresample/swresample_internal.h | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libswresample/

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Warn if a codec is opened with a codec id without codec descriptor

2015-06-02 Thread Michael Niedermayer
On Tue, Jun 02, 2015 at 06:53:36PM +0200, wm4 wrote: > On Mon, 1 Jun 2015 20:59:42 +0200 > Michael Niedermayer wrote: > > > On Mon, Jun 01, 2015 at 08:30:33PM +0200, wm4 wrote: > > > On Mon, 1 Jun 2015 20:27:11 +0200 > > > Michael Niedermayer wrote: > > > > > > > Signed-off-by: Michael Niederm

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/apng: Remove blending support for AV_PIX_FMT_ARGB

2015-06-02 Thread Michael Niedermayer
On Tue, Jun 02, 2015 at 06:27:40PM +0200, Paul B Mahol wrote: > On 6/2/15, Donny Yang wrote: > > ARGB is not a supported PNG pixel format > > > > Signed-off-by: Donny Yang > > --- > > libavcodec/pngdec.c | 7 +-- > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > lgtm applied than

[FFmpeg-devel] [PATCH] swresample: Add swr_get_out_samples()

2015-06-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libswresample/resample.c| 17 + libswresample/swresample.c | 30 ++ libswresample/swresample.h | 14 ++ libswresample/swresample_internal.h |2 ++ libswresample/v

Re: [FFmpeg-devel] goto statements and multi-threaded app

2015-06-02 Thread Ronald S. Bultje
Hi, On Tue, Jun 2, 2015 at 6:21 PM, Ratin wrote: > While searching for goto across whole ffmpeg codebase resulted in 3253 > instances (with goto statement) were found. How reliable is goto statements > when it comes to multi-threaded apps? I was under the impression its pretty > risky to use.

[FFmpeg-devel] goto statements and multi-threaded app

2015-06-02 Thread Ratin
While searching for goto across whole ffmpeg codebase resulted in 3253 instances (with goto statement) were found. How reliable is goto statements when it comes to multi-threaded apps? I was under the impression its pretty risky to use. Thanks, Ratin __

Re: [FFmpeg-devel] [libav-devel] [PATCH] libopenjpegdec: check existence of image component data

2015-06-02 Thread Andreas Cadhalpun
On 01.06.2015 15:30, Michael Niedermayer wrote: > On Mon, Jun 01, 2015 at 12:27:22AM +0200, Andreas Cadhalpun wrote: >> On 31.05.2015 11:11, Luca Barbato wrote: >>> On 30/05/15 20:00, Andreas Cadhalpun wrote: +memset(&ctx->event_mgr, 0, sizeof(opj_event_mgr_t)); >>> >>> usually the size is

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: add NULL check for img before accessing it

2015-06-02 Thread Andreas Cadhalpun
On 01.06.2015 15:15, Michael Niedermayer wrote: > On Mon, Jun 01, 2015 at 12:57:25AM +0200, Andreas Cadhalpun wrote: >> If opj_image_create fails to allocate an image it returns NULL, which >> causes a segmentation fault at 'img->x0 = 0'. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcode

Re: [FFmpeg-devel] [PATCH] ffmpeg_dxva2: call GetDesktopWindow() in place of GetShellWindow()

2015-06-02 Thread Hendrik Leppkes
On Tue, Jun 2, 2015 at 10:02 PM, Hendrik Leppkes wrote: > On Tue, Jun 2, 2015 at 7:11 PM, wm4 wrote: >> On Tue, 2 Jun 2015 12:25:34 +0200 >> Stefano Sabatini wrote: >> >>> On date Friday 2015-05-29 14:34:08 -0300, James Almer encoded: >>> > On 29/05/15 12:40 PM, Stefano Sabatini wrote: >>> > > O

Re: [FFmpeg-devel] [PATCH] ffmpeg_dxva2: call GetDesktopWindow() in place of GetShellWindow()

2015-06-02 Thread Hendrik Leppkes
On Tue, Jun 2, 2015 at 7:11 PM, wm4 wrote: > On Tue, 2 Jun 2015 12:25:34 +0200 > Stefano Sabatini wrote: > >> On date Friday 2015-05-29 14:34:08 -0300, James Almer encoded: >> > On 29/05/15 12:40 PM, Stefano Sabatini wrote: >> > > On date Friday 2015-05-29 16:32:11 +0200, Hendrik Leppkes encoded:

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: Write Block Keyframe correctly

2015-06-02 Thread Vignesh Venkatasubramanian
On Mon, Jun 1, 2015 at 5:35 PM, James Almer wrote: > On 01/06/15 9:07 PM, Vignesh Venkatasubramanian wrote: >> Per matroska Block Structure [1], for keyframes 0th bit of the flag >> should not be set (unlike SimpleBlocks). For Blocks, keyframes is >> inferred by the absence of ReferenceBlock eleme

[FFmpeg-devel] [PATCH] lavf/matroskaenc: Write Block Keyframe correctly

2015-06-02 Thread Vignesh Venkatasubramanian
Per matroska Block Structure [1], for keyframes 0th bit of the flag should not be set (unlike SimpleBlocks). For Blocks, keyframes is inferred by the absence of ReferenceBlock element (as done by matroskadec). This CL writes the flag correctly and inserts the ReferenceBlock element for non-keyframe

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/apng: Add support for blending with GRAY8A pixel format

2015-06-02 Thread Paul B Mahol
On 6/2/15, Donny Yang wrote: > On 3 June 2015 at 03:38, Paul B Mahol wrote: > >> Dana 2. 6. 2015. 17:50 osoba "Donny Yang" napisala je: >> > >> > Signed-off-by: Donny Yang >> > --- >> > libavcodec/pngdec.c | 8 +++- >> > 1 file changed, 7 insertions(+), 1 deletion(-) >> > >> > diff --git a

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/apng: Remove threading support

2015-06-02 Thread Ronald S. Bultje
Hi, On Tue, Jun 2, 2015 at 1:42 PM, Donny Yang wrote: > On 3 June 2015 at 03:31, Paul B Mahol wrote: > > > Dana 2. 6. 2015. 17:49 osoba "Donny Yang" napisala je: > > > > > > Each frame depends on the previous frame any way, and it will > > > cause bugs with frame disposal > > > > > > Signed-of

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/apng: Add support for blending with GRAY8A pixel format

2015-06-02 Thread Donny Yang
On 3 June 2015 at 03:38, Paul B Mahol wrote: > Dana 2. 6. 2015. 17:50 osoba "Donny Yang" napisala je: > > > > Signed-off-by: Donny Yang > > --- > > libavcodec/pngdec.c | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/apng: Remove threading support

2015-06-02 Thread Donny Yang
On 3 June 2015 at 03:31, Paul B Mahol wrote: > Dana 2. 6. 2015. 17:49 osoba "Donny Yang" napisala je: > > > > Each frame depends on the previous frame any way, and it will > > cause bugs with frame disposal > > > > Signed-off-by: Donny Yang > > --- > > libavcodec/pngdec.c | 11 +-- > >

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/apng: Add support for blending with GRAY8A pixel format

2015-06-02 Thread Paul B Mahol
Dana 2. 6. 2015. 17:50 osoba "Donny Yang" napisala je: > > Signed-off-by: Donny Yang > --- > libavcodec/pngdec.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index 1f5c433..1667530 100644 > --- a/libavcodec/pngdec.c >

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/apng: Remove threading support

2015-06-02 Thread Paul B Mahol
Dana 2. 6. 2015. 17:49 osoba "Donny Yang" napisala je: > > Each frame depends on the previous frame any way, and it will > cause bugs with frame disposal > > Signed-off-by: Donny Yang > --- > libavcodec/pngdec.c | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a

Re: [FFmpeg-devel] [PATCH] ffmpeg_dxva2: call GetDesktopWindow() in place of GetShellWindow()

2015-06-02 Thread wm4
On Tue, 2 Jun 2015 12:25:34 +0200 Stefano Sabatini wrote: > On date Friday 2015-05-29 14:34:08 -0300, James Almer encoded: > > On 29/05/15 12:40 PM, Stefano Sabatini wrote: > > > On date Friday 2015-05-29 16:32:11 +0200, Hendrik Leppkes encoded: > > >> On Fri, May 29, 2015 at 3:21 PM, Stefano Sab

[FFmpeg-devel] [RFC][WIP] Conversion of FFV1 specification to Markdown

2015-06-02 Thread Dave Rice
Hi all, As there is ongoing work on the FFV1 specification in support of a standardization process via the IETF, Ashley Blewer and I (as part of the PreForma project [1]) have drafted a translation of the current FFV1 specification which is formatted in lyx [2] to markdown. Such a transition wa

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Warn if a codec is opened with a codec id without codec descriptor

2015-06-02 Thread wm4
On Mon, 1 Jun 2015 20:59:42 +0200 Michael Niedermayer wrote: > On Mon, Jun 01, 2015 at 08:30:33PM +0200, wm4 wrote: > > On Mon, 1 Jun 2015 20:27:11 +0200 > > Michael Niedermayer wrote: > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/utils.c |2 ++ > > > 1 file cha

[FFmpeg-devel] [PATCH 3/3] avformat/mov: Use ff_configure_buffers_for_index()

2015-06-02 Thread Michael Niedermayer
Fixes Ticket2513 Fixes Ticket4432 Signed-off-by: Michael Niedermayer --- libavformat/mov.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 5300704..65b889f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4286,6 +4286,7 @@ static int m

[FFmpeg-devel] [PATCH 1/3] avformat/avio: move short seek threshold to the context

2015-06-02 Thread Michael Niedermayer
This allows us to adjust it internally. Signed-off-by: Michael Niedermayer --- libavformat/avio.h|6 ++ libavformat/aviobuf.c |3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index 51913e3..480b051 100644 --- a/libavfor

[FFmpeg-devel] [PATCH 2/3] avformat: Add ff_configure_buffers_for_index()

2015-06-02 Thread Michael Niedermayer
This allows configuring the io buffer in such way that few seeks are needed for playback Signed-off-by: Michael Niedermayer --- libavformat/internal.h |2 ++ libavformat/utils.c| 38 ++ 2 files changed, 40 insertions(+) diff --git a/libavformat/int

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/apng: Remove blending support for AV_PIX_FMT_ARGB

2015-06-02 Thread Paul B Mahol
On 6/2/15, Donny Yang wrote: > ARGB is not a supported PNG pixel format > > Signed-off-by: Donny Yang > --- > libavcodec/pngdec.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

[FFmpeg-devel] [PATCH 6/6] avcodec/apng: Add partial support for blending with PAL8 pixel format

2015-06-02 Thread Donny Yang
Currently restricted to blending pixels that only contain either 0 or 255 in their alpha components Signed-off-by: Donny Yang --- libavcodec/pngdec.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 1667530..40633

[FFmpeg-devel] [PATCH 5/6] avcodec/apng: Add support for blending with GRAY8A pixel format

2015-06-02 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 1f5c433..1667530 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -891,7 +891,8 @@ static int handle_p_frame_ap

[FFmpeg-devel] [PATCH 3/6] avcodec/apng: Dispose previous frame properly

2015-06-02 Thread Donny Yang
The spec specifies the dispose operation as how the current (i.e., currently being rendered) frame should be disposed when the next frame is blended onto it This is contrary to ffmpeg's current behaviour of interpreting the dispose operation as how the previous (i.e., already rendered) frame shoul

[FFmpeg-devel] avcodec/apng: Fix and add features to blending support

2015-06-02 Thread Donny Yang
This time with bug fixes and feature additions properly separated [PATCH 1/6] avcodec/apng: Remove threading support [PATCH 2/6] avcodec/apng: Remove blending support for AV_PIX_FMT_ARGB [PATCH 3/6] avcodec/apng: Dispose previous frame properly [PATCH 4/6] avcodec/apng: Add blending support for no

[FFmpeg-devel] [PATCH 2/6] avcodec/apng: Remove blending support for AV_PIX_FMT_ARGB

2015-06-02 Thread Donny Yang
ARGB is not a supported PNG pixel format Signed-off-by: Donny Yang --- libavcodec/pngdec.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 2ea3e8b..5571d20 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -877

[FFmpeg-devel] [PATCH 4/6] avcodec/apng: Add blending support for non-alpha pixel formats

2015-06-02 Thread Donny Yang
Signed-off-by: Donny Yang --- libavcodec/pngdec.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 90bf725..1f5c433 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -58,6 +58,7 @@ typedef struct PNGDecContext {

[FFmpeg-devel] [PATCH 1/6] avcodec/apng: Remove threading support

2015-06-02 Thread Donny Yang
Each frame depends on the previous frame any way, and it will cause bugs with frame disposal Signed-off-by: Donny Yang --- libavcodec/pngdec.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 2512799..2ea3e8b 100644 -

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/apng: Dispose previous frame properly

2015-06-02 Thread Paul B Mahol
On 6/2/15, Donny Yang wrote: > The spec specifies the dispose operation as how the current (i.e., > currently > being rendered) frame should be disposed when the next frame is blended onto > it > > This is contrary to ffmpeg's current behaviour of interpreting the dispose > operation as how the pr

Re: [FFmpeg-devel] [PATCH] avformat/sbgdec: Check alloc_array_elem() return value

2015-06-02 Thread Michael Niedermayer
On Tue, Jun 02, 2015 at 03:01:35PM +0200, Nicolas George wrote: > Le quartidi 14 prairial, an CCXXIII, Michael Niedermayer a écrit : > > Signed-off-by: Michael Niedermayer > > Ok, of course. Thanks. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FA

[FFmpeg-devel] [PATCH 2/2] avcodec/apng: Dispose previous frame properly

2015-06-02 Thread Donny Yang
The spec specifies the dispose operation as how the current (i.e., currently being rendered) frame should be disposed when the next frame is blended onto it This is contrary to ffmpeg's current behaviour of interpreting the dispose operation as how the previous (i.e., already rendered) frame shoul

[FFmpeg-devel] [PATCH 1/2] avcodec/apng: Remove threading support

2015-06-02 Thread Donny Yang
Each frame depends on the previous frame any way, and it will cause bugs with frame disposal Signed-off-by: Donny Yang --- libavcodec/pngdec.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 2512799..2ea3e8b 100644 -

[FFmpeg-devel] avcodec/apng: Dispose previous frame properly

2015-06-02 Thread Donny Yang
[PATCH 1/2] avcodec/apng: Remove threading support [PATCH 2/2] avcodec/apng: Dispose previous frame properly Patches have been tested against: - https://people.mozilla.org/~dolske/apng/ - http://littlesvr.ca/apng/images/clock.png - http://upload.wikimedia.org/wikipedia/commons/1/14/Animated_PN

Re: [FFmpeg-devel] [PATCH] avformat/sbgdec: Check alloc_array_elem() return value

2015-06-02 Thread Nicolas George
Le quartidi 14 prairial, an CCXXIII, Michael Niedermayer a écrit : > Signed-off-by: Michael Niedermayer Ok, of course. Thanks. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpe

[FFmpeg-devel] [PATCH] avformat/sbgdec: Check alloc_array_elem() return value

2015-06-02 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/sbgdec.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c index 23b7ea4..03cd922 100644 --- a/libavformat/sbgdec.c +++ b/libavformat/sbgdec.c @@ -973,6 +973,8 @@ static int expand_tseq(void *log

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: return error instead of segfaulting if there are no streams

2015-06-02 Thread Michael Niedermayer
On Sun, May 31, 2015 at 01:11:10PM +0200, Michael Niedermayer wrote: > Fixes segfault from ticket 4350 > > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfdec.c |4 > 1 file changed, 4 insertions(+) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611

Re: [FFmpeg-devel] [PATCH] avcodec: loongson3 optimized h264chroma put and avg with mmi

2015-06-02 Thread Michael Niedermayer
On Tue, Jun 02, 2015 at 11:32:31AM +0800, 周晓勇 wrote: > abort the one before and re-patch on the latest master. > > --- > From c35e1e18f446fc15233ab42f52077d57681b27fa Mon Sep 17 00:00:00 2001 > From: ZhouXiaoyong > Date: Fri, 17 Apr 2015 17:09:06 +0800 > Subject: [PATCH] avcodec: loongson3 optimi

Re: [FFmpeg-devel] [PATCH] ffmpeg_dxva2: call GetDesktopWindow() in place of GetShellWindow()

2015-06-02 Thread Stefano Sabatini
On date Friday 2015-05-29 14:34:08 -0300, James Almer encoded: > On 29/05/15 12:40 PM, Stefano Sabatini wrote: > > On date Friday 2015-05-29 16:32:11 +0200, Hendrik Leppkes encoded: > >> On Fri, May 29, 2015 at 3:21 PM, Stefano Sabatini > >> wrote: > >>> This fixes compilation with latest MinGW32

Re: [FFmpeg-devel] Test case for Closed caption decoder.

2015-06-02 Thread Michael Niedermayer
On Tue, Jun 02, 2015 at 06:13:20AM +, Carl Eugen Hoyos wrote: > Anshul gmail.com> writes: > > > can you provide me link of carl file you said it was > > smallest, I would make that test case again with > > carl file. > > http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/192583/focus=19

Re: [FFmpeg-devel] [PATCH][GSoC] lavf/http: Parse and set HTTP method when listening on HTTP(S)

2015-06-02 Thread Nicolas George
Le quartidi 14 prairial, an CCXXIII, Stephan Holljes a écrit : > I agree, I have probably thought a little bit too far ahead. > > I hope the attached patches are okay. > I'm somewhat unsure about the first patch, because it checks ret and > sets it explicitly if no other error occurred. > I also a

[FFmpeg-devel] [PATCH 4/4] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for HEVC uni mc epel functions

2015-06-02 Thread shivraj.patil
From: Shivraj Patil This patch adds MSA (MIPS-SIMD-Arch) optimizations for HEVC uni mc epel functions. Adds new generic macros (needed for this patch) in libavutil/mips/generic_macros_msa.h Signed-off-by: Shivraj Patil --- libavcodec/mips/hevc_mc_uni_msa.c | 2331 ++

[FFmpeg-devel] [PATCH 3/4] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for HEVC mc epel functions

2015-06-02 Thread shivraj.patil
From: Shivraj Patil This patch adds MSA (MIPS-SIMD-Arch) optimizations for HEVC mc epel functions. Signed-off-by: Shivraj Patil --- libavcodec/mips/hevcdsp_init_mips.c | 32 + libavcodec/mips/hevcdsp_mips.h | 30 + libavcodec/mips/hevcdsp_msa.c | 2265 +++