Re: [FFmpeg-devel] [PATCH] examples/demuxing_decoding: use properties from frame instead of video_dec_ctx

2015-06-14 Thread Michael Niedermayer
On Sun, Jun 14, 2015 at 08:40:50PM +0200, Andreas Cadhalpun wrote: > This is more robust. > > And only check if there is actually a frame returned. LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll d

Re: [FFmpeg-devel] [PATCH] h264: check frame properties for consistency before copying

2015-06-14 Thread Michael Niedermayer
On Sun, Jun 14, 2015 at 12:40:18PM +0200, Andreas Cadhalpun wrote: > Also use the frame pixel format instead of the one from the codec > context, which is more robust. the checks cant hurt ... LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us c

Re: [FFmpeg-devel] Contributing to the project?

2015-06-14 Thread George Boyle
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Clément, On 13/06/15 20:17, Clément Bœsch wrote: > > Ah, if you're interested in testing... http://coverage.ffmpeg.org/ > will give you an idea about how much or test suite covers the code > base. You can see that it's not bad but there are many

Re: [FFmpeg-devel] [PATCH] doc: avoid incorrect phrase 'allows to'

2015-06-14 Thread Lou Logan
Apologies for the formatting. On Sun, Jun 14, 2015, at 10:49 AM, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > Changelog | 2 +- > doc/decoders.texi | 2 +- > libavcodec/bitstream.c | 2 +- > libavcodec/libspeexenc.c| 2 +- > libavcodec/

[FFmpeg-devel] [PATCH] avfilter/af_afade: add couple of more curves

2015-06-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 12 +++- libavfilter/af_afade.c | 30 +- 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 6437c0c..0712494 100644 --- a/doc/filters.texi +++ b/doc/

Re: [FFmpeg-devel] [PATCH] tls_gnutls: fix hang on disconnection

2015-06-14 Thread Michael Niedermayer
On Sat, Jun 13, 2015 at 11:55:21PM +0200, wm4 wrote: > GNUTLS_SHUT_RDWR means GnuTLS will keep waiting for the server's > termination reply. But since we don't shutdown the TCP connection at > this point yet, GnuTLS will just keep skipping actual data from the > server, which basically is perceived

[FFmpeg-devel] [PATCH] doc: avoid incorrect phrase 'allows to'

2015-06-14 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- Changelog | 2 +- doc/decoders.texi | 2 +- libavcodec/bitstream.c | 2 +- libavcodec/libspeexenc.c| 2 +- libavcodec/ppc/me_cmp.c | 2 +- libavcodec/vp9.c| 2 +- libavcodec/x86/vc1dsp_mmx.c | 2 +- libavdev

[FFmpeg-devel] [PATCH] examples/demuxing_decoding: use properties from frame instead of video_dec_ctx

2015-06-14 Thread Andreas Cadhalpun
This is more robust. And only check if there is actually a frame returned. Signed-off-by: Andreas Cadhalpun --- doc/examples/demuxing_decoding.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/d

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-14 Thread Andreas Cadhalpun
On 14.06.2015 18:48, Luca Barbato wrote: > On 14/06/15 17:31, Andreas Cadhalpun wrote: >> On 14.06.2015 16:46, Luca Barbato wrote: >>> Sadly some codecs such as vdpau (thanks to wm4 for spotting) would >>> possibly break if those parameters aren't set to the current decoding >>> decoding set, so se

[FFmpeg-devel] [PATCH 5/5] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for pixblock functions

2015-06-14 Thread shivraj.patil
From: Shivraj Patil This patch adds MSA (MIPS-SIMD-Arch) optimizations for pixblock functions in new file pixblockdsp_msa.c Adds new generic macros (needed for this patch) in libavutil/mips/generic_macros_msa.h Signed-off-by: Shivraj Patil --- libavcodec/mips/Makefile| 2 +

[FFmpeg-devel] [PATCH 4/5] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for block functions

2015-06-14 Thread shivraj.patil
From: Shivraj Patil This patch adds MSA (MIPS-SIMD-Arch) optimizations for block functions in new file blockdsp_msa.c Signed-off-by: Shivraj Patil --- libavcodec/blockdsp.c| 2 + libavcodec/blockdsp.h| 1 + libavcodec/mips/Makefile | 2 + libavco

[FFmpeg-devel] [PATCH 3/5] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for hpel functions

2015-06-14 Thread shivraj.patil
From: Shivraj Patil This patch adds MSA (MIPS-SIMD-Arch) optimizations for hpel functions in new file hpeldsp_msa.c Adds new generic macros (needed for this patch) in libavutil/mips/generic_macros_msa.h Signed-off-by: Shivraj Patil --- libavcodec/hpeldsp.c|2 + libavcodec

[FFmpeg-devel] [PATCH 1/5] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for H263 lpf functions

2015-06-14 Thread shivraj.patil
From: Shivraj Patil This patch adds MSA (MIPS-SIMD-Arch) optimizations for H263 lpf functions in new file h263dsp_msa.c Signed-off-by: Shivraj Patil --- libavcodec/h263dsp.c| 2 + libavcodec/h263dsp.h| 1 + libavcodec/mips/Makefile| 2 + libav

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-14 Thread Andreas Cadhalpun
On 14.06.2015 16:46, Luca Barbato wrote: > On 14/06/15 15:07, Andreas Cadhalpun wrote: >> It would require changing a lot of code to use the internal values, but >> I think the same effect could be achieved by backing up/restoring the values. >> And that would require significantly less code change

Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors

2015-06-14 Thread Andreas Cadhalpun
On 14.06.2015 14:36, Michael Niedermayer wrote: > On Sat, Jun 13, 2015 at 09:46:01PM +0200, Andreas Cadhalpun wrote: >> Neccessary -> Necessary >> formated -> formatted >> thee -> the >> eventhough -> even though >> seperately -> separately >> >> Signed-off-by: Andreas Cadhalpun >> --- >>

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-14 Thread Andreas Cadhalpun
On 14.06.2015 13:46, Luca Barbato wrote: > On 14/06/15 12:38, Andreas Cadhalpun wrote: >> I discussed it with Hendrik and asked him for a better way to fix the >> problem. It seems he hasn't found one, yet. > > Told you how to that, did you miss that part from the previous email? If you mean just

Re: [FFmpeg-devel] [PATCH] doc: fix spelling errors

2015-06-14 Thread Michael Niedermayer
On Sat, Jun 13, 2015 at 09:46:01PM +0200, Andreas Cadhalpun wrote: > Neccessary -> Necessary > formated -> formatted > thee -> the > eventhough -> even though > seperately -> separately > > Signed-off-by: Andreas Cadhalpun > --- > doc/examples/transcoding.c | 2 +- > libavcodec/ass_split

[FFmpeg-devel] [PATCH] h264: check frame properties for consistency before copying

2015-06-14 Thread Andreas Cadhalpun
Also use the frame pixel format instead of the one from the codec context, which is more robust. Signed-off-by: Andreas Cadhalpun --- libavcodec/h264_slice.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 0c0812f.

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-14 Thread Andreas Cadhalpun
On 14.06.2015 03:12, Luca Barbato wrote: > I prefer fix bugs properly and I prefer to wait a second and listen to > everybody before do something. That's a commendable ideal, but if it results in problems not getting fixed at all, it's counter-productive. > Discuss with Hendrik, since he had been