Re: [FFmpeg-devel] [PATCH] ac3dsp: remove 3dnow version of float_to_fixed24

On Tue, Nov 17, 2015 at 12:00 AM, Daniel Verkamp wrote: > > This implementation is only used in a very narrow set of circumstances: > it is not bitexact, and there is an SSE implementation, so the 3DNow > version would only get used on K6-II/K6-III/early (pre-XP) Athlon CPUs. > It is completely de

Re: [FFmpeg-devel] 6c6ac9cb "avutil/x86/intmath: Use tzcnt in place of bsf."

On 17 November 2015 at 12:12, Hans Wennborg wrote: > Hello ffmpeg developers, > > This commit [1] is causing problems when compiling with Clang on Windows: > > ..\..\third_party\ffmpeg\libavutil/x86/intmath.h(53,33) : error: > always_inline function '__tzcnt_u32' requires target feature 'bmi', >

[FFmpeg-devel] [PATCH] ac3dsp: remove 3dnow version of float_to_fixed24

This implementation is only used in a very narrow set of circumstances: it is not bitexact, and there is an SSE implementation, so the 3DNow version would only get used on K6-II/K6-III/early (pre-XP) Athlon CPUs. It is completely dead code in x86-64 builds. Signed-off-by: Daniel Verkamp --- liba

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

On Mon, Nov 16, 2015 at 05:28:58PM -0800, Chris Cunningham wrote: > To test this new patch, again use testcount.mp3 > (CBR, > corrupt TOC). > > Current ffmpeg (with none of my mp3 patches) > > ./ffplay testcount.mp3 -ss 00:33:20 -use

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

To test this new patch, again use testcount.mp3 (CBR, corrupt TOC). Current ffmpeg (with none of my mp3 patches) ./ffplay testcount.mp3 -ss 00:33:20 -usetoc 0 plays out "1395", which is correct ./ffplay testcount.mp3 -ss 00:33:20

Re: [FFmpeg-devel] 6c6ac9cb "avutil/x86/intmath: Use tzcnt in place of bsf."

Hello ffmpeg developers, This commit [1] is causing problems when compiling with Clang on Windows: ..\..\third_party\ffmpeg\libavutil/x86/intmath.h(53,33) : error: always_inline function '__tzcnt_u32' requires target feature 'bmi', but would be inlined into function 'ff_ctzll_x86' that is compil

Re: [FFmpeg-devel] Error in ATRAC1 decoder?

Thank you for answer. If I understood available ATRAC1 docs, the purpose of this delay line is just to compensate delay of 1st QMF because for 1st and 2nd band we have two QMF but for 3rd band just one. About test, yes for some reason this patch brakes it. I will try to find out. Sorry, I should

[FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

From: Chris Cunningham "Fast seek" uses linear interpolation to find the position of the requested seek time. For CBR this is more direct than using the mp3 TOC and bypassing the TOC avoids problems when the TOC is corrupted (e.g. https://crbug.com/545914). For VBR, fast seek is not precise, so

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

Hey, sorry for the slow reply. Use this sample file. Its a CBR file with a corrupt TOC. http://happyworm.com/jPlayerLab/halite/jumptest/testcount.mp3 Before applying my patch: ./ffplay -ss 00:33:20 testcount.mp3 -usetoc 0 plays out "1395", which is the correct audio for the given seek time ./f

[FFmpeg-devel] [PATCH] avformat/mlpdec: consider all valid mlp access units when probing

Fixes probing of truehd/mlp files with a lot of frames in between the major sync frames. The spec allows a distance of up to 128 frames in between major sync frames, which leads to the probing code not reaching the desired score. --- libavformat/mlpdec.c | 5 - 1 file changed, 4 insertions(+),

Re: [FFmpeg-devel] [PATCH] avformat: add IVR demuxer

On 11/16/15, Michael Niedermayer wrote: > On Mon, Nov 16, 2015 at 11:25:33AM +0100, Paul B Mahol wrote: >> 2n version attached > >> Makefile |1 >> allformats.c |1 >> rmdec.c | 303 >> --- >> 3 files changed, 271 insertion

Re: [FFmpeg-devel] [PATCH] avformat: add IVR demuxer

On Mon, Nov 16, 2015 at 11:25:33AM +0100, Paul B Mahol wrote: > 2n version attached > Makefile |1 > allformats.c |1 > rmdec.c | 303 > --- > 3 files changed, 271 insertions(+), 34 deletions(-) > f8930413dadf24053ff1e19

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

On Mon, Nov 16, 2015 at 1:20 PM, Hendrik Leppkes wrote: > On Mon, Nov 16, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: >> On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell wrote: >>> Hi!, >>> >>> El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: Whoever wrote this stuff had

Re: [FFmpeg-devel] [PATCH 2/4] lavf/utils: avoid decoding a frame to get the codec parameters

On Mon, Nov 16, 2015 at 11:16:42AM -0500, Ronald S. Bultje wrote: > Hi, > > On Mon, Nov 16, 2015 at 11:06 AM, Matthieu Bouron > wrote: > > > On Sun, Nov 15, 2015 at 08:12:57AM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > Hi, > > > > > > > > On Sun, Nov 15, 2015 at 4:49 AM, Matthieu Bouron <

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

On Mon, Nov 16, 2015 at 6:24 PM, Ganesh Ajjanagadde wrote: > On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell wrote: >> Hi!, >> >> El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: >>> Whoever wrote this stuff had a pretty bad libm - digits differ pretty >>> quickly. >> >> The

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/select: add support for concatdec_select option

On Mon, 16 Nov 2015, Nicolas George wrote: Le quartidi 24 brumaire, an CCXXIV, Marton Balint a écrit : No, this is deliberately -1. This is the case where the duration metadata is missing (because it is unkown), but this also means that the outpoint was not set in the file segment, therefore w

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

On Mon, Nov 16, 2015 at 9:48 AM, Daniel Serpell wrote: > Hi!, > > El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: >> Whoever wrote this stuff had a pretty bad libm - digits differ pretty >> quickly. > > They where correctly rounded to 24bit precision. I don't know if that >

Re: [FFmpeg-devel] [PATCH] fate: fix concat demuxer extended test portability

On Mon, 16 Nov 2015, Timothy Gu wrote: tr -d '\r' ? Yep, good idea. Applied with tr -d. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] lavf/utils: avoid decoding a frame to get the codec parameters

Hi, On Mon, Nov 16, 2015 at 11:06 AM, Matthieu Bouron wrote: > On Sun, Nov 15, 2015 at 08:12:57AM -0500, Ronald S. Bultje wrote: > > Hi, > > Hi, > > > > > On Sun, Nov 15, 2015 at 4:49 AM, Matthieu Bouron < > matthieu.bou...@gmail.com> > > wrote: > > > > > On Mon, Nov 02, 2015 at 07:56:50AM -0500

Re: [FFmpeg-devel] [PATCH 2/4] lavf/utils: avoid decoding a frame to get the codec parameters

On Sun, Nov 15, 2015 at 08:12:57AM -0500, Ronald S. Bultje wrote: > Hi, Hi, > > On Sun, Nov 15, 2015 at 4:49 AM, Matthieu Bouron > wrote: > > > On Mon, Nov 02, 2015 at 07:56:50AM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Mon, Nov 2, 2015 at 5:45 AM, Matthieu Bouron < > > matthieu

Re: [FFmpeg-devel] [PATCH] fate: fix concat demuxer extended test portability

tr -d '\r' ? Timothy El El lun, 16 de nov de 2015 a las 4:26 AM, Marton Balint escribió: > Sed \r is not portable, it does not work on freebsd, hopefully awk will. > > Signed-off-by: Marton Balint > --- > tests/fate-run.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[FFmpeg-devel] [PATCH 06/13] MIPS i6400 core do has an FPU, so not disable it

Signed-off-by: Vicente Olivert Riera --- configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure b/configure index e1c8851..ff5e132 100755 --- a/configure +++ b/configure @@ -4100,7 +4100,6 @@ elif enabled mips; then i6400) disable mipsds

[FFmpeg-devel] [PATCH 05/13] Add MIPS i6400 core optimizations

Signed-off-by: Vicente Olivert Riera --- configure |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index d180c0d..e1c8851 100755 --- a/configure +++ b/configure @@ -4101,9 +4101,10 @@ elif enabled mips; then disable mipsdsp

[FFmpeg-devel] [PATCH 03/13] Add MIPS p5600 core optimizations

Signed-off-by: Vicente Olivert Riera --- configure |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 3fd156e..fa5207c 100755 --- a/configure +++ b/configure @@ -4094,8 +4094,9 @@ elif enabled mips; then disable mips64r6

[FFmpeg-devel] [PATCH 02/13] Remove --mips32r5 configure option

Having a configure option with the same name as a MIPS ISA is confusing, so better to remove it. This option was being used to add some optimizations to a specific core (p5600). We will add the optimizations just when the p5600 core has been detected, in a later patch. Signed-off-by: Vicente Olive

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/select: add support for concatdec_select option

Le quartidi 24 brumaire, an CCXXIV, Marton Balint a écrit : > No, this is deliberately -1. This is the case where the duration metadata is > missing (because it is unkown), but this also means that the outpoint was > not set in the file segment, therefore we need to select every frame after > start

[FFmpeg-devel] [PATCH 11/13] Remove the MIPS "generic" core in favor of "*"

There is no point to have a "generic" core when we can catch all unsupported cores with the "*" option, so remove it. Signed-off-by: Vicente Olivert Riera --- configure |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/configure b/configure index d366eb2..1bfcc67 100755

[FFmpeg-devel] [PATCH 12/13] Improve detection of MIPS ISAs, FPU and ASEs (DSP, MSA)

Signed-off-by: Vicente Olivert Riera --- configure | 77 ++-- 1 files changed, 59 insertions(+), 18 deletions(-) diff --git a/configure b/configure index 1bfcc67..4173684 100755 --- a/configure +++ b/configure @@ -4952,27 +4952,68 @@ elif

[FFmpeg-devel] [PATCH 10/13] Put "disable mipsfpu" in a better place for loongson

Let's disable the ISAs first, and then the core capabilities, as we do for the rest of the cores. This way the code is better organized. Signed-off-by: Vicente Olivert Riera --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 2f5456

[FFmpeg-devel] [PATCH 13/13] Add support for MIPS R6

Understanding the mips32r6 and mips64r6 ISAs in the configure script is not enough. In order to have full support for MIPS R6 in FFmpeg we need to be able to build it, and for that we need to make sure we don't use incompatible assembler code which makes the build fail. Ifdefing the offending code

[FFmpeg-devel] [PATCH 09/13] Add mips32r6 architecture variant

Signed-off-by: Vicente Olivert Riera --- configure | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 50db22b..2f5456c 100755 --- a/configure +++ b/configure @@ -1624,6 +1624,7 @@ ARCH_EXT_LIST_MIPS=" mipsfpu mips32r2 mi

[FFmpeg-devel] [PATCH 07/13] MIPS i6400 core is not mips32r2, so disable mips32r2

Signed-off-by: Vicente Olivert Riera --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index ff5e132..3530327 100755 --- a/configure +++ b/configure @@ -4098,6 +4098,7 @@ elif enabled mips; then add_asflags "-mfp64"

[FFmpeg-devel] [PATCH 08/13] Add mips64r2 architecture variant

Signed-off-by: Vicente Olivert Riera --- configure | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 3530327..50db22b 100755 --- a/configure +++ b/configure @@ -1623,6 +1623,7 @@ ARCH_EXT_LIST_ARM=" ARCH_EXT_LIST_MIPS=" mipsfpu

[FFmpeg-devel] [PATCH 04/13] Remove --mips64r6 configure option

Having a configure option with the same name as a MIPS ISA is confusing, so better to remove it. This option was being used to add some optimizations to a specific core (i6400). We will add the optimizations just when the i6400 core has been detected, in a later patch. Signed-off-by: Vicente Olive

[FFmpeg-devel] [PATCH 01/13] Rename mipsdspr1 to mipsdsp

Signed-off-by: Vicente Olivert Riera --- Makefile |2 +- arch.mak |2 +- configure | 34 + libavcodec/aacenc.c |2 +- libavcodec/mips/M

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ppc/fdctdsp: use more accurate constants

Hi!, El Fri, Nov 13, 2015 at 11:42:30AM -0500, Ganesh Ajjanagadde escribio: > Whoever wrote this stuff had a pretty bad libm - digits differ pretty > quickly. They where correctly rounded to 24bit precision. I don't know if that was intentional, so I can't comment on the correctness of the patch.

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

>> On 11.11.2015 13:46, Michael Niedermayer wrote: >> > On Sun, Nov 08, 2015 at 09:26:21PM +0100, Andreas Cadhalpun wrote: >> >> On 08.11.2015 20:17, Michael Niedermayer wrote: >> >>> but the patch does not look like an optimal solution >> >> >> >> It's certainly not pretty, but it fixes the crashe

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Mon, Nov 16, 2015 at 7:53 AM, Hendrik Leppkes wrote: > On Mon, Nov 16, 2015 at 1:52 PM, Ganesh Ajjanagadde wrote: >> On Mon, Nov 16, 2015 at 3:27 AM, wm4 wrote: >>> On Sun, 15 Nov 2015 17:56:22 -0500 >>> Ganesh Ajjanagadde wrote: >>> ffio_ensure_seekback can fail due to e.g ENOMEM. This

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Mon, Nov 16, 2015 at 1:52 PM, Ganesh Ajjanagadde wrote: > On Mon, Nov 16, 2015 at 3:27 AM, wm4 wrote: >> On Sun, 15 Nov 2015 17:56:22 -0500 >> Ganesh Ajjanagadde wrote: >> >>> ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is >>> propagated here, and all usage in the codeb

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Mon, Nov 16, 2015 at 3:27 AM, wm4 wrote: > On Sun, 15 Nov 2015 17:56:22 -0500 > Ganesh Ajjanagadde wrote: > >> ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is >> propagated here, and all usage in the codebase now has its return value >> checked. >> >> A potential memory l

Re: [FFmpeg-devel] [PATCH] avutil/libm: correct isnan, isinf compat hacks

On Mon, Nov 16, 2015 at 6:55 AM, Michael Niedermayer wrote: > On Sat, Nov 14, 2015 at 08:05:59PM -0500, Ganesh Ajjanagadde wrote: >> isnan and isinf are actually macros as per the standard. In particular, >> the existing implementation has incorrect signature. Furthermore, this >> results in undef

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

On Fri, Nov 13, 2015 at 11:19:44PM +0100, Andreas Cadhalpun wrote: > On 13.11.2015 04:21, Michael Niedermayer wrote: > > On Thu, Nov 12, 2015 at 08:51:28PM +0100, Andreas Cadhalpun wrote: > >> On 11.11.2015 23:19, Michael Niedermayer wrote: > >>> On Wed, Nov 11, 2015 at 09:31:18PM +0100, Andreas Ca

Re: [FFmpeg-devel] [PATCH] avformat/mov: remove redundant assignment

On Mon, Nov 16, 2015 at 6:40 AM, Michael Niedermayer wrote: > On Sun, Nov 15, 2015 at 09:05:18PM -0500, Ganesh Ajjanagadde wrote: >> This is possibly undefined behavior based on sequence point rules, but I >> have not studied the spec at that level of detail. >> >> Fixes: CID 1338321. >> >> Signed

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix memory leak

On Mon, Nov 16, 2015 at 5:27 AM, Paul B Mahol wrote: > On 11/16/15, Ganesh Ajjanagadde wrote: >> Fixes: CID 1338328. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavformat/mov.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/mov.c b/libavformat/mov.c >> index 38d

[FFmpeg-devel] [PATCH] fate: fix concat demuxer extended test portability

Sed \r is not portable, it does not work on freebsd, hopefully awk will. Signed-off-by: Marton Balint --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 966cbe2..a23f1e3 100755 --- a/tests/fate-run.sh +++ b/tests/

Re: [FFmpeg-devel] [PATCH] avutil/libm: correct isnan, isinf compat hacks

On Sat, Nov 14, 2015 at 08:05:59PM -0500, Ganesh Ajjanagadde wrote: > isnan and isinf are actually macros as per the standard. In particular, > the existing implementation has incorrect signature. Furthermore, this > results in undefined behavior for e.g double values outside float range > as per t

Re: [FFmpeg-devel] [libav-devel] [PATCH] hqx: correct type and size check of info_offset

On Sun, Nov 15, 2015 at 10:50 AM, Andreas Cadhalpun wrote: > It is used as size argument of ff_canopus_parse_info_tag, which uses it > as size argument to bytestream2_init, which only supports sizes up to > INT_MAX. > Changing it's type to unsigned simplifies the check. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/select: add support for concatdec_select option

On date Tuesday 2015-11-10 00:25:30 +0100, Marton Balint encoded: > This option can be used to select useful frames from an ffconcat file which is > using inpoints and outpoints but where the source files are not intra frame > only. > > Signed-off-by: Marton Balint > --- > doc/filters.texi

Re: [FFmpeg-devel] [PATCH] avformat/mov: remove redundant assignment

On Sun, Nov 15, 2015 at 09:05:18PM -0500, Ganesh Ajjanagadde wrote: > This is possibly undefined behavior based on sequence point rules, but I > have not studied the spec at that level of detail. > > Fixes: CID 1338321. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/mov.c | 2 +- > 1

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: Improve readability of aviobuf

On Sun, Nov 15, 2015 at 06:02:11PM -0800, Bryan Huh wrote: > No functional changes in this commit, mostly adding comments for > improved readability. Also minor re-arrangements of variables. > --- > libavformat/avio.h| 47 +++ > libavformat/aviobuf

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

Good day. We still need this feature. Can someone implement above functionality on bounty base (up to $2000)? 12.11.2015 12:28, Pavel Meshkov пишет: Thanks for explanation. We will try to rewrite it with new knowledge. I need your suggestion. We are try to send constant udp stream from rtmp l

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix memory leak

On 11/16/15, Ganesh Ajjanagadde wrote: > Fixes: CID 1338328. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/mov.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 38d3659..7ab2808 100644 > --- a/libavformat/mov.c > +++ b/libavforma

Re: [FFmpeg-devel] [PATCH] avformat: add IVR demuxer

2n version attached From bada349bdba599b92bcb1d3bc16b630c182174f9 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 11 Nov 2015 22:04:57 +0100 Subject: [PATCH] avformat: add IVR demuxer Signed-off-by: Paul B Mahol --- Problem with slices/frames ending in middle of packet is still there. R

Re: [FFmpeg-devel] [PATCH 2/2] fate: fix concat demuxer extended tests on windows

On Mon, Nov 16, 2015 at 3:39 AM, Michael Niedermayer wrote: > On Mon, Nov 16, 2015 at 01:25:19AM +0100, Marton Balint wrote: >> Line endings do matter to md5sum... >> >> Signed-off-by: Marton Balint >> --- >> tests/fate-run.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix overriding packet duration warning

On Mon, Nov 16, 2015 at 8:27 AM, Michael Niedermayer wrote: > On Mon, Nov 16, 2015 at 12:26:28AM +0700, Muhammad Faiz wrote: >> On Sun, Nov 15, 2015 at 5:55 PM, Michael Niedermayer >> wrote: >> > On Sun, Nov 15, 2015 at 04:04:42PM +0700, Muhammad Faiz wrote: >> >> no warning when packet duration

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Sun, 15 Nov 2015 17:56:22 -0500 Ganesh Ajjanagadde wrote: > ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is > propagated here, and all usage in the codebase now has its return value > checked. > > A potential memory leak in mp3_read_header is also fixed via a goto > fail

Re: [FFmpeg-devel] [PATCH] mxfdec: check edit_rate also for physical_track

On 15/11/15 18:07, Andreas Cadhalpun wrote: > Previously only the edit_rate of material_track was checked. > If it's negative, it causes assertion failures in av_rescale_rnd. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/mxfdec.c | 10 ++ > 1 file changed, 10 insertions(+) >