Re: [FFmpeg-devel] [PATCH 5/8] avcodec/amr: replace #define by typedef

On Fri, Nov 20, 2015 at 3:01 PM, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 08:14:12AM -0500, Ganesh Ajjanagadde wrote: >> See e.g >> https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c >> for rationale. >> >> Signed-off-by: Ganesh

[FFmpeg-devel] [PATCH] configure: Add user options to enable gcrypt/gmp for rtmp(t)e support.

Adding rtmp(t)e support when not using openssl or librtmp uses either gmp or gcrypt to implement the required Diffie-Hellmann code. Since this code can be compiled using either gmp or gcrypt a command line option to enable/disable either of those libs needs to be provided. Currently configure

Re: [FFmpeg-devel] [PATCH] avfilter: add deflash filter

On Fri, Nov 20, 2015 at 08:13:11PM +0100, Paul B Mahol wrote: [...] > +for (y = 0; y < h; y++) { > +for (x = 0; x < w; x++) { > +int diff = next[x] - src[x]; > +int t = 0; > + > +for (z = 0; z < FF_BUFQUEUE_SIZE - 1; z++) { > +

Re: [FFmpeg-devel] [PATCH] avfilter: add deflash filter

On Fri, Nov 20, 2015 at 08:13:11PM +0100, Paul B Mahol wrote: [...] > +static av_cold void uninit(AVFilterContext *ctx) > +{ > +DeFlashContext *s = ctx->priv; > +} > + > +static const AVFilterPad inputs[] = { > +{ > +.name = "default", > +.type =

Re: [FFmpeg-devel] [PATCHv2] configure+libm.h: add hypot emulation

On Tue, Nov 17, 2015 at 11:05 AM, Hendrik Leppkes wrote: > On Tue, Nov 17, 2015 at 5:00 PM, Ganesh Ajjanagadde wrote: >> On Sun, Nov 15, 2015 at 11:59 AM, Ganesh Ajjanagadde >> wrote: >>> On Sun, Nov 15, 2015 at 11:34 AM, Michael

Re: [FFmpeg-devel] [PATCH] configure: Add user options to enable gcrypt/gmp for rtmp(t)e support.

>+ --enable-gcrypt enable gmp, needed for rtmp(t)e support >+ if openssl, librtmp or gmp is not used [no] Probably meant "enable gcrypt" there? On 21 November 2015 at 15:28, Matt Oliver wrote: > Adding rtmp(t)e support when not using

Re: [FFmpeg-devel] [PATCH 2/3] avformat/rawvideodec: Rework packet size calculation

On Fri, Nov 20, 2015 at 09:34:12PM -0800, Timothy Gu wrote: > Calculate packet size only once, and propagate errors earlier in the chain. > > Also remove use of the deprecated av_image_get_buffer_size(). > --- > libavformat/rawvideodec.c | 17 + > 1 file changed, 9 insertions(+),

Re: [FFmpeg-devel] [PATCH 2/2] avutil/eval: change sqrt to hypot

On Sun, Nov 15, 2015 at 10:05 AM, Ganesh Ajjanagadde wrote: > On Sat, Nov 14, 2015 at 9:19 PM, Michael Niedermayer > wrote: >> On Sat, Nov 14, 2015 at 12:11:20PM -0500, Ganesh Ajjanagadde wrote: >>> This improves the mathematical behavior of hypotenuse

Re: [FFmpeg-devel] [PATCH 3/3] avformat/v210: Check width and height

On Fri, Nov 20, 2015 at 09:34:13PM -0800, Timothy Gu wrote: > Fixes a floating point exception when width and height are not supplied > (and therefore are zero). > --- > libavformat/v210.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCHv2] avutil/libm: correct isnan, isinf compat hacks

On Wed, Nov 18, 2015 at 3:04 PM, Ganesh Ajjanagadde wrote: > On Wed, Nov 18, 2015 at 2:58 PM, Michael Niedermayer wrote: >> On Tue, Nov 17, 2015 at 04:54:10PM -0500, Ganesh Ajjanagadde wrote: >>> isnan and isinf are actually macros as per the standard. In

Re: [FFmpeg-devel] [PATCH] avfilter: add deflash filter

On 11/21/15, Clement Boesch wrote: > On Fri, Nov 20, 2015 at 08:13:11PM +0100, Paul B Mahol wrote: > [...] >> +for (y = 0; y < h; y++) { >> +for (x = 0; x < w; x++) { >> +int diff = next[x] - src[x]; >> +int t = 0; >> + >> +

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/aacps_tablegen_template: replace #define by typedef

On Thu, Nov 19, 2015 at 8:14 AM, Ganesh Ajjanagadde wrote: > > See e.g > https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c > for rationale. > > Signed-off-by: Ganesh Ajjanagadde > --- >

Re: [FFmpeg-devel] [PATCH 5/5] swscale: use AV_OPT_TYPE_BOOL for {src, dst}_range options

On Sat, Nov 21, 2015 at 10:17:54PM +0100, Clément Bœsch wrote: > From: Clément Bœsch > > --- > libswscale/options.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

[FFmpeg-devel] [PATCH 3/5] avformat: use AV_OPT_TYPE_BOOL in a bunch of places

From: Clément Bœsch --- libavformat/adtsenc.c| 4 ++-- libavformat/aiffenc.c| 2 +- libavformat/apngdec.c| 2 +- libavformat/asfdec_f.c | 4 ++-- libavformat/assenc.c | 2 +- libavformat/avidec.c |

[FFmpeg-devel] [PATCH 5/5] swscale: use AV_OPT_TYPE_BOOL for {src, dst}_range options

From: Clément Bœsch --- libswscale/options.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/options.c b/libswscale/options.c index e666e5a..c1ea336 100644 --- a/libswscale/options.c +++ b/libswscale/options.c @@ -59,8 +59,8 @@ static

[FFmpeg-devel] [PATCH 4/5] swresample: use AV_OPT_TYPE_BOOL for linear_interp and cheby options

From: Clément Bœsch --- libswresample/options.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswresample/options.c b/libswresample/options.c index 654102a..eac1a7c 100644 --- a/libswresample/options.c +++ b/libswresample/options.c @@ -84,7

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: use constants for rc_strategy

On Sat, Nov 21, 2015 at 09:28:31PM +0100, Clément Bœsch wrote: > --- > libavcodec/mpegvideo.h | 10 +- > libavcodec/ratecontrol.c | 10 +++--- > 2 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h > index

[FFmpeg-devel] [PATCH 1/5] avcodec: use AV_OPT_TYPE_BOOL in a bunch of places

From: Clément Bœsch --- libavcodec/ac3dec_fixed.c | 2 +- libavcodec/ac3dec_float.c | 2 +- libavcodec/ac3enc_opts_template.c | 4 ++-- libavcodec/alac.c | 2 +- libavcodec/cinepakenc.c | 2 +- libavcodec/dcadec.c

[FFmpeg-devel] [PATCH 2/5] avfilter: use AV_OPT_TYPE_BOOL in a bunch of places

From: Clément Bœsch --- libavfilter/avf_showwaves.c | 2 +- libavfilter/vf_pullup.c | 2 +- libavfilter/vf_scale.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index

[FFmpeg-devel] [PATCH] avformat/thp: implement seeking

Signed-off-by: Paul B Mahol --- libavformat/thp.c | 44 +--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/libavformat/thp.c b/libavformat/thp.c index 5569027..c661569 100644 --- a/libavformat/thp.c +++