Re: [FFmpeg-devel] [PATCH 1/5] lavf: add FFERROR_REDO to let demuxer return no packet.

2015-11-27 Thread Clément Bœsch
On Fri, Nov 27, 2015 at 07:16:06PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavformat/internal.h | 6 ++ > libavformat/utils.c| 5 + > 2 files changed, 11 insertions(+) > > > Apparently, the most unhappyness was caused by the error

[FFmpeg-devel] [PATCH] aac: prevent calling ff_aac_tableinit() twice during init

2015-11-27 Thread Rostislav Pehlivanov
This commit prevents the corner case where both the decoder and the encoder could call ff_aac_tableinit() twice during init (in case of transcoding aac-aac). Signed-off-by: Rostislav Pehlivanov --- libavcodec/aacdec_template.c | 10 ++ libavcodec/aacenc.c |

Re: [FFmpeg-devel] [PATCH] avfilter/af_dynaudnorm: remove pow2

2015-11-27 Thread Paul B Mahol
On 11/27/15, Ganesh Ajjanagadde wrote: > On Wed, Nov 25, 2015 at 10:36 AM, Ronald S. Bultje > wrote: >> Hi, >> >> On Wed, Nov 25, 2015 at 8:00 AM, Ganesh Ajjanagadde >> >> wrote: >>> >>> pow2 is being used for trivial squaring.

Re: [FFmpeg-devel] [PATCH] avfilter/af_dynaudnorm: remove pow2

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 2:24 PM, Paul B Mahol wrote: > On 11/27/15, Ganesh Ajjanagadde wrote: >> On Wed, Nov 25, 2015 at 10:36 AM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Wed, Nov 25, 2015 at 8:00 AM, Ganesh Ajjanagadde >>>

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Hendrik Leppkes
On Fri, Nov 27, 2015 at 6:40 PM, Rostislav Pehlivanov wrote: > On Fri, 2015-11-27 at 09:08 -0800, Timothy Gu wrote: >> On Fri, Nov 27, 2015 at 03:08:05PM +, Rostislav Pehlivanov wrote: >> > I've just pushed a patch which makes the AAC encoder threadsafe, so >> > now >> >

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Timothy Gu
On Fri, Nov 27, 2015 at 03:08:05PM +, Rostislav Pehlivanov wrote: > I've just pushed a patch which makes the AAC encoder threadsafe, so now > it should be safe to always generate that table at runtime. This commit seems to break FATE on a couple of platforms (not sure about Linux yet but

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-27 Thread Ronald S. Bultje
Hi, On Thu, Nov 26, 2015 at 6:19 PM, Nicolas George wrote: > Le sextidi 6 frimaire, an CCXXIV, Marton Balint a écrit : > > Maybe I am missing something, but the existing error AVERROR(EINTR) > cannot > > be used for this? > > It would be less broken than EAGAIN, since it is

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 12:08 PM, Timothy Gu wrote: > On Fri, Nov 27, 2015 at 03:08:05PM +, Rostislav Pehlivanov wrote: >> I've just pushed a patch which makes the AAC encoder threadsafe, so now >> it should be safe to always generate that table at runtime. > > This

[FFmpeg-devel] [PATCH] avcodec/libdcadec: require first public release

2015-11-27 Thread James Almer
Signed-off-by: James Almer --- configure | 4 +--- libavcodec/libdcadec.c | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 0198b75..5583358 100755 --- a/configure +++ b/configure @@ -1877,7 +1877,6 @@

Re: [FFmpeg-devel] [PATCHv3 1/3] avutil/tablegen: add tablegen compatibility hacks

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 9:43 AM, Clément Bœsch wrote: > On Fri, Nov 27, 2015 at 06:32:40AM -0500, Ganesh Ajjanagadde wrote: >> On Fri, Nov 27, 2015 at 4:46 AM, Clément Bœsch wrote: >> > On Thu, Nov 26, 2015 at 11:58:10AM -0500, Ganesh Ajjanagadde wrote: >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Rostislav Pehlivanov
On Fri, 2015-11-27 at 09:08 -0800, Timothy Gu wrote: > On Fri, Nov 27, 2015 at 03:08:05PM +, Rostislav Pehlivanov wrote: > > I've just pushed a patch which makes the AAC encoder threadsafe, so > > now > > it should be safe to always generate that table at runtime. > > This commit seems to

[FFmpeg-devel] [PATCH 4/5] lavf/lxfdec: use FFERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/lxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Untested. diff --git a/libavformat/lxfdec.c b/libavformat/lxfdec.c index 7c3d065..696e112 100644 --- a/libavformat/lxfdec.c +++ b/libavformat/lxfdec.c @@ -305,7

[FFmpeg-devel] [PATCH 3/5] lavf/mpeg: use FFERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/mpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Problem can be observed with files containing large portions of junk, for example: { ffmpeg -lavfi testsrc=d=60 -f vob -; head -c $[256*1024*1024] /dev/zero; ffmpeg

[FFmpeg-devel] [PATCH 2/5] lavf/flvdec: use FFERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread Nicolas George
Fix trac ticket #5041. Signed-off-by: Nicolas George --- libavformat/flvdec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Problem can be observed by transcoding or remuxing a large FLV with both audio and video with and without -an or -vn and

[FFmpeg-devel] [PATCH 1/5] lavf: add FFERROR_REDO to let demuxer return no packet.

2015-11-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/internal.h | 6 ++ libavformat/utils.c| 5 + 2 files changed, 11 insertions(+) Apparently, the most unhappyness was caused by the error code in the public API. This is not the case here. diff --git

[FFmpeg-devel] [PATCH 5/5] lavf/mpegts: use AVERROR_INVALIDDATA instead of AVERROR(EINTR).

2015-11-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/mpegts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Untested. Offending commit was: commit df8aa4598c7cc1c2f863f6fc6b2d4b3e6dc7345e Author: Martin Storsjö Date: 2012-04-21 20:44:24 +0300

Re: [FFmpeg-devel] [PATCH] avfilter/af_dynaudnorm: remove pow2

2015-11-27 Thread Ganesh Ajjanagadde
On Wed, Nov 25, 2015 at 10:36 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Nov 25, 2015 at 8:00 AM, Ganesh Ajjanagadde > wrote: >> >> pow2 is being used for trivial squaring. Its name is not good: is this >> 2^x or x^2? > > > 2^x is exp2, not pow2. (I

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread wm4
On Fri, 27 Nov 2015 09:08:38 -0800 Timothy Gu wrote: > On Fri, Nov 27, 2015 at 03:08:05PM +, Rostislav Pehlivanov wrote: > > I've just pushed a patch which makes the AAC encoder threadsafe, so now > > it should be safe to always generate that table at runtime. > >

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Rostislav Pehlivanov
On Fri, 2015-11-27 at 18:50 +0100, Hendrik Leppkes wrote: > Note that the init is wrong for float as well. You use the same > condition for aacenc and aacdec, but they init different things. > aacdec inits much more, and if aacenc would init first for some > reason, it would leave aacdec without

[FFmpeg-devel] [PATCH] mpegencts: Fix overflow in cbr mode period calculations

2015-11-27 Thread Timo Teräs
ts->mux_rate is int (signed 32-bit) type. The period calculations will start to overflow when mux_rate > 5mbps. This fixes overflows by using av_rescale(). Fixes #5044. Signed-off-by: Timo Teräs --- libavformat/mpegtsenc.c | 9 +++-- 1 file changed, 3 insertions(+), 6

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 5:35 AM, Rostislav Pehlivanov wrote: > LGTM, but could you leave (just comment it out) the old code in there > so it's a little easier to follow? >> //ff_aac_pow2sf_tab[i] = pow(2, (i - POW_SF2_ZERO) / 4.0); >> //ff_aac_pow34sf_tab[i] =

Re: [FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread Nicolas George
Le septidi 7 frimaire, an CCXXIV, wm4 a écrit : > Not really. EARGUMENTNOTFOUND. > Well, unlike with peace in middle-east, everyone already figured out > that threads are a good solution to I/O. Argumentum ad numerum fallacy. Experienced people figured out that threads are a BAD solution to

Re: [FFmpeg-devel] QSV

2015-11-27 Thread Ivan Uskov
Hello All, Friday, November 27, 2015, 11:34:52 AM, you wrote: IU> Hello Michael, IU> Thursday, November 26, 2015, 11:13:45 PM, you wrote: MN>> Hi MN>> are there any QSV patches which have been reviewed and have no MN>> objections raised against them ? MN>> that is patches i should apply/push

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread wm4
On Fri, 27 Nov 2015 06:42:21 -0500 Ganesh Ajjanagadde wrote: > On Fri, Nov 27, 2015 at 5:35 AM, Rostislav Pehlivanov > wrote: > > LGTM, but could you leave (just comment it out) the old code in there > > so it's a little easier to follow? > >>

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Hendrik Leppkes
On Fri, Nov 27, 2015 at 1:48 PM, Ganesh Ajjanagadde wrote: > On Fri, Nov 27, 2015 at 7:05 AM, wm4 wrote: >> On Fri, 27 Nov 2015 06:42:21 -0500 >> Ganesh Ajjanagadde wrote: >> >>> On Fri, Nov 27, 2015 at 5:35 AM, Rostislav

Re: [FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread Nicolas George
Le septidi 7 frimaire, an CCXXIV, wm4 a écrit : > I might not be familiar with flvdec in particular. Can you explain me > how Matroska could be switched to non-blocking? It can not, and this has NOTHING to do with the current discussion. Non-blocking mode requires the demuxer to be able to stop

Re: [FFmpeg-devel] [PATCHv3 1/3] avutil/tablegen: add tablegen compatibility hacks

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 4:46 AM, Clément Bœsch wrote: > On Thu, Nov 26, 2015 at 11:58:10AM -0500, Ganesh Ajjanagadde wrote: >> Reviewed-by: Ronald S. Bultje >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/tablegen.h | 33

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-27 Thread Nicolas George
Le septidi 7 frimaire, an CCXXIV, Clement Boesch a écrit : > But then it's still exposed by the API, and someone looking at handling > every error code might be wondering how to handle it. « Handling every error code » seems to me like an impossible and idiotic objective. What do you suggest,

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Nicolas George
Le septidi 7 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > However, for this to be valid, at least some basic tests need to be > done, e.g what is the library size before and after > --enable-hardcoded-tables? That is not terribly difficult to do: -rwxr-xr-x 1 cigaes cigaes 15732448 Nov 27

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread wm4
On Fri, 27 Nov 2015 13:51:57 +0100 Hendrik Leppkes wrote: > On Fri, Nov 27, 2015 at 1:48 PM, Ganesh Ajjanagadde wrote: > > On Fri, Nov 27, 2015 at 7:05 AM, wm4 wrote: > >> On Fri, 27 Nov 2015 06:42:21 -0500 > >> Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-27 Thread Clément Bœsch
On Fri, Nov 27, 2015 at 01:10:29PM +0100, Nicolas George wrote: > Le septidi 7 frimaire, an CCXXIV, Clement Boesch a écrit : > > But then it's still exposed by the API, and someone looking at handling > > every error code might be wondering how to handle it. > > « Handling every error code »

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-27 Thread Derek Buitenhuis
On 11/27/2015 7:07 AM, Nicolas George wrote: > So basically, the question boils down to what people consider the better > design: adding a loop in every demuxer that needs it, or have the loop in > the framework. I'm erring on the latter approach, for one reason: This changes beavior, but does

Re: [FFmpeg-devel] [PATCHv3 1/3] avutil/tablegen: add tablegen compatibility hacks

2015-11-27 Thread Clément Bœsch
On Fri, Nov 27, 2015 at 06:32:40AM -0500, Ganesh Ajjanagadde wrote: > On Fri, Nov 27, 2015 at 4:46 AM, Clément Bœsch wrote: > > On Thu, Nov 26, 2015 at 11:58:10AM -0500, Ganesh Ajjanagadde wrote: > >> Reviewed-by: Ronald S. Bultje > >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread wm4
On Fri, 27 Nov 2015 13:32:30 +0100 Nicolas George wrote: > Le septidi 7 frimaire, an CCXXIV, wm4 a écrit : > > Not really. > > EARGUMENTNOTFOUND. Neither have I. In your posts. Can you just try explaining what you want to achieve, instead of writing lots of text with no

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 7:05 AM, wm4 wrote: > On Fri, 27 Nov 2015 06:42:21 -0500 > Ganesh Ajjanagadde wrote: > >> On Fri, Nov 27, 2015 at 5:35 AM, Rostislav Pehlivanov >> wrote: >> > LGTM, but could you leave (just comment it

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Hendrik Leppkes
On Fri, Nov 27, 2015 at 2:10 PM, wm4 wrote: > On Fri, 27 Nov 2015 13:51:57 +0100 > Hendrik Leppkes wrote: > >> On Fri, Nov 27, 2015 at 1:48 PM, Ganesh Ajjanagadde wrote: >> > On Fri, Nov 27, 2015 at 7:05 AM, wm4

Re: [FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread Nicolas George
Le septidi 7 frimaire, an CCXXIV, wm4 a écrit : > I still do not see how a potential flag to make the API user to be able > to use this is better than running the demuxer in a thread. I'm talking > about practice, not theory. Such a flag would work _sometimes_, with > _some_ demuxers in _some_

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 8:10 AM, wm4 wrote: > On Fri, 27 Nov 2015 13:51:57 +0100 > Hendrik Leppkes wrote: > >> On Fri, Nov 27, 2015 at 1:48 PM, Ganesh Ajjanagadde wrote: >> > On Fri, Nov 27, 2015 at 7:05 AM, wm4

Re: [FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread wm4
On Fri, 27 Nov 2015 13:53:33 +0100 Nicolas George wrote: > Le septidi 7 frimaire, an CCXXIV, wm4 a écrit : > > I might not be familiar with flvdec in particular. Can you explain me > > how Matroska could be switched to non-blocking? > > It can not, and this has NOTHING to do

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-27 Thread wm4
On Fri, 27 Nov 2015 15:14:54 -0500 Alex Agranovsky wrote: > > Hi - are there any additional corrections I need to address on this set of > patches, or is it good to go at this point? Sorry, forgot about it, will look tomorrow. Also, the quoting in your replies is

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Set width to actual coded_width for AVCI50

2015-11-27 Thread Tomas Härdin
On Thu, 2015-11-26 at 00:48 +0100, Carl Eugen Hoyos wrote: > On Wednesday 25 November 2015 12:57:07 am Tomas Härdin wrote: > > On Tue, 2015-11-24 at 12:02 +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #5029. > > > > > > Please comment, Carl Eugen > > > > Looks

[FFmpeg-devel] [PATCH 2/2] fate/concatdec: Use -bitexact

2015-11-27 Thread Timothy Gu
Fixes FATE failures on --enable-small builds. --- tests/fate-run.sh | 4 ++-- tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- tests/ref/fate/concat-demuxer-simple1-lavf-mxf | 4 ++--

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: get rid of hardcoded tables entirely

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 6:14 PM, Rostislav Pehlivanov wrote: > On Fri, 2015-11-27 at 17:07 -0500, Ganesh Ajjanagadde wrote: >> Commit 96786a12f6df26990bbe7c0ca4592b3731724469 makes runtime >> initialization cheap. > > Leaves a lot of the cruft around. aac_tablegen.h and >

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-27 Thread Marton Balint
On Fri, 27 Nov 2015, Nicolas George wrote: I am not sure distinguishing the different cases (packet in a disabled stream, utility data, corrupted data until a sync word) is very important. I think it is, loss off sync means data loss, which is a severe error condition for some use cases.

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: get rid of hardcoded tables entirely

2015-11-27 Thread Rostislav Pehlivanov
On Fri, 2015-11-27 at 17:07 -0500, Ganesh Ajjanagadde wrote: > Commit 96786a12f6df26990bbe7c0ca4592b3731724469 makes runtime > initialization cheap. Leaves a lot of the cruft around. aac_tablegen.h and aac_tablegen_decl.h are now quite unnecessary. I suggest getting rid of aac_tablegen* entirely

Re: [FFmpeg-devel] [PATCH] mpegencts: Fix overflow in cbr mode period calculations

2015-11-27 Thread Michael Niedermayer
On Fri, Nov 27, 2015 at 09:25:52PM +0200, Timo Teräs wrote: > ts->mux_rate is int (signed 32-bit) type. The period calculations > will start to overflow when mux_rate > 5mbps. This fixes overflows > by using av_rescale(). > > Fixes #5044. > > Signed-off-by: Timo Teräs > --- >

[FFmpeg-devel] [PATCH] avcodec/mpegaudio_tablegen: more dynamic initialization speedups

2015-11-27 Thread Ganesh Ajjanagadde
This further speeds up runtime initialization, with identical generated tables. Sample benchmark (x86-64, Haswell, GNU/Linux): old: 34441423 decicycles in mpegaudio_tableinit,8192 runs, 0 skips new: 10776291 decicycles in mpegaudio_tableinit,8192 runs, 0 skips Most low

Re: [FFmpeg-devel] [PATCH] Allow mpjpeg demuxer to process MIME parts which do not include Content-Length header.

2015-11-27 Thread Alex Agranovsky
On November 25, 2015 at 10:35:33 AM, Alex Agranovsky (a...@sighthound.com) wrote: On November 24, 2015 at 6:06:36 PM, Michael Niedermayer (michae...@gmx.at) wrote: On Tue, Nov 24, 2015 at 03:01:28PM -0500, Alex Agranovsky wrote:  [...]  > From 2c253d7978a6c9c2dc701d393eb5b9d68e831c98 Mon Sep

Re: [FFmpeg-devel] [PATCH] aac: prevent calling ff_aac_tableinit() twice during init

2015-11-27 Thread Hendrik Leppkes
On Fri, Nov 27, 2015 at 8:00 PM, Rostislav Pehlivanov wrote: > This commit prevents the corner case where both the decoder and the > encoder could call ff_aac_tableinit() twice during init (in case of > transcoding aac-aac). > > Signed-off-by: Rostislav Pehlivanov

[FFmpeg-devel] [PATCH] avcodec/aac_tablegen: get rid of hardcoded tables entirely

2015-11-27 Thread Ganesh Ajjanagadde
Commit 96786a12f6df26990bbe7c0ca4592b3731724469 makes runtime initialization cheap. Tested with FATE, with/without --enable-hardcoded-tables. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/Makefile| 6 ++ libavcodec/aac_tablegen.c | 39

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 4:33 PM, Rostislav Pehlivanov wrote: > On Fri, 2015-11-27 at 15:59 -0500, Ganesh Ajjanagadde wrote: >> I get build failures starting with commit >> 3d62e7a30fa552be52d12b31e3e0f79153aff891 under >> --enable-hardcoded-tables. >> @Rostislav: can you

[FFmpeg-devel] [PATCHv2] avcodec/aac_tablegen: get rid of hardcoded tables entirely

2015-11-27 Thread Ganesh Ajjanagadde
Commit 96786a12f6df26990bbe7c0ca4592b3731724469 makes runtime initialization cheap. Tested with FATE, with/without --enable-hardcoded-tables. Reviewed-by: Rostislav Pehlivanov Signed-off-by: Ganesh Ajjanagadde --- libavcodec/Makefile|

[FFmpeg-devel] [PATCH]lavf/rtpenc_jpeg: Fix huffman table test

2015-11-27 Thread Carl Eugen Hoyos
Hi! Jpeg over rtp requires standard huffman tables, but the test I implemented was too strict. Attached patch tries to improve this, related to ticket #3823. Please comment, Carl Eugen diff --git a/libavformat/rtpenc_jpeg.c b/libavformat/rtpenc_jpeg.c index a6f2b32..4bdfdda 100644 ---

[FFmpeg-devel] mpegtsenc cbr mode pcr accuracy

2015-11-27 Thread Timo Teras
Hi, While the pcr is accuracte, I was measuring the cbr pcr frequence with opencaster suite's tspcmeasure tool, and it says that the frequency is not that accurate. With default options (just muxrate specified) the pcr should appear every 20ms. But it appears every 19-22.5ms (also there some

Re: [FFmpeg-devel] [PATCHv3 1/3] avutil/tablegen: add tablegen compatibility hacks

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 9:43 AM, Clément Bœsch wrote: > On Fri, Nov 27, 2015 at 06:32:40AM -0500, Ganesh Ajjanagadde wrote: >> On Fri, Nov 27, 2015 at 4:46 AM, Clément Bœsch wrote: >> > On Thu, Nov 26, 2015 at 11:58:10AM -0500, Ganesh Ajjanagadde wrote: >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Rostislav Pehlivanov
On Fri, 2015-11-27 at 09:16 -0500, Ganesh Ajjanagadde wrote: > Ok, good. Let us proceed with this one step at a time. Here, I guess > it really does not matter since the net size is ~ 3 kB. Nevertheless, > it seems unnecessary now to do it at compile time, so unless AAC > maintainers object, I

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 9:37 AM, Clément Bœsch wrote: > On Fri, Nov 27, 2015 at 12:40:27PM +0100, Ganesh Ajjanagadde wrote: > [...] >> diff --git a/libavcodec/aac_tablegen.h b/libavcodec/aac_tablegen.h >> index 8b223f9..85e189d 100644 >> --- a/libavcodec/aac_tablegen.h >> +++

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Ganesh Ajjanagadde
On Fri, Nov 27, 2015 at 1:00 PM, Rostislav Pehlivanov wrote: > On Fri, 2015-11-27 at 18:50 +0100, Hendrik Leppkes wrote: >> Note that the init is wrong for float as well. You use the same >> condition for aacenc and aacdec, but they init different things. >> aacdec inits much

[FFmpeg-devel] [PATCH 1/2] ffprobe: Do not print profile names in -bitexact

2015-11-27 Thread Timothy Gu
Instead, print "unknown" if it's unknown, or their numerical values if they are known. --- Addresses Nicholas's comment. --- ffprobe.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index c304a6d..7128083 100644 --- a/ffprobe.c +++

[FFmpeg-devel] [PATCH] lavf/mxfdec: fix seeking before the first keyframe

2015-11-27 Thread Marton Balint
Regression since 53f2ef2c4afb1d49a679dea9163cb0e4671f3117. Fixes ticket #5017. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 429f46a..926d2a3 100644 ---

Re: [FFmpeg-devel] [PATCHv3 1/3] avutil/tablegen: add tablegen compatibility hacks

2015-11-27 Thread Clément Bœsch
On Thu, Nov 26, 2015 at 11:58:10AM -0500, Ganesh Ajjanagadde wrote: > Reviewed-by: Ronald S. Bultje > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/tablegen.h | 33 + > 1 file changed, 33 insertions(+) > create

Re: [FFmpeg-devel] QSV

2015-11-27 Thread Ivan Uskov
Hello Michael, Thursday, November 26, 2015, 11:13:45 PM, you wrote: MN> Hi MN> are there any QSV patches which have been reviewed and have no MN> objections raised against them ? MN> that is patches i should apply/push for qsv ... Excluding two patches by Will Kelleher which were re-checked

Re: [FFmpeg-devel] [PATCH 3/3] lavf/flvdec: use AVERROR_REDO instead of AVERROR(EAGAIN).

2015-11-27 Thread wm4
On Thu, 26 Nov 2015 21:21:08 +0100 Nicolas George wrote: > Le sextidi 6 frimaire, an CCXXIV, wm4 a écrit : > > I fail to see how letting such a workaround (required for flv) leak to > > ... and a few other demuxers... > > > common code is more elegant. > > You fail to

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-27 Thread Clément Bœsch
On Thu, Nov 26, 2015 at 11:42:03PM +0100, Nicolas George wrote: > Le sextidi 6 frimaire, an CCXXIV, Clement Boesch a écrit : > > > An option can be added later to grant applications fine-grained control on > > > the looping, but it can not be the default as it would be an API change, > > > and >

Re: [FFmpeg-devel] [PATCH] avcodec/aac_tablegen: speed up table initialization

2015-11-27 Thread Rostislav Pehlivanov
LGTM, but could you leave (just comment it out) the old code in there so it's a little easier to follow? >         //ff_aac_pow2sf_tab[i] = pow(2, (i - POW_SF2_ZERO) / 4.0); >         //ff_aac_pow34sf_tab[i] = pow(ff_aac_pow2sf_tab[i], 3.0/4.0); The accuracy increase is always nice. On Thu,