Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Γιώργος Μεταξάκης
didn't knew about that ticket. On Fri, Feb 12, 2016 at 10:57 AM Carl Eugen Hoyos wrote: > Γιώργος Μεταξάκης gmail.com> writes: > > > > > i'm sending you a new patch with only 6 changes. > > > > The problem was that when you where capturing the > > > > screen, the mouse wasn't

Re: [FFmpeg-devel] [PATCH v8] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/11/2016 03:46 AM, Mats Peterson wrote: Nice. The patch fails on tests/ref/fate/sub2video, since you JUST changed it over there. Can you fix that on your side? Ignore this patch. Mats ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v8] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Paul B Mahol
On 2/12/16, Mats Peterson wrote: > On 02/11/2016 03:46 AM, Mats Peterson wrote: > >> Nice. The patch fails on tests/ref/fate/sub2video, since you JUST >> changed it over there. Can you fix that on your side? >> > > Ignore this patch. Why?

[FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
Now handles non-standard 8 bpp raw AVI files created with "-vcodec rawvideo" that contain the palette at the end of each frame, like nut. 8 bpp raw QuickTime files created with "-vcodec rawvideo" won't work quite right, because they contain a palette both in the video sample description and

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Γιώργος Μεταξάκης
I have changed that. On Fri, Feb 12, 2016 at 10:25 AM Hendrik Leppkes wrote: > On Fri, Feb 12, 2016 at 9:21 AM, Γιώργος Μεταξάκης > wrote: > > i'm very sorry for those mistakes > > i'm sending you a new patch with only 6 changes. > > The problem was

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Hendrik Leppkes
On Fri, Feb 12, 2016 at 9:21 AM, Γιώργος Μεταξάκης wrote: > i'm very sorry for those mistakes > i'm sending you a new patch with only 6 changes. > The problem was that when you where capturing the screen, the mouse wasn't > on the correct location. > That looks much better

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2016-02-12 Thread Rodger Combs
This issue is fixed by this patch, but I'm unsure of possible implications on other files. It passes FATE, at least. diff --git a/libavformat/mov.c b/libavformat/mov.c index 149e3b4..c5e0a1e 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3609,7 +3609,7 @@ static int

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Moritz Barsnick
On Fri, Feb 12, 2016 at 09:25:54 +0100, Hendrik Leppkes wrote: > On Fri, Feb 12, 2016 at 9:21 AM, Γιώργος Μεταξάκης wrote: > > i'm very sorry for those mistakes > That looks much better already, unfortunately there is still tabs in the > patch. A good hint for new

Re: [FFmpeg-devel] [PATCH v8] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 10:53 AM, Paul B Mahol wrote: On 2/12/16, Mats Peterson wrote: On 02/11/2016 03:46 AM, Mats Peterson wrote: Nice. The patch fails on tests/ref/fate/sub2video, since you JUST changed it over there. Can you fix that on your side? Ignore this

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Carl Eugen Hoyos
Γιώργος Μεταξάκης gmail.com> writes: > > > i'm sending you a new patch with only 6 changes. > > > The problem was that when you where capturing the > > > screen, the mouse wasn't on the correct location. Does this fix ticket #5008? If yes, please mention it in the commit message. Thank you,

[FFmpeg-devel] [CLT2016] FFmpeg at Chemnitzer Linux-Tage 2016

2016-02-12 Thread Thilo Borgmann
Hi! FFmpeg has been accepted for CLT 2016 in Chemnitz, Germany! This "Chemnitzer Linux Tage" will take place from 19th to 20th of March. You can find more details on their homepage: https://chemnitzer.linux-tage.de/2016/en/ Thus once again, we will man a booth with our staff and are happily

Re: [FFmpeg-devel] [PATCH v8] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 11:06 AM, Paul B Mahol wrote: Why? Are you being sarcastic? No. Why patch should be ignored? ___ Because I had to fix some additional stuff. I should perhaps say "Ignore this *version* of the patch"... Mats

Re: [FFmpeg-devel] [PATCH] avfilter/af_anequalizer: Avoid loss of precision when calculating nyquist frequency

2016-02-12 Thread Paul B Mahol
On 2/12/16, Michael Niedermayer wrote: > Fixes: CID1351398 > Fixes: CID1351400 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_anequalizer.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zoompan: Fix use of uninitialized variables

2016-02-12 Thread Paul B Mahol
On 2/12/16, Michael Niedermayer wrote: > Fixes: CID1351392 > Fixes: CID1351393 > Fixes: CID1351395 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_zoompan.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_zoompan: Initialize ret

2016-02-12 Thread Paul B Mahol
On 2/12/16, Michael Niedermayer wrote: > Silences: CID1351394 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_zoompan.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_zoompan.c

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Γιώργος Μεταξάκης
i'm very sorry for those mistakes i'm sending you a new patch with only 6 changes. The problem was that when you where capturing the screen, the mouse wasn't on the correct location. On Fri, Feb 12, 2016 at 2:01 AM James Darnley wrote: > On 2016-02-11 23:19, Γιώργος

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 12:55:59PM +0100, Mats Peterson wrote: > On 02/12/2016 12:53 PM, Mats Peterson wrote: > >ahead. I know the debug code is superfluous, though. > > But it's handy in order to check packet size / stride, since this > circus is far from over and done with. i agree about its

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 12:31:56PM +0100, Mats Peterson wrote: > On 02/12/2016 12:02 PM, Mats Peterson wrote: > >On 02/12/2016 11:26 AM, Mats Peterson wrote: > >>Now handles non-standard 8 bpp raw AVI files created with "-vcodec > >>rawvideo" that contain the palette at the end of each frame, like

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 01:41 PM, Mats Peterson wrote: On 02/12/2016 01:09 PM, Mats Peterson wrote: On 02/12/2016 01:03 PM, Mats Peterson wrote: Well, it's not because of my patch. It was the same before it. And you have more knowledge than me when it comes to fixing the muxing code. I have mostly dealt

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread wm4
On Fri, 12 Feb 2016 13:23:02 +0100 Mats Peterson wrote: > On 02/12/2016 12:49 PM, Michael Niedermayer wrote: > >> +av_log(avctx, AV_LOG_DEBUG, "PACKET SIZE: %d\n", avpkt->size); > >> +av_log(avctx, AV_LOG_DEBUG, "STRIDE: %d\n", stride); > > > > this

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zoompan: Fix use of uninitialized variables

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 09:20:08AM +0100, Paul B Mahol wrote: > On 2/12/16, Michael Niedermayer wrote: > > Fixes: CID1351392 > > Fixes: CID1351393 > > Fixes: CID1351395 > > > > Signed-off-by: Michael Niedermayer > > --- > >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_zoompan: Initialize ret

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 09:20:22AM +0100, Paul B Mahol wrote: > On 2/12/16, Michael Niedermayer wrote: > > Silences: CID1351394 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_zoompan.c |2 +- > > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 12:53 PM, Mats Peterson wrote: ahead. I know the debug code is superfluous, though. But it's handy in order to check packet size / stride, since this circus is far from over and done with. Mats ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 01:00 PM, Michael Niedermayer wrote: can you fix that ? it is very important that generated files are correct and compliant to specs Well, it's not because of my patch. It was the same before it. And you have more knowledge than me when it comes to fixing the muxing code. I

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 01:09 PM, Mats Peterson wrote: I admit it sounded like it was because of my patch, but I worded it in a confusing way, I guess. I meant that since my patch will make 1 bpp raw AVI files use pal8 internally, to produce a 1 bpp file, you can either use "-vcodec copy", or "-vcodec

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 01:09 PM, Mats Peterson wrote: On 02/12/2016 01:03 PM, Mats Peterson wrote: Well, it's not because of my patch. It was the same before it. And you have more knowledge than me when it comes to fixing the muxing code. I have mostly dealt with the demuxing side so far, since that's

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 01:02 PM, Michael Niedermayer wrote: On Fri, Feb 12, 2016 at 12:55:59PM +0100, Mats Peterson wrote: On 02/12/2016 12:53 PM, Mats Peterson wrote: ahead. I know the debug code is superfluous, though. But it's handy in order to check packet size / stride, since this circus is far

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 01:03 PM, Mats Peterson wrote: Well, it's not because of my patch. It was the same before it. And you have more knowledge than me when it comes to fixing the muxing code. I have mostly dealt with the demuxing side so far, since that's where I feel decently comfortable. Mats I

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 12:49 PM, Michael Niedermayer wrote: +av_log(avctx, AV_LOG_DEBUG, "PACKET SIZE: %d\n", avpkt->size); +av_log(avctx, AV_LOG_DEBUG, "STRIDE: %d\n", stride); this looks like some private debug code, which doesnt belong in this patch This is easy enough for you to remove,

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/12/2016 01:27 PM, wm4 wrote: This is easy enough for you to remove, isn't it? It's even easier for you. (Should be.) Well, he seems to want to split the patch up anyway, so it shouldn't be that hard to remove those lines. Mats ___

Re: [FFmpeg-devel] [PATCH] fate/source: Attempt to fix BSD sed

2016-02-12 Thread Michael Niedermayer
On Thu, Feb 11, 2016 at 10:27:47PM -0800, Timothy Gu wrote: > I apparently used a GNU extension in the !{} syntax. Remove that rule > and the cause of it. > --- > cmdutils.h | 4 ++-- > tests/fate/source-check.sh | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) on

Re: [FFmpeg-devel] [PATCH] doc/filters: add geq diagonal split screen example

2016-02-12 Thread Michael Niedermayer
On Thu, Feb 11, 2016 at 03:51:34PM -0900, Lou Logan wrote: > Signed-off-by: Lou Logan > --- > doc/filters.texi | 7 +++ > 1 file changed, 7 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/dnxhd_parser: add parser and probe support raw 444 and dnxhr formats

2016-02-12 Thread Michael Niedermayer
On Thu, Feb 11, 2016 at 08:41:16PM -0800, Mark Reid wrote: > --- > libavcodec/dnxhd_parser.c | 11 +++ > libavformat/dnxhddec.c| 7 --- > 2 files changed, 11 insertions(+), 7 deletions(-) what effect on speed does this have ? AV_RB*() might be better than memcmp(), also a inline

Re: [FFmpeg-devel] [PATCH] avfilter: add loop filters

2016-02-12 Thread Paul B Mahol
On 2/11/16, Paul B Mahol wrote: > Hi, > > patch attached. > Better version attached. From d953f78bffbf3db8f0209b41b189ece12b402afa Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 11 Feb 2016 22:05:54 +0100 Subject: [PATCH] avfilter: add loop filters

Re: [FFmpeg-devel] [PATCH] doc/filters: add example of pipe protocol use in movie filter

2016-02-12 Thread Carl Eugen Hoyos
Dave Rice dericed.com> writes: > Based on Paul’s advice on > https://trac.ffmpeg.org/ticket/5229#comment:1. This adds > an example of the pipe protocol in the movie filter with > necessary escaping. On which system / shell does your example work? Carl Eugen

Re: [FFmpeg-devel] [PATCH] avfilter: add loop filters

2016-02-12 Thread Nicolas George
Le quartidi 24 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > This shoudl use av_frame_get_pkt_duration() > > /** > * duration of the corresponding packet, expressed in > * AVStream->time_base units, 0 if unknown. > * Code outside libavutil should access this field using:

[FFmpeg-devel] [PATCH] doc/filters: add example of pipe protocol use in movie filter

2016-02-12 Thread Dave Rice
Hi, Based on Paul’s advice on https://trac.ffmpeg.org/ticket/5229#comment:1. This adds an example of the pipe protocol in the movie filter with necessary escaping. Dave Rice 0001-doc-filters-add-example-of-pipe-protocol-use-in-movi.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] avfilter: add loop filters

2016-02-12 Thread Michael Niedermayer
On Thu, Feb 11, 2016 at 11:11:49PM +0100, Paul B Mahol wrote: > Hi, > > patch attached. > Makefile |2 > allfilters.c |2 > f_loop.c | 220 > +++ > 3 files changed, 224 insertions(+) >

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > On 2/10/2016 4:33 PM, Paul B Mahol wrote: > > I'm fine by this, but it would be nice to have SIMD > > and 10 bit support in decoder. > > I agree with the latter. > > I'd argue, however, we don't actually support 10-bit via the > wrapper anyway, since you

Re: [FFmpeg-devel] [PATCH v8] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Paul B Mahol
On 2/12/16, Mats Peterson wrote: > On 02/12/2016 10:53 AM, Paul B Mahol wrote: >> On 2/12/16, Mats Peterson wrote: >>> On 02/11/2016 03:46 AM, Mats Peterson wrote: >>> Nice. The patch fails on tests/ref/fate/sub2video,

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-12 Thread Carl Eugen Hoyos
Steve Lhomme gmail.com> writes: > can be found in such sample > http://streams.videolan.org/issues/16620/VLCSupportsample.mkv The sample works fine here both with current and old FFmpeg. I believe it should also work with vlc --demux=ffmpeg Is vlc supposed to remux alac from mkv to mov? Does

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > On 2/12/2016 5:03 PM, Paul B Mahol wrote: > > make install (as root)and then build FFmpeg with > > libutvideo support. > > Last time I tried this, it failed to configure, due to > duplicated symbol 'main'. It works fine here for 32 and 64 bit for

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > On 2/10/2016 4:33 PM, Paul B Mahol wrote: > > I'm fine by this, but it would be nice to have SIMD and > > 10 bit support in decoder. > > I agree with the latter. > > I'd argue, however, we don't actually support 10-bit via the > wrapper anyway, since you

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Derek Buitenhuis
On 2/12/2016 5:03 PM, Paul B Mahol wrote: > make install (as root)and then build FFmpeg with >> libutvideo support. Last time I tried this, it failed to configure, due to duplicated symbol 'main'. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] fate/source: Attempt to fix BSD sed

2016-02-12 Thread Henrik Gramner
On Fri, Feb 12, 2016 at 7:27 AM, Timothy Gu wrote: > -e 's/[^A-Za-z0-9]\{1\,\}/_/g' \ I don't think the comma is supposed to be escaped. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Stephen Hutchinson
On 2/12/2016 11:51 AM, Carl Eugen Hoyos wrote: Derek Buitenhuis gmail.com> writes: On 2/10/2016 4:33 PM, Paul B Mahol wrote: I'm fine by this, but it would be nice to have SIMD and 10 bit support in decoder. I agree with the latter. I'd argue, however, we don't actually support 10-bit via

[FFmpeg-devel] [PATCH] avfilter/avf_showcqt: improve pts handling

2016-02-12 Thread Paul B Mahol
Hi, patch attached. From 77075d790275f1d3728890c1ef82e89345490966 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Fri, 12 Feb 2016 18:17:30 +0100 Subject: [PATCH] avfilter/avf_showcqt: improve pts handling Makes seeking possible with mpv. Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > On 2/12/2016 2:24 PM, Carl Eugen Hoyos wrote: > > It works here with a repo I found on my hard disc > > This means nothing to users, unless you want to mail > your harddisk to each user. It works fine after "git pull". How do I ask git where it pulled

[FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-12 Thread Steve Lhomme
From: Steve Lhomme -- can be found in such sample http://streams.videolan.org/issues/16620/VLCSupportsample.mkv --- libavcodec/alac.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index fc8bc96..9c9df8f 100644

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Stephen Hutchinson
On 2/12/2016 9:24 AM, Carl Eugen Hoyos wrote: Derek Buitenhuis gmail.com> writes: On 2/10/2016 4:33 PM, Paul B Mahol wrote: I'm fine by this, but it would be nice to have SIMD and 10 bit support in decoder. I agree with the latter. I'd argue, however, we don't actually support 10-bit via

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libutvideo support

2016-02-12 Thread Ronald S. Bultje
Hi, On Fri, Feb 12, 2016 at 11:24 AM, Carl Eugen Hoyos wrote: > Derek Buitenhuis gmail.com> writes: > > > On 2/12/2016 2:24 PM, Carl Eugen Hoyos wrote: > > > It works here with a repo I found on my hard disc > > > > This means nothing to users, unless you want to mail > >

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Γιώργος Μεταξάκης
checked with patcheck also. only "problem" is "Missing changelog entry (ignore if minor change)' On Fri, Feb 12, 2016 at 11:51 AM Moritz Barsnick wrote: > On Fri, Feb 12, 2016 at 09:25:54 +0100, Hendrik Leppkes wrote: > > On Fri, Feb 12, 2016 at 9:21 AM, Γιώργος Μεταξάκης

[FFmpeg-devel] [PATCH][RFC/UNTESTED] swscale/slice: Actually use the buffers' strides

2016-02-12 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- I don't know how this could ever have worked, but I also am having a hard time testing the sliced path in swscale... has it even ever been run? I have CC'd the original author of this code in the hopes that he can confirm or deny

Re: [FFmpeg-devel] [PATCH] doc/filters: add geq diagonal split screen example

2016-02-12 Thread Lou Logan
On Fri, 12 Feb 2016 14:49:32 +0100, Michael Niedermayer wrote: > On Thu, Feb 11, 2016 at 03:51:34PM -0900, Lou Logan wrote: > > Signed-off-by: Lou Logan > > --- > > doc/filters.texi | 7 +++ > > 1 file changed, 7 insertions(+) > > LGTM > > thx Pushed. Also removed a

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/13/2016 05:44 AM, Mats Peterson wrote: ill try to split out some trivial parts from this patch and apply them as seperate commits after some testing though Alright. It shouldn't be that hard. Everything works just fine except that non-AVPALETTE_SIZE thing. Mats

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/13/2016 05:39 AM, Mats Peterson wrote: On 02/13/2016 12:51 AM, Michael Niedermayer wrote: +if (context->has_pkt_pal) { +memcpy(context->palette->data, + avpkt->data + avpkt->size - AVPALETTE_SIZE, AVPALETTE_SIZE); This is incorrect, the 8bit

[FFmpeg-devel] [PATCH] lavc/rawdec: Remove monowhite switching code (and only that)

2016-02-12 Thread Mats Peterson
What it sound like. Mats >From 59572f63d94bab07ab392be344c9cde7368fa33a Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Sat, 13 Feb 2016 06:45:02 +0100 Subject: [PATCH] lavc/rawdec: Remove monowhite switching code (and only that) --- libavcodec/rawdec.c | 19

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/13/2016 05:44 AM, Mats Peterson wrote: again, if you could help fix the bugs (which are not caused by your patch but which interact with these changes in nasty ways) that would be great The rawvideo muxing bugs (incorrect stride for AVI and QuickTime files produced with "-vcodec

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/13/2016 05:39 AM, Mats Peterson wrote: On 02/13/2016 12:51 AM, Michael Niedermayer wrote: +if (context->has_pkt_pal) { +memcpy(context->palette->data, + avpkt->data + avpkt->size - AVPALETTE_SIZE, AVPALETTE_SIZE); This is incorrect, the 8bit

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/13/2016 12:51 AM, Michael Niedermayer wrote: +if (context->has_pkt_pal) { +memcpy(context->palette->data, + avpkt->data + avpkt->size - AVPALETTE_SIZE, AVPALETTE_SIZE); This is incorrect, the 8bit palette in nut can have any number of entries up to

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/13/2016 05:48 AM, Mats Peterson wrote: It shouldn't be that hard. Everything works just fine except that non-AVPALETTE_SIZE thing. And how are we supposed to solve that? Knowing how many colors there are in the palette in the nut packets? Mats

Re: [FFmpeg-devel] [PATCH] lavc/rawdec: Remove monowhite switching code (and only that)

2016-02-12 Thread Mats Peterson
On 02/13/2016 06:46 AM, Mats Peterson wrote: What it sound like. Mats Forget this one. I forgot to update the FATE test files. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Mats Peterson
On 02/13/2016 05:39 AM, Mats Peterson wrote: ill try to split out some trivial parts from this patch and apply them as seperate commits after some testing though Alright. You could start with removing the monowhite switching code. Mats ___

[FFmpeg-devel] [PATCH] lavc/rawdec: Remove temporary monowhite switching code for 1 bpp raw AVI

2016-02-12 Thread Mats Peterson
What it sounds like. Remove the temporary monowhite switching code for 1 bpp raw AVI. -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From 470961cfde11ea31f4b00b2aad4f43caea0a Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Sat, 13 Feb 2016 07:23:19 +0100 Subject:

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 05:05:00PM +0100, Steve Lhomme wrote: > From: Steve Lhomme > > -- > can be found in such sample > http://streams.videolan.org/issues/16620/VLCSupportsample.mkv > --- > libavcodec/alac.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH] fate/source: Do not use GNU extensions in sed

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 05:07:20PM -0800, Timothy Gu wrote: > --- > > Tested on FreeBSD 10.2. patch should be ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way

Re: [FFmpeg-devel] [PATCH][RFC/UNTESTED] swscale/slice: Actually use the buffers' strides

2016-02-12 Thread Pedro Arthur
Hi Derek, Indeed it is a bug and that is the correct fix. The function ff_init_slice_from_src is used for initializing the source data but as it is always 'relative' it starts at 0. It is also used to initialize the destination slice but my guess is that usually the destination stride is equal,

Re: [FFmpeg-devel] [PATCH 2/2] avformat/img2enc: disable atomic file creation by default

2016-02-12 Thread Marton Balint
On Thu, 11 Feb 2016, Marton Balint wrote: Currently it is broken when explicitly using the file protocol, it uses an insecure temporary file name, and in commit b4431c80 disabling the option by default was already considered. Also it is not very consistent to have such an option for one

Re: [FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 11:26:02AM +0100, Mats Peterson wrote: > Now handles non-standard 8 bpp raw AVI files created with "-vcodec > rawvideo" that contain the palette at the end of each frame, like > nut. > > 8 bpp raw QuickTime files created with "-vcodec rawvideo" won't work > quite right,

[FFmpeg-devel] [PATCH] fate/source: Do not use GNU extensions in sed

2016-02-12 Thread Timothy Gu
--- Tested on FreeBSD 10.2. --- cmdutils.h | 4 ++-- tests/fate/source-check.sh | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/cmdutils.h b/cmdutils.h index 7f3db2a..83ea4ad 100644 --- a/cmdutils.h +++ b/cmdutils.h @@ -19,8 +19,8 @@ * Foundation,