Re: [FFmpeg-devel] dash encoder. Correct generated manifest for MPEG-DASH MPD Validator and calculate current bandwidth for eath chunk. Now works correctly with dash.sj

2016-09-07 Thread Reuben Martin
On Tuesday, September 6, 2016 1:56:57 PM CDT Ligverd Haer wrote: > В письме от вторник, 6 сентября 2016 г. 12:26:49 MSK пользователь Carl Eugen > > Attributes > > profiles > width > height > sar > frameRate > audioSamplingRate > mimeType > segmentProfiles > codecs > maximumSAPPeriod >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: implement initial_offset

2016-09-07 Thread Steven Liu
2016-09-08 9:47 GMT+08:00 Aman Gupta : > From: Aman Gupta > > --- > doc/muxers.texi | 4 > libavformat/hlsenc.c | 13 +++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index

[FFmpeg-devel] [PATCH] avformat/hlsenc: implement initial_offset

2016-09-07 Thread Aman Gupta
From: Aman Gupta --- doc/muxers.texi | 4 libavformat/hlsenc.c | 13 +++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index fd7ee50..e88dbf8 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -389,6

Re: [FFmpeg-devel] [PATCH] ffmpeg: drop format specific stream copy heuristics

2016-09-07 Thread James Almer
On 9/7/2016 6:14 AM, Michael Niedermayer wrote: >> libavformat/utils.c |4 +++- >> > tests/ref/fate/copy-trac4914 |4 ++-- >> > tests/ref/fate/copy-trac4914-avi |4 ++-- >> > 3 files changed, 7 insertions(+), 5 deletions(-) >> >

[FFmpeg-devel] [PATCH 1/2] ffmpeg: don't reconfigure terminal if we're not taking input from stdin

2016-09-07 Thread Rodger Combs
--- ffmpeg.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index d858407..1d793fe 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -366,7 +366,7 @@ static BOOL WINAPI CtrlHandler(DWORD fdwCtrlType) void term_init(void) { #if HAVE_TERMIOS_H -

[FFmpeg-devel] [PATCH 2/2] tests: add -nostdin flag when calling ffmpeg

2016-09-07 Thread Rodger Combs
This fixes a long-standing issue where running FATE in parallel could result in the terminal being left misconfigured, particularly if a test failed or was canceled wtih ^C. --- tests/fate/vpx.mak| 10 +- tests/regression-funcs.sh | 2 +- 2 files changed, 6 insertions(+), 6

Re: [FFmpeg-devel] Possible incomplete commit "avcodec/nvenc: support RGB input"

2016-09-07 Thread Sven C. Dack
On 08/09/16 00:57, Hendrik Leppkes wrote: The image copying code was refactored in an earlier patch to be generic and not rely on hard-coding format info, hence the second part is not needed anymore. This is not quite accurate. It doesn't explain the seg. fault. This didn't happen in my

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: implement program_date_time

2016-09-07 Thread Michael Niedermayer
On Thu, Sep 08, 2016 at 06:38:03AM +0800, Steven Liu wrote: > 2016-09-08 3:34 GMT+08:00 Michael Niedermayer : > > > TODO: docs, version bump > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/hlsenc.c | 23 +++ >

Re: [FFmpeg-devel] [PATCH v5 5/5] avformat/tee: Use BSF list API

2016-09-07 Thread Jan Sebechlebsky
On 09/05/2016 05:42 PM, Jan Sebechlebsky wrote: On 09/01/2016 09:42 PM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky Signed-off-by: Jan Sebechlebsky --- Changes since the last version of the patch: - added check for

Re: [FFmpeg-devel] Possible incomplete commit "avcodec/nvenc: support RGB input"

2016-09-07 Thread Hendrik Leppkes
On Wed, Sep 7, 2016 at 7:35 PM, Zoran Turalija wrote: > Today, new commit landed in git [1], but third part of submitted patch is > missing in that commit. Same part is missing in patchwork [2], too. Maybe > committer redacted patch, and threw out unneeded third part. It

Re: [FFmpeg-devel] [RFC] marking non developer tickets

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 10:24:15PM +0100, Josh de Kock wrote: > On 07/09/2016 18:48, Lou Logan wrote: > >If you want to use "task" for this then that would be fine with me. > > > >Alternatively, a wiki page could be setup similar to: >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: implement program_date_time

2016-09-07 Thread Steven Liu
2016-09-08 3:34 GMT+08:00 Michael Niedermayer : > TODO: docs, version bump > > Signed-off-by: Michael Niedermayer > --- > libavformat/hlsenc.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/libavformat/hlsenc.c

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Pedro Arthur
Your patch was truncated before being applied [1], someone needs to revert and apply it properly. [1] - http://ffmpeg.org/pipermail/ffmpeg-devel/2016-September/199079.html ​ ___

Re: [FFmpeg-devel] [PATCH] Fix potential integer overflow in mov_read_keys

2016-09-07 Thread Sergey Volk
I just realized that count+1 itself might overflow if count==UINT_MAX, so I guess it's better to subtract 1 from the right-hand side. Attached updated patch. On Wed, Sep 7, 2016 at 2:21 PM, Sergey Volk wrote: > Actual allocation size is computed as (count +

[FFmpeg-devel] [PATCH] Fix potential integer overflow in mov_read_keys

2016-09-07 Thread Sergey Volk
Actual allocation size is computed as (count + 1)*sizeof(meta_keys), so we need to check that (count + 1) won't cause overflow. From cfc0f5a099284c95476d5c020dca05fb743ff5ae Mon Sep 17 00:00:00 2001 From: Sergey Volk Date: Wed, 7 Sep 2016 14:05:35 -0700 Subject: [PATCH] Fix

Re: [FFmpeg-devel] [RFC] marking non developer tickets

2016-09-07 Thread Josh de Kock
On 07/09/2016 18:48, Lou Logan wrote: If you want to use "task" for this then that would be fine with me. Alternatively, a wiki page could be setup similar to: Are all these on the trac? It might be worth adding a 'small' keyword

Re: [FFmpeg-devel] [RFC] marking non developer tickets

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 09:43:26PM +0200, Michael Niedermayer wrote: > On Wed, Sep 07, 2016 at 09:48:55AM -0800, Lou Logan wrote: > > On Wed, 7 Sep 2016 13:31:37 +0200, Michael Niedermayer wrote: > > > > > Hi > > > > > > Most of the tickets on trac are about ffmpeg code. I belive this makes > >

Re: [FFmpeg-devel] [RFC] marking non developer tickets

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 09:48:55AM -0800, Lou Logan wrote: > On Wed, 7 Sep 2016 13:31:37 +0200, Michael Niedermayer wrote: > > > Hi > > > > Most of the tickets on trac are about ffmpeg code. I belive this makes > > it hard for non developers to find things to contribute to, yet at the > > same

[FFmpeg-devel] [PATCH] avformat/hlsenc: implement program_date_time

2016-09-07 Thread Michael Niedermayer
TODO: docs, version bump Signed-off-by: Michael Niedermayer --- libavformat/hlsenc.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index c0b5ef2..a376312 100644 --- a/libavformat/hlsenc.c +++

Re: [FFmpeg-devel] [PATCH 2/2] lavc/mediacodecdec_h264: use h264_parse.h instead of h264dec.h

2016-09-07 Thread Matthieu Bouron
On Wed, Sep 07, 2016 at 08:19:15PM +0200, Thomas Volkert wrote: > > On 07.09.2016 15:38, Matthieu Bouron wrote: > > On Mon, Sep 05, 2016 at 03:57:54PM +0200, Matthieu Bouron wrote: > > > From: Matthieu Bouron > > > > > > ff_h264_decode_extradata is referenced by

Re: [FFmpeg-devel] [PATCH 2/2] lavc/mediacodecdec_h264: use h264_parse.h instead of h264dec.h

2016-09-07 Thread Elijah Tully
sounds good thanks On Wed, Sep 7, 2016 at 2:19 PM, Thomas Volkert wrote: > > On 07.09.2016 15:38, Matthieu Bouron wrote: > >> On Mon, Sep 05, 2016 at 03:57:54PM +0200, Matthieu Bouron wrote: >> >>> From: Matthieu Bouron >>> >>>

[FFmpeg-devel] requested feature

2016-09-07 Thread Elijah Tully
Hello just wondering if you guys would mind adding the ability to encode to gamecube adp format soon. thanks in advance for any help :) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] lavc/mediacodecdec_h264: use h264_parse.h instead of h264dec.h

2016-09-07 Thread Thomas Volkert
On 07.09.2016 15:38, Matthieu Bouron wrote: On Mon, Sep 05, 2016 at 03:57:54PM +0200, Matthieu Bouron wrote: From: Matthieu Bouron ff_h264_decode_extradata is referenced by h264_parse.h and not h264dec.h. --- libavcodec/mediacodecdec_h264.c | 2 +- 1 file

[FFmpeg-devel] Possible incomplete commit "avcodec/nvenc: support RGB input"

2016-09-07 Thread Zoran Turalija
Today, new commit landed in git [1], but third part of submitted patch is missing in that commit. Same part is missing in patchwork [2], too. Maybe committer redacted patch, and threw out unneeded third part. It looks like patchwork was unable to recognize handmade patch sent to ML. Patch author

[FFmpeg-devel] ffmpeg-memory leak

2016-09-07 Thread lium...@fsmeeting.com
hello,Maybe I find a bug about the memory leak,I try to use the function“avformat_open_input”to open the file, after that,I use the function “avformat_close_input”,My memroy will increase several hundred KB,even several MB, if My media file's resolution is bigger, the memory leak will be

Re: [FFmpeg-devel] [RFC] marking non developer tickets

2016-09-07 Thread Lou Logan
On Wed, 7 Sep 2016 13:31:37 +0200, Michael Niedermayer wrote: > Hi > > Most of the tickets on trac are about ffmpeg code. I belive this makes > it hard for non developers to find things to contribute to, yet at the > same time there are quite a few non devel tasks that need to be done > and that

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]ffmpeg_opt: Suggest to use "file:..." if a protocol was not found

2016-09-07 Thread Carl Eugen Hoyos
2016-09-06 12:57 GMT+02:00 Michael Niedermayer : >> Subject: [PATCH] ffmpeg_opt: Suggest to use "file:..." if a >> protocol was not found. >> >> Fixes Debian bug 785690. >> --- >> ffmpeg_opt.c |2 ++ >> 1 file changed, 2 insertions(+) > > LGTM > > please give others a

Re: [FFmpeg-devel] [PATCH 1/2] tests/fate:Add FATE for hls_flags append option

2016-09-07 Thread Steven Liu
2016-09-08 0:41 GMT+08:00 Michael Niedermayer : > On Wed, Sep 07, 2016 at 11:10:48PM +0800, Steven Liu wrote: > > 2016-08-30 2:07 GMT+08:00 Michael Niedermayer : > > > > > On Mon, Aug 29, 2016 at 11:17:25PM +0800, Steven Liu wrote: > > > >

Re: [FFmpeg-devel] [PATCH]lavc/avcodec: Improve av_parser_parse() documentation

2016-09-07 Thread Carl Eugen Hoyos
2016-09-04 22:41 GMT+02:00 Michael Niedermayer : >> Fixes ticket #5809. >> --- >> libavcodec/avcodec.h |5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) > > LGTM, but please wait a day or 2 to allow others to comment Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/2] tests/fate:Add FATE for hls_flags append option

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 11:10:48PM +0800, Steven Liu wrote: > 2016-08-30 2:07 GMT+08:00 Michael Niedermayer : > > > On Mon, Aug 29, 2016 at 11:17:25PM +0800, Steven Liu wrote: > > > 2016-08-29 22:18 GMT+08:00 Michael Niedermayer : > > > > > > > On

Re: [FFmpeg-devel] [PATCH 2/5] af_hdcd: hdcd_analyze_gen() using int instead of float

2016-09-07 Thread Burt P.
applied as is for now. Thanks for the comment. I will look into a faster way of doing it. I only needed to change from the float version because it was giving different results for i686 than for amd64. I don't know why, exactly, but I do know that this version gives bit-perfect results

Re: [FFmpeg-devel] [PATCH 1/5] af_hdcd: some types renamed to remove _t

2016-09-07 Thread Burt P.
applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/5] af_hdcd: fix possible integer overflow

2016-09-07 Thread Burt P.
applied with fix: uint64_t sustain_reset = (uint64_t)cdt_ms * rate / 1000; Thank you, Michael. -- Burt On Tue, Sep 6, 2016 at 5:00 PM, Michael Niedermayer wrote: > On Mon, Sep 05, 2016 at 06:18:43AM -0500, Burt P wrote: >> Signed-off-by: Burt P

Re: [FFmpeg-devel] [PATCH 4/5] af_hdcd: move decoding setup from init to config_input

2016-09-07 Thread Burt P.
applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 5/5] af_hdcd: tweak hdcd_analyze_prepare() a bit

2016-09-07 Thread Burt P.
applied On Mon, Sep 5, 2016 at 6:18 AM, Burt P wrote: > * use the actual sample rate > * use a more sensible frequency for the tone > * update fate test result > > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 9 ++--- >

Re: [FFmpeg-devel] [PATCH 1/2] tests/fate:Add FATE for hls_flags append option

2016-09-07 Thread Steven Liu
2016-08-30 2:07 GMT+08:00 Michael Niedermayer : > On Mon, Aug 29, 2016 at 11:17:25PM +0800, Steven Liu wrote: > > 2016-08-29 22:18 GMT+08:00 Michael Niedermayer : > > > > > On Mon, Aug 29, 2016 at 07:52:23PM +0800, Steven Liu wrote: > > > >

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 04:44:54PM +0200, Michael Niedermayer wrote: > On Wed, Sep 07, 2016 at 04:39:54PM +0200, Michael Niedermayer wrote: > > On Wed, Sep 07, 2016 at 07:19:00AM -0700, Jonathan Campbell wrote: > > > On 09/07/2016 04:51 AM, Michael Niedermayer wrote: > > > > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 02:27:07PM +0200, Michael Niedermayer wrote: > On Wed, Sep 07, 2016 at 08:03:20AM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Sep 7, 2016 at 7:51 AM, Michael Niedermayer > > wrote: > > > > > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 2/2] lavc: add hevc mediacodec decoder

2016-09-07 Thread Matthieu Bouron
From: Matthieu Bouron --- configure | 3 + libavcodec/Makefile| 3 +- libavcodec/allcodecs.c | 2 + libavcodec/hevc_parse.c| 134

[FFmpeg-devel] [PATCH 1/2] lavc/hevc: store VPS/SPS/PPS data

2016-09-07 Thread Matthieu Bouron
From: Matthieu Bouron --- libavcodec/hevc.h| 9 + libavcodec/hevc_ps.c | 27 +++ 2 files changed, 36 insertions(+) diff --git a/libavcodec/hevc.h b/libavcodec/hevc.h index be91010..6a3c750 100644 --- a/libavcodec/hevc.h +++

[FFmpeg-devel] lavc/mediacodec: add hevc decoder

2016-09-07 Thread Matthieu Bouron
Hello, The following patchset add support for hevc mediacodec decoding. The patchset applies on top of: * lavc/mediacodecdec_h264: move bsf variable declaration at the top of the function * lavc/mediacodecdec_h264: use h264_parse.h instead of h264dec.h which are going to be pushed in one

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 04:39:54PM +0200, Michael Niedermayer wrote: > On Wed, Sep 07, 2016 at 07:19:00AM -0700, Jonathan Campbell wrote: > > On 09/07/2016 04:51 AM, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > > --- > > > doc/developer.texi | 6

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 07:19:00AM -0700, Jonathan Campbell wrote: > On 09/07/2016 04:51 AM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > doc/developer.texi | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Jonathan Campbell
On 09/07/2016 04:51 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 4d3a7ae..51e3da7 100644 > ---

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Sven C. Dack
On 07/09/16 15:01, Sven C. Dack wrote: On 07/09/16 14:33, Timo Rothenpieler wrote: 0RGB/0BGR does not mean the alpha bits are zeroed. It means they are undefined, so you convert from ARGB to 0RGB by doing nothing. There is no performance to gain by supporting a format that falsely advertises

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Sven C. Dack
On 07/09/16 14:33, Timo Rothenpieler wrote: 0RGB/0BGR does not mean the alpha bits are zeroed. It means they are undefined, so you convert from ARGB to 0RGB by doing nothing. There is no performance to gain by supporting a format that falsely advertises support for an alpha channel. Also, the

Re: [FFmpeg-devel] [PATCH 2/2] lavc/mediacodecdec_h264: use h264_parse.h instead of h264dec.h

2016-09-07 Thread Matthieu Bouron
On Mon, Sep 05, 2016 at 03:57:54PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > ff_h264_decode_extradata is referenced by h264_parse.h and not > h264dec.h. > --- > libavcodec/mediacodecdec_h264.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec_h264: fix SODB escaping

2016-09-07 Thread Matthieu Bouron
On Wed, Sep 07, 2016 at 02:50:18PM +0200, Benoit Fouet wrote: > Hi, > > > On 06/09/2016 16:53, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > > Fixes escaping of consecutive 0x00, 0x00, 0x0{0-3} sequences. > > --- > > libavcodec/mediacodecdec_h264.c | 6

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Timo Rothenpieler
Am 07.09.2016 um 15:26 schrieb Sven C. Dack: > On 07/09/16 12:40, Timo Rothenpieler wrote: >> libavutil/pixfmt.h defines AV_PIX_FMT_RGB0 and the other ones like this: >> >> packed RGB 8:8:8, 32bpp, XRGBXRGB... X=unused/undefined >> >> So I would expect the Alpha-Channel to be anything, and

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Sven C. Dack
On 07/09/16 12:40, Timo Rothenpieler wrote: libavutil/pixfmt.h defines AV_PIX_FMT_RGB0 and the other ones like this: packed RGB 8:8:8, 32bpp, XRGBXRGB... X=unused/undefined So I would expect the Alpha-Channel to be anything, and converting from RGBA to RGB0 to be a no-op "conversion". It

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec_h264: fix SODB escaping

2016-09-07 Thread Benoit Fouet
Hi, On 06/09/2016 16:53, Matthieu Bouron wrote: From: Matthieu Bouron Fixes escaping of consecutive 0x00, 0x00, 0x0{0-3} sequences. --- libavcodec/mediacodecdec_h264.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Michael Niedermayer
On Wed, Sep 07, 2016 at 08:03:20AM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Sep 7, 2016 at 7:51 AM, Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > doc/developer.texi | 6 ++ > > 1 file changed, 6

Re: [FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Ronald S. Bultje
Hi, On Wed, Sep 7, 2016 at 7:51 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index

[FFmpeg-devel] [PATCH] doc/developer: Add patchwork mentioning to "patch submission checklist"

2016-09-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/developer.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 4d3a7ae..51e3da7 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -641,6 +641,12 @@ are notoriously

Re: [FFmpeg-devel] [PATCH] avformat/mov: Enable stream parsing for VP9.

2016-09-07 Thread Ronald S. Bultje
Hi, On Tue, Sep 6, 2016 at 10:39 PM, Matthew Gregan wrote: > At 2016-09-06T22:18:18-0400, Ronald S. Bultje wrote: > > I think the patch is fine, but I wonder if it should set it to _FULL (the > > parser ignores the option, but it is semantically more correct). > > Good point,

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Sven C. Dack
On 07/09/16 12:27, Carl Eugen Hoyos wrote: If your patch adds "RGBA" as supported colour space, the encoder (by definition) announces that it supports transparency. nvenc does not support transparency (if it would, it would be a - grave - bug to use "RGB0" in the patch). So please do not add it.

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Timo Rothenpieler
Am 07.09.2016 um 13:27 schrieb Carl Eugen Hoyos: > 2016-09-07 12:50 GMT+02:00 Sven C. Dack : >> On 07/09/16 11:25, Carl Eugen Hoyos wrote: >>> Am 07.09.2016 um 11:40 schrieb "Sven C. Dack" : On 07/09/16 09:23, Timo Rothenpieler wrote:

[FFmpeg-devel] [RFC] marking non developer tickets

2016-09-07 Thread Michael Niedermayer
Hi Most of the tickets on trac are about ffmpeg code. I belive this makes it hard for non developers to find things to contribute to, yet at the same time there are quite a few non devel tasks that need to be done and that arent done ... Can type = task be used for non devel tasks or should a

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Carl Eugen Hoyos
2016-09-07 12:50 GMT+02:00 Sven C. Dack : > On 07/09/16 11:25, Carl Eugen Hoyos wrote: >> >>> Am 07.09.2016 um 11:40 schrieb "Sven C. Dack" : >>> >>> On 07/09/16 09:23, Timo Rothenpieler wrote: >>> Otherwise will RGBA/BGRA have to >>> be converted into

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Sven C. Dack
On 07/09/16 11:25, Carl Eugen Hoyos wrote: Hi! Am 07.09.2016 um 11:40 schrieb "Sven C. Dack" : On 07/09/16 09:23, Timo Rothenpieler wrote: Otherwise will RGBA/BGRA have to be converted into RGB0/BGR0 and you will again get a performance penalty. What makes you think so?

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Carl Eugen Hoyos
Hi! > Am 07.09.2016 um 11:40 schrieb "Sven C. Dack" : > > On 07/09/16 09:23, Timo Rothenpieler wrote: > Otherwise will RGBA/BGRA have to > be converted into RGB0/BGR0 > and you will again get a performance penalty. What makes you think so? (The problem is that your

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Carl Eugen Hoyos
Hi! > Am 07.09.2016 um 11:36 schrieb Paul B Mahol : > >> On 9/7/16, Carl Eugen Hoyos wrote: >> Hi! >> >> 2016-09-07 2:23 GMT+02:00 Sven C. Dack : On 07/09/16 01:08, Sven C. Dack wrote: > On 07/09/16 00:43, Carl Eugen

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Timo Rothenpieler
>> Also, why is the twist from AV_PIX_FMT_RGBA to NV_ENC_BUFFER_FORMAT_ABGR >> necessary? >> >> The nvenc header describes it as "8 bit Packed A8B8G8R8", so did they >> mess it up? > > It is necessary in order to make it work. The twist here is intentional > as I pointed out earlier. If you do it

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Sven C. Dack
On 07/09/16 10:40, Sven C. Dack wrote: It is necessary in order to make it work. The twist here is intentional as I pointed out earlier. If you do it the other way around as described in the documentation then you get false and missing colours. I'd like to keep in the transparency channel

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Sven C. Dack
On 07/09/16 09:23, Timo Rothenpieler wrote: avctx->width << 1, avctx->height); +} else if (frame->format == AV_PIX_FMT_RGBA || frame->format == AV_PIX_FMT_RGB0) { + av_image_copy_plane(buf, lockBufferParams->pitch, + frame->data[0], frame->linesize[0], +

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Paul B Mahol
On 9/7/16, Carl Eugen Hoyos wrote: > Hi! > > 2016-09-07 2:23 GMT+02:00 Sven C. Dack : >> On 07/09/16 01:08, Sven C. Dack wrote: >>> >>> On 07/09/16 00:43, Carl Eugen Hoyos wrote: Should be AV_PIX_FMT_RGB0... > > As pointed out by Timo, this

Re: [FFmpeg-devel] [PATCH] ffmpeg: drop format specific stream copy heuristics

2016-09-07 Thread Michael Niedermayer
On Tue, Sep 06, 2016 at 06:26:59PM +0200, Michael Niedermayer wrote: > On Tue, Sep 06, 2016 at 05:45:46PM +0200, Hendrik Leppkes wrote: > > On Tue, Sep 6, 2016 at 5:10 PM, Michael Niedermayer > > wrote: > > > On Tue, Sep 06, 2016 at 02:39:11PM +0200, Hendrik Leppkes wrote:

Re: [FFmpeg-devel] adding RGBA and BGRA to nvenc.c

2016-09-07 Thread Timo Rothenpieler
> avctx->width << 1, avctx->height); > +} else if (frame->format == AV_PIX_FMT_RGBA || frame->format == > AV_PIX_FMT_RGB0) { > + av_image_copy_plane(buf, lockBufferParams->pitch, > + frame->data[0], frame->linesize[0], > + avctx->width << 2,

Re: [FFmpeg-devel] [PATCH v2 04/18] avformat/movenc: deal with AVMEDIA_TYPE_DATA by using AV_CODEC_ID_META

2016-09-07 Thread Erkki Seppälä
On 09/06/2016 09:26 PM, Carl Eugen Hoyos wrote: 2016-09-06 15:07 GMT+02:00 Erkki Seppälä : Would it be even better to not copy the data tracks at all by default, so not set the .data_codec field for any format? This was my original question for which I do not