Re: [FFmpeg-devel] [PATCH] libavcodec/mmaldec.c: add interlaced_frame and format struct to AVFrame for deinterlacing]

On Sun, Aug 14, 2016 at 05:02:03PM +0200, Jens Ziller wrote: > Am Samstag, den 13.08.2016, 13:16 +0200 schrieb Jens Ziller: > > Am Freitag, den 12.08.2016, 17:12 +0200 schrieb Michael Niedermayer: > > > > > > On Sun, Jul 31, 2016 at 07:09:26PM +0200, Jens Ziller wrote: > > > > > > > > > > > >

Re: [FFmpeg-devel] [PATCH v5 5/5] avformat/tee: Use BSF list API

On 09/10/2016 10:48 AM, Nicolas George wrote: Le sextidi 16 fructidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : From: Jan Sebechlebsky Signed-off-by: Jan Sebechlebsky --- Changes since the last version of the patch: - added

Re: [FFmpeg-devel] [PATCH] lavc/ffjni: do not error out if the last non-mandatory field/method cannot be found

On Fri, Sep 09, 2016 at 04:40:00PM +0200, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > libavcodec/ffjni.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 21:41, Hendrik Leppkes wrote: We don't care because "caring" would severly limit the things we can change in the code. Your logic would be sound if the code hadn't been declared as deprecated. I do agree that for live code the users have to accept changes when it means there is a

Re: [FFmpeg-devel] [PATCH] avformat/mux: implement AVFMT_FLAG_SHORTEST

On Fri, Aug 12, 2016 at 09:51:19PM +0200, Clément Bœsch wrote: > On Fri, Aug 12, 2016 at 09:50:37PM +0200, Clément Bœsch wrote: > > On Fri, Aug 12, 2016 at 09:28:08PM +0200, Michael Niedermayer wrote: > > [...] > > > if (s->internal->nb_interleaved_streams == stream_count) > > > -

[FFmpeg-devel] [PATCH v6 1/3] lavd: Add SDL2 output device

Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- configure| 28 +++- libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 373 +++ 4 files changed, 402

Re: [FFmpeg-devel] [PATCH v4 1/3] lavd: Add SDL2 output device

On Sun, Sep 11, 2016 at 21:46:58 +0100, Josh de Kock wrote: > +{ "window_fullscreen", "set SDL window fullscreen", > OFFSET(window_fullscreen), AV_OPT_TYPE_BOOL, { .i64 = 0 }, INT_MIN, INT_MAX, > AV_OPT_FLAG_ENCODING_PARAM }, > +{ "window_borderless", "set SDL window border off", >

Re: [FFmpeg-devel] [PATCH v4 1/3] lavd: Add SDL2 output device

On 9/11/2016 4:46 PM, Josh de Kock wrote: -if ! disabled sdl; then +if ! disabled sdl && ! enabled sdl2; then SDL_CONFIG="${cross_prefix}sdl-config" if check_pkg_config sdl SDL_events.h SDL_PollEvent; then check_cpp_condition SDL.h "(SDL_MAJOR_VERSION<<16 |

[FFmpeg-devel] [PATCH v5 1/3] lavd: Add SDL2 output device

Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- configure| 25 +++- libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 373 +++ 4 files changed, 399

Re: [FFmpeg-devel] [PATCH v4 1/3] lavd: Add SDL2 output device

On 9/11/16, Josh de Kock wrote: > Integrated comments from Moritz Barsnick. > > Acked-by: Michael Niedermayer > Signed-off-by: Josh de Kock > --- > configure| 25 +++- > libavdevice/Makefile | 1 + > libavdevice/alldevices.c | 1 + >

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On Sun, Sep 11, 2016 at 7:52 PM, Sven C. Dack wrote: > On 11/09/16 18:27, Clément Bœsch wrote: >> >> Aside from the stdout output in ffprobe, no stdout/stderr output is >> standardized in FFmpeg and thus can be changed at will (and does >> regularly). You can try to parse it,

[FFmpeg-devel] [PATCH v4 1/3] lavd: Add SDL2 output device

Integrated comments from Moritz Barsnick. Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- configure| 25 +++- libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 373

Re: [FFmpeg-devel] Evolution of lavfi's design and API

On 9/10/16, Nicolas George wrote: > Le quartidi 24 fructidor, an CCXXIV, Paul B Mahol a ecrit : >> So everybody agrees, we should proceed. > > I am proceeding, but as you can see in the patch, there is still a fair > amount of work to be done. Still, people can help if they want

[FFmpeg-devel] Strategy to optimally playback audio & video

Hi all, My app needs best performance video playback in high resolutions. I have a graphic engine polling the video frames and an audio engine polling decoded audio packets. The problem is, sometimes, the audio thread needs data that are not ready, so it decodes all packets until it got the

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 19:45, Nicolas George wrote: Please stop about ffserver. This branch of the discussion is not about ffserver, it is about you not understanding 40+ years of good software design, namely the separation between normalized reliable output on stdout and human-readable diagnosis output on

Re: [FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

On 11/09/2016 20:00, Moritz Barsnick wrote: Nice, seeing how often this has been pitched in the past. On Sun, Sep 11, 2016 at 16:38:12 +0100, Josh de Kock wrote: This actually seems to work now, it didn't in the past, so maybe SDL2 was patched or something changed in FFmpeg. Interesting...

Re: [FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

Nice, seeing how often this has been pitched in the past. On Sun, Sep 11, 2016 at 16:38:12 +0100, Josh de Kock wrote: > This actually seems to work now, it didn't in the past, so maybe SDL2 > was patched or something changed in FFmpeg. Interesting... > + * Copyright (c) 2011 Stefano Sabatini

Re: [FFmpeg-devel] [PATCH v3 1/3] lavd: Add SDL2 output device

On 9/11/16, Josh de Kock wrote: > Acked-by: Michael Niedermayer > Signed-off-by: Josh de Kock > --- > configure| 23 +++ > libavdevice/Makefile | 1 + > libavdevice/alldevices.c | 1 + > libavdevice/sdl2.c | 373 >

[FFmpeg-devel] [PATCH v3 3/3] lavd: deprecate opengl outdev

This device depends on SDL which is deprecated. Signed-off-by: Josh de Kock --- Changelog| 2 +- doc/outdevs.texi | 2 ++ libavdevice/opengl_enc.c | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index

[FFmpeg-devel] [PATCH v3 2/3] lavd: deprecate SDL device

SDL1 has been unmaintained for quite a while (version 1.2.15 was released 4 years ago). Due to how SDL2 works (it requires the main thread), there won't be able to be a replacement to the SDL avdevice if FFmpeg were to switch to SDL2 in the future. This commit would also help in getting ffplay to

[FFmpeg-devel] [PATCH v3 1/3] lavd: Add SDL2 output device

Acked-by: Michael Niedermayer Signed-off-by: Josh de Kock --- configure| 23 +++ libavdevice/Makefile | 1 + libavdevice/alldevices.c | 1 + libavdevice/sdl2.c | 373 +++ 4 files changed, 398

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 18:57, Clément Bœsch wrote: I think we disagree, because no user of a working setup will ever read the documentation just to check for deprecated tools. Having the warning at runtime is the most efficient way to reach out a maximum of users as soon as possible so they have time to

Re: [FFmpeg-devel] [PATCH] Select cubic and lanczos as alternative where super-sampling is not supported

On Sun, Sep 11, 2016 at 19:04:39 +0100, Sven C. Dack wrote: > the second body if it entered the first, because the value is part of both > the > conditions. D'uh, I missed that part. (It wasn't obvious enough to me. ;-)) > I thought about some neat logic at first, but decided to do it this >

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

Le sextidi 26 fructidor, an CCXXIV, Sven C. Dack a écrit : > Did you at least read the second part of my mail? Because I sure do get you > don't care. It's all you, Nicolas and Hendrik have been saying here really. Not really. >

Re: [FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

On Sun, Sep 11, 2016 at 07:05:38PM +0100, Josh de Kock wrote: > On 11/09/2016 19:04, Clément Bœsch wrote: > > On Sun, Sep 11, 2016 at 08:02:12PM +0200, Michael Niedermayer wrote: > > > On Sun, Sep 11, 2016 at 04:38:12PM +0100, Josh de Kock wrote: > > > > This actually seems to work now, it didn't

Re: [FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

On 11/09/2016 19:04, Clément Bœsch wrote: On Sun, Sep 11, 2016 at 08:02:12PM +0200, Michael Niedermayer wrote: On Sun, Sep 11, 2016 at 04:38:12PM +0100, Josh de Kock wrote: This actually seems to work now, it didn't in the past, so maybe SDL2 was patched or something changed in FFmpeg. I will

Re: [FFmpeg-devel] [PATCH] Select cubic and lanczos as alternative where super-sampling is not supported

On 11/09/16 18:55, Moritz Barsnick wrote: Moin Sven, On Fri, Sep 09, 2016 at 11:13:55 +0100, Sven C. Dack wrote: I may be missing something, but my excuse is that I can't test, but just inspect by looking at it: + if (s->interp_algo == NPPI_INTER_SUPER && + (out_width >

Re: [FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

On Sun, Sep 11, 2016 at 08:02:12PM +0200, Michael Niedermayer wrote: > On Sun, Sep 11, 2016 at 04:38:12PM +0100, Josh de Kock wrote: > > This actually seems to work now, it didn't in the past, so maybe SDL2 > > was patched or something changed in FFmpeg. > > > > I will make an avfilter of this as

Re: [FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

On Sun, Sep 11, 2016 at 04:38:12PM +0100, Josh de Kock wrote: > This actually seems to work now, it didn't in the past, so maybe SDL2 > was patched or something changed in FFmpeg. > > I will make an avfilter of this as well as the outdev. > > Signed-off-by: Josh de Kock > ---

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On Sun, Sep 11, 2016 at 06:52:50PM +0100, Sven C. Dack wrote: > On 11/09/16 18:27, Clément Bœsch wrote: > > Aside from the stdout output in ffprobe, no stdout/stderr output is > > standardized in FFmpeg and thus can be changed at will (and does > > regularly). You can try to parse it, but there is

Re: [FFmpeg-devel] [PATCH] Select cubic and lanczos as alternative where super-sampling is not supported

Moin Sven, On Fri, Sep 09, 2016 at 11:13:55 +0100, Sven C. Dack wrote: I may be missing something, but my excuse is that I can't test, but just inspect by looking at it: > + if (s->interp_algo == NPPI_INTER_SUPER && > + (out_width > in_width && out_height > in_height)) { > +

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 18:27, Clément Bœsch wrote: Aside from the stdout output in ffprobe, no stdout/stderr output is standardized in FFmpeg and thus can be changed at will (and does regularly). You can try to parse it, but there is zero warranty that it will work the next day. Regards, Did you at

Re: [FFmpeg-devel] [PATCH] ffprobe: add -show_headers_first option

On date Saturday 2016-09-10 13:51:34 +0200, Nicolas George encoded: > Le tridi 23 fructidor, an CCXXIV, Stefano Sabatini a écrit : > > We have the -show_entries option, and we can extend it to consider > > order. The equivalent syntax will then be: > > > > ffprobe -show_entries

Re: [FFmpeg-devel] [PATCH v4] lavf : scale_vaapi : add denoise/sharpless support

On Fri, Sep 09, 2016 at 11:31:22 +0800, Jun Zhao wrote: > v4 : - fix sharpless typo(sharpless -> sharpness) [...] > Date: Tue, 30 Aug 2016 14:36:00 +0800 > Subject: [PATCH v4] lavf : scale_vaapi : add denoise/sharpless support. > > add denoise/sharpless support, used scope [-1, 100] as the input

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On Sun, Sep 11, 2016 at 06:17:01PM +0100, Sven C. Dack wrote: > On 11/09/16 16:31, Nicolas George wrote: > > I see how it can do that, but you refuse to understand that this part of the > > output is not meant to be parsed, unlike, for example, the output of > > ffprobe. > > Nonsense. All

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 16:31, Nicolas George wrote: I see how it can do that, but you refuse to understand that this part of the output is not meant to be parsed, unlike, for example, the output of ffprobe. Nonsense. All messages, regardless if send to stdout or stderr, can be parsed. There is no rule

[FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

This actually seems to work now, it didn't in the past, so maybe SDL2 was patched or something changed in FFmpeg. I will make an avfilter of this as well as the outdev. Signed-off-by: Josh de Kock --- configure| 24 ++- libavdevice/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On Sun, Sep 11, 2016 at 5:04 PM, Sven C. Dack wrote: > On 11/09/16 15:12, Nicolas George wrote: >> >> I do not care at all about ffserver, but the argument of parsing stderr to >> revuse a warning is completely void, period. >> >> Regards, > > > Please no foot stomping of

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

Le sextidi 26 fructidor, an CCXXIV, Sven C. Dack a écrit : > Please no foot stomping of opinions. When you cannot see how changing the > output can confuse scripts of users then that's ok I see how it can do that, but you refuse to understand that this part of the output is not meant to be

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 15:12, Nicolas George wrote: I do not care at all about ffserver, but the argument of parsing stderr to revuse a warning is completely void, period. Regards, Please no foot stomping of opinions. When you cannot see how changing the output can confuse scripts of users then that's

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

Le sextidi 26 fructidor, an CCXXIV, Sven C. Dack a écrit : > No, it's not bogus. Yes, it is. > It's what sometimes must be done. For example, just this > morning did I again have to pipe the output of ffprobe through "|&" because > it likes to print its findings to stderr and

Re: [FFmpeg-devel] [PATCH v3 2/2] lavd: deprecate opengl outdev

Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : > For achieving the same result as the SDL/opengl outdevs you can do something > like: > > ffmpeg -i t.mov -c:v ffv1 -c:a aac -f fifo -fifo_format mov -map 0:v > fifo.mov & mpv fifo.mov This is nowhere near the same functionality. >

Re: [FFmpeg-devel] [PATCH] avformat/segment: fix the duration error of use output_ts_offset

On Sun, Sep 11, 2016 at 08:10:12PM +0800, Steven Liu wrote: > 2016-09-11 18:22 GMT+08:00 Michael Niedermayer : > > > On Sat, Sep 10, 2016 at 06:47:38PM +0800, Steven Liu wrote: > > > 2016-09-10 13:55 GMT+08:00 Aman Gupta : > > > > > > > I confirmed your

Re: [FFmpeg-devel] [PATCH 01/11] lavf: add a flag to enable/disable automatic bitstream filtering

On Fri, Sep 09, 2016 at 11:37:15PM -0500, Rodger Combs wrote: > This is mostly useful for muxers that wrap other muxers, such as dashenc > and segment. The actual duplicated bitstream filtering is largely harmless, > but delaying the header can cause problems when the muxer intended the header >

Re: [FFmpeg-devel] [PATCH 1/3] lavf: add AV_DISPOSITION_TIMED_THUMBNAILS

On Fri, Sep 09, 2016 at 09:07:30PM -0500, Rodger Combs wrote: > --- > ffprobe.c | 1 + > libavformat/avformat.h | 12 +--- > tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- >

Re: [FFmpeg-devel] [PATCH] avformat/segment: fix the duration error of use output_ts_offset

2016-09-11 18:22 GMT+08:00 Michael Niedermayer : > On Sat, Sep 10, 2016 at 06:47:38PM +0800, Steven Liu wrote: > > 2016-09-10 13:55 GMT+08:00 Aman Gupta : > > > > > I confirmed your latest patch fixes the issue and is working as > expected > > > now. > > >

Re: [FFmpeg-devel] [PATCH v3 2/2] lavd: deprecate opengl outdev

On 11/09/2016 08:36, Nicolas George wrote: Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : This device depends on SDL which is deprecated. Are we in the business of deprecating things that do not have a replacement, now? Before deprecating the best video output device, making some

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mov: reindent

On Fri, Sep 09, 2016 at 09:07:32PM -0500, Rodger Combs wrote: > --- > libavformat/mov.c | 158 > +++--- > 1 file changed, 79 insertions(+), 79 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avformat/segment: fix the duration error of use output_ts_offset

On Sat, Sep 10, 2016 at 06:47:38PM +0800, Steven Liu wrote: > 2016-09-10 13:55 GMT+08:00 Aman Gupta : > > > I confirmed your latest patch fixes the issue and is working as expected > > now. > > > > Thank you! > > > > Aman > > > > On Sat, Sep 10, 2016 at 7:00 AM, Steven Liu

[FFmpeg-devel] [PATCH] avfilter/vf_w3fdif: add >8 but <16 bit support

Signed-off-by: Paul B Mahol --- libavfilter/vf_w3fdif.c | 134 --- libavfilter/w3fdif.h | 5 +- libavfilter/x86/vf_w3fdif_init.c | 9 +-- 3 files changed, 133 insertions(+), 15 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

Le sextidi 26 fructidor, an CCXXIV, Sven C. Dack a écrit : > Error messages go to stderr and one sometimes parses these to respond to an > error. This is bogus and should not be considered a reason for design decisions. If there are cases where this is actually necessary, then report them and

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 08:39, Nicolas George wrote: Le sextidi 26 fructidor, an CCXXIV, Sven C. Dack a écrit : This could interfere with users' current scripts for running ffserver and turn into "adding insult to injury" for the time it is still around. Deprecation messages go to stderr. If users'

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

Le sextidi 26 fructidor, an CCXXIV, Sven C. Dack a écrit : > This could interfere with users' current scripts for running ffserver and > turn into "adding insult to injury" for the time it is still around. Deprecation messages go to stderr. If users' scripts rely on the format of stderr, breaking

Re: [FFmpeg-devel] [PATCH v3 2/2] lavd: deprecate opengl outdev

Le sextidi 26 fructidor, an CCXXIV, Josh de Kock a écrit : > This device depends on SDL which is deprecated. Are we in the business of deprecating things that do not have a replacement, now? Before deprecating the best video output device, making some effort to port it to something more modern

Re: [FFmpeg-devel] [PATCH] configure: don't build ffserver unless explicitly enabled

On 11/09/16 02:07, Carl Eugen Hoyos wrote: Or actually: Don't you agree that a deprecation message printed by the program would make much more sense? Carl Eugen This could interfere with users' current scripts for running ffserver and turn into "adding insult to injury" for the time it is