Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF

2017-06-20 Thread Michael Niedermayer
On Fri, Jun 09, 2017 at 03:39:59PM +0200, Daniel Kučera wrote: > 2017-06-05 21:18 GMT+02:00 Daniel Kucera : > > Signed-off-by: Daniel Kucera > > --- > > libavformat/cache.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH] libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-06-20 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 10:34:34PM +0200, Daniel Kucera wrote: > transfer_func variable passed to retry_transfer_wrapper are > h->prot->url_read and h->prot->url_write functions. These need > to return EOF or other error properly. In case of returning >= 0, > url_read/url_write is retried until

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 08:18:20PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Jun 20, 2017 at 5:22 PM, Michael Niedermayer > wrote: > > > On Tue, Jun 20, 2017 at 08:47:33AM -0400, Ronald S. Bultje wrote: > > > This allows using non-simple (e.g. simplemmx) IDCT

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-20 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 08:24:55PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Jun 20, 2017 at 7:13 PM, Michael Niedermayer > wrote: > > > On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > > > Includes add/put functions > > > > > > Rounding

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-20 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 7:13 PM, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > > Includes add/put functions > > > > Rounding contributed by Ronald S. Bultje > > --- > > libavcodec/tests/x86/dct.c| 2 +

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 5:22 PM, Michael Niedermayer wrote: > On Tue, Jun 20, 2017 at 08:47:33AM -0400, Ronald S. Bultje wrote: > > This allows using non-simple (e.g. simplemmx) IDCT implementations. > > The result is not bitexact (which is why the fate test

Re: [FFmpeg-devel] [PATCH 1/5] build: Generalize yasm/nasm-related variable names

2017-06-20 Thread James Almer
On 6/20/2017 7:49 PM, James Almer wrote: > +--yasmexe) Locally changed to --yasmexe=*) > +warn "The ${opt} option is only provided for compatibility and > will be\n"\ > + "removed in the future. Use --x86asmexe instead." > +x86asmexe="$optval" > +

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-20 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > Includes add/put functions > > Rounding contributed by Ronald S. Bultje > --- > libavcodec/tests/x86/dct.c| 2 + > libavcodec/x86/idctdsp_init.c | 23 > libavcodec/x86/simple_idct.h

[FFmpeg-devel] [PATCH 5/5] build: Prefer NASM assembler over YASM

2017-06-20 Thread James Almer
From: Diego Biurrun NASM is more actively maintained and permits generating dependency information as a sideeffect of assembling, thus cutting build times in half. (Cherry-picked from libav commit 57b753b445e23363c997a8ec1c556e0b0f6e9da3) Signed-off-by: James Almer

[FFmpeg-devel] [PATCH 2/5] build: Allow generating dependencies as a side-effect of assembling

2017-06-20 Thread James Almer
From: Diego Biurrun (Cherry-picked from libav commit 3c0efbd03349ae68d3a25a08652a102e3fd4) Signed-off-by: James Almer --- configure | 8 ffbuild/common.mak | 10 +- 2 files changed, 13 insertions(+), 5 deletions(-) diff

[FFmpeg-devel] [PATCH 4/5] build: fix commandline selection of nasm

2017-06-20 Thread James Almer
"nasm --version" works on nasm since around version 2.11 and as such configure assumed it was yasm. Based on libav commit f54037da8af2f2aeb5e5633b48434211e6a97fe5 by Diego Biurrun. Signed-off-by: James Almer --- configure | 23 +-- 1 file changed, 17

[FFmpeg-devel] [PATCH 3/5] build: Explicitly set 32-bit/64-bit object formats for nasm/yasm

2017-06-20 Thread James Almer
From: Diego Biurrun Consistently use object format names with "32" suffix and set object format to "win64" on Windows x86_64, which fixes assembling with nasm. (Cherry-picked from libav commit 808ef43597b1e3d6e69a5b9abe2237c8ddb97b44) Signed-off-by: James Almer

[FFmpeg-devel] [PATCH 1/5] build: Generalize yasm/nasm-related variable names

2017-06-20 Thread James Almer
From: Diego Biurrun None of them are specific to the YASM assembler. (Cherry-picked from libav commit 39e208f4d4756367c7cd2d581847e0c1b8a429c1) Signed-off-by: James Almer --- Makefile| 2 +- configure

[FFmpeg-devel] [PATCH 0/5] assembler related build system merge from libav

2017-06-20 Thread James Almer
These are five commits from libav a bit away from out current merge point that are useful enough that i figured should be committed now. Diego Biurrun (4): build: Generalize yasm/nasm-related variable names build: Allow generating dependencies as a side-effect of assembling build:

Re: [FFmpeg-devel] [PATCH] Update decode_simple_internal() to get the side data correctly.

2017-06-20 Thread John Rummell
Using avci->last_pkt_props works. Chromium tests work, "make fate" passes. Updated patch: From 0fd3c5c9abd3cea943b12f65f219d479b5949e4b Mon Sep 17 00:00:00 2001 From: John Rummell Date: Wed, 14 Jun 2017 14:43:04 -0700 Subject: [PATCH] Update decode_simple_internal() to get

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Use intra_scantable in dct_unquantize_h263_intra_c()

2017-06-20 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 06:52:09PM +0200, James Darnley wrote: > On 2017-06-20 00:37, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mpegvideo.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 08:47:33AM -0400, Ronald S. Bultje wrote: > This allows using non-simple (e.g. simplemmx) IDCT implementations. > The result is not bitexact (which is why the fate test continues to > use -idct simple), but the PSNR between C/MMX goes from ~35 to ~90. > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Use intra_scantable in dct_unquantize_h263_intra_c()

2017-06-20 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 12:06:08AM +, Kieran Kunhya wrote: > On Tue, 20 Jun 2017, 00:38 Michael Niedermayer, > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mpegvideo.c | 2 +- > > 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCHv2 3/4] avformat: make flush_packets a tri-state and set it to -1 (auto) by default

2017-06-20 Thread Marton Balint
If flushing is not disabled, then mux.c will signal the end of the packets with an AVIO_DATA_MARKER_FLUSH_POINT, and aviobuf will be able to decide to flush or not based on the preferred minimum packet size set by the used protocol. Signed-off-by: Marton Balint ---

[FFmpeg-devel] [PATCHv2 2/4] avformat/aviobuf: add support for specifying minimum packet size and marking flush points

2017-06-20 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 13 - libavformat/aviobuf.c | 7 +++ libavformat/url.h | 1 + libavformat/version.h | 2 +- 5 files changed, 24 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] Update decode_simple_internal() to get the side data correctly.

2017-06-20 Thread James Almer
On 6/20/2017 5:09 PM, John Rummell wrote: > Using avci->last_pkt_props works. Chromium tests work, "make fate" > passes. Updated patch: > > From 0fd3c5c9abd3cea943b12f65f219d479b5949e4b Mon Sep 17 00:00:00 2001 > From: John Rummell > > Date:

Re: [FFmpeg-devel] [PATCH 2/2] aarch64: vp9 16bpp: Fix assembling with Xcode 6.2 and older

2017-06-20 Thread Matthieu Bouron
On Tue, Jun 20, 2017 at 10:09:05PM +0300, Martin Storsjö wrote: > From: Memphiz > > Properly use the b.eq form instead of the nonstandard form (which > both gas and newer clang accept though), and expand the register > lists that used a range (which the Xcode 6.2 clang, based

[FFmpeg-devel] [PATCH 1/2] aarch64: vp9: Fix assembling with Xcode 6.2 and older

2017-06-20 Thread Martin Storsjö
From: Memphiz Properly use the b.eq/b.ge forms instead of the nonstandard forms (which both gas and newer clang accept though), and expand the register list that used a range (which the Xcode 6.2 clang, based on clang 3.5 svn, didn't support). This is cherrypicked from libav

[FFmpeg-devel] [PATCH 2/2] aarch64: vp9 16bpp: Fix assembling with Xcode 6.2 and older

2017-06-20 Thread Martin Storsjö
From: Memphiz Properly use the b.eq form instead of the nonstandard form (which both gas and newer clang accept though), and expand the register lists that used a range (which the Xcode 6.2 clang, based on clang 3.5 svn, didn't support). ---

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-20 Thread Gyan
On Tue, Jun 20, 2017 at 11:29 PM, Paul B Mahol wrote: > On 12/24/16, Nicolas George wrote: > > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : > >> theres a change with "-af apad=pad_len=1 -shortest" (no -vframes) > >> the file is not

Re: [FFmpeg-devel] Requesting push access to FFmpeg repo

2017-06-20 Thread Kevin Mark
On Tue, Jun 20, 2017 at 7:14 AM, Michael Niedermayer wrote: > If you want push access, please send a patch that adds you to the > MAINTAINERs file > after the patch has been applied, you get push access > > (by going throgh this extra step changes to the git access list

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-06-20 Thread Paul B Mahol
On 12/24/16, Nicolas George wrote: > Le quartidi 4 nivose, an CCXXV, Michael Niedermayer a ecrit : >> theres a change with "-af apad=pad_len=1 -shortest" (no -vframes) >> the file is not sharable, this change undoes the effect of the >> non-recursive patch >> >> use of

Re: [FFmpeg-devel] configure/libopenjpegdec.c/libopenjpegenc.c: Add support for LibOpenJPEG v2.2/git

2017-06-20 Thread Michael Bradshaw
> From 70b53c1ea5a56a03cfef24d5b551b983ba2473b2 Mon Sep 17 00:00:00 2001 > From: Reino17 > Date: Wed, 14 Jun 2017 00:19:12 +0200 > Subject: [PATCH] Add support for LibOpenJPEG v2.2/git > > --- > configure | 4 +++- > libavcodec/libopenjpegdec.c | 10

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Use intra_scantable in dct_unquantize_h263_intra_c()

2017-06-20 Thread James Darnley
On 2017-06-20 00:37, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index 63a30b93ce..e29558b3a2

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-20 Thread James Darnley
On 2017-06-19 17:11, James Darnley wrote: > diff --git a/libavcodec/x86/simple_idct10_template.asm > b/libavcodec/x86/simple_idct10_template.asm > index 51baf84c82..02fd445ec0 100644 > --- a/libavcodec/x86/simple_idct10_template.asm > +++ b/libavcodec/x86/simple_idct10_template.asm > @@ -258,6

Re: [FFmpeg-devel] [PATCH 08/11] avcodec/x86: allow future 8-bit simple idct to use slightly different coefficients

2017-06-20 Thread James Darnley
On 2017-06-20 13:55, Ronald S. Bultje wrote: > Hi, > > On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > >> --- >> libavcodec/x86/proresdsp.asm | 18 ++ >> libavcodec/x86/simple_idct10.asm | 29 >> + >>

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread James Darnley
On 2017-06-20 18:16, Ronald S. Bultje wrote: > On Tue, Jun 20, 2017 at 12:04 PM, James Darnley wrote: >>> @@ -231,6 +230,13 @@ static av_cold int decode_init(AVCodecContext >> *avctx) >>> avctx->pix_fmt = AV_PIX_FMT_YUVJ420P; >>> avctx->color_range = AVCOL_RANGE_JPEG;

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Ronald S. Bultje
Hi, On Tue, Jun 20, 2017 at 12:04 PM, James Darnley wrote: > On 2017-06-20 14:47, Ronald S. Bultje wrote: > > This allows using non-simple (e.g. simplemmx) IDCT implementations. > > The result is not bitexact (which is why the fate test continues to > > use -idct simple), but

Re: [FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread James Darnley
On 2017-06-20 14:47, Ronald S. Bultje wrote: > This allows using non-simple (e.g. simplemmx) IDCT implementations. > The result is not bitexact (which is why the fate test continues to > use -idct simple), but the PSNR between C/MMX goes from ~35 to ~90. > --- > libavcodec/mdec.c | 14

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/x86: allow future 8-bit simple idct to have "DC only hack"

2017-06-20 Thread James Darnley
On 2017-06-20 13:56, Ronald S. Bultje wrote: > Hi, > > On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > >> Created by Ronald S. Bultje >> --- >> libavcodec/x86/simple_idct10_template.asm | 38 >> +++ >> 1 file changed, 38 insertions(+) >> >>

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

2017-06-20 Thread Paras Chadha
On Tue, Jun 20, 2017 at 2:44 PM, Paul B Mahol wrote: > On 6/19/17, Paras Chadha wrote: > > Added support for XTENSION keyword > > > > Signed-off-by: Paras Chadha > > --- > > Changelog | 1 + > >

[FFmpeg-devel] [PATCH] Add FITS Decoder

2017-06-20 Thread Paras Chadha
Above changes done. Also fixed an issue with BLANK keyword. Signed-off-by: Paras Chadha --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 +

Re: [FFmpeg-devel] Requesting push access to FFmpeg repo

2017-06-20 Thread James Almer
On 6/20/2017 8:36 AM, Hendrik Leppkes wrote: > On Tue, Jun 20, 2017 at 1:14 PM, Michael Niedermayer > wrote: >> On Tue, Jun 20, 2017 at 05:30:05AM +, Kevin Mark wrote: >>> Ronald Bultje via IRC recommended I ask on the mailing list for push access >>> to the FFmpeg

[FFmpeg-devel] [job] trim based on pic_timing SEI

2017-06-20 Thread David Holroyd
Hi there, I have been looking at using ffmpeg to trim and reencode some source content, and to use the clockTimestamp fields from the pic_timing SEI header as the basis of finding the correct start frame for the trimmed output. If I am correct in thinking this is not currently possible with

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 4:32 PM, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > > Includes add/put functions > > > > Rounding contributed by Ronald S. Bultje > > --- > > libavcodec/tests/x86/dct.c| 2 +

[FFmpeg-devel] [PATCH] mdec: use correctly permutated quant matrix for dequantization.

2017-06-20 Thread Ronald S. Bultje
This allows using non-simple (e.g. simplemmx) IDCT implementations. The result is not bitexact (which is why the fate test continues to use -idct simple), but the PSNR between C/MMX goes from ~35 to ~90. --- libavcodec/mdec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-)

Re: [FFmpeg-devel] [PATCH 03/11] avcodec/mdec: override IDCT choice before initing DSP structs

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 2:05 PM, Ronald S. Bultje wrote: > Hi, > > On Mon, Jun 19, 2017 at 11:10 AM, James Darnley wrote: > >> --- >> libavcodec/mdec.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/mdec.c

Re: [FFmpeg-devel] [PATCH 09/11] avcodec/x86: allow future 8-bit simple idct to have "DC only hack"

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > Created by Ronald S. Bultje > --- > libavcodec/x86/simple_idct10_template.asm | 38 > +++ > 1 file changed, 38 insertions(+) > > diff --git a/libavcodec/x86/simple_idct10_template.asm >

Re: [FFmpeg-devel] [PATCH 08/11] avcodec/x86: allow future 8-bit simple idct to use slightly different coefficients

2017-06-20 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > --- > libavcodec/x86/proresdsp.asm | 18 ++ > libavcodec/x86/simple_idct10.asm | 29 > + > libavcodec/x86/simple_idct10_template.asm | 19

Re: [FFmpeg-devel] [PATCH 07/11] avcodec/x86: modify simple_idct10 macros to add an action paramter

2017-06-20 Thread James Darnley
On 2017-06-19 20:31, Ronald S. Bultje wrote: > Hi, > > On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > >> --- >> libavcodec/x86/proresdsp.asm | 2 +- >> libavcodec/x86/simple_idct10.asm | 8 +++ >> libavcodec/x86/simple_idct10_template.asm

Re: [FFmpeg-devel] [PATCH 06/11] avcodec/x86: cleanup simple_idct10

2017-06-20 Thread James Darnley
On 2017-06-19 20:30, Ronald S. Bultje wrote: > Hi, > > On Mon, Jun 19, 2017 at 11:10 AM, James Darnley wrote: > >> Use named arguments for the functions so we can remove a define. The >> stride/linesize argument is now ptrdiff_t type so we no longer need to >> sign extend the

Re: [FFmpeg-devel] Requesting push access to FFmpeg repo

2017-06-20 Thread Hendrik Leppkes
On Tue, Jun 20, 2017 at 1:14 PM, Michael Niedermayer wrote: > On Tue, Jun 20, 2017 at 05:30:05AM +, Kevin Mark wrote: >> Ronald Bultje via IRC recommended I ask on the mailing list for push access >> to the FFmpeg repository so that I may push my own patches once

Re: [FFmpeg-devel] Requesting push access to FFmpeg repo

2017-06-20 Thread Michael Niedermayer
On Tue, Jun 20, 2017 at 05:30:05AM +, Kevin Mark wrote: > Ronald Bultje via IRC recommended I ask on the mailing list for push access > to the FFmpeg repository so that I may push my own patches once approved. > If someone with the access to do so could please consider this request it > would

Re: [FFmpeg-devel] [PATCH 02/11] avcodec/x86/mpegenc: support transpose permuation type

2017-06-20 Thread James Darnley
On 2017-06-19 18:30, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:10:55PM +0200, James Darnley wrote: >> --- >> libavcodec/x86/mpegvideoenc_template.c | 47 >> +- >> 1 file changed, 46 insertions(+), 1 deletion(-) > > LGTM > > thx You're welcome.

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/mpegenc: do not use unquantize shortcuts for wmv1

2017-06-20 Thread James Darnley
On 2017-06-20 00:08, Michael Niedermayer wrote: > On Mon, Jun 19, 2017 at 05:10:58PM +0200, James Darnley wrote: >> From: "Ronald S. Bultje" >> >> Commit message by James Darnley >> >> The shortcut is based on end-of-block positions. This leads to some >> coefficients not

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

2017-06-20 Thread Paul B Mahol
On 6/19/17, Paras Chadha wrote: > Added support for XTENSION keyword > > Signed-off-by: Paras Chadha > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 +

Re: [FFmpeg-devel] [PATCH] libavcodec/htmlsubtitles: skip newline characters at the beginning of the subtitle

2017-06-20 Thread wm4
On Fri, 16 Jun 2017 23:40:32 +0300 Evgeny Shulgin wrote: > > Anyway, I don't understand why this makes subtitle lines actually > > disappear? > > Because SubRip format does not allow to have empty lines, that is: > >1. Subtitle text itself on one or more lines >

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove misleading and incorrect error messages

2017-06-20 Thread wm4
On Sun, 18 Jun 2017 20:41:39 +0200 Paul B Mahol wrote: > On 6/15/17, wm4 wrote: > > Those are warnings, not error messages. Fixed locally. > > ___ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > >