Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-19 Thread Douglas Marsh
On 2017-10-19 20:08, Douglas Marsh wrote: Is that a commit (1e5ff78fec9b13eccac9a96acc358bbfd6a7015d) I should check out on my Decklink and try or is there another one I should try? Will try to get to testing it this weekend. Nevermind I found this: * commit

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-19 Thread Douglas Marsh
On 2017-10-18 12:23, Dave Rice wrote: [...] Updated. From 1e5ff78fec9b13eccac9a96acc358bbfd6a7015d Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Wed, 18 Oct 2017 15:21:46 -0400 Subject: [PATCH] libavdevice/decklink: 32 bit audio support Is that a commit

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Thierry Foucu
On Thu, Oct 19, 2017 at 3:43 PM, Michael Niedermayer wrote: > On Thu, Oct 19, 2017 at 09:51:05AM -0700, Thierry Foucu wrote: > > Instead of returning nothing when we detect the xvid skipped frame, we > > could return the last decoded frame, if we do have one. > >

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2017 at 09:51:05AM -0700, Thierry Foucu wrote: > Instead of returning nothing when we detect the xvid skipped frame, we > could return the last decoded frame, if we do have one. FRAME_SKIPPED is not limited to xvid (packed frames). There are a few other pathes that return it. For

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-19 Thread Carl Eugen Hoyos
2017-10-20 0:00 GMT+02:00 Bjorn Roche : > The palettes generated by palettegen include one transparent color. > This patch enables paletteuse to identify the transparency in incoming > video and tag transparent pixels on outgoing video. > > This requires tracking the transparency

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-19 Thread Carl Eugen Hoyos
2017-10-19 20:46 GMT+02:00 Nikolas Bowe : > Found via fuzzing. > /tmp/poc is a 1 MB mpegts file generated via fuzzing, where 1 packet has many > NALUs > Before this change: > $ /usr/bin/time -f "\t%M Max Resident Set Size (Kb)" ./ffprobe /tmp/poc > 2>&1 | tail

[FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-19 Thread Bjorn Roche
The palettes generated by palettegen include one transparent color. This patch enables paletteuse to identify the transparency in incoming video and tag transparent pixels on outgoing video. This requires tracking the transparency index in the palette, establishing an alpha threshold below which

Re: [FFmpeg-devel] [PATCH 1/4] lavf: add MP1 muxer

2017-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2017 at 02:39:45AM -0500, Rodger Combs wrote: > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/rawenc.c | 13 + > 3 files changed, 15 insertions(+) please add a fate test for this too [...] -- Michael GnuPG

Re: [FFmpeg-devel] [RFC] v4l2_m2m: Fix races around freeing data on close

2017-10-19 Thread Jorge Ramirez
On 10/19/2017 07:55 PM, Jorge Ramirez wrote: On 10/19/2017 11:49 AM, Mark Thompson wrote: On 19/10/17 08:28, Jorge Ramirez wrote: On 10/19/2017 02:10 AM, Mark Thompson wrote: Refcount all of the context information. --- As discussed in the other thread, something like this. We move most of

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-19 Thread Ronald S. Bultje
Hi, On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: > I tried decoding the file in both the cases and I don't see any > address related error in the console while decoding. Following is the > output after I apply the patch :- > [..] > Is there something which I'm

Re: [FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

2017-10-19 Thread Nicolas George
L'octidi 28 vendémiaire, an CCXXVI, Michael Niedermayer a écrit : > any reason why you dont apply it, if you think its correct ? Good question. Just did it. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-19 Thread Umair Khan
Hi Ronald, On Sun, Oct 15, 2017 at 12:21 AM, Ronald S. Bultje wrote: > Hi Umair, > > On Sat, Oct 14, 2017 at 1:43 PM, Umair Khan wrote: > >> On Sat, Oct 14, 2017 at 8:02 PM, Ronald S. Bultje >> wrote: >> > Hi Umair, >> > >> > On Sat,

Re: [FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

2017-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2017 at 04:22:33PM +0200, Nicolas George wrote: > Le sextidi 26 vendémiaire, an CCXXVI, Michael Niedermayer a écrit : > > Seems to work, no more comments from me > > I think this is correct too. any reason why you dont apply it, if you think its correct ? [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: fix access to priv_data after codec close.

2017-10-19 Thread Michael Niedermayer
On Thu, Oct 19, 2017 at 09:01:36AM +0200, Jorge Ramirez wrote: > On 10/18/2017 09:40 PM, Michael Niedermayer wrote: > >On Wed, Oct 18, 2017 at 09:46:40AM +0200, Jorge Ramirez wrote: > >>On 10/18/2017 12:34 AM, Mark Thompson wrote: > int ff_v4l2_m2m_codec_end(AVCodecContext *avctx) > {

[FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-19 Thread Nikolas Bowe
Found via fuzzing. /tmp/poc is a 1 MB mpegts file generated via fuzzing, where 1 packet has many NALUs Before this change: $ /usr/bin/time -f "\t%M Max Resident Set Size (Kb)" ./ffprobe /tmp/poc 2>&1 | tail -n 1 2158192 Max Resident Set Size (Kb) After this change: $ /usr/bin/time

Re: [FFmpeg-devel] [RFC] v4l2_m2m: Fix races around freeing data on close

2017-10-19 Thread Jorge Ramirez
On 10/19/2017 11:49 AM, Mark Thompson wrote: On 19/10/17 08:28, Jorge Ramirez wrote: On 10/19/2017 02:10 AM, Mark Thompson wrote: Refcount all of the context information. --- As discussed in the other thread, something like this. We move most of the context into a refcounted buffer and

[FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Thierry Foucu
Instead of returning nothing when we detect the xvid skipped frame, we could return the last decoded frame, if we do have one. --- libavcodec/h263dec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index

Re: [FFmpeg-devel] order T-shirts

2017-10-19 Thread Thilo Borgmann
Hi, > Some guys at the VDD asked for FFmpeg T-shirts. > I'd like to do a new T-shirt order. The shirts could be given to > multimedia devs who stop at one of our next booths. > > My idea is to order 25 shirts: > > 1*S > 5*M > 10*L > 7*XL > 2*XXL > > Last time we ordered 5 shirts and got a

Re: [FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

2017-10-19 Thread Nicolas George
Le sextidi 26 vendémiaire, an CCXXVI, Michael Niedermayer a écrit : > Seems to work, no more comments from me I think this is correct too. Thanks to Daniel for the efforts. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

2017-10-19 Thread Michael Bradshaw
On Thu, Oct 19, 2017 at 2:28 AM, Moritz Barsnick wrote: > On Wed, Oct 18, 2017 at 20:21:21 -0700, Michael Bradshaw wrote: > > I've added a note to the Changelog. Let me know if there are additional > > notices that should be made. > > It was remarked that pkg-config support was

Re: [FFmpeg-devel] [PATCH 2/7] nutdec: Fix repeated condition

2017-10-19 Thread Mark Thompson
On 19/10/17 00:45, Michael Niedermayer wrote: > On Tue, Oct 17, 2017 at 11:11:54PM +0100, Mark Thompson wrote: >> Fixes #6742. >> --- >> libavformat/nutdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > ok, also please backport this if this issue was in releases Sure. It was

Re: [FFmpeg-devel] [PATCH 7/9] hevc: Fix aligned array declarations

2017-10-19 Thread Mark Thompson
On 19/10/17 00:43, Michael Niedermayer wrote: > On Tue, Oct 17, 2017 at 10:12:23PM +0100, Mark Thompson wrote: >> (cherry picked from commit d41e10c1485ec34aa342f7bc2e5bf4f9b6e66414) >> --- >> This and the following patches were found with the TI ARM compiler. >> >> >> libavcodec/hevcdsp.c | 4

Re: [FFmpeg-devel] [RFC] v4l2_m2m: Fix races around freeing data on close

2017-10-19 Thread Mark Thompson
On 19/10/17 08:28, Jorge Ramirez wrote: > On 10/19/2017 02:10 AM, Mark Thompson wrote: >> Refcount all of the context information. >> --- >> As discussed in the other thread, something like this.  We move most of the >> context into a refcounted buffer and AVCodecContext.priv_data is left as a

Re: [FFmpeg-devel] [RFC] v4l2_m2m: Fix races around freeing data on close

2017-10-19 Thread Hendrik Leppkes
On Thu, Oct 19, 2017 at 9:28 AM, Jorge Ramirez wrote: > On 10/19/2017 02:10 AM, Mark Thompson wrote: >> >> Refcount all of the context information. >> --- >> As discussed in the other thread, something like this. We move most of >> the context into a refcounted

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

2017-10-19 Thread Moritz Barsnick
On Wed, Oct 18, 2017 at 20:21:21 -0700, Michael Bradshaw wrote: > I've added a note to the Changelog. Let me know if there are additional > notices that should be made. It was remarked that pkg-config support was introduced with *2.0.1*, not *2.1(.0)*. James's comment:

Re: [FFmpeg-devel] [RFC] v4l2_m2m: Fix races around freeing data on close

2017-10-19 Thread Jorge Ramirez
On 10/19/2017 02:10 AM, Mark Thompson wrote: Refcount all of the context information. --- As discussed in the other thread, something like this. We move most of the context into a refcounted buffer and AVCodecContext.priv_data is left as a stub holding a reference to it. Thoughts: * Change

Re: [FFmpeg-devel] [PATCH 4/4] lavf/movdec: request probing for an ambiguous codec tag

2017-10-19 Thread Jan Ekstrom
On Thu, Oct 19, 2017 at 10:39 AM, Rodger Combs wrote: > --- > libavformat/isom.c | 2 ++ > 1 file changed, 2 insertions(+) This change makes sense due to the ambiguousness of the container mapping. LGTM. Jan ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] lavf/utils: add MP2 to the probing list

2017-10-19 Thread Jan Ekstrom
On Thu, Oct 19, 2017 at 10:39 AM, Rodger Combs wrote: > --- Seems like a valid change to enable the following change of enabling probing in movdec for mp2/3 in ISOBMFF. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 2/4] lavf: identify MP1 and MP2 as distinct containers from MP3

2017-10-19 Thread Rodger Combs
This allows us to report the correct codec ID here --- libavformat/Makefile | 2 ++ libavformat/allformats.c | 4 +-- libavformat/mp3dec.c | 66 +++- libavformat/utils.c | 3 +-- libavformat/version.h| 4 +-- 5 files changed, 50

[FFmpeg-devel] [PATCH 4/4] lavf/movdec: request probing for an ambiguous codec tag

2017-10-19 Thread Rodger Combs
--- libavformat/isom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index 77983c5eaa..8b3f88ce74 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -519,6 +519,8 @@ FF_ENABLE_DEPRECATION_WARNINGS codec_id=

[FFmpeg-devel] [PATCH 1/4] lavf: add MP1 muxer

2017-10-19 Thread Rodger Combs
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 13 + 3 files changed, 15 insertions(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index d955a8b12a..2522a3e768 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile

[FFmpeg-devel] [PATCH 3/4] lavf/utils: add MP2 to the probing list

2017-10-19 Thread Rodger Combs
--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index a54687d239..416152eb39 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -329,6 +329,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,

Re: [FFmpeg-devel] [RFC] v4l2_m2m: Fix races around freeing data on close

2017-10-19 Thread Jorge Ramirez
On 10/19/2017 02:10 AM, Mark Thompson wrote: Refcount all of the context information. --- As discussed in the other thread, something like this. We move most of the context into a refcounted buffer and AVCodecContext.priv_data is left as a stub holding a reference to it. um, ok ... please

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: fix access to priv_data after codec close.

2017-10-19 Thread Jorge Ramirez
On 10/18/2017 09:40 PM, Michael Niedermayer wrote: On Wed, Oct 18, 2017 at 09:46:40AM +0200, Jorge Ramirez wrote: On 10/18/2017 12:34 AM, Mark Thompson wrote: int ff_v4l2_m2m_codec_end(AVCodecContext *avctx) { -V4L2m2mContext* s = avctx->priv_data; -int ret; +V4L2m2mContext