Re: [FFmpeg-devel] libavcodec/utvideodsp : add avx2 version

2017-11-20 Thread Martin Vignali
Hello, > > If noone reviews, and you tested it then it should be ok to > apply Ok will apply AVX2 for utvideodsp, huffyuv(enc)dsp and hapqa decoding (and fate) > especially considering you waited a month (which is longer than > needed generally) > > > > What is the recommanded time, to wait a

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2017-11-20 Thread Felix Matouschek
No more interest? Am 02.11.2017 13:42, schrieb Felix Matouschek: Hello, I've written an indev for Android devices to allow capturing their builtin cameras. What needs to be done to merge this? Greetings, Felix ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2 2/3] libavformat/http: Handled multiple_requests option during write

2017-11-20 Thread Jeyapal, Karthick
Please ignore the below patch, and use the updated patch attached. Forgot to reset the end_chunked_post variable in the below patch. Sorry for the inconvenience caused. Regards, Karthick On 11/21/17, 10:24 AM, "Karthick J" wrote: --- libavformat/http.c | 5 + 1 file

Re: [FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

2017-11-20 Thread Jeyapal, Karthick
>On 11/17/17, 4:31 PM, "Nicolas George" wrote: > >Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit : >> I have done the change as suggested. Please find the new patch attached. > >Sorry, but I still have doubts about it. > >To begin with, -1 is not an acceptable

[FFmpeg-devel] [PATCH v2 2/3] libavformat/http: Handled multiple_requests option during write

2017-11-20 Thread Karthick J
--- libavformat/http.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 056d5f6..45c0e72 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -171,6 +171,7 @@ static int http_connect(URLContext *h, const char *path, const char

[FFmpeg-devel] [PATCH v2 3/3] libavformat/hlsenc: Persistent HTTP connections supported as an option

2017-11-20 Thread Karthick J
--- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 48 +--- 2 files changed, 44 insertions(+), 7 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0bb8ad2..c1d753b 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -850,6

[FFmpeg-devel] [PATCH v2 1/3] libavformat/avio: Utility function to return URLContext

2017-11-20 Thread Karthick J
--- libavformat/avio_internal.h | 8 libavformat/aviobuf.c | 13 + 2 files changed, 21 insertions(+) diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h index c01835d..04c1ad5 100644 --- a/libavformat/avio_internal.h +++

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/mov.c| 50 tests/fate/mov.mak | 7 ++ tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ tests/ref/fate/mov-guess-delay-3 |

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Sasi Inguva
Reattaching Fate sample. On Tue, Nov 21, 2017 at 9:57 AM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c| 50 ++ > ++ > tests/fate/mov.mak | 7 ++ >

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Sasi Inguva
Ok. Just restricting this to H264 . On Tue, Nov 21, 2017 at 3:56 AM, Hendrik Leppkes wrote: > On Mon, Nov 20, 2017 at 11:06 PM, Michael Niedermayer > wrote: > > On Mon, Nov 20, 2017 at 09:58:05PM +0530, Sasi Inguva wrote: > >> On Sun, Nov 19, 2017

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-20 Thread Philip Langdale
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 20 Nov 2017 22:53:00 +0100 Michael Niedermayer wrote: > On Sun, Nov 19, 2017 at 11:52:28AM -0800, Philip Langdale wrote: > > This was predictably nightmarish, given how ridiculous mpeg4 is. > > I had to stare at the

Re: [FFmpeg-devel] [PATCH 07/13] lavc: Mark all AVHWAccel structures as const

2017-11-20 Thread Philip Langdale
On Sat, 18 Nov 2017 18:47:07 + Mark Thompson wrote: > --- > libavcodec/avcodec.h | 2 +- > libavcodec/decode.c | 2 +- > libavcodec/dxva2_h264.c | 6 +-- > libavcodec/dxva2_hevc.c | 6 +-- > libavcodec/dxva2_mpeg2.c | 6 +-- > libavcodec/dxva2_vc1.c|

Re: [FFmpeg-devel] [PATCH 06/13] lavc: Delete all fake hwaccels

2017-11-20 Thread Philip Langdale
On Sat, 18 Nov 2017 19:05:49 + Mark Thompson wrote: > On 18/11/17 18:47, Mark Thompson wrote: > > They are now unused. > > --- > > configure | 32 > > + libavcodec/mediacodec.c | > > 2 +-

Re: [FFmpeg-devel] [PATCH 05/13] lavc: Remove register mechanism for hwaccels

2017-11-20 Thread Philip Langdale
On Sat, 18 Nov 2017 18:47:05 + Mark Thompson wrote: > There is no longer any need for a list of them at runtime, because > decoders now carry the pointers to their associated hwaccels > internally. The file containing external declarations is now used to > make the list of

Re: [FFmpeg-devel] [PATCH 04/13] lavc: Deprecate av_hwaccel_next() and av_register_hwaccel()

2017-11-20 Thread Philip Langdale
On Sat, 18 Nov 2017 18:47:04 + Mark Thompson wrote: > --- > doc/APIchanges | 4 > libavcodec/avcodec.h | 13 + > libavcodec/utils.c | 16 +--- > libavcodec/version.h | 3 +++ > 4 files changed, 25 insertions(+), 11 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 03/13] lavc: Use hardware config information in ff_get_format()

2017-11-20 Thread Philip Langdale
On Sat, 18 Nov 2017 19:15:32 + Mark Thompson wrote: > On 18/11/17 18:47, Mark Thompson wrote: > > This removes the dependency that hardware pixel formats previously > > had on AVHWAccel instances, meaning only those which actually do > > something need exist after this patch.

Re: [FFmpeg-devel] [PATCH 1/3] lavu/qsv: remove unused variable

2017-11-20 Thread Li, Zhong
> On 20/11/17 09:14, Zhong Li wrote: > > suppres build warning of "variable 's' is declared but not used" > > > > Signed-off-by: Zhong Li > > --- > > libavutil/hwcontext_qsv.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libavutil/hwcontext_qsv.c

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 01:31:06PM -0800, Dale Curtis wrote: > On Mon, Nov 20, 2017 at 12:34 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Mon, Nov 20, 2017 at 12:01:11PM -0800, Dale Curtis wrote: > > > Derp, that's the wrong comment for this; I meant that for another

Re: [FFmpeg-devel] [ogg] Close ogg stream upon error when using AV_EF_EXPLODE.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 12:14:32PM -0800, Dale Curtis wrote: > Without this there can be multiple memory leaks with unknown ogg streams. > > - dale > oggdec.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > 1c3989df5e9a5ac43fb48f6cacaa20a6e25d87df fix_ogg_close_v1.patch > From

Re: [FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 12:05:02PM -0800, Jacob Trimble wrote: > Signed-off-by: Jacob Trimble > --- > libavformat/mov.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] ffmpeg: add return value check to suppress the build warning.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 05:07:04PM +0800, 刘歧 wrote: > > > 在 2017年11月20日,08:40,Jun Zhao 写道: > > > > > > <0001-ffmpeg-add-return-value-check-to-supress-the-build-w.patch>___ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Dale Curtis
On Mon, Nov 20, 2017 at 2:24 PM, Michael Niedermayer wrote: > > I think that could end with the correct result > > Thanks for the review. Done. - dale From fc7fb3511aa40810e64d9dacbd33d1e9336d0c52 Mon Sep 17 00:00:00 2001 From: Dale Curtis

[FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

2017-11-20 Thread James Zern
Corpus VBR mode is a variant of standard VBR where the complexity distribution midpoint is passed in rather than calculated for a specific clip or chunk. The valid range is [0, 1]. 0 (default) uses standard VBR. Signed-off-by: James Zern --- doc/encoders.texi | 5

Re: [FFmpeg-devel] [PATCH 1/2] hwcontext_vaapi: add support when driver return unimplemented.

2017-11-20 Thread Jun Zhao
On 2017/11/20 19:37, Mark Thompson wrote: > On 20/11/17 00:36, Jun Zhao wrote: >> From 5cbcd032de46e6a3f9563d1781776ea26728079d Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Sat, 18 Nov 2017 10:44:44 +0800 >> Subject: [PATCH 1/2] hwcontext_vaapi: add support when

Re: [FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern wrote: > Signed-off-by: James Zern > --- > libavcodec/libvpxdec.c | 25 - > 1 file changed, 25 deletions(-) > applied. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 4/4] libvpxenc: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern wrote: > Signed-off-by: James Zern > --- > libavcodec/libvpxenc.c | 25 +++-- > 1 file changed, 3 insertions(+), 22 deletions(-) > applied. ___

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern wrote: > Signed-off-by: James Zern > --- > libavcodec/libvpx.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > applied. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Mon, Nov 20, 2017 at 11:51 AM, James Almer wrote: > On 11/20/2017 4:38 PM, James Zern wrote: >> On Mon, Nov 20, 2017 at 11:17 AM, James Zern wrote: >>> On Sun, Nov 19, 2017 at 6:03 AM, James Almer wrote: On 11/17/2017 10:50 PM,

Re: [FFmpeg-devel] [PATCH] configure: fix module dependencies on zlib

2017-11-20 Thread James Almer
On 11/20/2017 4:25 PM, Michael Niedermayer wrote: > On Mon, Nov 20, 2017 at 02:58:58PM -0300, James Almer wrote: >> On 11/20/2017 2:34 PM, Michael Niedermayer wrote: >>> On Sun, Nov 19, 2017 at 04:00:11PM -0300, James Almer wrote: select should not be used with external libraries. It's mean

Re: [FFmpeg-devel] [PATCH 01/13] lavc: Add codec metadata to indicate hardware support

2017-11-20 Thread Mark Thompson
On 20/11/17 21:09, Philip Langdale wrote: > On 2017-11-18 10:47, Mark Thompson wrote: >> --- >>  doc/APIchanges   |  3 +++ >>  libavcodec/avcodec.h | 74 >> >>  libavcodec/hwaccel.h | 18 + >>  libavcodec/utils.c   | 12

Re: [FFmpeg-devel] [PATCH 1/2] avocdec/ttaenc: buffer packets directly

2017-11-20 Thread James Almer
On 11/20/2017 5:44 PM, James Almer wrote: > This is a bit more robust in case of OOM. > > Signed-off-by: James Almer Subject should be avformat, not avcodec. Fixed locally. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Hendrik Leppkes
On Mon, Nov 20, 2017 at 11:06 PM, Michael Niedermayer wrote: > On Mon, Nov 20, 2017 at 09:58:05PM +0530, Sasi Inguva wrote: >> On Sun, Nov 19, 2017 at 1:17 AM, Michael Niedermayer > > wrote: >> >> > On Sat, Nov 18, 2017 at 11:12:17AM -0800, Sasi

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 01:15:24PM -0800, Dale Curtis wrote: > On Mon, Nov 20, 2017 at 12:40 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Mon, Nov 20, 2017 at 12:05:05PM -0800, Dale Curtis wrote: > > > On Sat, Nov 18, 2017 at 2:44 AM, Michael Niedermayer > >

Re: [FFmpeg-devel] libavcodec/utvideodsp : add avx2 version

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 10:07:54PM +0100, Martin Vignali wrote: > 2017-11-04 19:33 GMT+01:00 Martin Vignali : > > > > > > > 2017-10-25 21:53 GMT+02:00 Martin Vignali : > > > >> > >> > >> 2017-10-22 14:05 GMT+02:00 Martin Vignali

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 09:58:05PM +0530, Sasi Inguva wrote: > On Sun, Nov 19, 2017 at 1:17 AM, Michael Niedermayer > wrote: > > > On Sat, Nov 18, 2017 at 11:12:17AM -0800, Sasi Inguva wrote: > > > Signed-off-by: Sasi Inguva > > > --- > > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-20 Thread Michael Niedermayer
On Sun, Nov 19, 2017 at 11:52:28AM -0800, Philip Langdale wrote: > This was predictably nightmarish, given how ridiculous mpeg4 is. > I had to stare at the cuvid parser output for a long time to work > out what each field was supposed to be, and even then, I still don't > fully understand some of

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/jpeg2000dsp: add test for ict_float

2017-11-20 Thread James Almer
On 11/19/2017 10:02 PM, Michael Niedermayer wrote: > On Sun, Nov 19, 2017 at 12:39:36AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> tests/checkasm/jpeg2000dsp.c | 33 + >> 1 file changed, 33 insertions(+) > > LGTM > > thx

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Dale Curtis
On Mon, Nov 20, 2017 at 12:34 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Nov 20, 2017 at 12:01:11PM -0800, Dale Curtis wrote: > > Derp, that's the wrong comment for this; I meant that for another thread. > > Returning an error for optional user data seems a bit harsh, but

Re: [FFmpeg-devel] [PATCH 02/13] lavc: Add hardware config metadata for decoders supporting hardware output

2017-11-20 Thread Philip Langdale
On 2017-11-20 13:15, Philip Langdale wrote: On 2017-11-18 10:47, Mark Thompson wrote: This includes a pointer to the associated hwaccel for decoders using hwaccels - these will be used later to implement the hwaccel setup without needing a global list. Also added is a new file listing all

Re: [FFmpeg-devel] [PATCH 02/13] lavc: Add hardware config metadata for decoders supporting hardware output

2017-11-20 Thread Philip Langdale
On 2017-11-18 10:47, Mark Thompson wrote: This includes a pointer to the associated hwaccel for decoders using hwaccels - these will be used later to implement the hwaccel setup without needing a global list. Also added is a new file listing all hwaccels as external declarations - this will

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Dale Curtis
On Mon, Nov 20, 2017 at 12:40 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Nov 20, 2017 at 12:05:05PM -0800, Dale Curtis wrote: > > On Sat, Nov 18, 2017 at 2:44 AM, Michael Niedermayer > > > wrote: > > > > > > this would skip the code for wrap_bits

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: > Tobias Rapp (2017-11-20): > > Would it be OK to backport the fix into release/3.4? I can do the > > cherry-picking but am unsure about the policies and what other older > > releases should possibly be adapted, too. > > I do not

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added configuration to override HTTP User-Agent

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 11:54:47PM +0800, Steven Liu wrote: > 2017-11-20 23:12 GMT+08:00 Hendrik Leppkes : > > On Mon, Nov 20, 2017 at 3:11 PM, Steven Liu wrote: > >> > >> > >>> 在 2017年11月20日,下午10:03,Carl Eugen Hoyos 写道: > >>> > >>>

Re: [FFmpeg-devel] libavcodec/hapdec : add support for hapqa decoding

2017-11-20 Thread Martin Vignali
2017-11-13 20:06 GMT+01:00 Martin Vignali : > > > 2017-10-21 21:37 GMT+02:00 Carl Eugen Hoyos : > >> 2017-10-21 21:32 GMT+02:00 Martin Vignali : >> > 2017-10-21 21:23 GMT+02:00 Carl Eugen Hoyos : >> > >>

Re: [FFmpeg-devel] [PATCH] avformat: rename AVOutputFormat.deinit to AVOutputFormat.close

2017-11-20 Thread James Almer
On 11/20/2017 5:45 PM, Nicolas George wrote: > James Almer (2017-11-20): >> This is more in line with other callbacks, like AVCodec.close and >> AVInputFormat.read_close > > Unless I am mistaken, unlike the "close" callbacks, this one is always > called, including when init fails. > > Regards,

Re: [FFmpeg-devel] [PATCH 01/13] lavc: Add codec metadata to indicate hardware support

2017-11-20 Thread Philip Langdale
On 2017-11-18 10:47, Mark Thompson wrote: --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 74 libavcodec/hwaccel.h | 18 + libavcodec/utils.c | 12 + 4 files changed, 107 insertions(+) diff --git

Re: [FFmpeg-devel] libavcodec/utvideodsp : add avx2 version

2017-11-20 Thread Martin Vignali
2017-11-04 19:33 GMT+01:00 Martin Vignali : > > > 2017-10-25 21:53 GMT+02:00 Martin Vignali : > >> >> >> 2017-10-22 14:05 GMT+02:00 Martin Vignali : >> >>> Hello, >>> >>> In attach patch to add AVX2 version for the

Re: [FFmpeg-devel] libavcodec/huffyuvdsp(enc) : add avx2 version for add(diff)_int16

2017-11-20 Thread Martin Vignali
2017-11-04 19:31 GMT+01:00 Martin Vignali : > > > 2017-10-22 0:26 GMT+02:00 Martin Vignali : > >> Hello, >> >> In attach patch to add avx2 version for huffyuv dsp and huffyuvdsp enc >> for add_int16 and diff_int16 func >> >> Check asm result for

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

2017-11-20 Thread Michael Niedermayer
On Sun, Nov 19, 2017 at 03:23:47PM -0800, Nick Lewycky wrote: > Sorry-- what should I do now? Wait for another patch to go in first then > rebase on top of it? Attempt to migrate error_count to C11 atomics myself? > If I'm migrating, is there a primer on how ffmpeg uses C11 atomics? For >

Re: [FFmpeg-devel] [PATCH] avformat/avio: remove must_flush from AVIOContext

2017-11-20 Thread Marton Balint
On Sun, 19 Nov 2017, Marton Balint wrote: On Wed, 15 Nov 2017, Marton Balint wrote: On Wed, 15 Nov 2017, Nicolas George wrote: Le quintidi 25 brumaire, an CCXXVI, Marton Balint a écrit : It is unused. Signed-off-by: Marton Balint --- libavformat/avio.h | 1 - 1 file

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: Use atomic addition for value updated in multiple threads.

2017-11-20 Thread Michael Niedermayer
On Sun, Nov 19, 2017 at 03:23:47PM -0800, Nick Lewycky wrote: [...] > error_resilience.c | 22 -- > error_resilience.h |3 ++- > h264_slice.c |6 -- > mpeg12dec.c| 11 ++- > mpegvideo_enc.c|5 - > 5 files changed, 28

[FFmpeg-devel] [PATCH 1/2] avocdec/ttaenc: buffer packets directly

2017-11-20 Thread James Almer
This is a bit more robust in case of OOM. Signed-off-by: James Almer --- libavformat/ttaenc.c | 42 +- 1 file changed, 33 insertions(+), 9 deletions(-) diff --git a/libavformat/ttaenc.c b/libavformat/ttaenc.c index

[FFmpeg-devel] [PATCH 2/2] avformat/ttaenc: add tta_init()

2017-11-20 Thread James Almer
Signed-off-by: James Almer --- libavformat/ttaenc.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/libavformat/ttaenc.c b/libavformat/ttaenc.c index b05705b6b6..add15873d0 100644 --- a/libavformat/ttaenc.c +++

Re: [FFmpeg-devel] [PATCH] avformat: rename AVOutputFormat.deinit to AVOutputFormat.close

2017-11-20 Thread Nicolas George
James Almer (2017-11-20): > This is more in line with other callbacks, like AVCodec.close and > AVInputFormat.read_close Unless I am mistaken, unlike the "close" callbacks, this one is always called, including when init fails. Regards, -- Nicolas George signature.asc Description: Digital

[FFmpeg-devel] [PATCH] avformat: rename AVOutputFormat.deinit to AVOutputFormat.close

2017-11-20 Thread James Almer
This is more in line with other callbacks, like AVCodec.close and AVInputFormat.read_close Signed-off-by: James Almer --- libavformat/avformat.h | 4 ++-- libavformat/dashenc.c | 6 +++--- libavformat/fifo.c | 4 ++-- libavformat/movenc.c| 18 +-

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 12:05:05PM -0800, Dale Curtis wrote: > On Sat, Nov 18, 2017 at 2:44 AM, Michael Niedermayer > wrote: > > > > this would skip the code for wrap_bits >= 63, this does not look > > correct > > > > Why do you think that's incorrect? The max int64_t

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 12:01:11PM -0800, Dale Curtis wrote: > Derp, that's the wrong comment for this; I meant that for another thread. > Returning an error for optional user data seems a bit harsh, but if that's > what you want, I'm happy to change it. Please let me know if this is the > route

Re: [FFmpeg-devel] [PATCH 11/13] vp8: Add hwaccel hooks

2017-11-20 Thread Philip Langdale
On 2017-11-18 10:47, Mark Thompson wrote: Also adds some extra fields to the main context structure that may be needed by a hwaccel decoder. The current behaviour of the WebP decoder is maintained by adding an additional field to the VP8 decoder private context to indicate that it is actually

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevcdsp_template: Fix invalid shift in put_hevc_epel_bi_w_v()

2017-11-20 Thread Michael Niedermayer
On Sat, Nov 18, 2017 at 01:33:17AM +0100, Michael Niedermayer wrote: > Fixes: runtime error: left shift of negative value -255 > Fixes: 4037/clusterfuzz-testcase-minimized-5290998163832832 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH] avcodec/mlpdsp: Fix signed integer overflow, 2nd try

2017-11-20 Thread Michael Niedermayer
The outputted bits should match what is used in the lossless check Fixes: runtime error: signed integer overflow: -538697856 * 256 cannot be represented in type 'int' Fixes: 4326/clusterfuzz-testcase-minimized-5689449645080576 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] Subscribe to ffmpeg-cvslog for patch discussion? Really?

2017-11-20 Thread Paul B Mahol
On 11/20/17, Jim DeLaHunt wrote: > On 2017-11-20 05:18, Carl Eugen Hoyos wrote: >> 2017-11-19 11:27 GMT+01:00 Jim DeLaHunt : >>> Looking in the ffmpeg-cvslog archives >>> , it's clear that diffs of >>>

Re: [FFmpeg-devel] Subscribe to ffmpeg-cvslog for patch discussion? Really?

2017-11-20 Thread Jim DeLaHunt
On 2017-11-20 05:18, Carl Eugen Hoyos wrote: 2017-11-19 11:27 GMT+01:00 Jim DeLaHunt : Looking in the ffmpeg-cvslog archives , it's clear that diffs of many, possibly all, commits are sent there. But I see no evidence there

[FFmpeg-devel] [ogg] Close ogg stream upon error when using AV_EF_EXPLODE.

2017-11-20 Thread Dale Curtis
Without this there can be multiple memory leaks with unknown ogg streams. - dale From 4fc9d288c50891a9740facc549c895da066af71b Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Mon, 20 Nov 2017 12:07:57 -0800 Subject: [PATCH] [ogg] Close ogg stream upon error when using

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Dale Curtis
On Sat, Nov 18, 2017 at 2:44 AM, Michael Niedermayer wrote: > > this would skip the code for wrap_bits >= 63, this does not look > correct > Why do you think that's incorrect? The max int64_t value is 1 << 63 and 2 << 63 == 1 << 64 ? - dale

[FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-20 Thread Jacob Trimble
Signed-off-by: Jacob Trimble --- libavformat/mov.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 0b8f8ad24b..b6cdf3a52a 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6753,6 +6753,7 @@

[FFmpeg-devel] [PATCH] avfilter: add mix filter

2017-11-20 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 28 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_mix.c | 283 +++ 4 files changed, 313 insertions(+) create mode 100644

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Dale Curtis
Derp, that's the wrong comment for this; I meant that for another thread. Returning an error for optional user data seems a bit harsh, but if that's what you want, I'm happy to change it. Please let me know if this is the route you want to take. - dale On Mon, Nov 20, 2017 at 11:55 AM, Dale

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Dale Curtis
On Fri, Nov 17, 2017 at 6:22 PM, Michael Niedermayer wrote: > > Not sure what is best but > throwing part of the version silently away is not correct > most likely erroring out and asking for a sample video to be uploaded > would make sense if such a file is encountered

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Almer
On 11/20/2017 4:38 PM, James Zern wrote: > On Mon, Nov 20, 2017 at 11:17 AM, James Zern wrote: >> On Sun, Nov 19, 2017 at 6:03 AM, James Almer wrote: >>> On 11/17/2017 10:50 PM, James Zern wrote: this will simplify libvpxenc/dec.c and ensure more stable

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Mon, Nov 20, 2017 at 11:17 AM, James Zern wrote: > On Sun, Nov 19, 2017 at 6:03 AM, James Almer wrote: >> On 11/17/2017 10:50 PM, James Zern wrote: >>> this will simplify libvpxenc/dec.c and ensure more stable versions of >>> the codecs are present. >>>

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Limit error concealment to max_pixels

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 06:30:28PM +, Kieran Kunhya wrote: > > > > On Mon, 20 Nov 2017 at 17:26 Michael Niedermayer > > wrote: > > Error concealment is time consuming, limiting it in a pixel dependant way > > allows > > the decoder to be fuzzed with more frames quicker

Re: [FFmpeg-devel] [PATCH] configure: fix module dependencies on zlib

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 02:58:58PM -0300, James Almer wrote: > On 11/20/2017 2:34 PM, Michael Niedermayer wrote: > > On Sun, Nov 19, 2017 at 04:00:11PM -0300, James Almer wrote: > >> select should not be used with external libraries. It's mean to soft > >> enable internal modules/features. > >> >

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Sun, Nov 19, 2017 at 5:57 AM, James Almer wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> Signed-off-by: James Zern >> --- >> libavcodec/libvpx.c | 12 +--- >> 1 file changed, 1 insertion(+), 11 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Sun, Nov 19, 2017 at 6:03 AM, James Almer wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> this will simplify libvpxenc/dec.c and ensure more stable versions of >> the codecs are present. >> >> Signed-off-by: James Zern >> --- >> configure | 20

Re: [FFmpeg-devel] [PATCH 11/11] avformat/wavdecuse FFABS to instead of fabs

2017-11-20 Thread Gregor Riepl
> FFABS is slower than fabs. Not generally. That is highly dependent on compiler/flags/architecture. In some cases, FFABS may actually be faster, in others maybe not. The expected result would be on-par performance. ___ ffmpeg-devel mailing list

[FFmpeg-devel] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-20 Thread John Stebbins
This update to the patch incorporates Marton's suggestion to eliminate the effects of buffering on the selection of frames to drop. It ties the decision to start dropping disposable frames to the "early" frame drop logic that happens immediately after avcodec_receive_frame. And disposable frames

[FFmpeg-devel] [PATCH 6/6] ffplay: use AV_PKT_FLAG_DISPOSABLE in frame drop logic

2017-11-20 Thread John Stebbins
--- fftools/ffplay.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..f1e0522528 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -198,6 +198,8 @@ typedef struct Decoder { int64_t next_pts;

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Limit error concealment to max_pixels

2017-11-20 Thread Kieran Kunhya
> > On Mon, 20 Nov 2017 at 17:26 Michael Niedermayer > wrote: > Error concealment is time consuming, limiting it in a pixel dependant way > allows > the decoder to be fuzzed with more frames quicker > How is this a reasonable fix considering you have submitted numerous

Re: [FFmpeg-devel] [PATCH] configure: fix module dependencies on zlib

2017-11-20 Thread James Almer
On 11/20/2017 2:34 PM, Michael Niedermayer wrote: > On Sun, Nov 19, 2017 at 04:00:11PM -0300, James Almer wrote: >> select should not be used with external libraries. It's mean to soft >> enable internal modules/features. >> >> Signed-off-by: James Almer >> --- >> configure |

Re: [FFmpeg-devel] [PATCH] configure: fix module dependencies on zlib

2017-11-20 Thread Michael Niedermayer
On Sun, Nov 19, 2017 at 04:00:11PM -0300, James Almer wrote: > select should not be used with external libraries. It's mean to soft > enable internal modules/features. > > Signed-off-by: James Almer > --- > configure | 48 ++-- > 1

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Limit error concealment to max_pixels

2017-11-20 Thread Michael Niedermayer
Error concealment is time consuming, limiting it in a pixel dependant way allows the decoder to be fuzzed with more frames quicker Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Derek Buitenhuis
On 11/20/2017 4:45 PM, Dave Rice wrote: > What do you propose as the default for guessed_hacky_crap? Also are there > supporters for the need of a guessed_hacky_crap optio? Is there precedence in > ffmpeg to enable/disable guesswork via a user option? I personally would never use the guesswork

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Dave Rice
> On Nov 20, 2017, at 11:22 AM, Derek Buitenhuis > wrote: > > On 11/20/2017 3:19 PM, Dave Rice wrote: >> TN2162 requires a colr atom for uncompressed yuv (including v210, v308, >> v408, etc) in mov, so I'd prefer to write it in this case. Note that the >> colr

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Sasi Inguva
Attaching the fate sample On Mon, Nov 20, 2017 at 8:28 AM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c| 55 ++ > ++ > tests/fate/mov.mak | 7 + >

Re: [FFmpeg-devel] Refund request of travel costs for GSoC Summit 2017

2017-11-20 Thread Ronald S. Bultje
Hi, On Mon, Nov 20, 2017 at 8:04 AM, Paul B Mahol wrote: > On 11/20/17, Carl Eugen Hoyos wrote: > > 2017-11-18 18:26 GMT+01:00 Thilo Borgmann : > > > >> some time ago Carl Eugen and me went to the GSoC Summit. > >> See review mail

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/mov.c| 55 tests/fate/mov.mak | 7 + tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ tests/ref/fate/mov-guess-delay-3 |

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-20 Thread Sasi Inguva
On Sun, Nov 19, 2017 at 1:17 AM, Michael Niedermayer wrote: > On Sat, Nov 18, 2017 at 11:12:17AM -0800, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c| 54 ++ > ++ > >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Derek Buitenhuis
On 11/20/2017 3:19 PM, Dave Rice wrote: > TN2162 requires a colr atom for uncompressed yuv (including v210, v308, v408, > etc) in mov, so I'd prefer to write it in this case. Note that the colr atom > provides an option for unspecified for each of the color values, so there's a > method to

Re: [FFmpeg-devel] [FFmpeg-cvslog] tests/fate: addition of test case for hls variant stream creation with master playlist

2017-11-20 Thread Liu Steven
> 在 2017年11月21日,上午12:04,James Almer 写道: > > On 11/20/2017 12:54 PM, Mark Thompson wrote: >> On 20/11/17 02:06, Vishwanath Dixit wrote: >>> ffmpeg | branch: master | Vishwanath Dixit | Mon Nov 20 >>> 10:05:33 2017 +0800|

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-20 Thread Nicolas George
Tobias Rapp (2017-11-20): > Would it be OK to backport the fix into release/3.4? I can do the > cherry-picking but am unsure about the policies and what other older > releases should possibly be adapted, too. I do not know how backporting to releases work either, but I have of course no objection

Re: [FFmpeg-devel] [PATCH 09/13] compat/cuda: Pass a logging context to load functions

2017-11-20 Thread Mark Thompson
On 18/11/17 23:23, Timo Rothenpieler wrote: > lgtm And applied. Thanks! - Mark ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] lavu/qsv: remove unused variable

2017-11-20 Thread Mark Thompson
On 20/11/17 09:14, Zhong Li wrote: > suppres build warning of "variable 's' is declared but not used" > > Signed-off-by: Zhong Li > --- > libavutil/hwcontext_qsv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c

Re: [FFmpeg-devel] [FFmpeg-cvslog] tests/fate: addition of test case for hls variant stream creation with master playlist

2017-11-20 Thread James Almer
On 11/20/2017 12:54 PM, Mark Thompson wrote: > On 20/11/17 02:06, Vishwanath Dixit wrote: >> ffmpeg | branch: master | Vishwanath Dixit | Mon Nov 20 >> 10:05:33 2017 +0800| [218ce1f6237b39090015809468f8e933bb09d9b8] | committer: >> Steven Liu >> >> tests/fate: addition of

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added configuration to override HTTP User-Agent

2017-11-20 Thread Steven Liu
2017-11-20 23:12 GMT+08:00 Hendrik Leppkes : > On Mon, Nov 20, 2017 at 3:11 PM, Steven Liu wrote: >> >> >>> 在 2017年11月20日,下午10:03,Carl Eugen Hoyos 写道: >>> >>> 2017-11-20 15:00 GMT+01:00 Steven Liu :

Re: [FFmpeg-devel] [FFmpeg-cvslog] tests/fate: addition of test case for hls variant stream creation with master playlist

2017-11-20 Thread Mark Thompson
On 20/11/17 02:06, Vishwanath Dixit wrote: > ffmpeg | branch: master | Vishwanath Dixit | Mon Nov 20 > 10:05:33 2017 +0800| [218ce1f6237b39090015809468f8e933bb09d9b8] | committer: > Steven Liu > > tests/fate: addition of test case for hls variant stream creation with master

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

2017-11-20 Thread Tobias Rapp
On 20.11.2017 14:47, Tobias Rapp wrote: Fixes ticket #6383. Signed-off-by: Tobias Rapp --- libavformat/avienc.c | 10 -- libavformat/version.h| 2 +- tests/ref/fate/copy-trac2211-avi | 2 +- 3 files changed, 10 insertions(+), 4

Re: [FFmpeg-devel] [PATCH 1/6] lavf/movenc: add sdtp (sample dependency) box

2017-11-20 Thread John Stebbins
On 11/19/2017 02:29 PM, Carl Eugen Hoyos wrote: > 2017-11-19 23:25 GMT+01:00 John Stebbins : >> On 11/19/2017 02:12 PM, Carl Eugen Hoyos wrote: >>> 2017-11-19 21:46 GMT+01:00 John Stebbins : The sdtp is required by the AppleTV 4K in order to

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: Implement mpeg4 nvdec hwaccel

2017-11-20 Thread Philip Langdale
On Mon, 20 Nov 2017 10:59:52 +0100 Timo Rothenpieler wrote: > > Duplicate. Will remove. > > Can't really tell if the parameters are in any way correct, but I > guess time will tell if some sample comes up that breaks it. > > lgtm with that duplicate removed > Thanks.

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

2017-11-20 Thread Dave Rice
> On Nov 20, 2017, at 9:55 AM, Derek Buitenhuis > wrote: > > On 11/20/2017 2:50 PM, Dave Rice wrote: >> I am hesitant to see write_colr option removed since the guesswork used here >>

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added configuration to override HTTP User-Agent

2017-11-20 Thread Hendrik Leppkes
On Mon, Nov 20, 2017 at 3:11 PM, Steven Liu wrote: > > >> 在 2017年11月20日,下午10:03,Carl Eugen Hoyos 写道: >> >> 2017-11-20 15:00 GMT+01:00 Steven Liu : >>> >>> 在 2017年11月20日,下午9:03,Carl Eugen Hoyos 写道:

  1   2   >