[FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

2018-01-19 Thread Brendan McGrath
If first_seq_no is not within the bounds of timelines then a segfault will occur. This patch removes the use of first_seq_no within the timelines array It also adds first_seq_no to the value returned by calc_next_seg_no_from_timelines (which allows for different values of 'startNumber')

Re: [FFmpeg-devel] [PATCH 1/3] avutil: add staticpool

2018-01-19 Thread Muhammad Faiz
On Sat, Jan 20, 2018 at 11:49 AM, James Almer wrote: > On 1/20/2018 1:29 AM, Muhammad Faiz wrote: >> Help avoiding malloc-free cycles when allocating-freeing common >> structures. >> >> Signed-off-by: Muhammad Faiz >> --- >> libavutil/staticpool.h | 117 >>

Re: [FFmpeg-devel] [PATCH 1/3] avutil: add staticpool

2018-01-19 Thread James Almer
On 1/20/2018 1:29 AM, Muhammad Faiz wrote: > Help avoiding malloc-free cycles when allocating-freeing common > structures. > > Signed-off-by: Muhammad Faiz > --- > libavutil/staticpool.h | 117 > + > 1 file changed, 117

[FFmpeg-devel] [PATCH 1/3] avutil: add staticpool

2018-01-19 Thread Muhammad Faiz
Help avoiding malloc-free cycles when allocating-freeing common structures. Signed-off-by: Muhammad Faiz --- libavutil/staticpool.h | 117 + 1 file changed, 117 insertions(+) create mode 100644 libavutil/staticpool.h diff --git

[FFmpeg-devel] [PATCH 2/3] avutil/buffer: use staticpool

2018-01-19 Thread Muhammad Faiz
Use default size 1024. Benchmark: time ./ffmpeg -f s16le -ac 5 -ar 48000 -t 1 -i /dev/zero \ -af "aformat=s16p, asetnsamples=256" -f null - old: 27.616s new: 22.079s Signed-off-by: Muhammad Faiz --- libavutil/buffer.c | 23 ++- 1 file changed, 14

[FFmpeg-devel] [PATCH 3/3] avutil/frame: use staticpool

2018-01-19 Thread Muhammad Faiz
Use default size 256. Benchmark: time ./ffmpeg -f s16le -ac 5 -ar 48000 -t 1 -i /dev/zero \ -af "aformat=s16p, asetnsamples=256" -f null - old: 22.079s new: 21.180s Signed-off-by: Muhammad Faiz --- libavutil/frame.c | 7 +-- 1 file changed, 5 insertions(+), 2

[FFmpeg-devel] [PATCH] avcodec/hevc_parser: use ff_hevc_decode_extradata() to parse extradata

2018-01-19 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index ff7e8a49d6..a3a9098c7c 100644 --- a/libavcodec/hevc_parser.c +++

[FFmpeg-devel] [PATCH] avcodec/truemotion2: Fix integer overflow in TM2_RECALC_BLOCK()

2018-01-19 Thread Michael Niedermayer
Fixes: signed integer overflow: 1477974040 - -1877995504 cannot be represented in type 'int' Fixes: 4861/clusterfuzz-testcase-minimized-4570316383715328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] Fix memory leak in lrcdec.c

2018-01-19 Thread Carl Eugen Hoyos
2018-01-20 3:10 GMT+01:00 Michael Niedermayer : > On Sat, Jan 20, 2018 at 02:39:02AM +0100, Carl Eugen Hoyos wrote: >> 2018-01-20 1:57 GMT+01:00 Michael Niedermayer : >> > On Fri, Jan 19, 2018 at 01:17:07PM -0800, Nikolas Bowe wrote: >> >> --- >> >>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Check that data is set

2018-01-19 Thread Jeyapal, Karthick
On 1/20/18 6:29 AM, Brendan McGrath wrote: > If codecpar->extradata is not set (for example, when the stream goes > through the 'tee' muxer), then a segfault occurs. > > This patch ensures the data variable is not null before attempting > to access it > > Signed-off-by: Brendan McGrath

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Fix integer overflow before htaps check

2018-01-19 Thread Michael Niedermayer
On Mon, Jan 15, 2018 at 03:27:16AM +0100, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: -1094995529 * 2 cannot be > represented in type 'int' > Fixes: 4828/clusterfuzz-testcase-minimized-5100849937252352 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Michael Niedermayer
On Sat, Jan 20, 2018 at 02:36:08AM +0100, Carl Eugen Hoyos wrote: > 2018-01-19 23:42 GMT+01:00 Michael Niedermayer : > > On Fri, Jan 19, 2018 at 07:25:43PM +0100, Carl Eugen Hoyos wrote: > >> 2018-01-19 18:51 GMT+01:00 Michael Niedermayer : > >> > On

Re: [FFmpeg-devel] [PATCH] Fix memory leak in lrcdec.c

2018-01-19 Thread Michael Niedermayer
On Sat, Jan 20, 2018 at 02:39:02AM +0100, Carl Eugen Hoyos wrote: > 2018-01-20 1:57 GMT+01:00 Michael Niedermayer : > > On Fri, Jan 19, 2018 at 01:17:07PM -0800, Nikolas Bowe wrote: > >> --- > >> libavformat/lrcdec.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >>

Re: [FFmpeg-devel] [PATCH] Fix memory leak in lrcdec.c

2018-01-19 Thread Carl Eugen Hoyos
2018-01-20 1:57 GMT+01:00 Michael Niedermayer : > On Fri, Jan 19, 2018 at 01:17:07PM -0800, Nikolas Bowe wrote: >> --- >> libavformat/lrcdec.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/lrcdec.c b/libavformat/lrcdec.c >> index

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 23:42 GMT+01:00 Michael Niedermayer : > On Fri, Jan 19, 2018 at 07:25:43PM +0100, Carl Eugen Hoyos wrote: >> 2018-01-19 18:51 GMT+01:00 Michael Niedermayer : >> > On Thu, Jan 18, 2018 at 09:28:40PM +0100, Carl Eugen Hoyos wrote: >> >> Hi!

[FFmpeg-devel] [PATCHv2] dashdec: Only free url string if being reused

2018-01-19 Thread Brendan McGrath
If no representation bandwidth value is set, the url value returned by get_content_url is corrupt (as it has been freed). This change ensures the url string is not freed unless it is about to be reused Signed-off-by: Brendan McGrath --- Changes since v1: - removed

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: parse size and colorspace values from frame headers

2018-01-19 Thread James Almer
On 1/19/2018 9:36 PM, Michael Niedermayer wrote: > On Fri, Jan 19, 2018 at 09:33:46PM -0300, James Almer wrote: >> On 1/19/2018 8:56 PM, Michael Niedermayer wrote: >>> On Fri, Jan 19, 2018 at 12:51:21AM -0300, James Almer wrote: Improves remuxing support when vp9 decoder is not compiled in.

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 03:46:57PM -0800, Kyle Swanson wrote: > Hi, > > > > > Ping. Unless text needs to be rescaled as well, this patch is ready for > > review. > > > > > > Regards, > > Gyan > > ___ > > ffmpeg-devel mailing list > >

[FFmpeg-devel] [PATCH] avformat/hlsenc: Check that data is set

2018-01-19 Thread Brendan McGrath
If codecpar->extradata is not set (for example, when the stream goes through the 'tee' muxer), then a segfault occurs. This patch ensures the data variable is not null before attempting to access it Signed-off-by: Brendan McGrath --- Before the var_stream_map option

Re: [FFmpeg-devel] [PATCH] Fix memory leak in lrcdec.c

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 01:17:07PM -0800, Nikolas Bowe wrote: > --- > libavformat/lrcdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/lrcdec.c b/libavformat/lrcdec.c > index 12f74b22a0..f4e9a4efa9 100644 > --- a/libavformat/lrcdec.c > +++ b/libavformat/lrcdec.c > @@

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflow undefined behavior

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 03:56:19PM -0800, Niki Bowe wrote: > On Fri, Jan 19, 2018 at 3:00 PM, Michael Niedermayer > wrote: > > > On Fri, Jan 19, 2018 at 02:48:08PM -0800, Nikolas Bowe wrote: > > > Found via fuzzing > > > --- > > > libavformat/rpl.c | 2 +- > > > 1 file

[FFmpeg-devel] [PATCHv3 4/4] avfilter/vf_framerate: add SIMD functions for frame blending

2018-01-19 Thread Marton Balint
Blend function speedups on x86_64 Core i5 4460: ffmpeg -f lavfi -i allyuv -vf framerate=60:threads=1 -f null none C: 447548411 decicycles in Blend,2048 runs, 0 skips SSSE3: 130020087 decicycles in Blend,2048 runs, 0 skips AVX2: 128508221 decicycles in Blend,2048 runs,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mlp_parser: don't try to combine frames when full frames are provided

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 08:30:59PM -0300, James Almer wrote: > On 1/19/2018 5:06 PM, wm4 wrote: > > On Fri, 19 Jan 2018 16:51:45 -0300 > > James Almer wrote: > > > >> Attempting full frame reconstruction is unnecessary for containers > >> like Matroska, so just skip it

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: parse size and colorspace values from frame headers

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 09:33:46PM -0300, James Almer wrote: > On 1/19/2018 8:56 PM, Michael Niedermayer wrote: > > On Fri, Jan 19, 2018 at 12:51:21AM -0300, James Almer wrote: > >> Improves remuxing support when vp9 decoder is not compiled in. > >> > >> Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: parse size and colorspace values from frame headers

2018-01-19 Thread James Almer
On 1/19/2018 8:56 PM, Michael Niedermayer wrote: > On Fri, Jan 19, 2018 at 12:51:21AM -0300, James Almer wrote: >> Improves remuxing support when vp9 decoder is not compiled in. >> >> Signed-off-by: James Almer >> --- >> libavcodec/vp9_parser.c | 98 >>

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflow undefined behavior

2018-01-19 Thread Niki Bowe
On Fri, Jan 19, 2018 at 3:00 PM, Michael Niedermayer wrote: > On Fri, Jan 19, 2018 at 02:48:08PM -0800, Nikolas Bowe wrote: > > Found via fuzzing > > --- > > libavformat/rpl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: parse size and colorspace values from frame headers

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 12:51:21AM -0300, James Almer wrote: > Improves remuxing support when vp9 decoder is not compiled in. > > Signed-off-by: James Almer > --- > libavcodec/vp9_parser.c | 98 > - > 1 file changed, 97

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-19 Thread Kyle Swanson
Hi, > > Ping. Unless text needs to be rescaled as well, this patch is ready for > review. > > > Regards, > Gyan > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel LGTM as-is. I'll push this

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mlp_parser: don't try to combine frames when full frames are provided

2018-01-19 Thread James Almer
On 1/19/2018 5:06 PM, wm4 wrote: > On Fri, 19 Jan 2018 16:51:45 -0300 > James Almer wrote: > >> Attempting full frame reconstruction is unnecessary for containers >> like Matroska, so just skip it altogether. >> >> Signed-off-by: James Almer >> --- >>

Re: [FFmpeg-devel] [PATCH 1/3] Add muxing/demuxing of RMHD

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 09:45:44PM +0100, Moritz Barsnick wrote: > On Fri, Jan 19, 2018 at 18:16:01 +0100, Michael Niedermayer wrote: > > > Patches are not made to be applyable on their own. If that is the only > > > thing > > > missing I might move it to 1/3. > > > > code must build after each

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflow undefined behavior

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 02:48:08PM -0800, Nikolas Bowe wrote: > Found via fuzzing > --- > libavformat/rpl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/rpl.c b/libavformat/rpl.c > index d373600478..df449bfc29 100644 > --- a/libavformat/rpl.c > +++

[FFmpeg-devel] [PATCH] Fix signed integer overflow undefined behavior

2018-01-19 Thread Nikolas Bowe
Found via fuzzing --- libavformat/rpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rpl.c b/libavformat/rpl.c index d373600478..df449bfc29 100644 --- a/libavformat/rpl.c +++ b/libavformat/rpl.c @@ -194,7 +194,7 @@ static int rpl_read_header(AVFormatContext *s)

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 07:25:43PM +0100, Carl Eugen Hoyos wrote: > 2018-01-19 18:51 GMT+01:00 Michael Niedermayer : > > On Thu, Jan 18, 2018 at 09:28:40PM +0100, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> The probe score for swf files (with uncompressed headers) is

Re: [FFmpeg-devel] [PATCH] cuvid : add support to force intra frames as in input source

2018-01-19 Thread Timo Rothenpieler
Am 19.01.2018 um 19:47 schrieb Michael Niedermayer: On Fri, Jan 19, 2018 at 11:09:51AM +0100, Timo Rothenpieler wrote: Am 18.01.2018 um 07:52 schrieb Yogender Gupta: Improved the patch by dynamic allocation. Thanks, Yogender @@ -1072,6 +1083,8 @@ static void cuvid_flush(AVCodecContext

[FFmpeg-devel] [PATCH] Fix memory leak in lrcdec.c

2018-01-19 Thread Nikolas Bowe
--- libavformat/lrcdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/lrcdec.c b/libavformat/lrcdec.c index 12f74b22a0..f4e9a4efa9 100644 --- a/libavformat/lrcdec.c +++ b/libavformat/lrcdec.c @@ -212,6 +212,7 @@ static int lrc_read_header(AVFormatContext *s) }

Re: [FFmpeg-devel] [PATCH 1/3] Add muxing/demuxing of RMHD

2018-01-19 Thread Moritz Barsnick
On Fri, Jan 19, 2018 at 18:16:01 +0100, Michael Niedermayer wrote: > > Patches are not made to be applyable on their own. If that is the only thing > > missing I might move it to 1/3. > > code must build after each commit when its pushed. > so if the patches represent future commits 1:1 then

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mlp_parser: don't try to combine frames when full frames are provided

2018-01-19 Thread wm4
On Fri, 19 Jan 2018 16:51:45 -0300 James Almer wrote: > Attempting full frame reconstruction is unnecessary for containers > like Matroska, so just skip it altogether. > > Signed-off-by: James Almer > --- > libavcodec/mlp_parser.c | 4 > 1 file

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mlp_parser: don't try to combine frames when full frames are provided

2018-01-19 Thread Rostislav Pehlivanov
On 19 January 2018 at 19:51, James Almer wrote: > Attempting full frame reconstruction is unnecessary for containers > like Matroska, so just skip it altogether. > > Signed-off-by: James Almer > --- > libavcodec/mlp_parser.c | 4 > 1 file changed, 4

[FFmpeg-devel] [PATCH 2/2] avcodec/mlp_parser: reindent after last commit

2018-01-19 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mlp_parser.c | 92 - 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/libavcodec/mlp_parser.c b/libavcodec/mlp_parser.c index 4827354f18..185bd4d667 100644 ---

[FFmpeg-devel] [PATCH 1/2] avcodec/mlp_parser: don't try to combine frames when full frames are provided

2018-01-19 Thread James Almer
Attempting full frame reconstruction is unnecessary for containers like Matroska, so just skip it altogether. Signed-off-by: James Almer --- libavcodec/mlp_parser.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/mlp_parser.c b/libavcodec/mlp_parser.c index

Re: [FFmpeg-devel] [PATCH] cuvid : add support to force intra frames as in input source

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 11:09:51AM +0100, Timo Rothenpieler wrote: > Am 18.01.2018 um 07:52 schrieb Yogender Gupta: > >Improved the patch by dynamic allocation. > > > >Thanks, > >Yogender > > > > > @@ -1072,6 +1083,8 @@ static void cuvid_flush(AVCodecContext *avctx) > > if (ret < 0) > >

Re: [FFmpeg-devel] [PATCH] dashdec: Only free url string if being reused

2018-01-19 Thread Michael Niedermayer
On Thu, Jan 18, 2018 at 09:15:49PM +1100, Brendan McGrath wrote: > If no representation bandwidth value is set, the url value returned > by get_content_url is corrupt (as the memory has been freed). > > This change ensures the url string is not freed unless it is about > to be reused > >

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 18:51 GMT+01:00 Michael Niedermayer : > On Thu, Jan 18, 2018 at 09:28:40PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> The probe score for swf files (with uncompressed headers) is currently >> very high after testing a little more than 24bit, attached patch >>

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 18:33 GMT+01:00 Michael Niedermayer : > On Fri, Jan 19, 2018 at 04:21:54PM +0100, Tomas Härdin wrote: >> On 2018-01-18 21:28, Carl Eugen Hoyos wrote: >> >Hi! >> > >> >The probe score for swf files (with uncompressed headers) is currently >> >very high after

Re: [FFmpeg-devel] [PATCH]lavc/svq3: Do not write into const memory

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 16:54 GMT+01:00 Tomas Härdin : > On 2018-01-18 23:34, Carl Eugen Hoyos wrote: >> >> Hi! >> >> Attached patch fixes a warning, I suspect it makes the code more correct. >> >> Please comment, Carl Eugen >> > >> --- a/libavcodec/svq3.c >> +++ b/libavcodec/svq3.c >> @@

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: parse size and colorspace values from frame headers

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 17:09 GMT+01:00 James Almer : > On 1/19/2018 8:19 AM, Carl Eugen Hoyos wrote: >> 2018-01-19 4:51 GMT+01:00 James Almer : >>> Improves remuxing support when vp9 decoder is not compiled in. >> >>> +static int

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Michael Niedermayer
On Thu, Jan 18, 2018 at 09:28:40PM +0100, Carl Eugen Hoyos wrote: > Hi! > > The probe score for swf files (with uncompressed headers) is currently > very high after testing a little more than 24bit, attached patch > reduces the score. hmm the first 24 bits are tested and all but 2 values are

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 04:21:54PM +0100, Tomas Härdin wrote: > On 2018-01-18 21:28, Carl Eugen Hoyos wrote: > >Hi! > > > >The probe score for swf files (with uncompressed headers) is currently > >very high after testing a little more than 24bit, attached patch > >reduces the score. > > > >Please

Re: [FFmpeg-devel] [PATCH 1/3] Add muxing/demuxing of RMHD

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 01:39:31PM +0100, Thilo Borgmann wrote: > Am 19.01.18 um 01:02 schrieb Michael Niedermayer: > > On Thu, Jan 18, 2018 at 07:39:07PM +0100, Thilo Borgmann wrote: > >> This time including the patch... > > > >> fftools/ffmpeg.c | 28 +++ > >> fftools/ffmpeg_opt.c

Re: [FFmpeg-devel] [PATCH 0/5] x86inc: Sync changes from x264

2018-01-19 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 12:06:10AM +0100, Henrik Gramner wrote: > Henrik Gramner (5): > x86inc: Enable AVX emulation for floating-point pseudo-instructions > x86inc: Use .rdata instead of .rodata on Windows > x86inc: Support creating global symbols from local labels > x86inc: Correctly set

Re: [FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

2018-01-19 Thread Michael Niedermayer
On Thu, Jan 18, 2018 at 03:21:56PM -0800, Nikolas Bowe wrote: > --- > libavformat/matroskadec.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) will apply with the indention and commit message fixed thanks [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself for avcodec/v4l2_

2018-01-19 Thread Jorge Ramirez-Ortiz
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e583926..d0de26c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -240,6 +240,7 @@ Codecs: tta.c Alex Beregszaszi, Jaikrishnan Menon ttaenc.c

Re: [FFmpeg-devel] [PATCH v1 1/3] avcodec: v4l2_m2m: fix races around freeing data on close

2018-01-19 Thread Jorge Ramirez-Ortiz
On 01/19/2018 12:30 AM, Michael Niedermayer wrote: On Thu, Jan 18, 2018 at 09:24:20AM +0100, Jorge Ramirez-Ortiz wrote: On 01/09/2018 11:56 PM, Jorge Ramirez-Ortiz wrote: From: Mark Thompson Refcount all of the context information. This also fixes a potential segmentation

Re: [FFmpeg-devel] [PATCH 1/2] lavc: Add coded_w/h to AVCodecParameters

2018-01-19 Thread James Almer
On 1/19/2018 7:12 AM, Hendrik Leppkes wrote: > On Fri, Jan 19, 2018 at 4:19 AM, Li, Zhong wrote: >>> -Original Message- >>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >>> Of James Almer >>> Sent: Thursday, January 18, 2018 1:15 PM >>> To:

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: parse size and colorspace values from frame headers

2018-01-19 Thread James Almer
On 1/19/2018 8:19 AM, Carl Eugen Hoyos wrote: > 2018-01-19 4:51 GMT+01:00 James Almer : >> Improves remuxing support when vp9 decoder is not compiled in. > >> +static int read_colorspace_details(AVCodecParserContext *ctx, >> AVCodecContext *avctx, >> +

Re: [FFmpeg-devel] [PATCH]lavc/svq3: Do not write into const memory

2018-01-19 Thread Tomas Härdin
On 2018-01-18 23:34, Carl Eugen Hoyos wrote: Hi! Attached patch fixes a warning, I suspect it makes the code more correct. Please comment, Carl Eugen --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -1048,12 +1048,12 @@ static int svq3_decode_slice_header(AVCodecContext *avctx)

Re: [FFmpeg-devel] [PATCH]lavf/swfdec: Reduce score when auto-detecting swf files

2018-01-19 Thread Tomas Härdin
On 2018-01-18 21:28, Carl Eugen Hoyos wrote: Hi! The probe score for swf files (with uncompressed headers) is currently very high after testing a little more than 24bit, attached patch reduces the score. Please comment, Carl Eugen Would be consistent with the discussion about .c2 files.

Re: [FFmpeg-devel] [PATCH 1/3] Add muxing/demuxing of RMHD

2018-01-19 Thread Thilo Borgmann
Am 19.01.18 um 01:02 schrieb Michael Niedermayer: > On Thu, Jan 18, 2018 at 07:39:07PM +0100, Thilo Borgmann wrote: >> This time including the patch... > >> fftools/ffmpeg.c | 28 +++ >> fftools/ffmpeg_opt.c |2 >> libavformat/Makefile |2 >> libavformat/allformats.c

[FFmpeg-devel] [PATCH] avcodec/h264_slice: use the new SAR early when setting the decoder

2018-01-19 Thread Steve Lhomme
If we don't do that get_format might not be called for a while and the proper SAR not used. See the sample mentioned here: https://trac.videolan.org/vlc/ticket/19435 --- libavcodec/h264_slice.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_slice.c

Re: [FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 2:06 GMT+01:00 Niki Bowe : > In the file the fuzzer produced the frame rate is incredibly small > (7.29112e-304). And the msvc documentation seems to indicate it is supported. No more comments from me, please avoid top-posting here. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: parse size and colorspace values from frame headers

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 4:51 GMT+01:00 James Almer : > Improves remuxing support when vp9 decoder is not compiled in. > +static int read_colorspace_details(AVCodecParserContext *ctx, AVCodecContext > *avctx, > + GetBitContext *gb) Isn't this a duplicate

Re: [FFmpeg-devel] [PATCH V2 2/2] Don't overwrite previously setup dimensions for all codecs

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 4:28 GMT+01:00 Li, Zhong : >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Carl Eugen Hoyos >> Sent: Thursday, January 18, 2018 5:26 PM >> To: FFmpeg development discussions and patches >> >> Subject: Re:

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Add CODECS attribute to master playlist

2018-01-19 Thread Steven Liu
2017-12-29 15:05 GMT+08:00 Jeyapal, Karthick : > > > On 12/28/17 5:17 PM, Karthick J wrote: >> From: Karthick Jeyapal >> >> --- >> libavformat/dashenc.c | 2 +- >> libavformat/hlsenc.c | 67 >> ++- >>

Re: [FFmpeg-devel] [PATCH 1/2] lavc: Add coded_w/h to AVCodecParameters

2018-01-19 Thread Hendrik Leppkes
On Fri, Jan 19, 2018 at 4:19 AM, Li, Zhong wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of James Almer >> Sent: Thursday, January 18, 2018 1:15 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH] cuvid : add support to force intra frames as in input source

2018-01-19 Thread Timo Rothenpieler
Am 18.01.2018 um 07:52 schrieb Yogender Gupta: Improved the patch by dynamic allocation. Thanks, Yogender > @@ -1072,6 +1083,8 @@ static void cuvid_flush(AVCodecContext *avctx) > if (ret < 0) > goto error; > > +av_free(ctx->key_frame); > + > ctx->prev_pts = INT64_MIN;

Re: [FFmpeg-devel] [PATCH] ffprobe: Initialize coded_width/height

2018-01-19 Thread Hendrik Leppkes
On Fri, Jan 19, 2018 at 6:05 AM, Zhong Li wrote: > coded_width/height are unnitialized and will be overwritten by > dec_ctx->width/height in avcodec_open2() > > This fixes tiket #6958. > > Signed-off-by: Zhong Li > --- > fftools/ffprobe.c | 6 ++ > 1

Re: [FFmpeg-devel] [PATCH] ffmpeg: Ignore SIGPIPE

2018-01-19 Thread Nicolas George
Mark Thompson (2018-01-18): > On systems which deliver SIGPIPE (Unices), a broken pipe will currently > result in the immediate termination of the ffmpeg process (the default > disposition as required by POSIX). This is undesirable, because while > the broken pipe is likely fatal to useful