[FFmpeg-devel] [PATCH 2/3] avformat, hls: add a flag to signal unavailability of seeking

2018-01-23 Thread wm4
The seek function can just return an error if seeking is unavailable, but often this is too late. Add a flag that signals that the stream is unseekable, and use it in HLS. --- Basically, this is equivalent to being a live stream. In theory, EVENT playlists can be live streams, but they have full

[FFmpeg-devel] [PATCH 3/3] hls: don't print a certain warning if playlist loading is aborted

2018-01-23 Thread wm4
AVERROR_EXIT happens when the user's interrupt callback signals that playback should be aborted. In this case, the demuxer shouldn't print a warning, as it's expected that all network accesses are stopped. --- libavformat/hls.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH 1/3] hls: do not allow fallback to generic seeking

2018-01-23 Thread wm4
This makes little sense due to how HLS works, and only causes some additional annoyances if the HLS read_seek function fails (for example if it's a live stream). It was most likely unintended. --- I guess in theory, this might allow skipping forward a bit, but let's be honest, API users are better

Re: [FFmpeg-devel] GSoC 2018

2018-01-23 Thread Thilo Borgmann
Am 24.01.18 um 00:38 schrieb Carl Eugen Hoyos: > 2018-01-23 18:27 GMT+01:00 Pascal Massimino : > >> Anyone interested in a project around completing the animated-WebP >> support in ffmpeg? > > Please consider to add the project and yourself as mentor > in the wiki: >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Check log2_sao_offset_scale_*

2018-01-23 Thread James Almer
On 1/24/2018 12:34 AM, Michael Niedermayer wrote: > Fixes: 4868/clusterfuzz-testcase-minimized-6236542906400768 > Fixes: runtime error: shift exponent 126 is too large for 32-bit type 'int' > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Check log2_sao_offset_scale_*

2018-01-23 Thread wm4
On Wed, 24 Jan 2018 04:34:49 +0100 Michael Niedermayer wrote: > Fixes: 4868/clusterfuzz-testcase-minimized-6236542906400768 > Fixes: runtime error: shift exponent 126 is too large for 32-bit type 'int' > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: Fix integer overflow in DC dequantization

2018-01-23 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: -65535 * 65312 cannot be represented in type 'int' Fixes: 4900/clusterfuzz-testcase-minimized-5769019744321536 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Check log2_sao_offset_scale_*

2018-01-23 Thread Michael Niedermayer
Fixes: 4868/clusterfuzz-testcase-minimized-6236542906400768 Fixes: runtime error: shift exponent 126 is too large for 32-bit type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-23 Thread wm4
On Tue, 23 Jan 2018 09:39:53 -0800 rshaf...@tunein.com wrote: > From: Richard Shaffer > > Enables getting access to ID3 PRIV tags from the command-line or metadata API > when demuxing. The PRIV owner is stored as the metadata key prepended with > "id3v2_priv.", and the data

[FFmpeg-devel] [PATCH V2 1/3] lavfi/vf_xxx_vaapi: fix typo.

2018-01-23 Thread Jun Zhao
V2: split the patches as carl's comments From 6e6b2cdf8f7f8e0452ab93834f35671e91b922da Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 24 Jan 2018 08:40:59 +0800 Subject: [PATCH V2 1/3] lavfi/vf_xxx_vaapi: fix typo. Signed-off-by: Jun Zhao ---

[FFmpeg-devel] [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if without arguments.

2018-01-23 Thread Jun Zhao
From 1d3b388c313881e931928dc4049896265919725d Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 24 Jan 2018 09:28:24 +0800 Subject: [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if without arguments. Fix the green output issue when use procamp_vaapi without

[FFmpeg-devel] [PATCH V2 3/3] lavfi/misc_vaapi: use default value setting if without arguments.

2018-01-23 Thread Jun Zhao
From 7a4a53fcc5a9b31b11818976dc02ea8e004d2c5a Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 24 Jan 2018 09:32:50 +0800 Subject: [PATCH V2 3/3] lavfi/misc_vaapi: use default value setting if without arguments. Signed-off-by: Jun Zhao ---

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread James Almer
On 1/23/2018 10:46 PM, wm4 wrote: > On Tue, 23 Jan 2018 17:03:26 -0800 > Richard Shaffer wrote: > >> On Tue, Jan 23, 2018 at 2:32 PM, wm4 wrote: >> >>> >>> I think this test program is pretty nice, though usually we try to get >>> by with running the

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread wm4
On Tue, 23 Jan 2018 17:03:26 -0800 Richard Shaffer wrote: > On Tue, Jan 23, 2018 at 2:32 PM, wm4 wrote: > > > > > I think this test program is pretty nice, though usually we try to get > > by with running the "ffmpeg" utility to test the libs. Having

[FFmpeg-devel] [PATCH] avformat/hlsenc: Check ret on avformat_write_header

2018-01-23 Thread Brendan McGrath
Encoding currently fails when using hls_ts_options with the fmp4 segment type. This is due to the fact that avformat_write_header does not process the passed options when the avformat is already initialized. When using fmp4, the hls_ts_options are parsed and the avformat initialized within

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread Richard Shaffer
On Tue, Jan 23, 2018 at 2:32 PM, wm4 wrote: > > I think this test program is pretty nice, though usually we try to get > by with running the "ffmpeg" utility to test the libs. Having a > relatively big program to test some obscure functionality might have a > maintenance

[FFmpeg-devel] [PATCH] rtmp: Plug leak if sending bytes read report fails.

2018-01-23 Thread Josh Allmann
--- libavformat/rtmpproto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index faf2a6f244..b741e421af 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -2431,8 +2431,10 @@ static int

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/procamp_vaapi: fix the green output issue.

2018-01-23 Thread Jun Zhao
On 2018/1/24 7:52, Carl Eugen Hoyos wrote: > 2018-01-23 5:33 GMT+01:00 Jun Zhao : > >> -procamp_params[i].type = VAProcFilterColorBalance; >> +procamp_params[i].type = VAProcFilterColorBalance; > Please split this patch, so that functional change and

Re: [FFmpeg-devel] GSoC 2018

2018-01-23 Thread James Almer
On 1/23/2018 2:27 PM, Pascal Massimino wrote: > Hi, > > sorry for coming late to the game... > > On Tue, Jan 9, 2018 at 10:27 AM, Thilo Borgmann > wrote: > >> Hi folks, >> >> yet again, the registration for Google Summer of Code 2018 has opened. >> >> Like in the

Re: [FFmpeg-devel] [PATCH 3/4] lavfi/procamp_vaapi: fix the green output issue.

2018-01-23 Thread Carl Eugen Hoyos
2018-01-23 5:33 GMT+01:00 Jun Zhao : > -procamp_params[i].type = VAProcFilterColorBalance; > +procamp_params[i].type = VAProcFilterColorBalance; Please split this patch, so that functional change and re-indentation of a large block do not happen in the same

Re: [FFmpeg-devel] GSoC 2018

2018-01-23 Thread Carl Eugen Hoyos
2018-01-23 18:27 GMT+01:00 Pascal Massimino : > Anyone interested in a project around completing the animated-WebP > support in ffmpeg? Please consider to add the project and yourself as mentor in the wiki: https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2018

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Adding myself as dashenc maintainer

2018-01-23 Thread Michael Niedermayer
On Sun, Jan 21, 2018 at 09:56:12AM +0530, Karthick J wrote: > From: Karthick Jeyapal > > If somebody else wants to maintain dashenc either now or in future, > I am absolutely fine with giving up this responsibility anytime. > But till then we need a maintainer for dashenc,

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread wm4
On Tue, 23 Jan 2018 09:54:38 -0800 rshaf...@tunein.com wrote: > From: Richard Shaffer > > Adds basic unit tests for parsing and writing ID3v2 tags. > --- > This requires the patch to "add option to parse/store ID3 PRIV tags in > metadata." > > libavformat/Makefile

Re: [FFmpeg-devel] [PATCH] avcodec/dxtory: Fix bits left checks

2018-01-23 Thread Michael Niedermayer
On Mon, Jan 22, 2018 at 10:25:21PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 4863/clusterfuzz-testcase-6347354178322432 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avutil/aes_ctr: Add method to set 16-byte IV.

2018-01-23 Thread Michael Niedermayer
On Mon, Jan 08, 2018 at 02:12:43PM -0800, Jacob Trimble wrote: > Signed-off-by: Jacob Trimble > --- > doc/APIchanges| 3 +++ > libavutil/aes_ctr.c | 6 ++ > libavutil/aes_ctr.h | 7 ++- > libavutil/tests/aes_ctr.c | 2 +- > libavutil/version.h

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevc_cabac: Check prefix so as to avoid invalid shifts in coeff_abs_level_remaining_decode()

2018-01-23 Thread Michael Niedermayer
On Tue, Jan 16, 2018 at 12:37:28AM +0100, Michael Niedermayer wrote: > I suspect that this can be limited tighter, but i failed to find anything > in the spec that would confirm that. > > Fixes: 4833/clusterfuzz-testcase-minimized-5302840101699584 > Fixes: runtime error: left shift of 134217730

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_cabac: Move prefix check in coeff_abs_level_remaining_decode() down

2018-01-23 Thread Michael Niedermayer
On Tue, Jan 16, 2018 at 12:37:27AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/hevc_cabac.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) applied [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] fate: add id3v2 tests

2018-01-23 Thread rshaffer
From: Richard Shaffer Adds basic unit tests for parsing and writing ID3v2 tags. --- This requires the patch to "add option to parse/store ID3 PRIV tags in metadata." libavformat/Makefile | 3 +- libavformat/tests/.gitignore | 1 + libavformat/tests/id3v2.c|

[FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-23 Thread rshaffer
From: Richard Shaffer Enables getting access to ID3 PRIV tags from the command-line or metadata API when demuxing. The PRIV owner is stored as the metadata key prepended with "id3v2_priv.", and the data is stored as the metadata value. As PRIV tags may contain arbitrary

Re: [FFmpeg-devel] GSoC 2018

2018-01-23 Thread Pascal Massimino
Hi, sorry for coming late to the game... On Tue, Jan 9, 2018 at 10:27 AM, Thilo Borgmann wrote: > Hi folks, > > yet again, the registration for Google Summer of Code 2018 has opened. > > Like in the previous years, we've setup an ideas page in our wiki: >

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: January 23, 2018 10:50 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input > > On 23/01/18 15:31, Mironov, Mikhail

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mark Thompson
On 23/01/18 15:31, Mironov, Mikhail wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: January 23, 2018 10:21 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [RFC] amfenc: Add support for

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: January 23, 2018 10:41 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input > > On 23/01/18 15:14, Mironov, Mikhail

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mark Thompson
On 23/01/18 15:14, Mironov, Mikhail wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mironov, Mikhail >> Sent: January 23, 2018 10:04 AM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re:

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: January 23, 2018 10:21 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input > > On 23/01/18 15:04, Mironov, Mikhail

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: January 23, 2018 10:21 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input > > On 23/01/18 15:04, Mironov, Mikhail

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mark Thompson
On 23/01/18 15:04, Mironov, Mikhail wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: January 22, 2018 6:57 PM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: [FFmpeg-devel]

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mironov, Mikhail > Sent: January 23, 2018 10:04 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

Re: [FFmpeg-devel] [PATCH v2] libopus: support disabling phase inversion.

2018-01-23 Thread Menno de Gier
On Tue, Jan 23, 2018 at 3:50 PM, Moritz Barsnick wrote: > On Tue, Jan 23, 2018 at 13:50:41 +0100, Menno wrote: > > +@item apply_phase_inv (N.A.) (requires libopus >= 1.2) > > What does the "N.A." stand for? Does it have a technical meaning? It's the `opusenc` equivalent

Re: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input

2018-01-23 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: January 22, 2018 6:57 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] [RFC] amfenc: Add support for OpenCL input > > ---

Re: [FFmpeg-devel] [PATCH v2] libopus: support disabling phase inversion.

2018-01-23 Thread Moritz Barsnick
On Tue, Jan 23, 2018 at 13:50:41 +0100, Menno wrote: > +@item apply_phase_inv (N.A.) (requires libopus >= 1.2) What does the "N.A." stand for? Does it have a technical meaning? Thanks, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-23 Thread Moritz Barsnick
On Wed, Jan 17, 2018 at 16:34:39 -0800, rshaf...@tunein.com wrote: If you have to post one more update anyway, some formal comments from me: > +char * escaped, * key; "*" attaches to the right-hand term. > +} > \ No newline at end of file Please do add this newline. :-) Moritz.

Re: [FFmpeg-devel] [PATCH v3 4/4] avformat/libopenmpt: Probe file format from file data if possible

2018-01-23 Thread Jörn Heusipp
On 01/11/2018 09:11 AM, Jörn Heusipp wrote: Signed-off-by: Jörn Heusipp --- libavformat/libopenmpt.c | 57 1 file changed, 57 insertions(+) Does anyone have any further comments on patches 3/4 and 4/4?

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-23 Thread Devin Heitmueller
Hi Ray, > On Jan 22, 2018, at 11:20 PM, Ray Tiley wrote: > > I'm reading 334-1:2017 Sec 4 > "When the ANC packets defined in this standard are carried in a high > definition signal, they shall be carried in the Y stream." > > I couldn't find anywhere in the document where

[FFmpeg-devel] [PATCH v2] libopus: support disabling phase inversion.

2018-01-23 Thread Menno
Renamed the option. I looked into adding support on the decoder side but things look a bit different there (e.g. there aren't any cli params set up yet.) Is it OK to merge this first and I can work on the decoder later? Signed-off-by: Menno --- doc/encoders.texi | 5

[FFmpeg-devel] [PATCH 2/2] examples/filtering_video: added loop for draining the filtergraph

2018-01-23 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- doc/examples/filtering_video.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/examples/filtering_video.c b/doc/examples/filtering_video.c index 9b607ba..be00a1b 100644 --- a/doc/examples/filtering_video.c +++

[FFmpeg-devel] [PATCH 1/2] examples/filtering_audio: added loop for draining the filtergraph

2018-01-23 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- doc/examples/filtering_audio.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/examples/filtering_audio.c b/doc/examples/filtering_audio.c index 18d6ca2..070d0cb3 100644 --- a/doc/examples/filtering_audio.c +++