Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: use a linked list to queue packets

2018-02-20 Thread wm4
On Wed, 21 Feb 2018 00:08:45 -0300 James Almer wrote: > It's more robust and efficient. > > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 90 > +++ > 1 file changed, 52 insertions(+), 38

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-20 Thread Gyan Doshi
On 2/21/2018 3:03 AM, Carl Eugen Hoyos wrote: 2018-02-20 16:17 GMT+01:00 Gyan Doshi : Please also mention LPCM. Only 16-bit LPCM BE can be muxed, which is mentioned. Regards, Gyan ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Maksym Veremeyenko
21.02.2018 0:39, Carl Eugen Hoyos пише: 2018-02-20 23:35 GMT+01:00 Marton Balint : On Tue, 20 Feb 2018, Carl Eugen Hoyos wrote: 2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : attached patch implement dynamic loading of NewTek library and drop

Re: [FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

2018-02-20 Thread Alex Converse
On Tue, Feb 20, 2018 at 4:56 PM, Dale Curtis wrote: > On Tue, Feb 20, 2018 at 4:18 PM, Alex Converse > wrote: > >> >> I would make this uint8_t >> > > Done. > > >> I would drop this stack struck and replace the leaf get_bits() with >> skip bits.

[FFmpeg-devel] [PATCH 2/2] avcodec/cavsdec: Check alpha/beta offset

2018-02-20 Thread Michael Niedermayer
Fixes: Integer overflow Fixes: 6183/clusterfuzz-testcase-minimized-6269224436629504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cavsdec.c | 5 + 1 file changed,

[FFmpeg-devel] [PATCH 1/2] avcodec/exr: fix invalid shift in unpack_14()

2018-02-20 Thread Michael Niedermayer
Fixes: 6154/clusterfuzz-testcase-minimized-5762231061970944 Fixes: runtime error: shift exponent 63 is too large for 32-bit type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH] avformat/matroskadec: use a linked list to queue packets

2018-02-20 Thread James Almer
It's more robust and efficient. Signed-off-by: James Almer --- libavformat/matroskadec.c | 90 +++ 1 file changed, 52 insertions(+), 38 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index

Re: [FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

2018-02-20 Thread Dale Curtis
On Tue, Feb 20, 2018 at 4:18 PM, Alex Converse wrote: > > I would make this uint8_t > Done. > I would drop this stack struck and replace the leaf get_bits() with > skip bits. It makes the code that much harder to exploit and there is > no point in storing data we

[FFmpeg-devel] [PATCH] Added support for version field flag 0x04 in OpenEXR files

2018-02-20 Thread Daniel Flehner Heen
Hi! First time poster so please excuse any mistakes made. I've tried submitting a patch through git send-email but got issues authentication through gmail. Attached is a patch file created with git format-patch. Commit message: Added support for version field flag 0x04 in OpenEXR files

Re: [FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

2018-02-20 Thread Alex Converse
On Tue, Feb 20, 2018 at 3:37 PM, Dale Curtis wrote: > From 97380752ef12337d9b9a01801a9a84df3b4b9c0a Mon Sep 17 00:00:00 2001 > From: Dale Curtis > Date: Thu, 15 Feb 2018 16:22:55 -0800 > Subject: [PATCH] [aacdec] Parse and drop gain control data,

[FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

2018-02-20 Thread Dale Curtis
This will result in poor quality audio for SSR streams, but they will at least demux and decode without error; partially fixing ticket #1693. This just pulls in the decode_gain_control() function from the ffmpeg summer-of-code repo (original author Robert Swain) at

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Carl Eugen Hoyos
2018-02-20 23:35 GMT+01:00 Marton Balint : > > On Tue, 20 Feb 2018, Carl Eugen Hoyos wrote: > >> 2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : >> >>> attached patch implement dynamic loading of NewTek library and >>> drop dependencies from NewTek SDK (if

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Marton Balint
On Tue, 20 Feb 2018, Carl Eugen Hoyos wrote: 2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : attached patch implement dynamic loading of NewTek library and drop dependencies from NewTek SDK (if previous patch with including headers applied) This patch is not ok assuming

Re: [FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Carl Eugen Hoyos
2018-02-20 17:32 GMT+01:00 Maksym Veremeyenko : > attached patch implement dynamic loading of NewTek library and > drop dependencies from NewTek SDK (if previous patch with > including headers applied) This patch is not ok assuming the runtime library is not open source and

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-20 Thread Carl Eugen Hoyos
2018-02-20 16:17 GMT+01:00 Gyan Doshi : Please also mention LPCM. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/tls: pass numeric hostnames to tls_connect_cbs()

2018-02-20 Thread Carl Eugen Hoyos
2018-02-20 19:40 GMT+01:00 Stefan _ : > attached patch fixes a small issue with the libtls backend. Please mention ticket #7029 if it is related. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 06:28:20PM +0100, wm4 wrote: > On Tue, 20 Feb 2018 17:30:32 +0100 > Michael Niedermayer wrote: > > > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > > On 2/20/2018 9:21 AM, wm4 wrote: > > > > On Tue, 20 Feb 2018 08:47:51 -0300 >

Re: [FFmpeg-devel] [PATCH v2 2/3] libavfilter/vf_fps: Rewrite using activate callback

2018-02-20 Thread Calvin Walton
I've found one minor problem with this patch. The actual functionality is correct, as best I can tell, but the stats collection (dropped/duplicated frames) will under-report dropped frames in my testing. I'm going to rework the stats collection code a bit, but I expect this to be a relatively

[FFmpeg-devel] [PATCH] libavformat/tls: pass numeric hostnames to tls_connect_cbs()

2018-02-20 Thread Stefan _
Hi, attached patch fixes a small issue with the libtls backend. reported here: https://github.com/shinchiro/mpv-winbuild-cmake/issues/61 From 4bba90874839cf98ac27756c4a3137be4c84c669 Mon Sep 17 00:00:00 2001 From: sfan5 Date: Tue, 20 Feb 2018 19:18:13 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 02:02:14PM -0300, James Almer wrote: > On 2/20/2018 1:30 PM, Michael Niedermayer wrote: > > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > >> On 2/20/2018 9:21 AM, wm4 wrote: > >>> On Tue, 20 Feb 2018 08:47:51 -0300 > >>> James Almer

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 04:44:13PM +, Rostislav Pehlivanov wrote: > On 20 February 2018 at 16:30, Michael Niedermayer > wrote: > > > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > > On 2/20/2018 9:21 AM, wm4 wrote: > > > > On Tue, 20 Feb 2018

Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread Nicolas George
Maksym Veremeyenko (2018-02-20): > attached patch add a NewTek NDI headers to source tree. I am against this, and the second patch, based on principles: this is helping NewTek circumvent the GPL. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread Ricardo Constantino
On 20 February 2018 at 16:32, Maksym Veremeyenko wrote: > Hi > > attached patch add a NewTek NDI headers to source tree. > > these headers is under MIT license. > > please apply. > Also, there's still no consideration that there's other compilers in Windows other than MSVC:

Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread wm4
On Tue, 20 Feb 2018 18:32:48 +0200 Maksym Veremeyenko wrote: > Hi > > attached patch add a NewTek NDI headers to source tree. > > these headers is under MIT license. > > please apply. > As it was concluded in the discussion about the AMD headers, we don't accept vendor

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread wm4
On Tue, 20 Feb 2018 17:30:32 +0100 Michael Niedermayer wrote: > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > On 2/20/2018 9:21 AM, wm4 wrote: > > > On Tue, 20 Feb 2018 08:47:51 -0300 > > > James Almer wrote: > > > > > >>> It

[FFmpeg-devel] [PATCH v3] lavf/mpegts: add supplementary audio descriptor

2018-02-20 Thread Stefan Pöschel
The supplementary audio descriptor is defined in ETSI EN 300 468 and provides more details regarding accessibility audio tracks, especially the normative annex J contains a detailed description of its use. Its language code (if present) overrides the language code of an also present ISO 639

Re: [FFmpeg-devel] [PATCH v2] lavf/mpegts: add supplementary audio descriptor

2018-02-20 Thread Stefan Pöschel
Am 20.02.2018 um 00:13 schrieb Marton Balint: >>> +    if (ext_desc_tag == 0x06) { /* supplementary audio descriptor */ >>> +    char flags; > > Change this to int, I see no reason why this is a char. OK, I will fix that with v3. >> LGTM. Will commit in a couple days along with my

Re: [FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread Ricardo Constantino
On 20 February 2018 at 16:32, Maksym Veremeyenko wrote: > Hi > > attached patch add a NewTek NDI headers to source tree. > > these headers is under MIT license. > > please apply. > Why not make them available in a public git repository instead? FFmpeg is trying to remove

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread James Almer
On 2/20/2018 1:30 PM, Michael Niedermayer wrote: > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: >> On 2/20/2018 9:21 AM, wm4 wrote: >>> On Tue, 20 Feb 2018 08:47:51 -0300 >>> James Almer wrote: >>> > It has fully achieved its objectives. There's no more

Re: [FFmpeg-devel] FFmpeg 3.5 / 4.0

2018-02-20 Thread Reto Kromer
Reto Kromer wrote: >I suggest as well to move the 2.8 branch from the Releases to >the Old Releases. I just noticed that the day before yesterday 2.8.14 has been released, therefore please ignore my suggestion. Thank you! ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Rostislav Pehlivanov
On 20 February 2018 at 16:30, Michael Niedermayer wrote: > On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > > On 2/20/2018 9:21 AM, wm4 wrote: > > > On Tue, 20 Feb 2018 08:47:51 -0300 > > > James Almer wrote: > > > > > >>> It has fully

[FFmpeg-devel] [PATCH 2/2] Implement dynamic loading of NewTek NDI library

2018-02-20 Thread Maksym Veremeyenko
Hi attached patch implement dynamic loading of NewTek library and drop dependencies from NewTek SDK (if previous patch with including headers applied) please review/comment/apply -- Maksym Veremeyenko From 8c0337878bdb8a1ccbc56ede42686e2a4d8e882e Mon Sep 17 00:00:00 2001 From: Maksym

[FFmpeg-devel] [PATCH 1/2] Add NewTek NDI headers

2018-02-20 Thread Maksym Veremeyenko
Hi attached patch add a NewTek NDI headers to source tree. these headers is under MIT license. please apply. -- Maksym Veremeyenko From 1f0ac55ce4da973f8def3ab24a70381007382cb8 Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko Date: Tue, 20 Feb 2018 17:14:46 +0200 Subject:

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread Michael Niedermayer
On Tue, Feb 20, 2018 at 10:17:02AM -0300, James Almer wrote: > On 2/20/2018 9:21 AM, wm4 wrote: > > On Tue, 20 Feb 2018 08:47:51 -0300 > > James Almer wrote: > > > >>> It has fully achieved its objectives. There's no more visible global > >>> mutable state, and the actual

[FFmpeg-devel] [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams

2018-02-20 Thread Gyan Doshi
From f0aabc7b9f959dc94084fb6d9b644104fc203566 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 20 Feb 2018 20:42:21 +0530 Subject: [PATCH 2/2] avformat/mpegenc - reject unsupported audio streams Only MP2, MP3, PCM S16BE, AC3 and DTS audio codecs are supported by the

[FFmpeg-devel] [PATCH 1/2] avformat/mpegenc - log error msgs for unsupported LPCM streams

2018-02-20 Thread Gyan Doshi
From 5f5cc12ff449fecfe668ec4537b8f2bb16d896d7 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Tue, 20 Feb 2018 20:31:28 +0530 Subject: [PATCH 1/2] avformat/mpegenc - log error msgs for unsupported LPCM streams The MPEG-PS muxer only accepts PCM streams having up to 8

Re: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: addition of flag to fragment at every frame

2018-02-20 Thread Michael Niedermayer
On Mon, Feb 19, 2018 at 11:25:09AM +0530, vdi...@akamai.com wrote: > From: Vishwanath Dixit > > --- > libavformat/movenc.c | 10 +++--- > libavformat/movenc.h | 1 + > 2 files changed, 8 insertions(+), 3 deletions(-) will apply thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_templat: Fix integer overflow in apply_ltp()

2018-02-20 Thread Michael Niedermayer
On Sun, Feb 18, 2018 at 11:07:20PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1625276744 + -1041893960 cannot be > represented in type 'int' > Fixes: 5948/clusterfuzz-testcase-minimized-5791479856365568 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dwt: Fix integer overflows in sr_1d53()

2018-02-20 Thread Michael Niedermayer
On Sun, Feb 18, 2018 at 12:34:11AM +0100, Michael Niedermayer wrote: > Fixes: 5918/clusterfuzz-testcase-minimized-5120505435652096 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/diracdec: Use int64 in global mv to prevent overflow

2018-02-20 Thread Michael Niedermayer
On Sun, Feb 18, 2018 at 12:34:10AM +0100, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 361 * -6295541 cannot be > represented in type 'int' > Fixes: 5911/clusterfuzz-testcase-minimized-6450382197751808 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dxtory: Remove code that corrupts dimensions

2018-02-20 Thread Michael Niedermayer
On Sat, Feb 17, 2018 at 10:25:10PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 5796/clusterfuzz-testcase-minimized-5206729085157376 > > Does someone have a valid sample that triggers this path ? > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread James Almer
On 2/20/2018 9:21 AM, wm4 wrote: > On Tue, 20 Feb 2018 08:47:51 -0300 > James Almer wrote: > >>> It has fully achieved its objectives. There's no more visible global >>> mutable state, and the actual global mutable state has been reduced to >>> less than 5 codec entries. >>

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread wm4
On Tue, 20 Feb 2018 08:47:51 -0300 James Almer wrote: > > It has fully achieved its objectives. There's no more visible global > > mutable state, and the actual global mutable state has been reduced to > > less than 5 codec entries. > > It's true that after the deprecation

Re: [FFmpeg-devel] [PATCH 0/3] Finish new iteration APIs

2018-02-20 Thread James Almer
On 2/20/2018 3:24 AM, wm4 wrote: > On Mon, 19 Feb 2018 23:30:24 -0300 > James Almer wrote: > >> On 2/19/2018 11:16 PM, Michael Niedermayer wrote: >>> On Mon, Feb 19, 2018 at 09:57:35PM +0100, Hendrik Leppkes wrote: On Mon, Feb 19, 2018 at 8:30 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] segment: Create missing directories

2018-02-20 Thread Ricardo Constantino
On 20 February 2018 at 11:17, Georgi Chorbadzhiyski wrote: > The attached patch allows segment muxer to be used for file archiving by > allowing it to automatically create the output directories. For example the > following should work as expected: > > ffmpeg >

[FFmpeg-devel] [PATCH] segment: Create missing directories

2018-02-20 Thread Georgi Chorbadzhiyski
The attached patch allows segment muxer to be used for file archiving by allowing it to automatically create the output directories. For example the following should work as expected: ffmpeg ...input_params... -f segment \ -segment_atclocktime 1 \ -segment_time 5 \

[FFmpeg-devel] [PATCH] doc/filters: add links to ffmpeg-utils and ffmpeg documentation

2018-02-20 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- doc/filters.texi | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index bd93e0a..0f0ec10 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH] Add android_capture indev

2018-02-20 Thread Felix Matouschek
I rebased the patch on the current master, it does apply again. Tested it - still works. Felix Am 19.02.2018 20:39, schrieb Michael Niedermayer: On Mon, Feb 19, 2018 at 08:39:56AM +0100, Felix Matouschek wrote: Hello Michael, do you think the patch could be merged in its current state? It