[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-21 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 380 ++ 4 files changed, 383 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH 0/1] Add Sega FILM muxer

2018-03-21 Thread misty
From: Misty De Meo This adds a muxer for the Sega FILM format, which was used by Sega Saturn games in the 1990s. This muxer provides a complete implementation of the FILM format, at least as far as all features I've seen used in the wild, except that it currently doesn't

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-21 Thread Gyan Doshi
On 3/22/2018 2:02 AM, Carl Eugen Hoyos wrote: Can you comment on why this 15-year old code was wrong? It inverts the correct assignment of keyframe status. On the sample file uploaded to trac, the existing code marks the first frame as non-KF and all remaining frames as KF. Changed to

[FFmpeg-devel] [PATCH] avcodec/dxva2_vc1: add missing frame_params callback to vc1_d3d11va2 hwaccel

2018-03-21 Thread James Almer
Fixes ticket #7096 Signed-off-by: James Almer --- libavcodec/dxva2_vc1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dxva2_vc1.c b/libavcodec/dxva2_vc1.c index f22c73cd1e..06f1083b3a 100644 --- a/libavcodec/dxva2_vc1.c +++ b/libavcodec/dxva2_vc1.c @@ -473,6

Re: [FFmpeg-devel] [PATCH] cmdutils: print supported codecs in show_help_bsf()

2018-03-21 Thread James Almer
On 3/21/2018 10:57 PM, Jun Zhao wrote: > > > On 2018/3/22 9:11, James Almer wrote: >> Signed-off-by: James Almer >> --- >> fftools/cmdutils.c | 2 ++ >> fftools/cmdutils.h | 3 +++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c

[FFmpeg-devel] [PATCH] avcodec/vp9_raw_reorder: cache input packets using new references

2018-03-21 Thread James Almer
Input packets may not be ref counted, meaning the data described in them may be gone at any time. Fixes segfaults related to the above. Signed-off-by: James Almer --- libavcodec/vp9_raw_reorder_bsf.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-)

[FFmpeg-devel] [PATCH 0/1] re: Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo OK, requested changes made. Misty De Meo (1): Sega FILM: set dts and duration when demuxing libavformat/segafilm.c | 19 +++ 1 file changed, 19 insertions(+) -- 2.16.2 ___ ffmpeg-devel

[FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo --- libavformat/segafilm.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c index 11768823fc..03a639e034 100644 --- a/libavformat/segafilm.c +++ b/libavformat/segafilm.c @@ -270,6

Re: [FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread Rostislav Pehlivanov
On 22 March 2018 at 02:44, wrote: > From: Misty De Meo > > --- > Changelog | 1 + > libavformat/segafilm.c | 21 + > 2 files changed, 22 insertions(+) > > diff --git a/Changelog b/Changelog > index 7969b414c4..6b3b2bf7fe

[FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/segafilm.c | 21 + 2 files changed, 22 insertions(+) diff --git a/Changelog b/Changelog index 7969b414c4..6b3b2bf7fe 100644 --- a/Changelog +++ b/Changelog @@ -47,6 +47,7 @@ version : -

Re: [FFmpeg-devel] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo OK, made both requested changes. Misty De Meo (1): Sega FILM: set dts and duration when demuxing Changelog | 1 + libavformat/segafilm.c | 21 + 2 files changed, 22 insertions(+) -- 2.16.2

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-21 Thread Misty De Meo
On Wed, Mar 21, 2018 at 1:32 PM, Carl Eugen Hoyos wrote: > 2018-03-21 14:37 GMT+01:00, Gyan Doshi : > Can you comment on why this 15-year old code was wrong? I think it was de facto unused before now. Since it wasn't passed through to AVPacket it wasn't

[FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-21 Thread Josh de Kock
--- I have -ffunroll'd the macros for you Nicolas. fftools/cmdutils.c | 248 - 1 file changed, 129 insertions(+), 119 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 708a849f51..956eb7b974 100644 ---

[FFmpeg-devel] [PATCH 5/7] lavf, lavd: add AVClass for lavd & use iterate API

2018-03-21 Thread Josh de Kock
Add an AVClass for AVDevice as the .child_class_next member for lavf's AVClass will no longer find devices. --- fftools/cmdutils.c | 10 + fftools/ffmpeg_opt.c | 2 +- libavdevice/Makefile | 1 + libavdevice/avdevice.h | 1 + libavdevice/options.c | 115

Re: [FFmpeg-devel] [PATCH] cmdutils: print supported codecs in show_help_bsf()

2018-03-21 Thread Jun Zhao
On 2018/3/22 9:11, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/cmdutils.c | 2 ++ > fftools/cmdutils.h | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 708a849f51..c0ddf0b287 100644 > ---

[FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: move the reference in the bsf internal buffer

2018-03-21 Thread James Almer
There's no need to allocate a new packet for it. Signed-off-by: James Almer --- Now using av_packet_make_writable() to make sure the packet can be written to. libavcodec/noise_bsf.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: added alpha decompanding in rgba12

2018-03-21 Thread Gagandeep Singh
On Thu 22 Mar, 2018, 1:54 AM Carl Eugen Hoyos, wrote: > 2018-03-21 17:52 GMT+01:00, Gagandeep Singh : > > On Wed, 21 Mar 2018, 22:20 Gagandeep Singh, > > wrote: > > > ticket #6265 > > Should be part of the commit message.

[FFmpeg-devel] [PATCH] avcodec/mpeg4_unpack_bframes: make sure the packet is writable when data needs to changed

2018-03-21 Thread James Almer
Nothing currently guarantees that the packet passed to the bsf will be writable. Signed-off-by: James Almer --- This supersedes "[PATCH 2/2] avcodec/mpeg4_unpack_bframes: allocate a new packet when data needs to be changed" libavcodec/mpeg4_unpack_bframes_bsf.c | 3 +++ 1

Re: [FFmpeg-devel] [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options.

2018-03-21 Thread Jun Zhao
On 2018/3/22 9:05, James Almer wrote: > On 3/20/2018 2:59 AM, Jun Zhao wrote: >> Ping?  >> >> Anybody will help to review or apply: >> >> Subject: [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options. >> Subject: [PATCH V3 09/11] lavc/noise_bsf: support dump options. >> Subject: [PATCH

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_make_writable()

2018-03-21 Thread James Almer
On 3/21/2018 2:14 PM, James Almer wrote: > On 3/19/2018 1:49 PM, James Almer wrote: >> On 3/19/2018 1:32 PM, wm4 wrote: >>> On Mon, 19 Mar 2018 12:42:16 -0300 >>> James Almer wrote: >>> Useful as well to quickly make a packet reference counted when it isn't already

[FFmpeg-devel] [PATCH] cmdutils: print supported codecs in show_help_bsf()

2018-03-21 Thread James Almer
Signed-off-by: James Almer --- fftools/cmdutils.c | 2 ++ fftools/cmdutils.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 708a849f51..c0ddf0b287 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1907,6 +1907,8

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-21 Thread Carl Eugen Hoyos
2018-03-21 21:32 GMT+01:00, Carl Eugen Hoyos : > 2018-03-21 14:37 GMT+01:00, Gyan Doshi : >> Fix for ticket 7091. > >> -film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 0 : >> 1; >> +film->sample_table[i].keyframe = (scratch[8]

Re: [FFmpeg-devel] [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options.

2018-03-21 Thread James Almer
On 3/20/2018 2:59 AM, Jun Zhao wrote: > Ping?  > > Anybody will help to review or apply: > > Subject: [PATCH V3 04/11] lavc/dump_extradata_bsf: support dump options. > Subject: [PATCH V3 09/11] lavc/noise_bsf: support dump options. > Subject: [PATCH V3 10/11] lavc/remove_extradata_bsf: support

Re: [FFmpeg-devel] [PATCH v2] fftools/cmdutils: add support for level flag in loglevel option parser

2018-03-21 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 03:20:30PM +0100, Tobias Rapp wrote: > Allows to manage the AV_LOG_PRINT_LEVEL flag as a prefix to the loglevel > option value, similar to the existing AV_LOG_SKIP_REPEATED flag. > > Signed-off-by: Tobias Rapp > --- > doc/fftools-common-opts.texi

Re: [FFmpeg-devel] [PATCH v2 2/7] hwcontext_vaapi: Add support for legacy DRM mapping

2018-03-21 Thread Rostislav Pehlivanov
On 21 March 2018 at 23:12, Mark Thompson wrote: > The old vaAcquireBufferHandle() API works in fewer cases and provides > less information than the current vaExportSurfaceHandle(), but it exists > on older versions and is already used by the OpenCL code. > --- > Now we set the

[FFmpeg-devel] [PATCH v2 2/7] hwcontext_vaapi: Add support for legacy DRM mapping

2018-03-21 Thread Mark Thompson
The old vaAcquireBufferHandle() API works in fewer cases and provides less information than the current vaExportSurfaceHandle(), but it exists on older versions and is already used by the OpenCL code. --- Now we set the INVALID format modifier so that a user can distinguish between ESH with

[FFmpeg-devel] [PATCH v2 5/7] vf_crop: Add support for cropping hardware frames

2018-03-21 Thread Mark Thompson
Set the cropping fields in the AVFrame. --- libavfilter/vf_crop.c | 61 --- 1 file changed, 43 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 0fdc4949e3..0b1b8a048b 100644 --- a/libavfilter/vf_crop.c

[FFmpeg-devel] [PATCH v2 6/7] vf_scale_vaapi: Apply cropping rectangle to input

2018-03-21 Thread Mark Thompson
--- libavfilter/vf_scale_vaapi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_scale_vaapi.c b/libavfilter/vf_scale_vaapi.c index c19e23ccd0..d6529d5235 100644 --- a/libavfilter/vf_scale_vaapi.c +++ b/libavfilter/vf_scale_vaapi.c @@ -100,13

[FFmpeg-devel] [PATCH v2 3/7] hwcontext_vaapi: Pass correct read/write flags when exporting surfaces

2018-03-21 Thread Mark Thompson
--- libavutil/hwcontext_vaapi.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 998e954c44..53a5b02822 100644 --- a/libavutil/hwcontext_vaapi.c +++ b/libavutil/hwcontext_vaapi.c @@ -1095,15 +1095,20 @@

[FFmpeg-devel] [PATCH v2 7/7] doc/indevs: Add example using cropping to capture part of a plane

2018-03-21 Thread Mark Thompson
--- doc/indevs.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi index 6951940a93..02d1cb3d86 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -462,6 +462,14 @@ Capture from CRTC ID 42 at 60fps, map the result to VAAPI, convert to NV12 and e

[FFmpeg-devel] [PATCH v2 1/7] hwcontext_drm: Clarify value for unknown format modifiers

2018-03-21 Thread Mark Thompson
--- This will allow users such as EGL or Vulkan to detect whether the format modifier has actually been set or not. libavutil/hwcontext_drm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_drm.h b/libavutil/hwcontext_drm.h index 2e225451e1..42709f215e 100644 ---

[FFmpeg-devel] [PATCH v2 4/7] hwcontext_opencl: Add support for mapping DRM objects to Beignet

2018-03-21 Thread Mark Thompson
Also use that to support mapping VAAPI to Beignet. --- The Beignet interface can't actually do anything with the format modifier. configure| 16 +-- libavutil/hwcontext_opencl.c | 265 +-- 2 files changed, 139 insertions(+), 142

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: pass reference counted packets on codec copy when possible

2018-03-21 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 12:03:32PM -0300, James Almer wrote: > Should prevent unnecessary copy of data in cases where new references > to the packet are created within the muxer or a bitstream filter. > > Signed-off-by: James Almer > --- > fftools/ffmpeg.c | 5 + > 1 file

[FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Paul B Mahol
So user can pick which channels to extract. Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 ++ libavfilter/af_channelsplit.c | 39 +-- 2 files changed, 51 insertions(+), 6 deletions(-) diff --git

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Marton Balint
On Wed, 21 Mar 2018, Devin Heitmueller wrote: Hi James, No, this is done after that, while processing a packet. It is also making changes to the output codecpar after write_header() was called, which is wrong. libavformat used to delay writing the header until you feed it the first packet,

Re: [FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 09:14:44AM -0700, mi...@brew.sh wrote: > From: Misty De Meo > > --- > Changelog | 1 + > libavformat/segafilm.c | 24 > 2 files changed, 25 insertions(+) > > diff --git a/Changelog b/Changelog > index

Re: [FFmpeg-devel] [PATCH] lavf/utils.c: Don't compute start_time from DISCARD packets for video.

2018-03-21 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 01:35:05PM -0700, Sasi Inguva wrote: > Attaching fate sample. sample uploded thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

2018-03-21 Thread Courtland Idstrom
> > > Any way of verifying will do, even a hex editor. > > Output from Quicktime (screenshot of the movie inspector -- initial movie was created in ffmpeg, title added in quicktime, file saved: https://imgur.com/a/TPCkN) 00308ef0 00 00 00 21 75 64 74 61 00 00 00 15 6e 61 6d 65 |...!udta

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Alexander Strasser
Hi Paul! On 2018-03-20 19:11 +0100, Paul B Mahol wrote: > So user can pick which channels to extract. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 > libavfilter/af_channelsplit.c | 54 > +++ >

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Nicolas George
Paul B Mahol (2018-03-21): > I have legitimate technical concert about your faulty review. Seriously, have you no pride at all for the quality of your code? Personally, I would feel ashamed to publish that code, let alone defend it if somebody points the flaw to me. > There is log message which

[FFmpeg-devel] [PATCH] lavf/utils.c: Don't compute start_time from DISCARD packets for video.

2018-03-21 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/utils.c | 4 +++- tests/fate/mov.mak| 10 +++- tests/ref/fate/mov-neg-firstpts-discard | 3 +++ .../ref/fate/mov-neg-firstpts-discard-frames | 24

[FFmpeg-devel] [PATCH] lavf/utils.c: Don't compute start_time from DISCARD packets for video.

2018-03-21 Thread Sasi Inguva
Signed-off-by: Sasi Inguva --- libavformat/utils.c | 4 +++- tests/fate/mov.mak | 10 +- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 4d0b56c2a8..f13c8208b1 100644 ---

Re: [FFmpeg-devel] [PATCH] lavf/utils.c: Don't compute start_time from DISCARD packets for video.

2018-03-21 Thread Sasi Inguva
Attaching fate sample. On Wed, Mar 21, 2018 at 1:33 PM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/utils.c | 4 +++- > tests/fate/mov.mak | 10 +- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Paul B Mahol
On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> It is hardly identical, and I can not read your mind. > > More than half the block is identical to the previous one. > >> And it is functionally incompatible. > > I told you how you can factor it. > >> Enough

Re: [FFmpeg-devel] [PATCH] lavf/utils.c: Don't compute start_time from DISCARD packets for video.

2018-03-21 Thread Sasi Inguva
Sorry, forgot to add the test reference files. Sending the revised patch. On Wed, Mar 21, 2018 at 1:35 PM, Sasi Inguva wrote: > Attaching fate sample. > > On Wed, Mar 21, 2018 at 1:33 PM, Sasi Inguva wrote: > >> Signed-off-by: Sasi Inguva

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-21 Thread Carl Eugen Hoyos
2018-03-21 14:37 GMT+01:00, Gyan Doshi : > Fix for ticket 7091. > -film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 0 : 1; > +film->sample_table[i].keyframe = (scratch[8] & 0x80) ? 1 : 0; Can you comment on why this 15-year old code was wrong?

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Nicolas George
Paul B Mahol (2018-03-21): > It is hardly identical, and I can not read your mind. More than half the block is identical to the previous one. > And it is functionally incompatible. I told you how you can factor it. > Enough bikesheds from you! This is a legitimate technical concern:

Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-21 Thread Carl Eugen Hoyos
2018-03-21 16:33 GMT+01:00, sanilraut : > +if(pls->last_seq_no == 0){ Please add a space to avoid mixing styles: "if (" We usually use "if (!pls->last_seq_no)", same above. > +pls->last_seq_no = calc_max_seg_no(pls, s->priv_data); > +} Carl Eugen

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Paul B Mahol
On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> >> +uint64_t channel_layout; >> >> +int nb_extracted_channels; >> > Inconsistent variable names. >> I dont follow. > > The two variables describe the same entity, they should have the same > base

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: added alpha decompanding in rgba12

2018-03-21 Thread Carl Eugen Hoyos
2018-03-21 17:52 GMT+01:00, Gagandeep Singh : > On Wed, 21 Mar 2018, 22:20 Gagandeep Singh, > wrote: > ticket #6265 Should be part of the commit message. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Devin Heitmueller
Hi James, > No, this is done after that, while processing a packet. > It is also making changes to the output codecpar after write_header() > was called, which is wrong. > > libavformat used to delay writing the header until you feed it the first > packet, an internal functionality this code

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Devin Heitmueller
Hi Marton, > As far as I remember ffmpeg.c has code for this around line 1220: > > if (in_picture->interlaced_frame) { > if (enc->codec->id == AV_CODEC_ID_MJPEG) >mux_par->field_order = in_picture->top_field_first ? > AV_FIELD_TT:AV_FIELD_BB; > else >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: initialize saveptrs

2018-03-21 Thread Timo Rothenpieler
Am 21.03.2018 um 20:33 schrieb Timo Rothenpieler: av_strtok calls strspn on a non-NULL *saveptr, so not NULL initializing it is an issue. Fixes CID #1428568 --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH] avformat/hlsenc: initialize saveptrs

2018-03-21 Thread Timo Rothenpieler
av_strtok calls strspn on a non-NULL *saveptr, so not NULL initializing it is an issue. Fixes CID #1428568 --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index b7c6fbde6a..fa17776efe 100644 ---

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread James Almer
On 3/21/2018 4:18 PM, Marton Balint wrote: > > > On Wed, 21 Mar 2018, Devin Heitmueller wrote: > >> Hello, >> >> I’m doing some debugging of format selection for the decklink device, >> and in particular trying to get it to properly support interlaced >> formats.  One thing that came to my

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Marton Balint
On Wed, 21 Mar 2018, Devin Heitmueller wrote: Hello, I’m doing some debugging of format selection for the decklink device, and in particular trying to get it to properly support interlaced formats. One thing that came to my attention was the following commit:

Re: [FFmpeg-devel] [PATCH] avformat/unix: handling EOF in case of SOCK_STREAM

2018-03-21 Thread Nicolas George
Bodecs Bela (2018-03-21): > thank you, I have no commit rights. Ok, pushed. Thanks for the fix. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Nicolas George
Paul B Mahol (2018-03-21): > >> +uint64_t channel_layout; > >> +int nb_extracted_channels; > > Inconsistent variable names. > I dont follow. The two variables describe the same entity, they should have the same base name: nb_extracted_channels and extracted_channels, obviously. >

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Paul B Mahol
On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-20): >> So user can pick which channels to extract. >> >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 15 >> libavfilter/af_channelsplit.c | 54 >>

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_make_writable()

2018-03-21 Thread James Almer
On 3/19/2018 1:49 PM, James Almer wrote: > On 3/19/2018 1:32 PM, wm4 wrote: >> On Mon, 19 Mar 2018 12:42:16 -0300 >> James Almer wrote: >> >>> Useful as well to quickly make a packet reference counted when it >>> isn't already so. >>> >>> Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: added alpha decompanding in rgba12

2018-03-21 Thread Gagandeep Singh
On Wed, 21 Mar 2018, 22:20 Gagandeep Singh, wrote: > alpha decompanding curve added to post process the decoded alpha channel > --- > libavcodec/cfhd.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c

[FFmpeg-devel] [PATCH] lavc/cfhd: added alpha decompanding in rgba12

2018-03-21 Thread Gagandeep Singh
alpha decompanding curve added to post process the decoded alpha channel --- libavcodec/cfhd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c index fd834b..e35732df45 100644 --- a/libavcodec/cfhd.c +++ b/libavcodec/cfhd.c @@

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Nicolas George
Paul B Mahol (2018-03-20): > So user can pick which channels to extract. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 > libavfilter/af_channelsplit.c | 54 > +++ > 2 files changed, 60

Re: [FFmpeg-devel] [PATCH] avformat/unix: handling EOF in case of SOCK_STREAM

2018-03-21 Thread Bodecs Bela
2018.03.21. 17:36 keltezéssel, Nicolas George írta: Bodecs Bela (2018-03-20): >From 3a022da0ebd01b65fd3beed95a13ea0f0fcabb20 Mon Sep 17 00:00:00 2001 From: Bela Bodecs Date: Tue, 20 Mar 2018 23:24:11 +0100 Subject: [PATCH] avformat/unix: handling EOF in case of

Re: [FFmpeg-devel] [RFC] Proposing new filter: extractchannels

2018-03-21 Thread Nicolas George
Paul B Mahol (2018-03-20): > pan filter would need asplit filter for multiple channels extractions. You could propose a patch to automatically insert the (a)split filter when a pad is referenced several times in a graph description. > pan syntax is hardly user-friendly. What? What do you find

[FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/segafilm.c | 24 2 files changed, 25 insertions(+) diff --git a/Changelog b/Changelog index 7969b414c4..6b3b2bf7fe 100644 --- a/Changelog +++ b/Changelog @@ -47,6 +47,7 @@ version :

Re: [FFmpeg-devel] [PATCH] avformat/unix: properly handling timeout at reading

2018-03-21 Thread Nicolas George
Bodecs Bela (2018-03-21): > Should not the unix_write behaves the  same? so, when > > ret = send(s->fd, buf, size, MSG_NOSIGNAL); > > return 0 in case of SOCK_STREAM type, then the unix_write() should return > AVERROR_EOF instead of 0? No: there is no EOF reporting on writing, since the

Re: [FFmpeg-devel] [PATCH] avformat/unix: handling EOF in case of SOCK_STREAM

2018-03-21 Thread Nicolas George
Bodecs Bela (2018-03-20): > >From 3a022da0ebd01b65fd3beed95a13ea0f0fcabb20 Mon Sep 17 00:00:00 2001 > From: Bela Bodecs > Date: Tue, 20 Mar 2018 23:24:11 +0100 > Subject: [PATCH] avformat/unix: handling EOF in case of SOCK_STREAM > > when recv() returns 0 in case of

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: alpha decompanding added to rgba12 output

2018-03-21 Thread Paul B Mahol
On 3/21/18, Gagandeep Singh wrote: > decompanding curve or offset were required ticket #6265 > --- > libavcodec/cfhd.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index a064cd1599..480bf93566

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: alpha decompanding added to rgba12 output

2018-03-21 Thread Gagandeep Singh
Guys, can you analyse this patch. On Wed, 21 Mar 2018, 10:25 Gagandeep Singh, wrote: > decompanding curve or offset were required ticket #6265 > --- > libavcodec/cfhd.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/cfhd.c

[FFmpeg-devel] [PATCH 0/1] Sega FILM: set timestamps when demuxing

2018-03-21 Thread misty
From: Misty De Meo Timestamp information isn't currently set when demuxing Sega FILM videos, which breaks direct stream copy of packets into certain other containers. I've tested with my WIP Sega FILM muxer, which creates valid .CPK files copying packets from existing .CPK

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread wm4
On Wed, 21 Mar 2018 16:07:32 +0100 Nicolas George wrote: > Paul B Mahol (2018-03-21): > > I can't wait. > > Sure you can. Easy: go read wikipedia, go watch youtobe, go run in the > neighbourhood, go read a book. Do you need more ideas? > > > You could instead of

Re: [FFmpeg-devel] [PATCH] avformat/unix: properly handling timeout at reading

2018-03-21 Thread Bodecs Bela
2018.03.20. 22:41 keltezéssel, Nicolas George írta: Bodecs Bela (2018-03-20): start a. and in a separate terminal window start b.  After 10 seconds a. terminates but b. remains running on infinite time. Ok, got it. But I expected b. to

[FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-21 Thread sanilraut
Last segment indicated by mpd is not parsed. Example stream: http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd This patch supports parsing of Supplemental Descriptor with @schemeIdUri set to http://dashif.org/guide- lines/last-segment-number with

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Paul B Mahol
On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> I can't wait. > > Sure you can. Easy: go read wikipedia, go watch youtobe, go run in the > neighbourhood, go read a book. Do you need more ideas? > >> You could instead of spending time replying to

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Nicolas George
Paul B Mahol (2018-03-21): > I can't wait. Sure you can. Easy: go read wikipedia, go watch youtobe, go run in the neighbourhood, go read a book. Do you need more ideas? > You could instead of spending time replying to this mails > do review patches. Are you under the

[FFmpeg-devel] [PATCH 2/2] ffmpeg: pass reference counted packets on codec copy when possible

2018-03-21 Thread James Almer
Should prevent unnecessary copy of data in cases where new references to the packet are created within the muxer or a bitstream filter. Signed-off-by: James Almer --- fftools/ffmpeg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c

[FFmpeg-devel] [PATCH 1/2] ffmpeg: remove dead call to av_parser_change()

2018-03-21 Thread James Almer
It's been a noop for years, and it's been argued that in-band headers should not be forcedly removed without the user's explicit request. Also, as the FIXME line stated, this is a job for a bitstream filter like extract_extradata, remove_extradata, dump_extradata, and filter_units.

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Paul B Mahol
On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> Enough hours passed, time to apply. > > Stop being ridiculous. Wait three days at least, then ping, then wait > one week more if there are no answers. I can't wait. You could instead of spending time replying to

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Nicolas George
Paul B Mahol (2018-03-21): > Enough hours passed, time to apply. Stop being ridiculous. Wait three days at least, then ping, then wait one week more if there are no answers. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

2018-03-21 Thread Derek Buitenhuis
On 3/21/2018 2:30 AM, Courtland Idstrom wrote: > What can I do to facilitate this? Would it help to create a couple of > samples from QuickTime Pro, and perhaps show the metadata atoms as > displayed by ffprobe -v trace? Any way of verifying will do, even a hex editor. - Derek

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

2018-03-21 Thread Paul B Mahol
On 3/20/18, Paul B Mahol wrote: > On 3/20/18, Nicolas George wrote: >> Paul B Mahol (2018-03-20): >>> Please comment, comitting ASAP. >> >> Three hours? Really? >> >> Seriously, what is your rush? > > It is snowing, and electricity is near full depletion. >

[FFmpeg-devel] [PATCH] avcodec/mpeg4_unpack_bframes: cache input packets directly

2018-03-21 Thread James Almer
Avoids unnecessary allocs+copies and makes the code slightly simpler. Signed-off-by: James Almer --- libavcodec/mpeg4_unpack_bframes_bsf.c | 55 +-- 1 file changed, 20 insertions(+), 35 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2] fftools/cmdutils: add support for level flag in loglevel option parser

2018-03-21 Thread Tobias Rapp
Allows to manage the AV_LOG_PRINT_LEVEL flag as a prefix to the loglevel option value, similar to the existing AV_LOG_SKIP_REPEATED flag. Signed-off-by: Tobias Rapp --- doc/fftools-common-opts.texi | 11 +++ fftools/cmdutils.c | 26

[FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Devin Heitmueller
Hello, I’m doing some debugging of format selection for the decklink device, and in particular trying to get it to properly support interlaced formats. One thing that came to my attention was the following commit:

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-21 Thread wm4
On Tue, 20 Mar 2018 23:59:46 +0100 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_scale.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_scale.c

[FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-21 Thread Gyan Doshi
Fix for ticket 7091. Regards, Gyan From 24a68eca54a5051b3386664f07d21358aa0db02d Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Wed, 21 Mar 2018 18:59:33 +0530 Subject: [PATCH] avformat/segafilm - fix keyframe detection and set packet flags Streams from a Segafilm cpk

Re: [FFmpeg-devel] [PATCH] lavfi: Add OpenCL avgblur filter

2018-03-21 Thread Dylan Fernando
On Tue, Mar 20, 2018 at 10:34 AM, Mark Thompson wrote: > On 19/03/18 02:30, dylanf...@gmail.com wrote: > > From: drfer3 > > > > Behaves like the existing avgblur filter, except working on OpenCL > > hardware frames. Takes exactly the same options. > >

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/libopenmpt: Probe file format from file data if possible

2018-03-21 Thread Jörn Heusipp
On 03/20/2018 10:37 PM, Michael Niedermayer wrote: On Sun, Mar 18, 2018 at 09:10:47PM +, Josh de Kock wrote: On 2018/03/18 8:23, wm4 wrote: On Sun, 18 Mar 2018 08:44:12 +0100 Jörn Heusipp wrote: On 03/04/2018 08:55 AM, Jörn Heusipp wrote: On

Re: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: add logflags option

2018-03-21 Thread Tobias Rapp
On 21.03.2018 00:04, Michael Niedermayer wrote: On Tue, Mar 20, 2018 at 09:36:51AM +0100, Tobias Rapp wrote: On 20.03.2018 02:44, Michael Niedermayer wrote: On Mon, Mar 19, 2018 at 09:31:44AM +0100, Tobias Rapp wrote: On 14.03.2018 09:55, Tobias Rapp wrote: Allows to set the

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-21 Thread Paul B Mahol
On 3/20/18, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_scale.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c > index

[FFmpeg-devel] [PATCH 1/2] lavf: make overlay_qsv work based on framesync.

2018-03-21 Thread Ruiling Song
the previous version which was cherry-picked from Libav does not work with FFmpeg framework, because ff_request_frame() was totally different between Libav and FFmpeg. So, I make it work through using framesync. Some other fixing that is needed to run overlay_qsv was put in another separate patch.

[FFmpeg-devel] [PATCH 2/2] lavf: clone the frame managed by framework.

2018-03-21 Thread Ruiling Song
we should clone the frame, which is managed by the framework. directly assign it will cause double-free issue when qsv try to free it. In fact, the frames was managed by the framework! Right now, I am still not quite sure why we receive 'more data' error from libmfx. But some simple debugging