[FFmpeg-devel] [PATCH] lavc/videotoolbox: fix failure to decode PAFF

2018-03-28 Thread Rodger Combs
--- libavcodec/videotoolbox.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index f82c31c5df..57b6698e1b 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -326,11 +326,8 @@ static int

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Michael Niedermayer
On Wed, Mar 28, 2018 at 09:35:12PM +0300, Jan Ekström wrote: > On Wed, Mar 28, 2018 at 9:12 PM, Michael Niedermayer > wrote: > >> +/** > >> + * An in-order array of entries for the given timeline. > >> + * Each entry contains information on which samples to

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Michael Niedermayer
On Wed, Mar 28, 2018 at 07:53:31PM +0100, Derek Buitenhuis wrote: > On 3/28/2018 7:49 PM, wm4 wrote: > > You just need to change * to **. Then the size of the struct doesn't > > matter anymore for array access and can be excluded from the ABI. > > To be thorough: Does anyone else have opinions on

Re: [FFmpeg-devel] [GSOC] [PATCH] SRCNN filter

2018-03-28 Thread Michael Niedermayer
On Wed, Mar 28, 2018 at 11:17:40AM +0300, Sergey Lavrushkin wrote: > > [...] > > > +#define OFFSET(x) offsetof(SRCNNContext, x) > > > +#define FLAGS AV_OPT_FLAG_FILTERING_PARAM | AV_OPT_FLAG_VIDEO_PARAM > > > +static const AVOption srcnn_options[] = { > > > +{ "config_file", "path to

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-28 Thread Jan Ekström
On Thu, Mar 29, 2018 at 12:53 AM, Jan Ekström wrote: > From: Jan Ekström > > With some streams multiple nullptr AVSubtitles can get pushed > into sub2video_update() in a row. > > This causes end_pts, and on the next round pts, to become > INT64_MAX,

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: Make sure the input bitstream with padding can be addressed

2018-03-28 Thread Michael Niedermayer
On Wed, Mar 28, 2018 at 01:11:06AM -0300, James Almer wrote: > On 3/25/2018 9:13 PM, Michael Niedermayer wrote: > > On Sat, Mar 24, 2018 at 01:56:26AM +0100, Michael Niedermayer wrote: > >> Signed-off-by: Michael Niedermayer > >> --- > >> libavcodec/get_bits.h | 3 ++- >

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

2018-03-28 Thread Michael Niedermayer
On Tue, Mar 27, 2018 at 02:26:45AM +0300, Даниил Чередник wrote: > Now it should be fine. Second patch has been fixed. > > On Mon, Mar 26, 2018 at 3:59 PM, Даниил Чередник > wrote: > > > Hi. > > Yes, I reproduced it on mac. A bit strange, I run fate with valgrind > >

Re: [FFmpeg-devel] [PATCHv2] avfilter/af_pan: reject expressions referencing the same channel multiple times

2018-03-28 Thread Marton Balint
On Sun, 25 Mar 2018, Nicolas George wrote: Marton Balint (2018-03-25): Fixes parsing of expressions like c0=c0+c0 or c0=c0|c0=c1. Previously no error was thrown and for input channels, only the last gain factor was used, for output channels the source channel gains were combined.

Re: [FFmpeg-devel] [PATCHv2 1/2] ffmpeg: fallback to codecpar parameters on input filter eof

2018-03-28 Thread Marton Balint
On Sat, 24 Mar 2018, Marton Balint wrote: Fixes ticket #6854 and the following simpler case: ffmpeg -f lavfi -i testsrc=d=1 -f lavfi -i testsrc=d=0 -filter_complex overlay -f null none Signed-off-by: Marton Balint --- fftools/ffmpeg.c | 33 +

[FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

2018-03-28 Thread Jan Ekström
From: Jan Ekström With some streams multiple nullptr AVSubtitles can get pushed into sub2video_update() in a row. This causes end_pts, and on the next round pts, to become INT64_MAX, latter of which signals EOF in framesync, leading to complete loss of subtitles from

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add eac3_core bitstream filter

2018-03-28 Thread James Almer
On 3/28/2018 4:53 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/bitstream_filters.texi | 4 ++ > libavcodec/Makefile| 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/eac3_core_bsf.c | 86 >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add eac3_core bitstream filter

2018-03-28 Thread Paul B Mahol
On 3/28/18, James Almer wrote: > On 3/28/2018 4:00 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/bitstream_filters.texi | 4 +++ >> libavcodec/Makefile| 1 + >> libavcodec/bitstream_filters.c | 1 + >>

[FFmpeg-devel] [PATCH 2/2] avcodec: add eac3_core bitstream filter

2018-03-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/bitstream_filters.texi | 4 ++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/eac3_core_bsf.c | 86 ++ 4 files changed, 92 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add eac3_core bitstream filter

2018-03-28 Thread James Almer
On 3/28/2018 4:00 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/bitstream_filters.texi | 4 +++ > libavcodec/Makefile| 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/eac3_core_bsf.c | 80 >

[FFmpeg-devel] [PATCH 1/2] avcodec/eac3: add support for dependent stream

2018-03-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/aac_ac3_parser.c | 9 ++- libavcodec/ac3_parser.c | 2 +- libavcodec/ac3dec.c | 177 +++- libavcodec/ac3dec.h | 10 ++- libavcodec/eac3dec.c| 11 +--

[FFmpeg-devel] [PATCH 2/2] avcodec: add eac3_core bitstream filter

2018-03-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/bitstream_filters.texi | 4 +++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/eac3_core_bsf.c | 80 ++ 4 files changed, 86 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread James Almer
On 3/28/2018 3:47 PM, Nicolas George wrote: > Derek Buitenhuis (2018-03-28): >> Do you have an actual suggest though? > > Maybe not using a badly designed API that requires everything to be > stored in a serialized uint8_t array. > >> Afaict, this is exactly

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread James Almer
On 3/28/2018 3:53 PM, Derek Buitenhuis wrote: > On 3/28/2018 7:49 PM, wm4 wrote: >> You just need to change * to **. Then the size of the struct doesn't >> matter anymore for array access and can be excluded from the ABI. > > To be thorough: Does anyone else have opinions on this approach? It's

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Derek Buitenhuis
On 3/28/2018 7:49 PM, wm4 wrote: > You just need to change * to **. Then the size of the struct doesn't > matter anymore for array access and can be excluded from the ABI. To be thorough: Does anyone else have opinions on this approach? - Derek ___

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Derek Buitenhuis
On 3/28/2018 7:47 PM, Nicolas George wrote: > Derek Buitenhuis (2018-03-28): >> Do you have an actual suggest though? > > Maybe not using a badly designed API that requires everything to be > stored in a serialized uint8_t array. Isn't this the same as saying "don't use the existing side data

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread wm4
On Wed, 28 Mar 2018 19:42:21 +0100 Derek Buitenhuis wrote: > On 3/28/2018 7:12 PM, Michael Niedermayer wrote: > > This is problematic as its non extensible. (unless iam missing something) > > Consider that a field is added to AVTimelineEntry, the entries array would >

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Nicolas George
Derek Buitenhuis (2018-03-28): > Do you have an actual suggest though? Maybe not using a badly designed API that requires everything to be stored in a serialized uint8_t array. > Afaict, this is exactly how the recently > pushed encryption support works with

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Derek Buitenhuis
On 3/28/2018 7:12 PM, Michael Niedermayer wrote: > This is problematic as its non extensible. (unless iam missing something) > Consider that a field is added to AVTimelineEntry, the entries array would > have a larger element size and that would require all user apps to be rebuild Do you have an

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Jan Ekström
On Wed, Mar 28, 2018 at 9:12 PM, Michael Niedermayer wrote: >> +/** >> + * An in-order array of entries for the given timeline. >> + * Each entry contains information on which samples to display for a >> + * particular edit. >> + */ >> +

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-03-28 Thread Michael Niedermayer
On Tue, Mar 27, 2018 at 08:44:01PM +0100, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/avcodec.h | 8 +++ > libavutil/timeline.h | 160 > +++ > 2 files changed, 168 insertions(+) >

Re: [FFmpeg-devel] [RFC] Exporting virtual timelines as stream side data

2018-03-28 Thread Dave Rice
> On Mar 27, 2018, at 5:16 PM, wm4 wrote: > > On Tue, 27 Mar 2018 16:45:23 -0400 > Dave Rice > wrote: > >>> On Mar 27, 2018, at 4:33 PM, wm4 wrote: >>> >>> On Tue, 27 Mar 2018 16:11:11 -0400 >>> Dave

[FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

2018-03-28 Thread Timo Teräs
iTunes currently uses the 'cprt' atom to store the copyright notice and this patch fixes compatibility with majority of software that supports the 'ilst' atom. Other software and documentation using this: - AtomicParseley encodes and parses only 'cprt' - Most players recognize only 'cprt' -

[FFmpeg-devel] Writing iTunes cover images to mp4 files

2018-03-28 Thread Timo Teras
Hi ffmpeg-devel, I am looking into and happy to write the code to write iTunes cover images to mp4 files. It seems there's a bug tracking this at: https://trac.ffmpeg.org/ticket/2798 And apparently there was already patches posted some years ago. The best patch around seems to be:

Re: [FFmpeg-devel] [PATCH] movtextenc: fix handling of utf-8 subtitles

2018-03-28 Thread Philip Langdale
On Wed, 28 Mar 2018 13:14:57 +0200 wm4 wrote: > On Wed, 28 Mar 2018 14:02:04 +0300 > Andrey Turkin wrote: > > > I think first check (ascii case) should be explicit bit-test, or > > (if there is some reason to use sign-bit approach) at least "c" >

Re: [FFmpeg-devel] [PATCH] movtextenc: fix handling of utf-8 subtitles

2018-03-28 Thread Philip Langdale
On Wed, 28 Mar 2018 12:01:47 +0200 wm4 wrote: > > LGTM. > > Maybe a later patch that adds the UTF-8 length as lavu function (or > macro for SPEEED?) eould be nice, since we seem to need that often. I can do that. Although, I'm not sure the SPEEED version is readable

[FFmpeg-devel] [PATCH] movtextenc: fix handling of utf-8 subtitles

2018-03-28 Thread Philip Langdale
See the earlier fix for movtextdec for details. The equivalent bug is present on the encoder side as well. We need to track the text length in 'characters' (which seems to really mean codepoints) to ensure that styles are applied across the correct ranges. Signed-off-by: Philip Langdale

Re: [FFmpeg-devel] [PATCH v3 2/3] avutil/log: add av_log_set_opts function

2018-03-28 Thread wm4
On Wed, 28 Mar 2018 17:03:39 +0200 Tobias Rapp wrote: > Allows to set log level and flag values from string. > > Signed-off-by: Tobias Rapp > --- > doc/APIchanges | 3 +++ > libavutil/log.c | 76 >

[FFmpeg-devel] [PATCH v3 3/3] fftools/cmdutils: replace loglevel option parsing with av_log_set_opts

2018-03-28 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- fftools/cmdutils.c | 48 +++- 1 file changed, 7 insertions(+), 41 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index c0ddf0b..2a0a995 100644 --- a/fftools/cmdutils.c +++

[FFmpeg-devel] [PATCH v3 2/3] avutil/log: add av_log_set_opts function

2018-03-28 Thread Tobias Rapp
Allows to set log level and flag values from string. Signed-off-by: Tobias Rapp --- doc/APIchanges | 3 +++ libavutil/log.c | 76 + libavutil/log.h | 16 +++ libavutil/version.h | 2 +- 4 files

[FFmpeg-devel] [PATCH v3 1/3] avutil/log: rename and initialize global log flags variable

2018-03-28 Thread Tobias Rapp
Rename global variable for symmetry with av_log_level. Signed-off-by: Tobias Rapp --- libavutil/log.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavutil/log.c b/libavutil/log.c index 9b7d484..0a99d01 100644 --- a/libavutil/log.c +++

Re: [FFmpeg-devel] [PATCH] avutil/buffer: add a dynamic size buffer pool API

2018-03-28 Thread James Almer
On 3/28/2018 6:59 AM, wm4 wrote: > On Tue, 27 Mar 2018 23:11:27 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> Implemented as a completely separate API as suggested. Missing >> Changelog, APIChanges and version bump as usual. >> >>

[FFmpeg-devel] Soft Subtitles (DVB) size problem on direct convert MPEG-TS video

2018-03-28 Thread Eleftherios Antoniades
Hi, Here is my case: I have a MPEG-TS video file with one video and one audio stream and i am trying to create a direct video convert with adding a DVBSUB stream inside it. My original subs file is a stl file. After many workarounds i finally managed to add the DVBSUB stream, after converting

[FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-28 Thread Alexander Kravchenko
Hello. I fixed couple of issues in previous patch. So if it is possible to use newer one, could you please review the following patch. Subject: amfenc: Retain a reference to D3D frames used as input during the encoding process --- libavcodec/amfenc.c | 91

Re: [FFmpeg-devel] [PATCH v3] libavformat/dashdec: Support signaling of last segment number

2018-03-28 Thread Steven Liu
2018-03-27 22:34 GMT+08:00 Steven Liu : > > >> On 27 Mar 2018, at 9:28 PM, sanilraut wrote: >> >> Last segment indicated by mpd is not parsed. >> Example stream: >>

Re: [FFmpeg-devel] [PATCH] movtextenc: fix handling of utf-8 subtitles

2018-03-28 Thread wm4
On Wed, 28 Mar 2018 14:02:04 +0300 Andrey Turkin wrote: > I think first check (ascii case) should be explicit bit-test, or (if there > is some reason to use sign-bit approach) at least "c" should be signed char > instead of simply char. Good point actually. It relies on

Re: [FFmpeg-devel] [PATCH] movtextenc: fix handling of utf-8 subtitles

2018-03-28 Thread Andrey Turkin
I think first check (ascii case) should be explicit bit-test, or (if there is some reason to use sign-bit approach) at least "c" should be signed char instead of simply char. 2018-03-28 6:07 GMT+03:00 Philip Langdale : > See the earlier fix for movtextdec for details. The

Re: [FFmpeg-devel] [RFC] Exporting virtual timelines as stream side data

2018-03-28 Thread wm4
On Tue, 27 Mar 2018 20:44:00 +0100 Derek Buitenhuis wrote: > So, I know we have edit list "support" in mov.c, but I am steadfast in my > belief that it is incorrect to implement it at the demuxing layer. By the > ISOBMFF spec, it is supposed to be applied at the

Re: [FFmpeg-devel] [PATCH] avutil/buffer: add a dynamic size buffer pool API

2018-03-28 Thread wm4
On Tue, 27 Mar 2018 23:11:27 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > Implemented as a completely separate API as suggested. Missing > Changelog, APIChanges and version bump as usual. > > libavutil/buffer.c | 159 >

Re: [FFmpeg-devel] [PATCH] movtextenc: fix handling of utf-8 subtitles

2018-03-28 Thread wm4
On Tue, 27 Mar 2018 20:07:05 -0700 Philip Langdale wrote: > See the earlier fix for movtextdec for details. The equivalent bug is > present on the encoder side as well. > > We need to track the text length in 'characters' (which seems to really > mean codepoints) to ensure

Re: [FFmpeg-devel] [PATCH] avfilter: add OpenCL scale filter

2018-03-28 Thread Song, Ruiling
> > No license, can't use it. Shadertoy has no explicit license. > > > Moreover the whole filter is incorrectly designed. Take a look at what mpv > does and how it has no explicit per-algorithm scaling functions. Hi Rostislav, It is just a coincidence that I am also working on the OpenCL

Re: [FFmpeg-devel] [GSOC] [PATCH] SRCNN filter

2018-03-28 Thread Sergey Lavrushkin
> [...] > > +#define OFFSET(x) offsetof(SRCNNContext, x) > > +#define FLAGS AV_OPT_FLAG_FILTERING_PARAM | AV_OPT_FLAG_VIDEO_PARAM > > +static const AVOption srcnn_options[] = { > > +{ "config_file", "path to configuration file with network > parameters", OFFSET(config_file_path),

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/eac3: add support for dependent stream

2018-03-28 Thread Paul B Mahol
On 3/28/18, Michael Niedermayer wrote: > On Tue, Mar 27, 2018 at 10:55:05PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/aac_ac3_parser.c | 9 ++- >> libavcodec/ac3_parser.c | 2 +- >> libavcodec/ac3dec.c