Re: [FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop

2018-05-29 Thread Eran Kornblau
> > > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Wednesday, May 30, 2018 12:37 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg - rewrite Stream Selection chapter

2018-05-29 Thread Gyan Doshi
On 30-05-2018 04:57 AM, Carl Eugen Hoyos wrote: 2018-05-27 6:16 GMT+02:00, Gyan Doshi : v2 attached. +In the absence of any map options for a particular output file, ffmpeg inspects the output +format to check which type of streams can be included in it, viz. video, audio and/or

Re: [FFmpeg-devel] [PATCH 2/2] flvenc: Fix sequence header update timestamps

2018-05-29 Thread Alex Converse
On Sun, May 13, 2018 at 3:24 AM, Michael Niedermayer wrote: > On Thu, May 10, 2018 at 06:40:08PM -0700, Alex Converse wrote: >> From: Alex Converse >> >> --- >> libavformat/flvenc.c | 9 - >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/flvenc.c

Re: [FFmpeg-devel] [GSOC] [PATCH] DNN module introduction and SRCNN filter update

2018-05-29 Thread Guo, Yejun
For the case that ffmpeg is built with TENSORFLOW_BACKEND enabled, while there is no TF at runtime, ff_get_dnn_module always returns valid pointer, and no chance for the filter to fall back to native mode. Looks that we need a runtime check in function ff_get_dnn_module. static av_cold int

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Avoid truncating timestamp before avio_write_marker()

2018-05-29 Thread Alex Converse
On Sun, May 13, 2018 at 3:41 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/flvenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c > index e8af48cb64..168ff9ffb8 100644 > ---

[FFmpeg-devel] [PATCH v3 1/3] lavc,doc: add avs2 codec

2018-05-29 Thread hwren
Signed-off-by: hwren --- doc/APIchanges | 3 +++ libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/version.h| 4 ++-- 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index efe15ba..3d08bb9 100644 ---

[FFmpeg-devel] [PATCH v3 3/3] lavf: add avs2 fourcc

2018-05-29 Thread hwren
Signed-off-by: hwren --- libavformat/riff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 8911725..4153372 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -369,6 +369,7 @@ const AVCodecTag ff_codec_bmp_tags[] = { {

[FFmpeg-devel] [PATCH v3 2/3] lavc, doc, configure: add libdavs2 video decoder

2018-05-29 Thread hwren
Add avs2 video decoder via libdavs2 library. Signed-off-by: hwren --- Changelog | 1 + configure | 4 + doc/decoders.texi | 10 +++ doc/general.texi | 8 ++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/libdavs2.c | 204

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-29 Thread Michael Niedermayer
On Tue, May 29, 2018 at 07:20:33PM +0100, Derek Buitenhuis wrote: > Hi, > > On Tue, May 29, 2018 at 5:04 PM, Sasi Inguva > wrote: > > Hi. sorry for the late reply. I sent a patch similar to this a while back > > https://patchwork.ffmpeg.org/patch/8227/ but it got lost in the sea. You > > also

Re: [FFmpeg-devel] [PATCH] lavfi/tests: Fix 16-bit vf_blend test to avoid memory not aligned to 2 bytes

2018-05-29 Thread Michael Niedermayer
On Tue, May 29, 2018 at 02:41:33PM +0200, Paul B Mahol wrote: > On 5/29/18, Andrey Semashev wrote: > > On 05/24/18 00:07, Andrey Semashev wrote: > >> Generic C implementation of vf_blend performs reads and writes of 16-bit > >> elements, which requires the buffers to be aligned to at least 2-byte

Re: [FFmpeg-devel] [PATCH 1/2] qt-faststart - stricter input validations

2018-05-29 Thread Michael Niedermayer
On Tue, May 29, 2018 at 02:35:23PM +, Eran Kornblau wrote: > Hi, > > The attached patch fixes a couple of input validation issues in fast start > that I noticed while going over the code > > Thanks > > Eran > qt-faststart.c | 13 + > 1 file changed, 9 insertions(+), 4

Re: [FFmpeg-devel] [PATCH] avcodec/qtrle: Do not output duplicated frames on insufficient input

2018-05-29 Thread Michael Niedermayer
On Sun, May 27, 2018 at 09:59:58PM +0200, Michael Niedermayer wrote: > This improves performance and makes qtrle behave more similar to other > decoders. > Libavcodec does generally not output known duplicated frames, instead the > calling Application > can insert them as it needs. > > Fixes:

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg - rewrite Stream Selection chapter

2018-05-29 Thread Carl Eugen Hoyos
2018-05-27 6:16 GMT+02:00, Gyan Doshi : > v2 attached. > +In the absence of any map options for a particular output file, ffmpeg > inspects the output > +format to check which type of streams can be included in it, viz. video, > audio and/or Sorry, what is "viz."? > +subtitles. For each

Re: [FFmpeg-devel] [PATCH]ffplay: Mention codec_name if decoder for codec_id could not be found.

2018-05-29 Thread Carl Eugen Hoyos
2018-05-29 9:54 GMT+02:00, Marton Balint : > > > On Tue, 29 May 2018, Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch makes debugging a little easier imo. >> >> Please comment, Carl Eugen >> >> diff --git a/fftools/ffplay.c b/fftools/ffplay.c >> index dcca9c2..f9571d7 100644 >> ---

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg - rewrite Stream Selection chapter

2018-05-29 Thread Lou Logan
On Sun, 27 May 2018 09:46:46 +0530 Gyan Doshi wrote: > I was talking about the vertical margins appled to the 'code' element. That's ugly too. I removed the margin for the code element. > From 60ed76348e70f1b0a25eadde8d886d47be3fca69 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Thu, 24

[FFmpeg-devel] [PATCH] lavf/mov.c: Set st->start_time for video streams explicitly.

2018-05-29 Thread Sasi Inguva
If start_time is not set, ffmpeg takes the duration from the global movie instead of the per stream duration. Signed-off-by: Sasi Inguva --- libavformat/mov.c| 20 +--- tests/fate/mov.mak | 4 +++

Re: [FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop

2018-05-29 Thread Michael Niedermayer
On Tue, May 29, 2018 at 02:36:28PM +, Eran Kornblau wrote: > Hi, > > The attached is a slightly more optimized (and IMHO elegant) code for > updating the stco/co64 offsets > > Thanks > > Eran > qt-faststart.c | 42 +- > 1 file changed, 25

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: fix overlap smoothing filter for P frames

2018-05-29 Thread Carl Eugen Hoyos
2018-05-29 22:02 GMT+02:00, Jerome Borsboom : > The v_overlap_filter needs to run on the colocated block of the previous > macroblock. For the luma plane, the colocated block is located two blocks > on the left instead of one. > > Signed-off-by: Jerome Borsboom > --- > This should fix the issue

Re: [FFmpeg-devel] [PATCH v3] avcodec/vc1: fix out-of-bounds reference pixel replication

2018-05-29 Thread Michael Niedermayer
On Tue, May 29, 2018 at 02:26:17PM +0200, Jerome Borsboom wrote: > Out-of-bounds reference pixel replication should take into account the frame > coding mode of the reference frame(s), not the frame coding mode of the > current frame. > > Signed-off-by: Jerome Borsboom > --- > Even more

[FFmpeg-devel] [PATCH] avcodec/vc1: fix overlap smoothing filter for P frames

2018-05-29 Thread Jerome Borsboom
The v_overlap_filter needs to run on the colocated block of the previous macroblock. For the luma plane, the colocated block is located two blocks on the left instead of one. Signed-off-by: Jerome Borsboom --- This should fix the issue with the SA10100.vc1 test file.

[FFmpeg-devel] [PATCH v3 1/3] libavformat/mov: treat udta atoms within trak atoms as stream metadata

2018-05-29 Thread Nik Johnson
Some muxers produce mp4s with a udta (user data) atom nested within a trak atom. The nested udta atoms typically contain stream information such as the title. ffmpeg should treat nested udta atoms as applicable to the stream instead of globally. Signed-off-by: Nik Johnson --- libavformat/mov.c

[FFmpeg-devel] [PATCH v3 3/3] libavformat/mov: add fate tests for parsing of trak titles from mov format

2018-05-29 Thread Nik Johnson
Create a fate test to verify ffprobe correctly identifies stream titles in mp4 containers. Signed-off-by: Nik Johnson --- Sample file for fate uploaded to https://www.dropbox.com/s/8itks08yf4s1pgs/trak-name.mp4?dl=0. Should be added to the fate samples under mov/trak-name.mp4

[FFmpeg-devel] [PATCH v3 2/3] libavformat/mov: recognize udta name tag as the stream title

2018-05-29 Thread Nik Johnson
Some muxers write the stream title in a udta atom with the tag 'name'. Recognize 'name' tags as the stream title instead of an unknown tag. Signed-off-by: Nik Johnson --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-29 Thread Derek Buitenhuis
Hi, On Tue, May 29, 2018 at 5:04 PM, Sasi Inguva wrote: > Hi. sorry for the late reply. I sent a patch similar to this a while back > https://patchwork.ffmpeg.org/patch/8227/ but it got lost in the sea. You > also want to do, Sorry I missed that! I'd prefer to use your patch over mine. I'll

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-29 Thread Sasi Inguva
Hi. sorry for the late reply. I sent a patch similar to this a while back https://patchwork.ffmpeg.org/patch/8227/ but it got lost in the sea. You also want to do, @@ -3579,7 +3579,8 @@ static void mov_fix_index(MOVContext *mov, AVStream *st)

Re: [FFmpeg-devel] [PATCH] Limited timecode support for lavd/decklink

2018-05-29 Thread Jonathan Morley
Thank you Marton, That makes sense to me, but can you please clarify which context is the most appropriate to use? Thanks, Jon > On May 29, 2018, at 1:41 AM, Marton Balint wrote: > > > > On Sat, 26 May 2018, Jonathan Morley wrote: > >> Attaching again from another mail client. > > Thanks.

[FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop

2018-05-29 Thread Eran Kornblau
Hi, The attached is a slightly more optimized (and IMHO elegant) code for updating the stco/co64 offsets Thanks Eran 0002-qt-faststart-optimize-the-offset-change-loop.patch Description: 0002-qt-faststart-optimize-the-offset-change-loop.patch ___

[FFmpeg-devel] [PATCH 1/2] qt-faststart - stricter input validations

2018-05-29 Thread Eran Kornblau
Hi, The attached patch fixes a couple of input validation issues in fast start that I noticed while going over the code Thanks Eran 0001-qt-faststart-stricter-input-validations.patch Description: 0001-qt-faststart-stricter-input-validations.patch

Re: [FFmpeg-devel] [GSOC] [PATCH] DNN module introduction and SRCNN filter update

2018-05-29 Thread Pedro Arthur
Patch 0001 pushed. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavfi/tests: Fix 16-bit vf_blend test to avoid memory not aligned to 2 bytes

2018-05-29 Thread Paul B Mahol
On 5/29/18, Andrey Semashev wrote: > On 05/24/18 00:07, Andrey Semashev wrote: >> Generic C implementation of vf_blend performs reads and writes of 16-bit >> elements, which requires the buffers to be aligned to at least 2-byte >> boundary. >> >> Also, the change fixes source buffer overrun

Re: [FFmpeg-devel] [GSOC] [PATCH] DNN module introduction and SRCNN filter update

2018-05-29 Thread Pedro Arthur
2018-05-29 5:14 GMT-03:00 Sergey Lavrushkin : > 2018-05-29 4:08 GMT+03:00 Pedro Arthur : >> >> 2018-05-28 19:52 GMT-03:00 Sergey Lavrushkin : >> > 2018-05-28 9:32 GMT+03:00 Guo, Yejun : >> > >> >> looks that no tensorflow dependency is introduced, a new model format >> >> is >> >> created together

Re: [FFmpeg-devel] [PATCH] lavfi/tests: Fix 16-bit vf_blend test to avoid memory not aligned to 2 bytes

2018-05-29 Thread Andrey Semashev
On 05/24/18 00:07, Andrey Semashev wrote: Generic C implementation of vf_blend performs reads and writes of 16-bit elements, which requires the buffers to be aligned to at least 2-byte boundary. Also, the change fixes source buffer overrun caused by src_offset being added to to test handling of

Re: [FFmpeg-devel] [PATCH v3] avcodec/vc1: fix out-of-bounds reference pixel replication

2018-05-29 Thread Jerome Borsboom
Out-of-bounds reference pixel replication should take into account the frame coding mode of the reference frame(s), not the frame coding mode of the current frame. Signed-off-by: Jerome Borsboom --- Even more corrections. The starting line must also be adjusted by one for an opposite refence

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Use the colour properties from the input stream when doing transcode

2018-05-29 Thread Tobias Rapp
On 28.05.2018 09:30, Xiang, Haihao wrote: On Sat, 2018-05-26 at 17:29 +0100, Mark Thompson wrote: On 25/05/18 07:57, Tobias Rapp wrote: On 25.05.2018 07:58, Xiang, Haihao wrote: On Thu, 2018-05-24 at 11:15 +0100, Mark Thompson wrote: For example: ffmpeg -i bt709_input.mkv -vf

Re: [FFmpeg-devel] [PATCH] lavfi: add opencl tonemap filter.

2018-05-29 Thread Niklas Haas
I see no obvious issues with the algorithm. (Though I haven't tested it) So "LGTM" On Tue, 29 May 2018 13:54:27 +0800, Ruiling Song wrote: > This filter does HDR(HDR10/HLG) to SDR conversion with tone-mapping. > > An example command to use this filter with vaapi codecs: > FFMPEG

Re: [FFmpeg-devel] [PATCH v2] avcodec/vc1: fix out-of-bounds reference pixel replication

2018-05-29 Thread Jerome Borsboom
Out-of-bounds reference pixel replication should take into account the frame coding mode of the reference frame(s), not the frame coding mode of the current frame. Signed-off-by: Jerome Borsboom --- Does this resolve the SIGSEGV? I think I made a mistake in the calculation of the starting line

Re: [FFmpeg-devel] [PATCH] lavfi: add opencl tonemap filter.

2018-05-29 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of myp...@gmail.com > Sent: Tuesday, May 29, 2018 3:40 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add opencl tonemap

Re: [FFmpeg-devel] [GSOC] [PATCH] DNN module introduction and SRCNN filter update

2018-05-29 Thread Sergey Lavrushkin
2018-05-29 4:08 GMT+03:00 Pedro Arthur : > 2018-05-28 19:52 GMT-03:00 Sergey Lavrushkin : > > 2018-05-28 9:32 GMT+03:00 Guo, Yejun : > > > >> looks that no tensorflow dependency is introduced, a new model format is > >> created together with some CPU implementation for inference. With this > >>

Re: [FFmpeg-devel] [PATCH] Limited timecode support for lavd/decklink

2018-05-29 Thread Marton Balint
On Sat, 26 May 2018, Jonathan Morley wrote: Attaching again from another mail client. Thanks. There is one issue I found: You are setting >video_st->metadata from the VideoInputFrameArrived callback. That runs in a separate thread from the main thread handling read_packet calls, and you

Re: [FFmpeg-devel] [PATCH]ffplay: Mention codec_name if decoder for codec_id could not be found.

2018-05-29 Thread Marton Balint
On Tue, 29 May 2018, Carl Eugen Hoyos wrote: Hi! Attached patch makes debugging a little easier imo. Please comment, Carl Eugen diff --git a/fftools/ffplay.c b/fftools/ffplay.c index dcca9c2..f9571d7 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -2578,7 +2578,7 @@ static int

Re: [FFmpeg-devel] [PATCH] lavfi: add opencl tonemap filter.

2018-05-29 Thread myp...@gmail.com
2018-05-29 13:54 GMT+08:00 Ruiling Song : > This filter does HDR(HDR10/HLG) to SDR conversion with tone-mapping. > > An example command to use this filter with vaapi codecs: > FFMPEG -init_hw_device vaapi=va:/dev/dri/renderD128 -init_hw_device \ > opencl=ocl@va -hwaccel vaapi -hwaccel_device va