Re: [FFmpeg-devel] [PATCH v4 30/38] vaapi_encode_h264: Enable multiple-slice support

2018-09-18 Thread myp...@gmail.com
On Wed, Sep 19, 2018 at 6:35 AM Mark Thompson wrote: > > --- > libavcodec/vaapi_encode_h264.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c > index 8feae0d42f..7bb77cfba2 100644 > ---

[FFmpeg-devel] [V2 PATCH 2/3] avfilter/dnn_backend_native: fix invalid free

2018-09-18 Thread Zhao Zhili
--- libavfilter/dnn_backend_native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_native.c index 184fe54..7dd35d46 100644 --- a/libavfilter/dnn_backend_native.c +++ b/libavfilter/dnn_backend_native.c @@ -343,7

[FFmpeg-devel] [V2 PATCH 3/3] avfilter/dnn_backend_native: fix memleak

2018-09-18 Thread Zhao Zhili
--- libavfilter/dnn_backend_native.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_native.c index 7dd35d46..70d857f 100644 --- a/libavfilter/dnn_backend_native.c +++ b/libavfilter/dnn_backend_native.c @@ -343,6 +343,7 @@ void

[FFmpeg-devel] [V2 PATCH 1/3] avfilter/vf_sr: fix read out of bounds

2018-09-18 Thread Zhao Zhili
--- libavfilter/vf_sr.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_sr.c b/libavfilter/vf_sr.c index 8a77a1d..c1ae6c5 100644 --- a/libavfilter/vf_sr.c +++ b/libavfilter/vf_sr.c @@ -227,7 +227,8 @@ static int filter_frame(AVFilterLink *inlink,

[FFmpeg-devel] [PATCH V2] avcodec/vaapi:free slice_buffers when decoding failed

2018-09-18 Thread Linjie Fu
If vaEndPicture failed in ff_vaapi_decode_issue, free the pic->slice_buffer. Fix the memory leak issue in ticket #7385 [V2] unit the return paths under the "exit" tag at the end of the function. Signed-off-by: Linjie Fu --- libavcodec/vaapi_decode.c | 15 --- 1 file changed, 8

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi:free slice_buffers when decoding failed

2018-09-18 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, September 19, 2018 06:45 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vaapi:free slice_buffers when > decoding failed > > On

Re: [FFmpeg-devel] [PATCH V7 0/3] enable multi-slices in vaapi_h264/265 encoder

2018-09-18 Thread myp...@gmail.com
On Wed, Sep 19, 2018 at 6:39 AM Mark Thompson wrote: > > On 29/08/18 11:38, Jun Zhao wrote: > > V7: - Fix h264 first_mb_in_slice setting issue. (root cause by Mark) > > - Refine the error handle > > > > V6: - Use rectangular slices and refine the code. > > > > V5: - In h265_vaapi encoder,

Re: [FFmpeg-devel] [PATCH 2/2] lavc/avpacket: Add missing conversions from side data enum to name.

2018-09-18 Thread myp...@gmail.com
On Wed, Sep 19, 2018 at 6:41 AM Michael Niedermayer wrote: > > On Mon, Sep 17, 2018 at 10:29:51PM +0800, Jun Zhao wrote: > > Add missing conversions from side data enum to name. > > > > Signed-off-by: Jun Zhao > > --- > > libavcodec/avpacket.c |6 ++ > > 1 files changed, 6

[FFmpeg-devel] [PATCH 1/2 v2] avcodec/libaomenc: support setting chroma sample location

2018-09-18 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libaomenc.c | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 6a79d9b873..9669e82049 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -76,6 +76,7 @@

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/libaomdec: export chroma sample location

2018-09-18 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libaomdec.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 2530c9f76b..68157b253d 100644 --- a/libavcodec/libaomdec.c +++ b/libavcodec/libaomdec.c @@ -94,6 +94,15 @@ static int

Re: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] refine ff_vc1_inv_trans_8x8_mmi.

2018-09-18 Thread Michael Niedermayer
On Mon, Sep 17, 2018 at 05:20:28PM +0800, Shiyou Yin wrote: > Combined 1st and 2nd loop into one inline asm in function > ff_vc1_inv_trans_8x8_mmi to > reduce memory operation, and made some small optimization in > ff_vc1_inv_trans_4x8_mmi. > --- > libavcodec/mips/vc1dsp_mmi.c | 227 >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/zmbv: Update decomp_len in raw frames

2018-09-18 Thread Michael Niedermayer
On Mon, Sep 17, 2018 at 09:33:59PM +0200, Michael Niedermayer wrote: > decomp_len is used in raw frames, so it should not be left at the value from > whatever was decoded previously (which may be any other frame) > > Signed-off-by: Michael Niedermayer > --- > libavcodec/zmbv.c | 1 + > 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Check that the decompressed data size is correct

2018-09-18 Thread Michael Niedermayer
On Tue, Sep 18, 2018 at 09:04:14AM +0200, Paul B Mahol wrote: > On 9/18/18, Michael Niedermayer wrote: > > This checks the value exactly for intra frames and checks it against a > > minimum for inter frames as they can be variable. > > > > Fixes: Timeout > > Fixes: > >

Re: [FFmpeg-devel] [PATCH v2 1/3] libaomenc: Add support for tiles

2018-09-18 Thread James Almer
On 9/18/2018 7:55 PM, Mark Thompson wrote: > On 18/09/18 01:12, James Almer wrote: >> On 9/17/2018 8:47 PM, Mark Thompson wrote: >>> Adds an option to specify the number of tile rows and columns, then uses >>> equal-sized tiles to fill the frame. >>> --- >>> libavcodec/libaomenc.c | 54

Re: [FFmpeg-devel] [PATCH v2 1/3] libaomenc: Add support for tiles

2018-09-18 Thread Mark Thompson
On 18/09/18 01:12, James Almer wrote: > On 9/17/2018 8:47 PM, Mark Thompson wrote: >> Adds an option to specify the number of tile rows and columns, then uses >> equal-sized tiles to fill the frame. >> --- >> libavcodec/libaomenc.c | 54 ++ >> 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi:free slice_buffers when decoding failed

2018-09-18 Thread Mark Thompson
On 14/09/18 08:25, Linjie Fu wrote: > If vaEndPicture failed in ff_vaapi_decode_issue, free > the pic->slice_buffer. > > Fix the memory leak issue in ticket #7385 > > Signed-off-by: Linjie Fu > --- > libavcodec/vaapi_decode.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH]lavd/dshow: Interpret negative height as bottom-down frame

2018-09-18 Thread Michael Niedermayer
On Tue, Sep 18, 2018 at 12:36:39AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch was tested by the reporter of ticket #7436. > > Please comment, Carl Eugen > dshow.c |4 > 1 file changed, 4 insertions(+) > f58dda8dfdb1eb76eb262fd3ce64eee3fa263c02 >

Re: [FFmpeg-devel] [PATCH 2/2] lavc/avpacket: Add missing conversions from side data enum to name.

2018-09-18 Thread Michael Niedermayer
On Mon, Sep 17, 2018 at 10:29:51PM +0800, Jun Zhao wrote: > Add missing conversions from side data enum to name. > > Signed-off-by: Jun Zhao > --- > libavcodec/avpacket.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH V7 0/3] enable multi-slices in vaapi_h264/265 encoder

2018-09-18 Thread Mark Thompson
On 29/08/18 11:38, Jun Zhao wrote: > V7: - Fix h264 first_mb_in_slice setting issue. (root cause by Mark) > - Refine the error handle > > V6: - Use rectangular slices and refine the code. > > V5: - In h265_vaapi encoder, when setting slice number > max slice number > supported by

[FFmpeg-devel] [PATCH v4 36/38] vaapi_encode_h264: Support more complex reference structures

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode_h264.c | 180 ++--- 1 file changed, 120 insertions(+), 60 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index 59feb95740..9ad31d4e0c 100644 --- a/libavcodec/vaapi_encode_h264.c +++

[FFmpeg-devel] [PATCH v4 35/38] vaapi_encode: Let the reconstructed frame pool be sized dynamically

2018-09-18 Thread Mark Thompson
No supported encode driver requires the pool to be fixed-size, so just remove this constraint. --- libavcodec/vaapi_encode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 87397965d3..abd80b2df9 100644 ---

[FFmpeg-devel] [PATCH v4 37/38] vaapi_encode_h265: Support more complex reference structures

2018-09-18 Thread Mark Thompson
The reference picture sets are now constructed directly from the DPB information. --- libavcodec/vaapi_encode_h265.c | 191 +++-- 1 file changed, 111 insertions(+), 80 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index

[FFmpeg-devel] [PATCH v4 38/38] vaapi_encode_vp9: Support more complex reference structures

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode_vp9.c | 104 +- 1 file changed, 51 insertions(+), 53 deletions(-) diff --git a/libavcodec/vaapi_encode_vp9.c b/libavcodec/vaapi_encode_vp9.c index 94f29c0483..97142dcc49 100644 --- a/libavcodec/vaapi_encode_vp9.c +++

[FFmpeg-devel] [PATCH v4 34/38] vaapi_encode: Convert to send/receive API

2018-09-18 Thread Mark Thompson
This attaches the logic of picking the mode of for the next picture to the output, which simplifies some choices by removing the concept of the picture for which input is not yet available. At the same time, we allow more complex reference structures and track more reference metadata

[FFmpeg-devel] [PATCH v4 32/38] vaapi_encode: Add flag to mark encoders supporting only constant-quality

2018-09-18 Thread Mark Thompson
And set it for MJPEG. --- libavcodec/vaapi_encode.c | 3 ++- libavcodec/vaapi_encode.h | 2 ++ libavcodec/vaapi_encode_mjpeg.c | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 601d74b5c4..230b322ad0

[FFmpeg-devel] [PATCH v4 33/38] vaapi_encode: Allocate picture-private data in generic code

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode.c | 15 --- libavcodec/vaapi_encode.h | 4 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 230b322ad0..9431738472 100644 --- a/libavcodec/vaapi_encode.c +++

[FFmpeg-devel] [PATCH v4 31/38] vaapi_encode_h265: Enable multiple-slice support

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode_h265.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index 1ada973dd3..ddda9165fa 100644 --- a/libavcodec/vaapi_encode_h265.c +++

[FFmpeg-devel] [PATCH v4 25/38] vaapi_encode_h265: Improve profile support

2018-09-18 Thread Mark Thompson
Set profile compatibility/constraint flags properly (including the constraint flags used for RExt profiles, as all streams we can currently generate are RExt-compatible), and use that to add support for the "Main Intra" and "Main 10 Intra" RExt subprofiles (for which we can re-use the existing

[FFmpeg-devel] [PATCH v4 30/38] vaapi_encode_h264: Enable multiple-slice support

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode_h264.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index 8feae0d42f..7bb77cfba2 100644 --- a/libavcodec/vaapi_encode_h264.c +++ b/libavcodec/vaapi_encode_h264.c @@

[FFmpeg-devel] [PATCH v4 27/38] vaapi_encode_h265: Set level based on stream if not set by user

2018-09-18 Thread Mark Thompson
Sets the level based on the stream properties if it is not explicitly set by the user. Also add a tier option to set general_tier_flag, since that affects the level choice. --- doc/encoders.texi | 4 libavcodec/Makefile| 2 +- libavcodec/vaapi_encode_h265.c | 40

[FFmpeg-devel] [PATCH v4 26/38] lavc/h265: Add some common code for profile/tier/level handling

2018-09-18 Thread Mark Thompson
Adds support for determining for level limits, including mapping PTL blocks to profiles to check profile-dependent level limits. --- libavcodec/h265_profile_level.c | 245 libavcodec/h265_profile_level.h | 89 2 files changed, 334 insertions(+)

[FFmpeg-devel] [PATCH v4 28/38] doc/encoders: Document -sei option to hevc_vaapi

2018-09-18 Thread Mark Thompson
--- doc/encoders.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index cfb2cedf34..8d184f72f8 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -2663,6 +2663,16 @@ Include access unit delimiters in the stream (not included by

[FFmpeg-devel] [PATCH v4 29/38] vaapi_encode: Support configurable slices

2018-09-18 Thread Mark Thompson
This adds common code to query driver support and set appropriate address/size information for each slice. It only supports rectangular slices for now, since that is the most common use-case. Also immediately use that to replace the ad-hoc code doing the same thing for MPEG-2. ---

[FFmpeg-devel] [PATCH v4 23/38] cbs_h264: Fix profile typo

2018-09-18 Thread Mark Thompson
--- libavcodec/cbs_h264_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_h264_syntax_template.c b/libavcodec/cbs_h264_syntax_template.c index 1efa97dccb..7befde4b68 100644 --- a/libavcodec/cbs_h264_syntax_template.c +++

[FFmpeg-devel] [PATCH v4 22/38] cbs_h264: Fix default value for max mv lengths

2018-09-18 Thread Mark Thompson
A recent version of the standard changed the max and default to 15, from 16 in older versions. This updates the default to 15 to match, but the max stays as 16 so that we don't reject older streams. --- libavcodec/cbs_h264_syntax_template.c | 6 -- libavcodec/vaapi_encode_h264.c| 4

[FFmpeg-devel] [PATCH v4 20/38] vaapi_encode_h264: Set level based on stream if not set by user

2018-09-18 Thread Mark Thompson
--- libavcodec/Makefile| 2 +- libavcodec/vaapi_encode_h264.c | 40 ++ 2 files changed, 37 insertions(+), 5 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index a5a110c7b6..5e6f044ce0 100644 --- a/libavcodec/Makefile +++

[FFmpeg-devel] [PATCH v4 24/38] cbs_h264: Infer default VUI values if VUI parameters are not present

2018-09-18 Thread Mark Thompson
--- libavcodec/cbs_h264_syntax_template.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/libavcodec/cbs_h264_syntax_template.c b/libavcodec/cbs_h264_syntax_template.c index 7befde4b68..32e6acd68e 100644 --- a/libavcodec/cbs_h264_syntax_template.c +++

[FFmpeg-devel] [PATCH v4 21/38] h264_metadata: Add option to set the level of the stream

2018-09-18 Thread Mark Thompson
--- doc/bitstream_filters.texi | 9 libavcodec/h264_metadata_bsf.c | 90 ++ 2 files changed, 99 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 7d7e97503a..d948c6d658 100644 --- a/doc/bitstream_filters.texi +++

[FFmpeg-devel] [PATCH v4 19/38] lavc/h264: Add common code for level handling

2018-09-18 Thread Mark Thompson
Including a unit test. --- libavcodec/Makefile| 3 +- libavcodec/h264_levels.c | 130 +++ libavcodec/h264_levels.h | 53 ++ libavcodec/tests/.gitignore| 1 + libavcodec/tests/h264_levels.c | 183 +

[FFmpeg-devel] [PATCH v4 18/38] hwcontext_vaapi: Improve format mapping

2018-09-18 Thread Mark Thompson
Give the entries in the VAAPI format map table an explicit type and add functions to do the necessary lookups. Add another field to this table indicating whether the chroma planes are swapped (as in YV12), and use that rather than explicit comparisons where swapping is needed. ---

[FFmpeg-devel] [PATCH v4 17/38] vaapi_encode_mjpeg: Mark as intra-only

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode_mjpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_mjpeg.c b/libavcodec/vaapi_encode_mjpeg.c index db9b36321a..fe8439ce88 100644 --- a/libavcodec/vaapi_encode_mjpeg.c +++ b/libavcodec/vaapi_encode_mjpeg.c @@ -554,7

[FFmpeg-devel] [PATCH v4 13/38] doc/encoders: Add missing options to VAAPI encoders

2018-09-18 Thread Mark Thompson
--- doc/encoders.texi | 24 1 file changed, 24 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 4133bc15ee..5ddf1f303a 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -2631,12 +2631,36 @@ Use CABAC. @item cavlc Use CAVLC. @end table +

[FFmpeg-devel] [PATCH v4 08/38] vaapi_encode: Add support for max QP in rate control

2018-09-18 Thread Mark Thompson
This was added in libva 2.1.0 (VAAPI 1.1.0). Use AVCodecContext.qmax, matching the existing behaviour for qmin, and clean up the defaults so that we only pass min/max when explicitly set. --- doc/encoders.texi | 3 ++- libavcodec/vaapi_encode.c | 3 +++

[FFmpeg-devel] [PATCH v4 16/38] vaapi_encode_mjpeg: Use CBS to store parameters and write headers

2018-09-18 Thread Mark Thompson
Also adds greyscale, 4:2:2, 4:4:4 and RGB support. --- configure | 2 +- doc/encoders.texi | 17 +- libavcodec/vaapi_encode_mjpeg.c | 529 3 files changed, 347 insertions(+), 201 deletions(-) diff --git a/configure

[FFmpeg-devel] [PATCH v4 15/38] lavc/cbs: Add JPEG support

2018-09-18 Thread Mark Thompson
--- configure | 2 + libavcodec/Makefile | 1 + libavcodec/cbs.c | 6 + libavcodec/cbs_internal.h | 1 + libavcodec/cbs_jpeg.c | 520 ++ libavcodec/cbs_jpeg.h

[FFmpeg-devel] [PATCH v4 14/38] hwcontext_vaapi: Improve logging around quirk detection

2018-09-18 Thread Mark Thompson
Clarify that the list is the naughty list, and therefore being on it is not desirable. The i965 driver does not need to be on the list after version 2.0 (when the standard parameter buffer rendering behaviour was changed). --- libavutil/hwcontext_vaapi.c | 27 +++ 1 file

[FFmpeg-devel] [PATCH v4 12/38] vaapi_encode_h26[45]: Make the AUD option a boolean

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode_h264.c | 2 +- libavcodec/vaapi_encode_h265.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index bba6848f03..0774ec25f9 100644 --- a/libavcodec/vaapi_encode_h264.c +++

[FFmpeg-devel] [PATCH v4 07/38] vaapi_encode: Clean up rate control configuration

2018-09-18 Thread Mark Thompson
Query which modes are supported and select between VBR and CBR based on that - this removes all of the codec-specific rate control mode selection code. --- doc/encoders.texi | 2 - libavcodec/vaapi_encode.c | 181 +++- libavcodec/vaapi_encode.h

[FFmpeg-devel] [PATCH v4 11/38] vaapi_encode_h264: Properly set constraint flags

2018-09-18 Thread Mark Thompson
constraint_set1_flag should be set for constrained baseline and main profiles, because the stream conforms to main profile. constraint_set3_flag should be set for high profile when the stream is intra-only. constraint_set4_flag should always be set for main and high profiles because interlaced

[FFmpeg-devel] [PATCH v4 10/38] vaapi_encode: Clean up the packed header configuration

2018-09-18 Thread Mark Thompson
Add a larger warning more clearly explaining the consequences of missing packed header support in the driver. Also only write the extradata if the user actually requests it via the GLOBAL_HEADER flag. --- libavcodec/vaapi_encode.c | 119 +---

[FFmpeg-devel] [PATCH v4 03/38] vaapi_encode: Add common options between all encoders

2018-09-18 Thread Mark Thompson
The only common option here is low_power - it was previously supported for H.264 only, that specific option is removed. --- doc/encoders.texi | 14 -- libavcodec/vaapi_encode.h | 9 + libavcodec/vaapi_encode_h264.c | 8 ++--

[FFmpeg-devel] [PATCH v4 09/38] vaapi_encode: Clean up the GOP structure configuration

2018-09-18 Thread Mark Thompson
Choose what types of reference frames will be used based on what types are available, and make the intra-only mode explicit (GOP size one, which must be used for MJPEG). --- libavcodec/vaapi_encode.c | 83 ++--- libavcodec/vaapi_encode.h | 1 +

[FFmpeg-devel] [PATCH v4 06/38] vaapi_encode: Always reapply global parameters after the sequence header

2018-09-18 Thread Mark Thompson
The codec sequence headers may contain fields which can overwrite the fine parameters given in the specific settings (e.g. a crude bitrate value vs. the max-rate / target-percentage / etc. values in VAEncMiscParameterRateControl). Always reapply all global parameters after a sequence header to

[FFmpeg-devel] [PATCH v4 04/38] vaapi_encode_mpeg2: Add options

2018-09-18 Thread Mark Thompson
Include the common options, and also named options for setting the profile and level. --- libavcodec/vaapi_encode_mpeg2.c | 53 +++-- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_mpeg2.c b/libavcodec/vaapi_encode_mpeg2.c index

[FFmpeg-devel] [PATCH v4 05/38] vaapi_encode: Clean up the encode quality configuration

2018-09-18 Thread Mark Thompson
--- libavcodec/vaapi_encode.c | 84 +- libavcodec/vaapi_encode_h264.c | 7 ++- 2 files changed, 54 insertions(+), 37 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index f838ee5bd5..35a4e90f67 100644 ---

[FFmpeg-devel] [PATCH v4 00/38] VAAPI encode and related stuff

2018-09-18 Thread Mark Thompson
1-28 should be complete and had only a few very minor changes since last time. I'll push them this weekend if there are no further comments. (17 is new but hopefully obvious.) 29-32 are new, but should be pretty much complete. 33-38 still need a bit more work to be complete, but any testing

[FFmpeg-devel] [PATCH v4 01/38] configure: Use pkgconfig for VAAPI

2018-09-18 Thread Mark Thompson
Set the minimum version to 0.35.0 (libva 1.3.0) and remove redundant configure tests. This also allows the proprietary libmfx fork of libva, which always shows the version number 0.99.0 (independent of the actual version). --- configure | 31 ---

[FFmpeg-devel] [PATCH v4 02/38] vaapi_encode: Choose profiles dynamically

2018-09-18 Thread Mark Thompson
Previously there was one fixed choice for each codec (e.g. H.265 -> Main profile), and using anything else then required an explicit option from the user. This changes to selecting the profile based on the input format and the set of profiles actually supported by the driver (e.g. P010 input will

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/dnn_backend_native: fix invalid free

2018-09-18 Thread Pedro Arthur
Hi, 2018-09-13 4:49 GMT-03:00 Zhao Zhili : > --- > libavfilter/dnn_backend_native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_ > native.c > index baefea7..7ed155d 100644 > ---

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/dnn_backend_native: fix memleak

2018-09-18 Thread Pedro Arthur
Hi, 2018-09-13 4:49 GMT-03:00 Zhao Zhili : > --- > libavfilter/dnn_backend_native.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_ > native.c > index 7ed155d..3108185 100644 > --- a/libavfilter/dnn_backend_native.c > +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_sr: fix read out of bounds

2018-09-18 Thread Pedro Arthur
Hi, 2018-09-17 0:43 GMT-03:00 Zhao Zhili : > Ping for review. > > On 2018年09月13日 15:58, Zhao Zhili wrote: > >> --- >> libavfilter/vf_sr.c | 9 ++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/libavfilter/vf_sr.c b/libavfilter/vf_sr.c >> index 5ad1baa..bc9d186

Re: [FFmpeg-devel] [PATCH v2] http connect: retry few times before reporting about error

2018-09-18 Thread Derek Buitenhuis
On 16/09/2018 23:01, Artjom Vejsel wrote: > Signed-off-by: Artjom Vejsel > --- > libavformat/http.c | 22 +++--- > 1 file changed, 15 insertions(+), 7 deletions(-) This should be an AVOption instead of a hardcoded number. - Derek ___

[FFmpeg-devel] [PATCH] lavfi/deshake: fix deshake crash issue.

2018-09-18 Thread Jun Zhao
Fixes ticket #7441. Signed-off-by: Jun Zhao --- libavfilter/vf_deshake.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c index 55ce5e1..5d2c7fa 100644 --- a/libavfilter/vf_deshake.c +++

[FFmpeg-devel] [PATCH v2] http connect: retry few times before reporting about error

2018-09-18 Thread Artjom Vejsel
Signed-off-by: Artjom Vejsel --- libavformat/http.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 4fdb2f13f2..d3558f522e 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -252,7 +252,7 @@ static

Re: [FFmpeg-devel] [PATCH] avcodec/zmbv: Check that the decompressed data size is correct

2018-09-18 Thread Paul B Mahol
On 9/18/18, Michael Niedermayer wrote: > This checks the value exactly for intra frames and checks it against a > minimum for inter frames as they can be variable. > > Fixes: Timeout > Fixes: > 10182/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZMBV_fuzzer-6245951174344704 > > Found-by: