Re: [FFmpeg-devel] [PATCH V2] examples/vaapi_dec_scaling: add a vaapi decoding/scaling sample

2018-10-11 Thread myp...@gmail.com
On Tue, Aug 28, 2018 at 10:12 AM myp...@gmail.com wrote: > > On Tue, Aug 28, 2018 at 2:14 AM Mark Thompson wrote: > > > > On 23/08/18 14:08, Jun Zhao wrote: > > > add a vaapi decoding/scaling sample. > > > > > > Signed-off-by: Jun Zhao > > > --- > > > configure|2 +

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: fix crash due to assert failure on empty nalu

2018-10-11 Thread myp...@gmail.com
On Fri, Oct 12, 2018 at 12:02 PM Aman Gupta wrote: > > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavcodec/cbs_h2645.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c > index ab33cdb69b..13e4c1561c 100644

[FFmpeg-devel] [PATCH 4/5] avcodec/cbs: fix crash in sei_pic_timestamp

2018-10-11 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/cbs_h264_syntax_template.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/cbs_h264_syntax_template.c b/libavcodec/cbs_h264_syntax_template.c index 32e6acd68e..106da0630e 100644 ---

[FFmpeg-devel] [PATCH 5/5] avcodec/cbs: ensure user_data is padded for GBC parsing

2018-10-11 Thread Aman Gupta
From: Aman Gupta Fixes crash noticed in the cbs_metadata patchset. ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60926c89 at pc 0x00010725d37b bp 0x7ffeea04e750 sp 0x7ffeea04e748 READ of size 4 at 0x60926c89 thread T0 #0 0x10725d37a in ff_cbs_read_unsigned

[FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: fix crash due to assert failure on empty nalu

2018-10-11 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/cbs_h2645.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index ab33cdb69b..13e4c1561c 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -521,7

[FFmpeg-devel] [PATCH 3/5] avcodec/cbs_h264: silence errors about end_of_seq nalus

2018-10-11 Thread Aman Gupta
From: Aman Gupta [ffmpeg] AVBSFContext: Decomposition unimplemented for unit 4 (type 10). Signed-off-by: Aman Gupta --- libavcodec/cbs_h2645.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 13e4c1561c..2c7faf36e7 100644 ---

[FFmpeg-devel] [PATCH 1/5] avcodec/avpacket: fix whitespace

2018-10-11 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/avpacket.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 002fa0f513..e160ad3033 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -580,10

[FFmpeg-devel] [PATCH] lavf/vc1test: fix vc1test can't probe some RCV file.

2018-10-11 Thread Jun Zhao
case 1: use the hexdump -C SMM0005.rcv get: size skip (size - 4) || VV 18 00 00 c5 05 00 00 00 4d f1 0a 11 00 e0 01 00 0010 00 d0 02 00 00 0c 00 00 00 88

[FFmpeg-devel] [PATCH 2/2] avformat/utils: Fix long overflow in compute_pkt_fields()

2018-10-11 Thread Michael Niedermayer
From: Thomas Guilbert If ever we have a negative last_IP_duration, we can end up with a long overflow. This makes sure we use pkt->duration instead of last_IP_duration if last_IP_duration is negative. Fixes: compute_pkt_usan --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH 1/2] avformat/utils: Fix integer overflow in discontinuity check

2018-10-11 Thread Michael Niedermayer
Fixes: signed integer overflow: 7738135736989908991 - -7954308516317364223 cannot be represented in type 'long' Fixes: find_stream_info_usan Reported-by: Thomas Guilbert Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] libavcodec/libaomenc.c: Added code for computing PSNR/SSIM for libaom encoder.Updated the patch to read the AV_PICTURE_TYPE_I flag for AOM.

2018-10-11 Thread James Almer
On 10/11/2018 9:49 PM, Sam John wrote: > James, > > Is there anything to be done for this patch? Can you please approve this > change and apply the patch to ffmpeg head. Sorry for the delay. Pushed it after changing it so psnr is only exported when every frame can be properly tagged as intra or

Re: [FFmpeg-devel] [PATCH] libavcodec/libaomenc.c: Added code for computing PSNR/SSIM for libaom encoder.Updated the patch to read the AV_PICTURE_TYPE_I flag for AOM.

2018-10-11 Thread Sam John
James, Is there anything to be done for this patch? Can you please approve this change and apply the patch to ffmpeg head. On Fri, Sep 28, 2018 at 3:09 PM Sam John wrote: > --- > libavcodec/libaomenc.c | 60 +- > 1 file changed, 54 insertions(+), 6

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Derek Buitenhuis
On 11/10/2018 23:39, Alex Sukhanov wrote: > The only "spec" I'm aware of:https://wiki.multimedia.cx/index.php/IVF Yeah, not really a spec. I have no strong objections, I guess. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: bump the intra stream discontinuity message to warning

2018-10-11 Thread Michael Niedermayer
On Thu, Oct 11, 2018 at 09:50:22PM +0200, Marton Balint wrote: > > > On Thu, 11 Oct 2018, Michael Niedermayer wrote: > > >On Wed, Oct 10, 2018 at 02:10:26AM +0300, Jan Ekström wrote: > >>As libavformat should at this point be handling general input > >>timestamp discontinuities for us - such as

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/utils: keep CORRUPT and TRUSTED packet flags when parsing packets

2018-10-11 Thread Michael Niedermayer
On Thu, Oct 11, 2018 at 10:39:54PM +0200, Marton Balint wrote: > > > On Thu, 11 Oct 2018, Michael Niedermayer wrote: > > >On Wed, Oct 10, 2018 at 01:32:14AM +0200, Marton Balint wrote: > >>An FF_ macro got defined in avcodec.h to store the flags which need to be > >>propagated when parsers

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1dec_template: Check for the end of input after 1024 pixels

2018-10-11 Thread Michael Niedermayer
On Tue, Oct 09, 2018 at 05:14:22AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 10385/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1_fuzzer-5689206987292672 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_template: Allow duplicated elements

2018-10-11 Thread Michael Niedermayer
On Thu, Oct 11, 2018 at 12:56:30PM +0200, Paul B Mahol wrote: > On 10/7/18, Michael Niedermayer wrote: > > Such streams are invalid according to > > 4.5.2.1 Top level payloads for the audio object types AAC main, AAC SSR, AAC > > LC and AAC LTP > > 4.5.2.1.1 Definitions > > ...cIn the

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-11 Thread Michael Niedermayer
On Thu, Oct 11, 2018 at 09:37:52PM +0200, Martin Vignali wrote: > > > > the split should be > > the removal of the code that stays removed > > the porting of the remaining code > > > > I understand its easier to drop both and then add one but thats a ugly way > > to split the patch. The patch

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Alex Sukhanov
On Thu, Oct 11, 2018 at 2:47 PM Derek Buitenhuis wrote: > On 11/10/2018 22:21, Jan Ekström wrote: > > I'd probably disable creation of such files unless you enable a less > > standards-compliant strictness mode. > > Is there even an IVF spec, though? If not, there's not really such a > thing as

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Derek Buitenhuis
On 11/10/2018 22:21, Jan Ekström wrote: > I'd probably disable creation of such files unless you enable a less > standards-compliant strictness mode. Is there even an IVF spec, though? If not, there's not really such a thing as "standards-compliant". - Derek

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: bump the intra stream discontinuity message to warning

2018-10-11 Thread Marton Balint
On Thu, 11 Oct 2018, Jan Ekström wrote: On Thu, Oct 11, 2018 at 10:50 PM Marton Balint wrote: On Thu, 11 Oct 2018, Michael Niedermayer wrote: > On Wed, Oct 10, 2018 at 02:10:26AM +0300, Jan Ekström wrote: >> As libavformat should at this point be handling general input >> timestamp

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Jan Ekström
On Thu, Oct 11, 2018 at 10:58 PM Alex Sukhanov wrote: > > Hi Mark, > > at Google we have some old service which is still running and it works only > with the IVF container. It would be great if ffmpeg could generate such > videos so we could give them to the service then. Given that ffmpeg IVF >

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: bump the intra stream discontinuity message to warning

2018-10-11 Thread Jan Ekström
On Thu, Oct 11, 2018 at 10:50 PM Marton Balint wrote: > On Thu, 11 Oct 2018, Michael Niedermayer wrote: > > > On Wed, Oct 10, 2018 at 02:10:26AM +0300, Jan Ekström wrote: > >> As libavformat should at this point be handling general input > >> timestamp discontinuities for us - such as with

Re: [FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

2018-10-11 Thread Alex Sukhanov
On Sat, Oct 6, 2018 at 10:37 AM Mark Thompson wrote: > On 05/10/18 21:45, Alex Sukhanov wrote: > > On Mon, Oct 1, 2018 at 11:01 AM wrote: > > > >> From: Alex Sukhanov > >> > >> --- > >> libavformat/ivfenc.c | 50 +--- > >> 1 file changed, 38

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: bump the intra stream discontinuity message to warning

2018-10-11 Thread Marton Balint
On Thu, 11 Oct 2018, Michael Niedermayer wrote: On Wed, Oct 10, 2018 at 02:10:26AM +0300, Jan Ekström wrote: As libavformat should at this point be handling general input timestamp discontinuities for us - such as with MPEG-TS - the amount of messages from this case should be small, and if

Re: [FFmpeg-devel] swscale/x86/rgb2rgb : port shuffle2103 to external asm

2018-10-11 Thread Martin Vignali
> > the split should be > the removal of the code that stays removed > the porting of the remaining code > > I understand its easier to drop both and then add one but thats a ugly way > to split the patch. The patch porting the code should show both the code > thats removed as well as the added

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: bump the intra stream discontinuity message to warning

2018-10-11 Thread Michael Niedermayer
On Wed, Oct 10, 2018 at 02:10:26AM +0300, Jan Ekström wrote: > As libavformat should at this point be handling general input > timestamp discontinuities for us - such as with MPEG-TS - the > amount of messages from this case should be small, and if it > does start spamming messages, that would be

Re: [FFmpeg-devel] avcodec/libopenh264enc.c

2018-10-11 Thread Moritz Barsnick
On Thu, Oct 11, 2018 at 16:45:02 +0200, Timo Rothenpieler wrote: > This patch is corrupted, also needs a more meaningful commit message. Valery previously sent the patch as an attachment, which looked okay. (Perhaps needed a better commit message nevertheless.) Moritz

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-11 Thread Paul B Mahol
On 10/11/18, Jerome Martinez wrote: > On 11/10/2018 14:08, Paul B Mahol wrote: >> On 10/11/18, Jerome Martinez wrote: >>> Hi, >>> >>> Testing FFmpeg FFV1 encoder on big frames (more than 4K: 4300x3956), I >>> have a warning for each frame encoded (so a lot of warnings!): >>> [ffv1 @

Re: [FFmpeg-devel] avcodec/libopenh264enc.c

2018-10-11 Thread Timo Rothenpieler
This patch is corrupted, also needs a more meaningful commit message. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] avcodec/libopenh264enc.c

2018-10-11 Thread Valery Kot
When using libx264 (GPL) encoder, sample aspect ratio gets stored on both container and frame levels. For libopenh264 (LGPL), aspect ratio on codec/frame level currently is ignored, which results in weird display aspect ratio for non-square pixels on some players. Proposed patch fixes that, if

Re: [FFmpeg-devel] [PATCH 2/3] lavf/timecode: document SMPTE struct

2018-10-11 Thread Joshua de Kock
On 9 October 2018 at 21:21, Devin Heitmueller wrote: > >> On Oct 9, 2018, at 4:07 PM, Carl Eugen Hoyos wrote: >> >> 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >>> From: Devin Heitmueller >>> >>> There are a number of different binary representations in which >>> SMPTE timecodes can

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-11 Thread Jerome Martinez
On 11/10/2018 14:08, Paul B Mahol wrote: On 10/11/18, Jerome Martinez wrote: Hi, Testing FFmpeg FFV1 encoder on big frames (more than 4K: 4300x3956), I have a warning for each frame encoded (so a lot of warnings!): [ffv1 @ 024a6bcfe880] Cannot allocate worst case packet size, the encoding

Re: [FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

2018-10-11 Thread Joshua de Kock
On 9 October 2018 at 21:03, Carl Eugen Hoyos wrote: > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >> From: Josh de Kock > >> [...] > > If the first patch gets committed as-is, please split this one > in a functional and a cosmetic patch, above is unreviewable. > > Thank you, Carl Eugen

[FFmpeg-devel] avcodec/libopenh264enc.c

2018-10-11 Thread Valery Kot
When using libx264 (GPL) encoder, sample aspect ratio gets stored on both container and frame levels. For libopenh264 (LGPL), aspect ratio on codec/frame level currently is ignored, which results in weird display aspect ratio for non-square pixels on some players. Proposed patch fixes that, if

Re: [FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-11 Thread Paul B Mahol
On 10/11/18, Jerome Martinez wrote: > Hi, > > Testing FFmpeg FFV1 encoder on big frames (more than 4K: 4300x3956), I > have a warning for each frame encoded (so a lot of warnings!): > [ffv1 @ 024a6bcfe880] Cannot allocate worst case packet size, the > encoding could fail > > Checking

[FFmpeg-devel] ffv1enc: question about "Cannot allocate worst case packet size, the encoding could fail"

2018-10-11 Thread Jerome Martinez
Hi, Testing FFmpeg FFV1 encoder on big frames (more than 4K: 4300x3956), I have a warning for each frame encoded (so a lot of warnings!): [ffv1 @ 024a6bcfe880] Cannot allocate worst case packet size, the encoding could fail Checking avcodec/ffv1enc.c, it is due to the following lines:    

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: improve the intra stream discontinuity message

2018-10-11 Thread Michael Niedermayer
On Wed, Oct 10, 2018 at 02:10:25AM +0300, Jan Ekström wrote: > Now it actually tells which stream from which input and of > which type had an absolute DTS discontinuity larger than > dts_delta_threshold. > --- > fftools/ffmpeg.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) should

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/utils: keep CORRUPT and TRUSTED packet flags when parsing packets

2018-10-11 Thread Michael Niedermayer
On Thu, Oct 11, 2018 at 12:50:53PM +0200, Michael Niedermayer wrote: > On Wed, Oct 10, 2018 at 01:32:14AM +0200, Marton Balint wrote: > > An FF_ macro got defined in avcodec.h to store the flags which need to be > > propagated when parsers split packets so this won't be forgotten when a new > >

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_template: Allow duplicated elements

2018-10-11 Thread Paul B Mahol
On 10/7/18, Michael Niedermayer wrote: > Such streams are invalid according to > 4.5.2.1 Top level payloads for the audio object types AAC main, AAC SSR, AAC > LC and AAC LTP > 4.5.2.1.1 Definitions > ...cIn the raw_data_block(), several instances of the > same syntactic element may occur, but

Re: [FFmpeg-devel] Is Patchwork broken?

2018-10-11 Thread Michael Niedermayer
On Wed, Oct 10, 2018 at 11:00:07PM +0530, Gyan wrote: > The latest commit that shows at > https://patchwork.ffmpeg.org/project/ffmpeg/list/?state=%2A=both is > from 1st October. > > Is Patchwork no longer active? fixed by raz Thanks for reporting the issue -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/utils: keep CORRUPT and TRUSTED packet flags when parsing packets

2018-10-11 Thread Michael Niedermayer
On Wed, Oct 10, 2018 at 01:32:14AM +0200, Marton Balint wrote: > An FF_ macro got defined in avcodec.h to store the flags which need to be > propagated when parsers split packets so this won't be forgotten when a new > packet flag is introduced. > > (I wonder if DISPOSABLE also fits here, or

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: log corrupted packets and frames

2018-10-11 Thread Michael Niedermayer
On Wed, Oct 10, 2018 at 01:32:13AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > fftools/ffmpeg.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) maybe this should also print some time information so the user knows from the printout when issues

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc_jpeg: set a default quality

2018-10-11 Thread Zhong Li
Keep alignment with vaapi mjpeg encoder. Signed-off-by: Zhong Li --- libavcodec/qsvenc_jpeg.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/qsvenc_jpeg.c b/libavcodec/qsvenc_jpeg.c index 01c10125..1e7785a 100644 --- a/libavcodec/qsvenc_jpeg.c +++

[FFmpeg-devel] [PATCH 1/2] lavc/qsvenc_jpeg: add async_depth support

2018-10-11 Thread Zhong Li
Currently qsv (m)jpeg encoding is broken. Regression introducing by the commit(id: c1bcd3): fix async support, which requires the minimum async_depth to be 1, instead previous zero. But the default async_depth of qsv (m)jpeg encoding is still initialized (mostly) as zero. This patch also

[FFmpeg-devel] [PATCH 5/5] avformat:hlsenc.c: fix the output's duration smaller than input's in sub-range mode.

2018-10-11 Thread Charles Liu
In fmp4 & sub-range mode, the output's duration always smaller than expected, because the size of the last #EXT-X-BYTERANGE is too small. Signed-off-by: Charles Liu --- libavformat/hlsenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH 4/5] avformat:hlsenc.c: the size of init.mp4 is zero.

2018-10-11 Thread Charles Liu
The size of init.mp4 is zero in fmp4 mode, when the input duraton smaller than the expected segment time. fix ticket: 7166 Signed-off-by: Charles Liu --- libavformat/hlsenc.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH 1/5] avformat/hlsenc: fix the duration of m4s segment is unusually smaller than expected.

2018-10-11 Thread Charles Liu
In fmp4 mode, the duration of the second m4s segment is unusually smaller than the expected segment time. Signed-off-by: Charles Liu --- libavformat/hlsenc.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 28c2dd62fc..3ccd8756f6 100644

[FFmpeg-devel] [PATCH 2/5] avformat:hlsenc.c: fix memory leak in fmp4 mode.

2018-10-11 Thread Charles Liu
Signed-off-by: Charles Liu --- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 3ccd8756f6..c322b5a48f 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2205,6 +2205,7 @@ static int

[FFmpeg-devel] [PATCH 3/5] avformat:hlsenc.c: remove the useless variable - fmp4_init_mode.

2018-10-11 Thread Charles Liu
Signed-off-by: Charles Liu --- libavformat/hlsenc.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index c322b5a48f..0fd5d2a995 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -147,7 +147,6 @@ typedef struct VariantStream {

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: only write video streams into HLS master playlist

2018-10-11 Thread Jeyapal, Karthick
On 9/14/18 12:38 PM, Jian Yang wrote: > Tool mediastreamvalidator reports error "Variant media_[N].m3u8 is > missing audio group" for audio streams in HLS master playlist. As audio > streams are already listed in audio group, skip them as variant media > streams in master playlist. > --- >