Re: [FFmpeg-devel] [PATCH] lavc/mjpegdec: fix VA-API MJPEG decoding uninitialized huffman table

2018-11-08 Thread myp...@gmail.com
On Fri, Nov 9, 2018 at 1:27 PM Eoff, Ullysses A wrote: > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > Eoff, Ullysses A > > Sent: Tuesday, October 30, 2018 11:42 AM > > To: FFmpeg development discussions and patches > > Cc: Zhao,

[FFmpeg-devel] [PATCH 5/6] h264_redundant_pps: Make it reference-compatible

2018-11-08 Thread Andreas Rheinhardt
Since c6a63e11092c975b89d824f08682fe31948d3686, the parameter sets modified as content of PPS units were references shared with the CodedBitsreamH264Context, so modifying them alters the parsing process of future access units which meant that frames often got discarded because invalid values were

[FFmpeg-devel] [PATCH 6/6] h264_redundant_pps: Fix logging context

2018-11-08 Thread Andreas Rheinhardt
The first element of H264RedundantPPSContext is not a pointer to an AVClass as required. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_redundant_pps_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_redundant_pps_bsf.c

[FFmpeg-devel] [PATCH 3/6] cbs_h2645: Create functions to make parameter sets writeable

2018-11-08 Thread Andreas Rheinhardt
av_buffer_make_writable can't be used here, because a shallow copy isn't enough for parameter sets. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h264.h | 8 libavcodec/cbs_h2645.c | 16 libavcodec/cbs_h265.h | 9 + 3 files changed, 33 insertions(+)

[FFmpeg-devel] [PATCH 2/6] cbs_h2645: Do a deep copy for parameter sets

2018-11-08 Thread Andreas Rheinhardt
This commit solves dangling pointers problems when the content of a parameter set isn't refcounted in the beginning: Now a deep copy of the parameter sets is performed. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h2645.c | 59 +++--- 1 file changed,

[FFmpeg-devel] [PATCH 0/6] h264_redundant_pps: Make bsf refcount-compliant

2018-11-08 Thread Andreas Rheinhardt
Commit c6a63e11092c975b89d824f08682fe31948d3686 made the parameter sets of both the CodedBitstreamH264Context and CodedBitstreamH265Context reference-counted and also stopped copying the parameter sets read from input; instead, the content of the parameter set units read from input are now shared

[FFmpeg-devel] [PATCH 1/6] cbs_h2645: Unify the free-functions via macro

2018-11-08 Thread Andreas Rheinhardt
The similarity between several free-functions is exploited to create them via a common macro. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h2645.c | 55 -- 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/libavcodec/cbs_h2645.c

[FFmpeg-devel] [PATCH 4/6] h264_redundant_pps: Fix memleak in case of errors

2018-11-08 Thread Andreas Rheinhardt
Now the fragment is uninitialized and the input packet freed in case of errors. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_redundant_pps_bsf.c | 46 ++--- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/libavcodec/h264_redundant_pps_bsf.c

Re: [FFmpeg-devel] [PATCH] lavc/mjpegdec: fix VA-API MJPEG decoding uninitialized huffman table

2018-11-08 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Eoff, Ullysses A > Sent: Thursday, November 08, 2018 9:27 PM > To: FFmpeg development discussions and patches > Cc: Zhao, Jun ; Lin, Decai > Subject: Re: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH] lavc/mjpegdec: fix VA-API MJPEG decoding uninitialized huffman table

2018-11-08 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Eoff, Ullysses A > Sent: Tuesday, October 30, 2018 11:42 AM > To: FFmpeg development discussions and patches > Cc: Zhao, Jun ; Lin, Decai > Subject: Re: [FFmpeg-devel] [PATCH]

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_scale_vaapi: add scaling mode setting support.

2018-11-08 Thread myp...@gmail.com
ping? On Sat, Oct 13, 2018 at 3:59 PM Jun Zhao wrote: > > before this change, scale_vaapi hard coding the scaling mode, add a > new option "mode" to setting the scaling mode, it can be use to change > scaling algorithm for performance/quality trade off. >

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: add an option to forbid the fallback to software path when hardware init fails

2018-11-08 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Linjie Fu > Sent: Thursday, November 08, 2018 7:14 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: add an option to forbid > the

[FFmpeg-devel] [PATCH v2] fftools/ffmpeg: add an option to forbid the fallback to software path when hardware init fails

2018-11-08 Thread Linjie Fu
Currently ff_get_format will go through all usable choices if the chosen format was not supported. It will fallback to software path if the hardware init fails. Provided an option "-fallback_forbid 1" in user-code to detect frame->format and hwaccel_get_buffer in get_buffer. If hardware init

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: Refine the do_video_out.

2018-11-08 Thread myp...@gmail.com
On Thu, Nov 8, 2018 at 11:45 PM Carl Eugen Hoyos wrote: > > 2018-11-08 16:35 GMT+01:00, Jun Zhao : > > Signed-off-by: Jun Zhao > > --- > > fftools/ffmpeg.c | 62 > > - > > 1 files changed, 28 insertions(+), 34 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: Refine the do_video_out.

2018-11-08 Thread myp...@gmail.com
On Fri, Nov 9, 2018 at 4:24 AM Michael Niedermayer wrote: > > On Thu, Nov 08, 2018 at 11:35:20PM +0800, Jun Zhao wrote: > > Signed-off-by: Jun Zhao > > --- > > fftools/ffmpeg.c | 62 > > - > > 1 files changed, 28 insertions(+), 34

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

2018-11-08 Thread Carl Eugen Hoyos
2018-11-08 21:44 GMT+01:00, Ard Oerlemans : > +#if CONFIG_LIBVPX_VP8_ENCODER > +if (frame->metadata) { if (CONFIG_LIBVPX_VP8_ENCODER && frame->metadata) may be more inline with FFmpeg's code style. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-08 Thread James Zern
On Mon, Nov 5, 2018 at 5:03 PM James Zern wrote: > > On Mon, Nov 5, 2018 at 5:02 PM James Zern wrote: > > > > vp9 now supports [0, 6] > > > > Signed-off-by: James Zern > > --- > > doc/encoders.texi | 1 + > > libavcodec/libvpxenc.c | 6 -- > > 2 files changed, 5 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] libvpxenc,vp9: add enable-tpl option

2018-11-08 Thread James Zern
On Sat, Nov 3, 2018 at 2:01 PM James Zern wrote: > > enables temporal dependency model > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 11 +++ > 2 files changed, 13 insertions(+) > If there aren't any comments I'll submit this one soon.

Re: [FFmpeg-devel] [PATCH] avcodec/qpeg: Optimize full width runs in qpeg_decode_intra()

2018-11-08 Thread Michael Niedermayer
On Mon, Nov 05, 2018 at 11:17:47PM +0100, Michael Niedermayer wrote: > This improves the speed of decoding large patches of constant color > > Fixes: Timeout > Fixes: > 10967/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QPEG_fuzzer-5630803793936384 > > Found-by: continuous fuzzing process

[FFmpeg-devel] avfilter/af_headphone : fix memleak

2018-11-08 Thread Martin Vignali
Hello, Patch in attach should fix the memleak report by coverity CID 1439934 CID 1439935 Replace return ret, by goto fail. Martin 0004-avfilter-af_headphone-fix-mem-leak.patch Description: Binary data ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-11-08 Thread Martin Vignali
Le dim. 28 oct. 2018 à 12:59, Martin Vignali a écrit : > Thanks for the comments > > New patch in attach > > - Change the options, to only authorized few value in prores frame (based > on rdd36). > - Change option name to match setparams filter > - Include intreadwrite instead of bytestream > -

Re: [FFmpeg-devel] avcodec/prores_aw : add support for alpha encoding

2018-11-08 Thread Martin Vignali
Rebase after prores profile patch fix stride used by alpha reorganization and pushed Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/1] cbs_h264: Fix handling of auxiliary pictures

2018-11-08 Thread Mark Thompson
On 07/11/18 03:47, Andreas Rheinhardt wrote: > The earlier code used the most recent non-auxiliary slice to determine > whether an auxiliary slice has the syntax of an IDR slice, even when > the most recent slice was from a slice of a redundant frame. Now only > slices of the primary coded picture

Re: [FFmpeg-devel] [PATCH] libavformat/ffmetadec: use dynamic allocation for line buffer

2018-11-08 Thread François Revol
Hi, Le 08/11/2018 à 20:50, Michael Niedermayer a écrit : >> +line = av_malloc(line_size); >> +if (!line) >> +return AVERROR(ENOMEM); > > this would use alot of memory for large files, also avio_size() will not > work with all inputs Yes I thought so as well, that was a quick fix

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

2018-11-08 Thread Ard Oerlemans
This commit adds configuration options to libvpxenc.c that can be used to enable VP8 temporal scalability. It also adds a way to programmatically set the per-frame encoding flags which can be used to control usage and updates of reference frames while encoding with temporal scalability enabled.

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: Refine the do_video_out.

2018-11-08 Thread Michael Niedermayer
On Thu, Nov 08, 2018 at 11:35:20PM +0800, Jun Zhao wrote: > Signed-off-by: Jun Zhao > --- > fftools/ffmpeg.c | 62 - > 1 files changed, 28 insertions(+), 34 deletions(-) The commit message "Refine the do_video_out." is too terse its not

Re: [FFmpeg-devel] [PATCH] libavformat/ffmetadec: use dynamic allocation for line buffer

2018-11-08 Thread Michael Niedermayer
On Wed, Nov 07, 2018 at 02:34:43PM +0100, François Revol wrote: > When adding thumbnails to OGG files, the line can easily go up to 100kB. > > We thus try to allocate the file size or SIZE_MAX to avoid truncation. > --- > libavformat/ffmetadec.c | 21 + > 1 file changed, 17

[FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-08 Thread Andrey Semashev
This commit restores the ability to create DASH streams with codecs that require different containers that was lost after commit 2efdbf7367989cf9d296c25fa3d2aff8d6e25fdd. It extends the dash_segment_type option syntax to allow to specify segment container types for individual streams, in addition

Re: [FFmpeg-devel] [PATCH v2] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-11-08 Thread Jan Ekström
On Thu, Nov 8, 2018, 03:39 Carl Eugen Hoyos 2018-11-08 0:11 GMT+01:00, Jan Ekström : > > > +{ AV_CODEC_ID_HEVC, MKTAG('d', 'v', 'h', '1') }, /* HEVC-based Dolby > > Vision derived from hvc1 */ > > As said before, this breaks real-world files, the patch is therefore not > ok. > (And as said

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: Refine the do_video_out.

2018-11-08 Thread Carl Eugen Hoyos
2018-11-08 16:35 GMT+01:00, Jun Zhao : > Signed-off-by: Jun Zhao > --- > fftools/ffmpeg.c | 62 > - > 1 files changed, 28 insertions(+), 34 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index da4259a..e989e7a 100644 >

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: indent the code

2018-11-08 Thread Jun Zhao
Signed-off-by: Jun Zhao --- fftools/ffmpeg.c | 69 ++--- 1 files changed, 34 insertions(+), 35 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index e989e7a..dbcc9cf 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1488,7

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: Refine the do_video_out.

2018-11-08 Thread Jun Zhao
Signed-off-by: Jun Zhao --- fftools/ffmpeg.c | 62 - 1 files changed, 28 insertions(+), 34 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index da4259a..e989e7a 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1193,33

Re: [FFmpeg-devel] [PATCH]lavf/apngdec: Return eof for incomplete files

2018-11-08 Thread Carl Eugen Hoyos
2018-11-08 13:36 GMT+01:00, Paul B Mahol : > On 11/8/18, Carl Eugen Hoyos wrote: >> 2018-11-08 13:23 GMT+01:00, Paul B Mahol : >>> On 11/7/18, Carl Eugen Hoyos wrote: 2018-11-07 1:07 GMT+01:00, Marton Balint : > > > On Wed, 7 Nov 2018, Carl Eugen Hoyos wrote: > >> Hi!

Re: [FFmpeg-devel] [PATCH]lavf/apngdec: Return eof for incomplete files

2018-11-08 Thread Paul B Mahol
On 11/8/18, Carl Eugen Hoyos wrote: > 2018-11-08 13:23 GMT+01:00, Paul B Mahol : >> On 11/7/18, Carl Eugen Hoyos wrote: >>> 2018-11-07 1:07 GMT+01:00, Marton Balint : On Wed, 7 Nov 2018, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences the console

Re: [FFmpeg-devel] [PATCH]lavf/apngdec: Return eof for incomplete files

2018-11-08 Thread Carl Eugen Hoyos
2018-11-08 13:23 GMT+01:00, Paul B Mahol : > On 11/7/18, Carl Eugen Hoyos wrote: >> 2018-11-07 1:07 GMT+01:00, Marton Balint : >>> >>> >>> On Wed, 7 Nov 2018, Carl Eugen Hoyos wrote: >>> Hi! Attached patch silences the console flooding for incomplete apng files and fixes

Re: [FFmpeg-devel] [PATCH]lavf/apngdec: Return eof for incomplete files

2018-11-08 Thread Paul B Mahol
On 11/7/18, Carl Eugen Hoyos wrote: > 2018-11-07 1:07 GMT+01:00, Marton Balint : >> >> >> On Wed, 7 Nov 2018, Carl Eugen Hoyos wrote: >> >>> Hi! >>> >>> Attached patch silences the console flooding for incomplete apng files >>> and fixes ticket #7536: >>> In-stream tag=[0][0][0][0] (0x)

Re: [FFmpeg-devel] [PATCH] add an option to forbid the fallback to sw when hardware init fails

2018-11-08 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Hendrik Leppkes > Sent: Tuesday, October 30, 2018 17:11 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] add an option to forbid the