Re: [FFmpeg-devel] [PATCH v3 1/2] lavf: Add general API for IO buffer synchronization.

2018-12-14 Thread Andrey Semashev
Ping? On December 10, 2018 3:05:54 PM Andrey Semashev wrote: This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media. The most obvious target for this extension if the filesystem streams. Invoking IO

[FFmpeg-devel] [PATCH v2] lavc/libdavs2: enable multithread

2018-12-14 Thread hwrenx
From: hwrenx Signed-off-by: hwrenx --- libavcodec/libdavs2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c index 37635bb..2846ecf 100644 --- a/libavcodec/libdavs2.c +++ b/libavcodec/libdavs2.c @@ -205,7 +205,7 @@ AVCodec

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/mxfdec: fix error check in macro

2018-12-14 Thread James Almer
> ffmpeg | branch: master | Paul B Mahol > | Thu Dec 13 23:51:02 > 2018 +0100| [e5a0013c4a6248fe7e2a651db1fda6b9bb2cd743] | committer: Paul B > Mahol > > avformat/mxfdec: fix error check in macro > > Fixes #6750. > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp7: Check for end of input in vp78_decode_mv_mb_modes()

2018-12-14 Thread Peter Ross
On Sat, Dec 15, 2018 at 02:44:43AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 10313/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5637719389110272 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avutil/tests/random_seed: seeds[] is uint32_t, therefore use PRIX32 macro

2018-12-14 Thread Peter Ross
On Sat, Dec 15, 2018 at 03:10:52AM +0100, Carl Eugen Hoyos wrote: > 2018-12-15 3:07 GMT+01:00, Peter Ross : > > squelch format type warning > > --- > > libavutil/tests/random_seed.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavutil/tests/random_seed.c

Re: [FFmpeg-devel] [PATCH] avutil/tests/random_seed: seeds[] is uint32_t, therefore use PRIX32 macro

2018-12-14 Thread Carl Eugen Hoyos
2018-12-15 3:07 GMT+01:00, Peter Ross : > squelch format type warning > --- > libavutil/tests/random_seed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c > index 78067dbe41..bf0c6c7986 100644 > ---

[FFmpeg-devel] [PATCH] avutil/tests/random_seed: seeds[] is uint32_t, therefore use PRIX32 macro

2018-12-14 Thread Peter Ross
squelch format type warning --- libavutil/tests/random_seed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/tests/random_seed.c b/libavutil/tests/random_seed.c index 78067dbe41..bf0c6c7986 100644 --- a/libavutil/tests/random_seed.c +++

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: skip subtitle PES packets if PCR not available

2018-12-14 Thread Carl Eugen Hoyos
2018-12-15 2:31 GMT+01:00, Jan Ekström : > Fixes issues when a subtitle packet is received before PCR for the > program has been received, leading to wildly jumping timestamps > on the lavf client side as well as in the re-ordering logic. > > This usually happens in case of multiplexes where the

[FFmpeg-devel] [PATCH 1/2] avcodec/vp7: Check for end of input in vp78_decode_mv_mb_modes()

2018-12-14 Thread Michael Niedermayer
Fixes: Timeout Fixes: 10313/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5637719389110272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 21 ++--- 1

[FFmpeg-devel] [PATCH 2/2] avcodec/rasc: Check that the number of moves is less than or equal the number of pixels

2018-12-14 Thread Michael Niedermayer
Fixes: OOM Fixes: 10307/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5393974559244288 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rasc.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH] avformat/mpegts: skip subtitle PES packets if PCR not available

2018-12-14 Thread Jan Ekström
Fixes issues when a subtitle packet is received before PCR for the program has been received, leading to wildly jumping timestamps on the lavf client side as well as in the re-ordering logic. This usually happens in case of multiplexes where the PCR of a program is not taken into account with

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/gif: enable encoding single gif image per frame

2018-12-14 Thread Carl Eugen Hoyos
2018-12-13 19:32 GMT+01:00, Paul B Mahol : > ffmpeg | branch: master | Paul B Mahol | Wed Dec 12 > 13:19:33 2018 +0100| [bb0984cc29e93e56506722fe0ce5c6d43b6d4326] | committer: > Paul B Mahol > > avcodec/gif: enable encoding single gif image per frame > > Unbreaks gif image2 muxer. > >>

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-14 Thread Carl Eugen Hoyos
2018-12-14 16:48 GMT+01:00, Paul B Mahol : > On 12/14/18, Carl Eugen Hoyos wrote: >> 2018-12-14 15:52 GMT+01:00, Paul B Mahol : >>> On 12/14/18, Carl Eugen Hoyos wrote: 2018-12-12 23:44 GMT+01:00, Paul B Mahol : > On 12/12/18, Carl Eugen Hoyos wrote: >> 2018-12-12 23:30 GMT+01:00,

Re: [FFmpeg-devel] [PATCH] lavf/mov: ensure only one tkhd per trak

2018-12-14 Thread Chris Cunningham
> > from a quick look, i did not find a file this breaks > Woot. Baptiste, I'm happy with this last patch if you are. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/avio: fix avio_feof documentation

2018-12-14 Thread Marton Balint
On Sun, 9 Dec 2018, Marton Balint wrote: It has been this way too long to change behaviour, so let's change the docs instead. Signed-off-by: Marton Balint --- libavformat/avio.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h

[FFmpeg-devel] [PATCH] lavf/id3v2: fail read_apic on EOF reading mimetype

2018-12-14 Thread chcunningham
avio_read may return EOF, leaving the mimetype array unitialized. fail early when this occurs to avoid using the array in an unitialized state. --- libavformat/id3v2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index

Re: [FFmpeg-devel] [PATCH] avcodec/rasc: Check input space before reading chunk

2018-12-14 Thread Michael Niedermayer
On Wed, Dec 05, 2018 at 03:05:58AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 8/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5652564066959360 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Document trailer index assert better

2018-12-14 Thread Paul B Mahol
On 12/14/18, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/nutenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c > index a92ff55c01..e9a3bb49db 100644 > --- a/libavformat/nutenc.c > +++

[FFmpeg-devel] [PATCH] avformat/nutenc: Document trailer index assert better

2018-12-14 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/nutenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c index a92ff55c01..e9a3bb49db 100644 --- a/libavformat/nutenc.c +++ b/libavformat/nutenc.c @@ -1172,7 +1172,7 @@ static int

Re: [FFmpeg-devel] [PATCH] avcodec/raw: add tags for P016

2018-12-14 Thread Paul B Mahol
On 12/14/18, Michael Niedermayer wrote: > On Fri, Dec 14, 2018 at 01:18:07PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/raw.c | 2 ++ >> 1 file changed, 2 insertions(+) > > this seems to break fate > Yes, I know. Is change OK as is? The P016 coverage is

Re: [FFmpeg-devel] [PATCH] avcodec/raw: add tags for P016

2018-12-14 Thread Michael Niedermayer
On Fri, Dec 14, 2018 at 01:18:07PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/raw.c | 2 ++ > 1 file changed, 2 insertions(+) this seems to break fate make: *** [fate-filter-pixdesc-p016le] Error 1 make: *** [fate-filter-pixdesc-p016be] Error 1 make: ***

Re: [FFmpeg-devel] [PATCH] lavf/id3v2: fail read_apic on EOF reading mimetype

2018-12-14 Thread Chris Cunningham
> > -char mimetype[64]; > +char mimetype[64] = {0}; > > would be enough > Agree! Next patch. I'd love to do similar for the isv34 branch, but I'm not sure how to detect > the condition given the EOF behavior for avio_get_str: > * @return number of bytes read (is always <= maxlen). > * If

Re: [FFmpeg-devel] [PATCH] fix infinite retry issue for rtsp when the uri has redirection

2018-12-14 Thread Lou Logan
On Thu, Dec 13, 2018, at 3:19 PM, tianhu yang wrote: > --- > libavformat/rtsp.c | 1 + > 1 file changed, 1 insertion(+) Thank you for the patch, but it does not apply. Please create patches with "git format-patch" or "git send-email", and provide a commit message.

Re: [FFmpeg-devel] [PATCH]lavc/ivi: Fix a Google-reported memleak

2018-12-14 Thread Carl Eugen Hoyos
2018-12-13 2:39 GMT+01:00, Michael Niedermayer : > On Tue, Dec 04, 2018 at 12:34:27AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch is supposed to fix a memleak from clusterfuzz, untested... >> >> Please review, Carl Eugen > >> ivi.c |1 + >> 1 file changed, 1 insertion(+) >>

[FFmpeg-devel] [PATCH] fix infinite retry issue for rtsp when the uri has redirection

2018-12-14 Thread tianhu yang
--- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index ceb770a3a4..6093424431 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1920,6 +1920,7 @@ redirect: } ff_format_set_url(s, new_url);

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg: Initialize quarter_sample parameter from previous thread.

2018-12-14 Thread Michael Niedermayer
On Wed, Dec 12, 2018 at 11:57:35PM -0500, Andriy Gelman wrote: > Fixes #7410. > The value of sub-pixel precision for me/mc can change during an Intra frame. > In multi-threaded decoding this change is not propagated to other frame > threads causing decoding artifacts. This patch initializes the

Re: [FFmpeg-devel] [PATCH v2] swscale/output: VSX-optimize 16-bit yuv2plane1

2018-12-14 Thread Michael Niedermayer
On Thu, Dec 13, 2018 at 02:07:58PM +0200, Lauri Kasanen wrote: > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > yuv420p16le \ > -f null -vframes 100 -v error -nostats - > > 2120 UNITS in planar1, 65393 runs,143 skips > > -cpuflags 0 > > 19157 UNITS in planar1,

Re: [FFmpeg-devel] [PATCH] lavf/mov: ensure only one tkhd per trak

2018-12-14 Thread Michael Niedermayer
On Thu, Dec 13, 2018 at 01:58:40PM -0800, chcunningham wrote: > Chromium fuzzing produced a whacky file with extra tkhds. This caused > an AVStream that was already in use to be corrupted by assigning it a > new id, which blows up later in mov_read_trun because the >

[FFmpeg-devel] [PATCH] avcodec/tiff: add support for 12bit grayscale images

2018-12-14 Thread Paul B Mahol
Fixes #4688. Signed-off-by: Paul B Mahol --- libavcodec/tiff.c | 29 + 1 file changed, 29 insertions(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index f71885d156..570b3cbd01 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -310,6 +310,19 @@ static

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-14 Thread Paul B Mahol
On 12/14/18, Carl Eugen Hoyos wrote: > 2018-12-14 15:52 GMT+01:00, Paul B Mahol : >> On 12/14/18, Carl Eugen Hoyos wrote: >>> 2018-12-12 23:44 GMT+01:00, Paul B Mahol : On 12/12/18, Carl Eugen Hoyos wrote: > 2018-12-12 23:30 GMT+01:00, Paul B Mahol : >> On 12/12/18, Carl Eugen

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/flac_picture: try to guess PNG by actual picture data

2018-12-14 Thread Carl Eugen Hoyos
2018-12-14 11:36 GMT+01:00, Paul B Mahol : > ffmpeg | branch: master | Paul B Mahol | Thu Dec 13 > 20:12:52 2018 +0100| [e9817636a7e132129fee0c34e05f224da14c5200] | committer: > Paul B Mahol > > avformat/flac_picture: try to guess PNG by actual picture data > > Fixes #5028. > >>

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-14 Thread Carl Eugen Hoyos
2018-12-14 15:52 GMT+01:00, Paul B Mahol : > On 12/14/18, Carl Eugen Hoyos wrote: >> 2018-12-12 23:44 GMT+01:00, Paul B Mahol : >>> On 12/12/18, Carl Eugen Hoyos wrote: 2018-12-12 23:30 GMT+01:00, Paul B Mahol : > On 12/12/18, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
From e85edcc4d8b0312c7871f78ed0859ec7436be460 Mon Sep 17 00:00:00 2001 From: Aleksey Skripka Date: Fri, 14 Dec 2018 14:48:31 + Subject: [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file 1. fix addressing '->flags' while assigning 'use_temp_file'. 2. before

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
one more try, via 'git format-patch'. 0001-libavformat-hlsenc-fix-broken-hls_flags-temp_file.patch Description: Binary data > On 14 Dec 2018, at 17:21, Steven Liu wrote: > > > >> On Dec 14, 2018, at 19:23, Aleksey Skripka wrote: >> >>> >>> On 14 Dec 2018, at 13:10, Liu Steven wrote:

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-14 Thread Paul B Mahol
On 12/14/18, Carl Eugen Hoyos wrote: > 2018-12-12 23:44 GMT+01:00, Paul B Mahol : >> On 12/12/18, Carl Eugen Hoyos wrote: >>> 2018-12-12 23:30 GMT+01:00, Paul B Mahol : On 12/12/18, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4553 for me. > > Please

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-14 Thread Carl Eugen Hoyos
2018-12-12 23:44 GMT+01:00, Paul B Mahol : > On 12/12/18, Carl Eugen Hoyos wrote: >> 2018-12-12 23:30 GMT+01:00, Paul B Mahol : >>> On 12/12/18, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #4553 for me. Please comment, Carl Eugen >>> >>> I do not like

Re: [FFmpeg-devel] [PATCH] lavc/libdavs2: enable multithread

2018-12-14 Thread Steven Liu
> On Dec 14, 2018, at 15:43, hwrenx wrote: > > From: hwrenx > > Signed-off-by: hwrenx > --- > libavcodec/libdavs2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c > index 37635bb..a714213 100644 > ---

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Steven Liu
> On Dec 14, 2018, at 19:23, Aleksey Skripka wrote: > >> >> On 14 Dec 2018, at 13:10, Liu Steven wrote: >> >> >> >>> 在 2018年12月14日,下午5:27,Aleksey Skripka 写道: >>> >>> greetings! >>> >>> fixed version. >>> thanks. >> Is this patch create by git format-patch ? > no. > diff -up fileA

[FFmpeg-devel] avformat/hls.c: Fix memory leak

2018-12-14 Thread Valery Kot
Patch for https://trac.ffmpeg.org/ticket/7610 hls.c:933 free_segment_dynarray(prev_segments, prev_n_segments); cleans all elements of prev_segments, but does not frees prev_segments array itself. As a result, process slowly leaks memory every time it updates playlist. Added call to

[FFmpeg-devel] [PATCH] avcodec/raw: add tags for P016

2018-12-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/raw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/raw.c b/libavcodec/raw.c index b6fb91c1c6..bfb9e8083b 100644 --- a/libavcodec/raw.c +++ b/libavcodec/raw.c @@ -72,6 +72,8 @@ const PixelFormatTag ff_raw_pix_fmt_tags[] = { {

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-14 Thread Paul B Mahol
Hi, On 12/13/18, Paul B Mahol wrote: > On 12/12/18, Carl Eugen Hoyos wrote: >> 2018-12-12 23:44 GMT+01:00, Paul B Mahol : >>> On 12/12/18, Carl Eugen Hoyos wrote: 2018-12-12 23:30 GMT+01:00, Paul B Mahol : > On 12/12/18, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch

Re: [FFmpeg-devel] [PATCH] lavf/id3v2: fail read_apic on EOF reading mimetype

2018-12-14 Thread Tomas Härdin
tor 2018-12-13 klockan 11:28 -0800 skrev chcunningham: > avio_read may return EOF, leaving the mimetype array unitialized. fail > early when this occurs to avoid using the array in an unitialized state. > --- >  libavformat/id3v2.c | 5 - >  1 file changed, 4 insertions(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
> On 14 Dec 2018, at 13:10, Liu Steven wrote: > > > >> 在 2018年12月14日,下午5:27,Aleksey Skripka 写道: >> >> greetings! >> >> fixed version. >> thanks. > Is this patch create by git format-patch ? no. diff -up fileA fileB >> >> --- >> --- libavformat/hlsenc.c.orig 2018-12-14

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Liu Steven
> 在 2018年12月14日,下午5:27,Aleksey Skripka 写道: > > greetings! > > fixed version. > thanks. Is this patch create by git format-patch ? > > --- > --- libavformat/hlsenc.c.orig 2018-12-14 09:25:06.541809226 + > +++ libavformat/hlsenc.c2018-12-14 09:19:16.129377384 + > @@

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Aleksey Skripka
greetings! fixed version. thanks. --- --- libavformat/hlsenc.c.orig 2018-12-14 09:25:06.541809226 + +++ libavformat/hlsenc.c2018-12-14 09:19:16.129377384 + @@ -1348,7 +1348,7 @@ static int hls_window(AVFormatContext *s char temp_filename[1024]; int64_t sequence =

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix broken -hls_flags +temp_file

2018-12-14 Thread Liu Steven
> 在 2018年12月14日,下午3:04,Aleksey Skripka 写道: > > greetings! > > after commit 223d2bde22ce33dcbcb6f17f234b609cb98f1fb6 temp_file functionality > totally broken. > > attached patch prototype will fix: > 1) while assigning 'use_temp_file' addressing to '->flags' is done > incorrectly in 4