Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-14 Thread Tobias Rapp
On 14.01.2019 17:20, Nicolas George wrote: Tobias Rapp (12019-01-14): Writing good code requires time. I don't see how being sponsored for development should have a negative correlation (in general) to the time invested on a specific topic/patch. Let us say somebody worked one day on a

Re: [FFmpeg-devel] [PATCH 2/2] lavf/qsvvpp: cope with MFX_ERR_MORE_DATA condition in VPP pipeline

2019-01-14 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Fu, Linjie > Sent: Tuesday, January 15, 2019 9:37 AM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavf/qsvvpp: cope with > MFX_ERR_MORE_DATA condition in VPP pipeline > >

[FFmpeg-devel] [PATCH] avfilter/vf_paletteuse: don't constantly free and realloc internal frames

2019-01-14 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_paletteuse.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index 5966f10685..289c663e8e 100644 --- a/libavfilter/vf_paletteuse.c +++

Re: [FFmpeg-devel] [PATCH 2/2] lavf/qsvvpp: cope with MFX_ERR_MORE_DATA condition in VPP pipeline

2019-01-14 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Maxym Dmytrychenko > Sent: Tuesday, January 15, 2019 03:12 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavf/qsvvpp: cope with

Re: [FFmpeg-devel] [PATCH] Mark .rodata section as read only in COFF object file

2019-01-14 Thread Tom Tan
Hi Carl Eugen, Could you please review the updated patch? Thanks. From 9f20fb097b8006ad38634a943298e47884bf2696 Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Thu, 10 Jan 2019 11:50:49 -0800 Subject: [PATCH] Switch .rodata section name to .rdata for COFF object file .rodata section is custom

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/utils: fix error like "offset 0x1f85: partial file"

2019-01-14 Thread myp...@gmail.com
On Tue, Jan 15, 2019 at 12:44 AM Nicolas George wrote: > > Hendrik Leppkes (12019-01-14): > >http is > > probably the only network protocol you're ever going to read a mov/mp4 > > file from > > Why? Generic file access like SFTP or

[FFmpeg-devel] [PATCH] img2enc: mention -frames:v in error message

2019-01-14 Thread Lou Logan
Signed-off-by: Lou Logan --- libavformat/img2enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index a09cc8ec50..bec4bf81dd 100644 --- a/libavformat/img2enc.c +++ b/libavformat/img2enc.c @@ -110,7 +110,8 @@ static int

[FFmpeg-devel] [PATCH 2/2] avcodec/ilbcdec: Fix undefined integer overflow lsf2poly()

2019-01-14 Thread Michael Niedermayer
The addition is moved up into the context where the variable is unsigned avoiding the undefined behavior Fixes: runtime error: signed integer overflow: 2147481972 + 4096 cannot be represented in type 'int' Fixes:

[FFmpeg-devel] [PATCH 1/2] avcodec/ilbcdec: Fix integer overflow in construct_vector()

2019-01-14 Thread Michael Niedermayer
webrtc contains explicit code to ignore the undefined behavior (RTC_NO_SANITIZE / OverflowingAddS32S32ToS32()) Probably fixes: Integer overflow (unreproducable here) Probably fixes: 12215/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-5767142427852800 Found-by: continuous

Re: [FFmpeg-devel] [PATCH]ffmpeg_opt: Warn if more than one -vf/-af option was specified

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 16:59 GMT+01:00, Gyan : > > On 14-01-2019 06:09 PM, Carl Eugen Hoyos wrote: >> This user mistake affects many people, attached patch fixes ticket #4184. > Partially useful. Users who do this, are usually not aware of how to > apply multiple filters, and this syntax is their attempt.

[FFmpeg-devel] [PATCH]lavf/cafdec: Do not fail hard for files ending with junk

2019-01-14 Thread Carl Eugen Hoyos
Hi! A user provided a real-life caf file ending with junk after the data chunk, QuickTime reads such files. Please comment, Carl Eugen From 67d49072d60b95ffc8838a20cb87b33b5904dc21 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 15 Jan 2019 00:22:50 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCHv2 2/6] avcodec/vp3dsp: add 12 pixel loop filter functions

2019-01-14 Thread Hendrik Leppkes
On Mon, Jan 14, 2019 at 9:48 PM Peter Ross wrote: > > --- > libavcodec/vp3dsp.c | 28 > libavcodec/vp3dsp.h | 5 + > 2 files changed, 25 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c > index 4e08ee0b8f..de0130a9cf

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not fail hard for more mov atoms

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 21:07 GMT+01:00, Michael Niedermayer : > On Mon, Jan 14, 2019 at 12:46:08PM +0100, Carl Eugen Hoyos wrote: >> 2019-01-14 10:05 GMT+01:00, Michael Niedermayer : >> > On Sun, Jan 13, 2019 at 11:14:52PM +0100, Carl Eugen Hoyos wrote: >> >> Hi! >> >> >> >> Attached patch fixes ticket #7679.

[FFmpeg-devel] [PATCHv2 6/6] avcodec/vp6: select idct based (loosely) on number of coefficients decoded

2019-01-14 Thread Peter Ross
The VP3/4/5/6 reference decoders all use three IDCT versions: one for the DC-only case, another for blocks with more than 10 coefficients, and an optimised one for blocks with up to 10 AC coefficents. VP6 relies on the sparse 10 coefficient version, and without it, IDCT drift occurs. Fixes:

[FFmpeg-devel] [PATCHv2 5/6] avcodec/vp6: use ff_vp3dsp_[hv]_loop_filter_12

2019-01-14 Thread Peter Ross
Partially fixes: https://trac.ffmpeg.org/ticket/1282 --- libavcodec/vp56.c| 10 ++ libavcodec/vp56.h| 1 + libavcodec/vp56dsp.c | 19 --- tests/ref/fate/vp61 | 230 ++--- tests/ref/fate/vp6f | 340 +-- 5 files changed,

[FFmpeg-devel] [PATCHv2 4/6] avcodec/vp6: use rounded shift for chroma motion vector calculation

2019-01-14 Thread Peter Ross
Partially fixes: https://trac.ffmpeg.org/ticket/1282 --- libavcodec/vp56.c | 8 +- tests/ref/fate/vp60 | 202 +- tests/ref/fate/vp61 | 238 +++--- tests/ref/fate/vp6f | 342 ++-- 4 files changed, 393

[FFmpeg-devel] [PATCHv2 3/6] avcodec/vp3dsp: add 10 coefficient version of the VP3 IDCT

2019-01-14 Thread Peter Ross
This version of the IDCT is used by the VP6 decoder. --- libavcodec/vp3dsp.c | 152 libavcodec/vp3dsp.h | 3 + 2 files changed, 155 insertions(+) diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c index de0130a9cf..ac4c57441c 100644 ---

[FFmpeg-devel] [PATCHv2 2/6] avcodec/vp3dsp: add 12 pixel loop filter functions

2019-01-14 Thread Peter Ross
--- libavcodec/vp3dsp.c | 28 libavcodec/vp3dsp.h | 5 + 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c index 4e08ee0b8f..de0130a9cf 100644 --- a/libavcodec/vp3dsp.c +++ b/libavcodec/vp3dsp.c @@ -228,14

[FFmpeg-devel] [PATCHv2 1/6] avcodec/vp3dsp: move vp3 init loop filter function to vp3dsp

2019-01-14 Thread Peter Ross
This is also used by the VP6 decoder. --- libavcodec/vp3.c| 22 +- libavcodec/vp3dsp.c | 32 libavcodec/vp3dsp.h | 2 ++ 3 files changed, 35 insertions(+), 21 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index

[FFmpeg-devel] [PATCHv2 0/6] improved VP6 decoding

2019-01-14 Thread Peter Ross
My last patch set omitted an essential vp3dsp modification. Thanks Michael for spotting this. I have incorporated Carl's other suggestions. Peter Ross (6): avcodec/vp3dsp: move vp3 init loop filter function to vp3dsp avcodec/vp3dsp: add 12 pixel loop filter functions avcodec/vp3dsp: add 10

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-01-14 Thread Michael Dirks
On 14.01.2019 20:32, Carl Eugen Hoyos wrote: 2019-01-14 20:02 GMT+01:00, Michael Fabian 'Xaymar' Dirks : Adds support for the pict_type field in AVFrame to amf_h264 and amf_h265 simultaneously. This field is needed in cases where the application wishes to override the frame type with another

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not fail hard for more mov atoms

2019-01-14 Thread Michael Niedermayer
On Mon, Jan 14, 2019 at 12:46:08PM +0100, Carl Eugen Hoyos wrote: > 2019-01-14 10:05 GMT+01:00, Michael Niedermayer : > > On Sun, Jan 13, 2019 at 11:14:52PM +0100, Carl Eugen Hoyos wrote: > >> Hi! > >> > >> Attached patch fixes ticket #7679. > >> > >> Please comment, Carl Eugen > > > >> mov.c |

Re: [FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 20:02 GMT+01:00, Michael Fabian 'Xaymar' Dirks : > Adds support for the pict_type field in AVFrame to amf_h264 and amf_h265 > simultaneously. This field is needed in cases where the application wishes > to override the frame type with another one, such as forcefully inserting a > key

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add HCOM decoder

2019-01-14 Thread Paul B Mahol
On 1/6/19, Carl Eugen Hoyos wrote: > 2019-01-03 0:51 GMT+01:00, Rostislav Pehlivanov : >> On Wed, 2 Jan 2019 at 19:02, Paul B Mahol wrote: > > >>> +while (bits-- > 0) { >>> + >>> +if (current & 0x8000) { >>> +s->dict_entry = s->dict[s->dict_entry].r; >>> +

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Michael Niedermayer
On Mon, Jan 14, 2019 at 01:43:45PM -0500, Devin Heitmueller wrote: > On Mon, Jan 14, 2019 at 12:45 PM Michael Niedermayer > wrote: > > well, there are other types of side data too. for example motion > > vectors would need to be updated on crop depending on which rectangle > > is croped out > >

[FFmpeg-devel] [PATCH 2/2] avcodec/dxva2: check pix_fmt before the loop instead of checking it inside

2019-01-14 Thread Anton Fedchin
--- libavcodec/dxva2.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c index e0919d0b1c..dfae500444 100644 --- a/libavcodec/dxva2.c +++ b/libavcodec/dxva2.c @@ -778,9 +778,11 @@ unsigned ff_dxva2_get_surface_index(const

[FFmpeg-devel] [PATCH 1/2] avcodec/dxva2: d3d11va: don't try to get surface description for nullptr

2019-01-14 Thread Anton Fedchin
From: Anton Fedchin after 153b36f there is a possibility to crash when trying to get index of a surface which points to nirvana. it may occurs when a stream starts with non i-frame. --- libavcodec/dxva2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxva2.c

[FFmpeg-devel] [PATCH] amfenc: Add support for pict_type field

2019-01-14 Thread Michael Fabian 'Xaymar' Dirks
Adds support for the pict_type field in AVFrame to amf_h264 and amf_h265 simultaneously. This field is needed in cases where the application wishes to override the frame type with another one, such as forcefully inserting a key frame for chapter markers or similar. Additionally this abuses

Re: [FFmpeg-devel] [PATCH 2/2] lavf/qsvvpp: cope with MFX_ERR_MORE_DATA condition in VPP pipeline

2019-01-14 Thread Maxym Dmytrychenko
On Mon, Jan 14, 2019 at 5:53 PM Rostislav Pehlivanov wrote: > On Mon, 14 Jan 2019 at 12:40, Linjie Fu wrote: > > > Returning AVERROR(EAGAIN) when libmfx needs more data will cause the > > failure > > of requesting the next frame and lead to an infinite loop. > > > > Sleep for a while to release

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Devin Heitmueller
On Mon, Jan 14, 2019 at 12:45 PM Michael Niedermayer wrote: > well, there are other types of side data too. for example motion > vectors would need to be updated on crop depending on which rectangle > is croped out Ah, yes, of course. I thought we were just discussing captions. So are you

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-01-14 Thread Paul B Mahol
On 1/14/19, Nicolas George wrote: > Paul B Mahol (12019-01-14): >> Will apply ASAP! > > I have spotted at least one problem (conditional compilation) but I have > no time to make a real review until at least ten days, alas. If you have no time for real review why not disconnect from

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-01-14 Thread Nicolas George
Paul B Mahol (12019-01-14): > Will apply ASAP! I have spotted at least one problem (conditional compilation) but I have no time to make a real review until at least ten days, alas. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-01-14 Thread Paul B Mahol
On 1/13/19, Paul B Mahol wrote: > On 1/13/19, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 14 ++ >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter/vf_colorkey.c | 93 ++-

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Michael Niedermayer
On Mon, Jan 14, 2019 at 11:11:59AM -0500, Devin Heitmueller wrote: > > > In short, a centralized function would be good, but we probably need > > > to think through what the API looks like so we don't have to introduce > > > a new API in libavutil and then deprecate it once we want to make the > >

Re: [FFmpeg-devel] [PATCH v2] api-h264-slice-test: fix arguments and help

2019-01-14 Thread Michael Niedermayer
On Sun, Jan 13, 2019 at 05:35:32PM +0100, Rafaël Carré wrote: > This patch also changes the call to api-h264-slice-test. > > v1 was done during a working day but was not requested by the direction. > > v2 was done on sunday. > > I think it's fair to say I was not paid for this, and to reassure

Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function

2019-01-14 Thread Paul B Mahol
On 1/14/19, Carl Eugen Hoyos wrote: > 2019-01-14 17:39 GMT+01:00, Paul B Mahol : >> On 1/14/19, Carl Eugen Hoyos wrote: >>> 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : >>> Attached patch removes an unused function from cfhd.c. >>> >>> Ping, the function seems less needed than expected

[FFmpeg-devel] [PATCH]lavf/rtpproto: Use correct path when including poll.h

2019-01-14 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a warning when compiling with musl. Please comment, Carl Eugen From 91aabded879973cd266988790e894fe687c69a0d Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 14 Jan 2019 18:21:15 +0100 Subject: [PATCH] lavf/rtpproto: Use the correct patch when including poll.h

Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 17:39 GMT+01:00, Paul B Mahol : > On 1/14/19, Carl Eugen Hoyos wrote: >> 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : >> >>> Attached patch removes an unused function from cfhd.c. >> >> Ping, the function seems less needed than expected (and >> can be resurrected anytime). > NACK >

Re: [FFmpeg-devel] [PATCH 2/2] lavf/qsvvpp: cope with MFX_ERR_MORE_DATA condition in VPP pipeline

2019-01-14 Thread Rostislav Pehlivanov
On Mon, 14 Jan 2019 at 12:40, Linjie Fu wrote: > Returning AVERROR(EAGAIN) when libmfx needs more data will cause the > failure > of requesting the next frame and lead to an infinite loop. > > Sleep for a while to release the resources before calling > MFXVideoCORE_SyncOperation > in hwupload to

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-14 Thread Ronald S. Bultje
Hi, On Mon, Jan 14, 2019 at 11:13 AM Nicolas George wrote: > Ronald S. Bultje (12019-01-13): > > Wait, what? *You* are suggesting a policy change, not me/us. There is no > > burden of proof on me. You have to convince me (and us) that your problem > > is important and your proposal solves the

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/utils: fix error like "offset 0x1f85: partial file"

2019-01-14 Thread Nicolas George
Hendrik Leppkes (12019-01-14): >http is > probably the only network protocol you're ever going to read a mov/mp4 > file from Why? Generic file access like SFTP or Samba seem like good candidates too. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/utils: fix error like "offset 0x1f85: partial file"

2019-01-14 Thread Hendrik Leppkes
On Mon, Jan 14, 2019 at 5:32 PM Hendrik Leppkes wrote: > > On Mon, Jan 14, 2019 at 5:09 PM Jun Zhao wrote: > > > > fix the issue like "offset 0x1f85: partial file" when demuxer mp4 > > from http/https/crypto > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/utils.c |3 ++- > > 1

Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function

2019-01-14 Thread Paul B Mahol
On 1/14/19, Carl Eugen Hoyos wrote: > 2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : > >> Attached patch removes an unused function from cfhd.c. > > Ping, the function seems less needed than expected (and > can be resurrected anytime). > > Carl Eugen >

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/utils: fix error like "offset 0x1f85: partial file"

2019-01-14 Thread Hendrik Leppkes
On Mon, Jan 14, 2019 at 5:09 PM Jun Zhao wrote: > > fix the issue like "offset 0x1f85: partial file" when demuxer mp4 > from http/https/crypto > > Signed-off-by: Jun Zhao > --- > libavformat/utils.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-14 Thread Nicolas George
Tobias Rapp (12019-01-14): > Writing good code requires time. I don't see how being sponsored for > development should have a negative correlation (in general) to the time > invested on a specific topic/patch. Let us say somebody worked one day on a sponsored patch. They now have two choices: -

Re: [FFmpeg-devel] [PATCH]lavc/cfhd: Drop an unused function

2019-01-14 Thread Carl Eugen Hoyos
2018-08-23 16:00 GMT+02:00, Carl Eugen Hoyos : > Attached patch removes an unused function from cfhd.c. Ping, the function seems less needed than expected (and can be resurrected anytime). Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-14 Thread Nicolas George
Ronald S. Bultje (12019-01-13): > Wait, what? *You* are suggesting a policy change, not me/us. There is no > burden of proof on me. You have to convince me (and us) that your problem > is important and your proposal solves the problem. I am not convinced. I gave arguments in the commit message.

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Devin Heitmueller
> > In short, a centralized function would be good, but we probably need > > to think through what the API looks like so we don't have to introduce > > a new API in libavutil and then deprecate it once we want to make the > > splitting/combining logic work according to the spec. > > I fear that no

[FFmpeg-devel] [PATCH V2 2/2] lavc/hls: Cosmetics: Fix indentation for free_segment_list

2019-01-14 Thread Jun Zhao
Commit 673d8cfd518 missed the indent Signed-off-by: Jun Zhao --- libavformat/hls.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 63e1abe..8975a87 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -223,9 +223,9

[FFmpeg-devel] [PATCH V2 1/2] lavf/utils: fix error like "offset 0x1f85: partial file"

2019-01-14 Thread Jun Zhao
fix the issue like "offset 0x1f85: partial file" when demuxer mp4 from http/https/crypto Signed-off-by: Jun Zhao --- libavformat/utils.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 7afef54..92a0eb7 100644 ---

Re: [FFmpeg-devel] [PATCH V1 2/2] lavc/hls: Cosmetics: Fix indentation for free_segment_list

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 16:54 GMT+01:00, Jun Zhao : > Commit 673d8cfd518 missed the indent > > Signed-off-by: Jun Zhao > --- > libavformat/hls.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 63e1abe..2dd42ff 100644 > ---

[FFmpeg-devel] [PATCH V1 2/2] lavc/hls: Cosmetics: Fix indentation for free_segment_list

2019-01-14 Thread Jun Zhao
Commit 673d8cfd518 missed the indent Signed-off-by: Jun Zhao --- libavformat/hls.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 63e1abe..2dd42ff 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -12,7 +12,7

[FFmpeg-devel] [PATCH V1 1/2] lavf/utils: fix error like "offset 0x1f85: partial file"

2019-01-14 Thread Jun Zhao
fix the issue like "offset 0x1f85: partial file" when demuxer mp4 from http/https/crypto Signed-off-by: Jun Zhao --- libavformat/utils.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 7afef54..92a0eb7 100644 ---

Re: [FFmpeg-devel] [PATCH]ffmpeg_opt: Warn if more than one -vf/-af option was specified

2019-01-14 Thread Gyan
On 14-01-2019 06:09 PM, Carl Eugen Hoyos wrote: Hi! This user mistake affects many people, attached patch fixes ticket #4184. Please comment, Carl Eugen Partially useful. Users who do this, are usually not aware of how to apply multiple filters, and this syntax is their attempt. The error

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Michael Niedermayer
On Mon, Jan 14, 2019 at 09:21:10AM -0500, Devin Heitmueller wrote: > On Mon, Jan 14, 2019 at 3:31 AM Michael Niedermayer > wrote: > > Thus a new function should be added which does all this, and that then > > be used > > For what it's worth, the fix is actually incorrect both here and in >

Re: [FFmpeg-devel] [PATCH v6] libswscale/ppc: VSX-optimize 9-16 bit yuv2planeX

2019-01-14 Thread Michael Niedermayer
On Sun, Jan 13, 2019 at 10:26:20AM +0200, Lauri Kasanen wrote: > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > yuv420p16be \ > -s 1920x1728 -f null -vframes 100 -v error -nostats - > > 9-14 bit funcs get about 6x speedup, 16-bit gets about 15x. > Fate passes, each

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Devin Heitmueller
On Mon, Jan 14, 2019 at 3:31 AM Michael Niedermayer wrote: > Thus a new function should be added which does all this, and that then > be used For what it's worth, the fix is actually incorrect both here and in vf_vps. When doubling the framerate, the correct behavior is to split the content

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Nicolas George
Carl Eugen Hoyos (12019-01-14): > Then we would have the same function as now, no? No, the function we have now removes side data based on its type, the new function would remove it based on circumstances, whatever that means to be determined at a later point. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: fix B predictor validity for 4-MV MBs

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 13:05 GMT+01:00, Jerome Borsboom : >> 2019-01-14 9:05 GMT+01:00, Jerome Borsboom > carpalis.nl>: >>> The B predictor for 4-MV MBs in interlace field pictures is not used >>> for blocks 0 and 2 when the picture is 1 MB wide. >>> >>> Signed-off-by: Jerome Borsboom >>> --- >>> My 'shuffle

[FFmpeg-devel] [PATCH 2/2] lavf/qsvvpp: cope with MFX_ERR_MORE_DATA condition in VPP pipeline

2019-01-14 Thread Linjie Fu
Returning AVERROR(EAGAIN) when libmfx needs more data will cause the failure of requesting the next frame and lead to an infinite loop. Sleep for a while to release the resources before calling MFXVideoCORE_SyncOperation in hwupload to avoid the crash (in MCTF for example). Signed-off-by:

[FFmpeg-devel] [PATCH] lavf/qsvvpp: add support for Motion Compensated Temporal Filter

2019-01-14 Thread Linjie Fu
Add support for Motion Compensated Temporal Filter in QSV VPP. [1, 20] to indicate the filter-strength of MCTF, 0 stands for AUTO mode, -1 stands for default OFF. A strength of MCTF process controls degree of possible changes of pixel values eligible for MCTF. The limitation of MSDK API version:

[FFmpeg-devel] [PATCH]ffmpeg_opt: Warn if more than one -vf/-af option was specified

2019-01-14 Thread Carl Eugen Hoyos
Hi! This user mistake affects many people, attached patch fixes ticket #4184. Please comment, Carl Eugen From cb10736ba113a7791816a4db2478eb25f148100f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 14 Jan 2019 13:34:22 +0100 Subject: [PATCH] ffmpeg_opt: Print a warning if more than

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 13:12 GMT+01:00, Nicolas George : > Carl Eugen Hoyos (12019-01-14): >> Do you mean a new function that exactly removes the kind of side >> data that we decide in advance should always be removed from >> duplicated frames? > > That seems like a good idea. Applications may want to

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Nicolas George
Carl Eugen Hoyos (12019-01-14): > Do you mean a new function that exactly removes the kind of side > data that we decide in advance should always be removed from > duplicated frames? That seems like a good idea. Applications may want to duplicate frames too, and they will not be updated when we

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: fix B predictor validity for 4-MV MBs

2019-01-14 Thread Jerome Borsboom
> 2019-01-14 9:05 GMT+01:00, Jerome Borsboom : >> The B predictor for 4-MV MBs in interlace field pictures is not used >> for blocks 0 and 2 when the picture is 1 MB wide. >> >> Signed-off-by: Jerome Borsboom >> --- >> My 'shuffle calculation of MV predictor candidates' patch overlooked the >>

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not fail hard for more mov atoms

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 10:05 GMT+01:00, Michael Niedermayer : > On Sun, Jan 13, 2019 at 11:14:52PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #7679. >> >> Please comment, Carl Eugen > >> mov.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >>

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/vp6: use ff_vp4_[hv]_loop_filter_12_c

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 9:11 GMT+01:00, Peter Ross : > On Sun, Jan 13, 2019 at 09:39:57PM +0100, Carl Eugen Hoyos wrote: >> 2019-01-13 21:02 GMT+01:00, Peter Ross : >> > --- >> > libavcodec/vp56.c| 10 ++ >> > libavcodec/vp56.h| 1 + >> > libavcodec/vp56dsp.c | 19 --- >> > 3

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 9:03 GMT+01:00, Fu, Linjie : >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Li, Zhong >> Sent: Friday, January 11, 2019 11:43 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re:

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: fix B predictor validity for 4-MV MBs

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 9:05 GMT+01:00, Jerome Borsboom : > The B predictor for 4-MV MBs in interlace field pictures is not used > for blocks 0 and 2 when the picture is 1 MB wide. > > Signed-off-by: Jerome Borsboom > --- > My 'shuffle calculation of MV predictor candidates' patch overlooked the > corner case

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Carl Eugen Hoyos
2019-01-14 9:31 GMT+01:00, Michael Niedermayer : > On Sun, Jan 13, 2019 at 05:26:49PM -0500, Gabriel Blanchard wrote: >> When frame doubling using yadif/bwdif closed captioning gets copied to >> the >> second frame - as a result the closed captioning text is garbage. >> >> I've attached a very

Re: [FFmpeg-devel] [PATCH] doc/developer: require transparency about sponshorships.

2019-01-14 Thread Tobias Rapp
On 13.01.2019 16:24, Nicolas George wrote: James Almer (12019-01-13): How is that related to sponsored work? If a patch was ignored, then the extra line in the commit message would have been ignored as much as the actual code. Without sponsoring, most reasons for developing code are

Re: [FFmpeg-devel] [PATCH]lavf/mov: Do not fail hard for more mov atoms

2019-01-14 Thread Michael Niedermayer
On Sun, Jan 13, 2019 at 11:14:52PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #7679. > > Please comment, Carl Eugen > mov.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > a2759589f6ab06b09057969490ffc13291965144 >

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Michael Niedermayer
On Sun, Jan 13, 2019 at 05:26:49PM -0500, Gabriel Blanchard wrote: > When frame doubling using yadif/bwdif closed captioning gets copied to the > second frame - as a result the closed captioning text is garbage. > > I've attached a very simple patch that fixes this issue. Very similar to > what

Re: [FFmpeg-devel] [PATCH 0/6] improved VP6 decoding

2019-01-14 Thread Peter Ross
On Sun, Jan 13, 2019 at 09:42:10PM +0100, Carl Eugen Hoyos wrote: > 2019-01-13 21:00 GMT+01:00, Peter Ross : > > These patches make FFmpeg match the output of the VP6 reference > > decoder. Collectively they fix > > But none of the commit messages mention the

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/vp6: select idct based (loosely) on number of coefficients decoded

2019-01-14 Thread Peter Ross
On Sun, Jan 13, 2019 at 09:52:33PM +0100, Carl Eugen Hoyos wrote: > 2019-01-13 21:03 GMT+01:00, Peter Ross : > > --- > > libavcodec/vp5.c | 1 + > > libavcodec/vp56.c | 30 -- > > libavcodec/vp56.h | 2 ++ > > libavcodec/vp6.c | 14 ++ > > 4 files

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/vp6: use ff_vp4_[hv]_loop_filter_12_c

2019-01-14 Thread Peter Ross
On Sun, Jan 13, 2019 at 09:39:57PM +0100, Carl Eugen Hoyos wrote: > 2019-01-13 21:02 GMT+01:00, Peter Ross : > > --- > > libavcodec/vp56.c| 10 ++ > > libavcodec/vp56.h| 1 + > > libavcodec/vp56dsp.c | 19 --- > > 3 files changed, 11 insertions(+), 19 deletions(-)

[FFmpeg-devel] [PATCH] avcodec/vc1: fix B predictor validity for 4-MV MBs

2019-01-14 Thread Jerome Borsboom
The B predictor for 4-MV MBs in interlace field pictures is not used for blocks 0 and 2 when the picture is 1 MB wide. Signed-off-by: Jerome Borsboom --- My 'shuffle calculation of MV predictor candidates' patch overlooked the corner case of 1 MB wide field interlace pictures. According to VC-1

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC support for H264

2019-01-14 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Friday, January 11, 2019 11:43 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/qsvenc: add VDENC >