Re: [FFmpeg-devel] lavc/libvpxenc: Deprecate lossless option

2019-02-08 Thread Gyan
On 09-02-2019 02:26 AM, Carl Eugen Hoyos wrote: 2019-02-08 6:08 GMT+01:00, Gyan : On 08-02-2019 03:31 AM, Carl Eugen Hoyos wrote: . No strong opinion here, I hadn't realized that -crf 0 only works with newer versions. Can you explain why crf alone has no effect and needs -b:v 0? Isn't this

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Elliott Balsley
> my understand was that nvenc was just calling the actual driver with a few > trampoline functions. The kernel module is compilable, but the actual driver > is not open source, and installed with the machine, but is called from the > kernel module. Both are system libraries. The Nvidia Driver

[FFmpeg-devel] [PATCH]lavu/parseutils: Allow to parse >100 hours

2019-02-08 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7721 for the reporter. Please comment, Carl Eugen From ba6abc57d563bcc22607ff5d9f77fdce76000bf6 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 9 Feb 2019 01:20:43 +0100 Subject: [PATCH] lavu/parseutils: Allow to parse >= 100 hours. Reported and

Re: [FFmpeg-devel] [PATCH] configure: warn about disabled explicitly enabled components

2019-02-08 Thread Marton Balint
On Sat, 9 Feb 2019, Carl Eugen Hoyos wrote: 2019-02-05 22:14 GMT+01:00, Marton Balint : If we enable a component but a dependant library is disabled, then the enabled component gets silently disabled. Warning about disabled explicitly enabled components allows configure to show the missing

Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Convert service name and service provider to utf-8

2019-02-08 Thread Carl Eugen Hoyos
2019-02-08 23:09 GMT+01:00, Marton Balint : > > > On Fri, 8 Feb 2019, Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch fixes ticket #6320, tested with the sample from ticket >> #7069. >> >> Please comment, Carl Eugen >> >> From fdcd141a29f336925681193a9cdd3f4eaa5c368e Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH] configure: warn about disabled explicitly enabled components

2019-02-08 Thread Carl Eugen Hoyos
2019-02-05 22:14 GMT+01:00, Marton Balint : > If we enable a component but a dependant library is disabled, then the > enabled > component gets silently disabled. Warning about disabled explicitly enabled > components > allows configure to show the missing dependencies and if --fatal-warnings is >

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Jean-Baptiste Kempf
On Fri, 8 Feb 2019, at 23:42, Carl Eugen Hoyos wrote: > 2019-02-08 22:51 GMT+01:00, Jean-Baptiste Kempf : > > > The Decklink part is similar > > I don't think it is similar: How can a driver for a very optional hardware > that nearly no user possesses and for which you have to download a >

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Michael Niedermayer
On Fri, Feb 08, 2019 at 10:03:36AM +0100, Jean-Baptiste Kempf wrote: > Hello, > > On Wed, 6 Feb 2019, at 21:41, Werner Robitza wrote: > > Homebrew has, with its 2.0 release, removed all options for its core > > formulae [1], including ffmpeg. This means users can no longer add > > non-default

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Carl Eugen Hoyos
2019-02-08 22:51 GMT+01:00, Jean-Baptiste Kempf : > The Decklink part is similar I don't think it is similar: How can a driver for a very optional hardware that nearly no user possesses and for which you have to download a driver via a complicated procedure be called a system library? Carl

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Michael Niedermayer
On Fri, Feb 08, 2019 at 05:07:03PM -0300, James Almer wrote: > On 2/8/2019 12:17 AM, Chris Cunningham wrote: > > On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: > > > >> Can a valid ogm stream contain more than one header packet? > > > > > > Looking at ogg_packet oggdec.c, we read headers

Re: [FFmpeg-devel] [PATCH] configure: warn about disabled explicitly enabled components

2019-02-08 Thread Marton Balint
On Tue, 5 Feb 2019, Marton Balint wrote: If we enable a component but a dependant library is disabled, then the enabled component gets silently disabled. Warning about disabled explicitly enabled components allows configure to show the missing dependencies and if --fatal-warnings is used it

[FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Mathieu Duponchelle
--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 32 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++

Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Convert service name and service provider to utf-8

2019-02-08 Thread Marton Balint
On Fri, 8 Feb 2019, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #6320, tested with the sample from ticket #7069. Please comment, Carl Eugen From fdcd141a29f336925681193a9cdd3f4eaa5c368e Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 8 Feb 2019 01:35:33 +0100

[FFmpeg-devel] [PATCH] avformat/matroskadec: Do not leak queued packets on sync errors

2019-02-08 Thread Michael Niedermayer
Fixes: memleak Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-5649187601121280 Reported-by: Chris Cunningham Tested-by: Chris Cunningham Signed-off-by: Michael Niedermayer --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Jean-Baptiste Kempf
On Fri, 8 Feb 2019, at 22:27, Elliott Balsley wrote: > > But this is a different case than nvenc. > > How is it different? Nvenc links against libraries in the proprietary > Nvidia driver, for which source is not available. This is fine since > Nvidia library is considered to be a system

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread James Almer
On 2/8/2019 5:51 PM, Carl Eugen Hoyos wrote: > 2019-02-08 21:07 GMT+01:00, James Almer : >> On 2/8/2019 12:17 AM, Chris Cunningham wrote: >>> On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: >>> Can a valid ogm stream contain more than one header packet? >>> >>> >>> Looking at ogg_packet

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Elliott Balsley
> But this is a different case than nvenc. How is it different? Nvenc links against libraries in the proprietary Nvidia driver, for which source is not available. This is fine since Nvidia library is considered to be a system library under GPL. So why is Blackmagic not considered a system

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Jean-Baptiste Kempf
On Fri, 8 Feb 2019, at 22:08, Lou Logan wrote: > On Fri, Feb 8, 2019, at 11:27 AM, Jean-Baptiste Kempf wrote: > > > > Also, the AUR recipe does not push for non-free packages. > > The proposed homebrew formulae will not push for non-free packages. It > will simply provide the options for the

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Jean-Baptiste Kempf
On Fri, 8 Feb 2019, at 22:11, Elliott Balsley wrote: > > > The source of the driver is in the Linux SDK package, but not of the > > controlling library. > > (This is the opposite of the nVidia drivers, from my understanding) > > Could you explain what you mean by that? I think the source for

Re: [FFmpeg-devel] [PATCH v6] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Aman Gupta
On Fri, Feb 8, 2019 at 7:26 AM Mathieu Duponchelle wrote: > --- > doc/encoders.texi | 3 +++ > libavcodec/mpeg12enc.c | 32 > libavcodec/mpegvideo.h | 2 ++ > 3 files changed, 37 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Elliott Balsley
> The source of the driver is in the Linux SDK package, but not of the > controlling library. > (This is the opposite of the nVidia drivers, from my understanding) Could you explain what you mean by that? I think the source for both Blackmagic and Nvidia libraries are proprietary.

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Lou Logan
On Fri, Feb 8, 2019, at 11:27 AM, Jean-Baptiste Kempf wrote: > > Also, the AUR recipe does not push for non-free packages. The proposed homebrew formulae will not push for non-free packages. It will simply provide the options for the user to enable two non-free components (openssh and fdk-aac

Re: [FFmpeg-devel] lavc/libvpxenc: Deprecate lossless option

2019-02-08 Thread Carl Eugen Hoyos
2019-02-08 6:08 GMT+01:00, Gyan : > > > On 08-02-2019 03:31 AM, Carl Eugen Hoyos wrote: >> . >> No strong opinion here, I hadn't realized that -crf 0 only works with >> newer versions. >> >> Can you explain why crf alone has no effect and needs -b:v 0? >> Isn't this a bug both with libvpx and

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Carl Eugen Hoyos
2019-02-08 21:07 GMT+01:00, James Almer : > On 2/8/2019 12:17 AM, Chris Cunningham wrote: >> On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: >> >>> Can a valid ogm stream contain more than one header packet? >> >> >> Looking at ogg_packet oggdec.c, we read headers until hitting the first >>

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Jean-Baptiste Kempf
On Fri, 8 Feb 2019, at 18:31, Elliott Balsley wrote: > > > On Feb 8, 2019, at 01:17, Jean-Baptiste Kempf wrote: > > > > Decklink SDK has a very weird EULA + headers license that makes it very > > dubious that it is free. > > Decklink refuses to clarify for now. That warrants a non-free flag. >

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Jean-Baptiste Kempf
On Fri, 8 Feb 2019, at 21:18, Lou Logan wrote: > On Fri, Feb 8, 2019, at 12:03 AM, Jean-Baptiste Kempf wrote: > > > > Helping people to build non-free distributions of FFmpeg is a very weird > > and dubious goal. > > This is just helping other people violate the FFmpeg license. > > You could

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Jean-Baptiste Kempf
On Fri, 8 Feb 2019, at 19:06, Werner Robitza wrote: > Hello, > > Thanks for your comments. > > On Fri, Feb 8, 2019 at 10:03 AM Jean-Baptiste Kempf wrote: > > Why do something special for homebrew, and not for all the other > > distributions? > > Why is homebrew different? Are you going to

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Lou Logan
On Fri, Feb 8, 2019, at 12:03 AM, Jean-Baptiste Kempf wrote: > > Helping people to build non-free distributions of FFmpeg is a very weird > and dubious goal. > This is just helping other people violate the FFmpeg license. You could say the same thing for other build scripts such as the AUR for

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread James Almer
On 2/8/2019 12:17 AM, Chris Cunningham wrote: > On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: > >> Can a valid ogm stream contain more than one header packet? > > > Looking at ogg_packet oggdec.c, we read headers until hitting the first > non-header (counted in ogg stream field

[FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Chris Cunningham
Codec information may change while reading ogg packets. Update the stream's internal avctx to match. --- libavformat/oggparseogm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/oggparseogm.c b/libavformat/oggparseogm.c index a07453760b..b07a5d55ba 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Chris Cunningham
I'll re-send with my full name. On Fri, Feb 8, 2019 at 4:57 AM Michael Niedermayer wrote: > Hi > > On Wed, Feb 06, 2019 at 05:13:03PM -0800, chcunningham wrote: > > From: chcunningham > > Is the name intended ? As this ends up as author name in git, and several > developers dislike this: >

Re: [FFmpeg-devel] [PATCH V2 1/2] add support for ROI-based encoding

2019-02-08 Thread Tom Han
Can I get an example of ROI file for a video? Regards -Tom Sent from Mail for Windows 10 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Werner Robitza
Hello, Thanks for your comments. On Fri, Feb 8, 2019 at 10:03 AM Jean-Baptiste Kempf wrote: > Why do something special for homebrew, and not for all the other > distributions? > Why is homebrew different? Are you going to merge all .spec files from all > Linux distributions too? I don't

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Elliott Balsley
> On Feb 8, 2019, at 01:17, Jean-Baptiste Kempf wrote: > > Decklink SDK has a very weird EULA + headers license that makes it very > dubious that it is free. > Decklink refuses to clarify for now. That warrants a non-free flag. > I know it's very weird, since the SDK has the source code of

Re: [FFmpeg-devel] SDR->HDR tone mapping algorithm?

2019-02-08 Thread Niklas Haas
Hi, The important thing to consider is what constraints we are trying to solve. And I think the expected behavior is that an SDR signal in SDR mode should look identical to an SDR signal in HDR mode, to the end user. This is, of course, an impossible constraint to solve, since we don't know

Re: [FFmpeg-devel] SDR->HDR tone mapping algorithm?

2019-02-08 Thread Harish Krupo
Hi Vittorio, Vittorio Giovara writes: > On Fri, Feb 8, 2019 at 3:22 AM Harish Krupo > wrote: > >> Hello, >> >> We are in the process of implementing HDR rendering support in the >> Weston display compositor [1] (HDR discussion here [2]). When HDR >> and SDR surfaces like a video buffer and a

Re: [FFmpeg-devel] SDR->HDR tone mapping algorithm?

2019-02-08 Thread Harish Krupo
Hi Jean, Jean-Baptiste Kempf writes: > Hello, > > On Fri, 8 Feb 2019, at 09:17, Harish Krupo wrote: >> The literature available for SDR->HDR tone mapping varies from simple >> linear expansion of luminance to CNN based approaches. We wanted to know >> your recommendations for an acceptable

[FFmpeg-devel] [PATCH v6] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Mathieu Duponchelle
--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 32 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++

[FFmpeg-devel] [PATCH v5] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Mathieu Duponchelle
--- doc/encoders.texi | 3 +++ libavcodec/mpeg12enc.c | 32 libavcodec/mpegvideo.h | 2 ++ 3 files changed, 37 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index e86ae69cc5..a283b9fddf 100644 --- a/doc/encoders.texi +++

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Devin Heitmueller
> On Feb 8, 2019, at 9:47 AM, Mathieu Duponchelle > wrote: > > On 2/8/19 11:58 AM, Michael Niedermayer wrote: >> what if size is not a multiple of 3 ? > > Good point, more bytes will be written than advertised. Do you reckon > the input should be straight up refused? The other solution is to

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Mathieu Duponchelle
On 2/8/19 11:58 AM, Michael Niedermayer wrote: > what if size is not a multiple of 3 ? Good point, more bytes will be written than advertised. Do you reckon the input should be straight up refused? The other solution is to warn then iterate over side_data->size rounded down to the closest 3

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Michael Niedermayer
Hi On Wed, Feb 06, 2019 at 05:13:03PM -0800, chcunningham wrote: > From: chcunningham Is the name intended ? As this ends up as author name in git, and several developers dislike this: (and i cannot edit other authors names of course, that would be not right) (from IRC) Could you stop

Re: [FFmpeg-devel] SDR->HDR tone mapping algorithm?

2019-02-08 Thread Vittorio Giovara
On Fri, Feb 8, 2019 at 3:22 AM Harish Krupo wrote: > Hello, > > We are in the process of implementing HDR rendering support in the > Weston display compositor [1] (HDR discussion here [2]). When HDR > and SDR surfaces like a video buffer and a subtitle buffer are presented > together, the

Re: [FFmpeg-devel] [PATCH] avformat/mov.c: require tfhd to begin parsing trun

2019-02-08 Thread Michael Niedermayer
On Thu, Feb 07, 2019 at 08:03:01PM +, Derek Buitenhuis wrote: > On 07/02/2019 19:30, Chris Cunningham wrote: > > This will reject the file entirely. The testcase I have (can share once > > chromium bug is fixed) was previously hitting an av_assert0 in > > mov_read_trun, arguably also a total

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Michael Niedermayer
On Thu, Feb 07, 2019 at 09:03:16PM +0100, Mathieu Duponchelle wrote: > --- > doc/encoders.texi | 3 +++ > libavcodec/mpeg12enc.c | 31 +++ > libavcodec/mpegvideo.h | 2 ++ > 3 files changed, 36 insertions(+) > > diff --git a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] avformat/mov: validate chunk_count vs stsc_data

2019-02-08 Thread Michael Niedermayer
On Thu, Feb 07, 2019 at 02:58:17PM -0800, chcunningham wrote: > Bad content may contain stsc boxes with a first_chunk index that > exceeds stco.entries (chunk_count). This ammends the existing check to > include cases where chunk_count == 0. It also patches up the case > when stsc refers to

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: no need check ref list1 for P slices.

2019-02-08 Thread Michael Niedermayer
On Thu, Jan 31, 2019 at 03:36:56PM +0800, Decai Lin wrote: > This is robust for some corner case there is incorrect list1 count > in pps header, but it's a P slice and can be decoded well. > > Signed-off-by: Decai Lin > --- > libavcodec/h264_parse.c | 11 ++- > 1 file changed, 6

Re: [FFmpeg-devel] SDR->HDR tone mapping algorithm?

2019-02-08 Thread Jean-Baptiste Kempf
Hello, On Fri, 8 Feb 2019, at 09:17, Harish Krupo wrote: > The literature available for SDR->HDR tone mapping varies from simple > linear expansion of luminance to CNN based approaches. We wanted to know > your recommendations for an acceptable algorithm for SDR->HDR tone mapping. You really

Re: [FFmpeg-devel] [PATCH] doc/examples: port muxing example to new send/receive API

2019-02-08 Thread Lennart Blanco
Hi Have anyone had time to look at this patch? Best Regards, Lennart On Mon, Feb 4, 2019 at 12:05 PM Lennart Blanco wrote: > Hi > > Noticed that the example code for muxing uses depricated API. This is my > attempt to > port the doc/examples/muxing.c to use the avcodec_send_frame() and >

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Jean-Baptiste Kempf
Hello, On Fri, 8 Feb 2019, at 09:01, Elliott Balsley wrote: > > On Jan 30, 2019, at 12:53, Carl Eugen Hoyos wrote: > > Imo, it is different in (nearly) every regard but as said, I don't see > > how this discussion can be fruitful in any way. > > > If anyone else has an opinion, I would love to

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Jean-Baptiste Kempf
Hello, On Wed, 6 Feb 2019, at 21:41, Werner Robitza wrote: > Homebrew has, with its 2.0 release, removed all options for its core > formulae [1], including ffmpeg. This means users can no longer add > non-default dependencies that aren't included in the core formula [2]. > I propose that FFmpeg

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-08 Thread Werner Robitza
On Thu, Feb 7, 2019 at 11:11 PM Lou Logan wrote: > > On Thu, Feb 7, 2019, at 12:49 PM, Carl Eugen Hoyos wrote: > > > > This sounds like a strong reason not to add it to an FFmpeg > > repository: It was claimed in the past that I am the only one > > not supporting releases but the same was now

[FFmpeg-devel] SDR->HDR tone mapping algorithm?

2019-02-08 Thread Harish Krupo
Hello, We are in the process of implementing HDR rendering support in the Weston display compositor [1] (HDR discussion here [2]). When HDR and SDR surfaces like a video buffer and a subtitle buffer are presented together, the composition would take place as follows: - If the display does not

Re: [FFmpeg-devel] configure: Fix decklink license dependency

2019-02-08 Thread Elliott Balsley
> On Jan 30, 2019, at 12:53, Carl Eugen Hoyos wrote: > > Imo, it is different in (nearly) every regard but as said, I don't see > how this discussion can be fruitful in any way. > If anyone else has an opinion, I would love to learn why Nvidia driver is considered a system library under GPL