Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Added #EXT-X-PROGRAM-DATE-TIME to HLS playlists

2019-02-25 Thread Jeyapal, Karthick
On 2/22/19 12:25 PM, joepadmiraal wrote: > From: joepadmiraal > > --- > libavformat/dashenc.c | 29 - > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index 37a7547b12..d0d0d6f030 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-25 Thread C.H.Liu
Attach one of my massif outputs. The max memory usage is approximately 22.05MB. And the *extra *heap is not too big. The peak snapshot is the 7th. The H.264 decoder is responsible for 86.11% of the memory usage. The update_frag_index is responsible for 78,264 bytes. And the relevant code is at

Re: [FFmpeg-devel] [PATCH v3] avcodec/mips: [loongson] mmi optimizations for VP9 put and avg functions

2019-02-25 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of gxw >Sent: Monday, February 25, 2019 6:14 PM >To: ffmpeg-devel@ffmpeg.org >Cc: gxw >Subject: [FFmpeg-devel] [PATCH v3] avcodec/mips: [loongson] mmi optimizations >for VP9 put

Re: [FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] mmi optimizations for VP9 put and avg functions

2019-02-25 Thread gxw
> 在 2019年2月24日,上午10:55,Shiyou Yin 写道: > > > >> -Original Message- >> From: ffmpeg-devel-boun...@ffmpeg.org >> >> [mailto:ffmpeg-devel-boun...@ffmpeg.org >> ] On Behalf Of gxw >> Sent: Thursday,

[FFmpeg-devel] [PATCH] ffmpeg: explicitly handle sub2video subpicture initialization

2019-02-25 Thread Jan Ekström
Each time the sub2video structure is initialized, the sub2video subpicture is initialized together with the first received heartbeat. The heartbeat's PTS is utilized as the subpicture start time. Additionally, add some documentation on the stages. --- fftools/ffmpeg.c| 22

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/vaapi_encode: add frame-skip func

2019-02-25 Thread Mark Thompson
On 22/02/2019 03:09, Sun, Jing A wrote: > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Thursday, February 21, 2019 5:35 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/1]

Re: [FFmpeg-devel] [PATCH v3 01/12] vaapi_encode: Support more RC modes

2019-02-25 Thread Mark Thompson
On 13/02/2019 03:14, Carl Eugen Hoyos wrote: > 2019-02-10 20:46 GMT+01:00, Mark Thompson : >> Allow setting the mode explicitly, and try to make a sensible choice >> given the available parameters if not. > > Please mention ticket #7650 if this patch fixes the assertion failure. Yep, marked on

Re: [FFmpeg-devel] [PATCH 1/2] filter_units, trace_headers: Always use fragment from context

2019-02-25 Thread Mark Thompson
On 11/02/2019 22:47, Andreas Rheinhardt wrote: > This is in preparation for another patch that will stop needless > reallocations of the unit array. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/filter_units_bsf.c | 8 > libavcodec/trace_headers_bsf.c | 13 +++-- >

Re: [FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

2019-02-25 Thread Michael Niedermayer
On Mon, Feb 25, 2019 at 09:01:16PM +0100, Martin Vignali wrote: > Hello, > > Thanks for testing. > Can you send me the result file vsynth3-prores_int.mov, so i can try to > find why the result are not the same. https://ffmpeg.org/~michael/vsynth3-prores_int.mov

[FFmpeg-devel] [PATCH] avcodec/diracdec: Correct max pixels check

2019-02-25 Thread Michael Niedermayer
Dirac internally allocates 5 images per plane and frame currently. One being the actual image the other 4 being filtered for motion compensation. Fixes: Out of memory Fixes: 12870/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5684825871089664 Found-by: continuous fuzzing

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Moritz Barsnick
Hi Yufei, before providing large patches here, do read this mailing list and the ffmpeg codebase for a while. It will help you to understand the process, and to understand how ffmpeg's sources are organized. I'm sure you missed this: https://www.ffmpeg.org/developer.html Read all of it

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Tomas Härdin
Hi > +void convert_to_annexb(unsigned char * dest, unsigned long > data_size) > +{ > + unsigned char *current = dest; > + union > + { > + unsigned char by4[4]; > + uint32_t length; > + } union_u32_byte; > + > + while ((dest + data_size) > (current + 4)) > + { > +

[FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Yufei He
Hi Please review this one. Thanks. Yufei. On 02/25/2019 02:58 PM, Nicolas George wrote: Yufei He (12019-02-25): From 7dd17409a22858f3c18d832c301fb904508dea3b Mon Sep 17 00:00:00 2001 From: yhe Date: Mon, 25 Feb 2019 14:38:21 -0500 Subject: [PATCH] M264 codec

Re: [FFmpeg-devel] avcodec/qtrle : improve decoding speed of 24bpp and 32 bpp

2019-02-25 Thread Carl Eugen Hoyos
> Am 25.02.2019 um 20:59 schrieb Martin Vignali : > > Hello, > > thanks for testing and comments. > New patch in attach > 001 : unchanged > 002 : use ARGB for little and big endian, and change the commit msg I know we forgot before but this definitely needs a micro version bump. Carl Eugen

[FFmpeg-devel] [PATCH] Parallelize vf_lut

2019-02-25 Thread Britt Cyr
--- libavfilter/vf_lut.c | 106 --- 1 file changed, 70 insertions(+), 36 deletions(-) diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c index c815ddc194..14386938be 100644 --- a/libavfilter/vf_lut.c +++ b/libavfilter/vf_lut.c @@ -72,6 +72,12 @@

Re: [FFmpeg-devel] avcodec/qtrle : improve decoding speed of 24bpp and 32 bpp

2019-02-25 Thread Martin Vignali
Hello, thanks for testing and comments. New patch in attach 001 : unchanged 002 : use ARGB for little and big endian, and change the commit msg 003 and 004 : mention test platform in commit msg I can't compile anymore for x86_32, so can't test speed in X86_32. Martin

Re: [FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

2019-02-25 Thread Martin Vignali
Hello, Thanks for testing. Can you send me the result file vsynth3-prores_int.mov, so i can try to find why the result are not the same. Only the two vsynth3 interlaced test fail ? Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Nicolas George
Yufei He (12019-02-25): > From 7dd17409a22858f3c18d832c301fb904508dea3b Mon Sep 17 00:00:00 2001 > From: yhe > Date: Mon, 25 Feb 2019 14:38:21 -0500 > Subject: [PATCH] M264 codec support Quick comments. They are in no way to be taken as any kind of endorsement for the patch. > > --- >

[FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Yufei He
Hi Here is the patch. Please check. Thanks. Yufei. From 7dd17409a22858f3c18d832c301fb904508dea3b Mon Sep 17 00:00:00 2001 From: yhe Date: Mon, 25 Feb 2019 14:38:21 -0500 Subject: [PATCH] M264 codec support --- .vscode/settings.json| 27 +++ Changelog|

Re: [FFmpeg-devel] [PATCH 0/5] Clean up CUDA SDK usage and remove non-free requirement

2019-02-25 Thread Soft Works
> I've been thinking about this for a while, but I only recently made the > realisation that compiling cuda kernels to the ptx format does not > introduce any non-free dependencies - the ptx files are an intermediate > assembly code format that is actually compiled to binary form at > runtime.

[FFmpeg-devel] patch for a new H.264 codec

2019-02-25 Thread Yufei He
Hi I just finished a new codec for h.264, how to send patches to review ? This is my first piece of code for ffmpeg. When you submit your patch, please use git format-patch or git send-email.

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

2019-02-25 Thread Mathieu Duponchelle
Ping? :) On 2/17/19 1:23 PM, Mathieu Duponchelle wrote: >> It would be better to test against a decoder from a unrelated codebase >> Otherwise its a bit like testing your new language skills by talking with >> yourself. > I have just tested with gstreamer's mpegvideoparse element, it detects the

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/error_resilience: Use a symmetric check for skipping MV estimation

2019-02-25 Thread Michael Niedermayer
On Tue, Feb 19, 2019 at 09:09:22PM +0100, Michael Niedermayer wrote: > This speeds up the testcase by a factor of 4 > > Fixes: Timeout > Fixes: > 13100/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV2_fuzzer-5767533905313792 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mjpegdec: Fix stereo3d memleak

2019-02-25 Thread Michael Niedermayer
On Mon, Feb 18, 2019 at 01:07:55AM +0100, Michael Niedermayer wrote: > Fixes: > 12937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THP_fuzzer-5714945346371584 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/arbc: Check nb_tiles against dimensions

2019-02-25 Thread Michael Niedermayer
On Mon, Feb 18, 2019 at 01:07:56AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 12967/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARBC_fuzzer-5639021454163968 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix start_time for streams with empty edits in the middle

2019-02-25 Thread Vittorio Giovara
On Sat, Feb 23, 2019 at 1:09 PM Vittorio Giovara wrote: > Empty edits can occur at any position within the edit list except for at > the end. Empty edits in the middle should not impact the reported stream > start_time or the video PTS adjustment, so only include empty edits at > the start of

[FFmpeg-devel] [PATCH] avcodec/aic: Check remaining bits in aic_decode_coeffs()

2019-02-25 Thread Michael Niedermayer
Fixes: Timeout (78 seconds -> 2 seconds) Fixes: 13186/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AIC_fuzzer-5639516533030912 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aic.c | 3

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-25 Thread C.H.Liu
Would you mind share your input file? I still can’t reproduce the OOM. I have tried several types of mp4. I also tried to create a file like yours. According to the snapshot, seems it has no ‘sidx’ box and enable ‘use_mfra_for’. Massif didn’t report update_frag_index() function. I didn’t see

[FFmpeg-devel] [PATCH] libavformat/movenc: mov: added subtitle codec tags to codec tag list

2019-02-25 Thread Paweł Wegner
This fixes avformat_query_codec incorrectly returning 0 for mov container and mov_text subtitles. Signed-off-by: Paweł Wegner --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 77943304b5..8969d5b170

[FFmpeg-devel] [PATCH v3] avcodec/mips: [loongson] mmi optimizations for VP9 put and avg functions

2019-02-25 Thread gxw
VP9 decoding speed improved about 60.5%(from 38fps to 61fps, tested on loongson 3A3000). --- libavcodec/mips/Makefile | 1 + libavcodec/mips/vp9_mc_mmi.c | 628 + libavcodec/mips/vp9dsp_init_mips.c | 42 +++ libavcodec/mips/vp9dsp_mips.h