Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of James Almer Sent: Friday, May 31, 2019 11:17 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper >You should return 0 here.

[FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 501 +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_zscale: add slice threading

2019-05-30 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Paul B Mahol > Sent: Thursday, May 30, 2019 3:22 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] avfilter/vf_zscale: add slice threading > > Signed-off-by: Paul B Mahol >

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread James Almer
On 5/31/2019 12:50 AM, Jing Sun wrote: > Signed-off-by: Zhengxu Huang > Signed-off-by: Hassene Tmar > Signed-off-by: Jun Zhao > Signed-off-by: Jing Sun > --- > configure| 4 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/libsvt_hevc.c

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: Fix VP9 dynamic resolution changing decoding on VAAPI.

2019-05-30 Thread Yan Wang
On 5/30/2019 7:39 AM, Mark Thompson wrote: On 28/05/2019 08:46, Yan Wang wrote: On 5/28/2019 3:16 PM, Hendrik Leppkes wrote: On Tue, May 28, 2019 at 8:57 AM Yan Wang wrote: When the format change, the VAAPI context cannot be destroyed. Otherwise, the reference frame surface will lost.

[FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 499 +++

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of James Almer Sent: Friday, May 31, 2019 10:38 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper >No, with the encode2 API

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Sun, Jing A
-Original Message- From: Sun, Jing A Sent: Friday, May 31, 2019 11:37 AM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper Sorry I forgot to remove some debugging code lines,

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread James Almer
On 5/30/2019 11:16 PM, Sun, Jing A wrote: > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > James Almer > Sent: Thursday, May 30, 2019 11:35 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add

[FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 499 +++

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of James Almer Sent: Thursday, May 30, 2019 11:35 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper >Why the switch to

[FFmpeg-devel] [PATCH v6 1/2] lavf/vf_transpose: add exif orientation support

2019-05-30 Thread Jun Li
Add exif orientation support and expose an option. --- libavfilter/hflip.h| 2 + libavfilter/transpose.h| 14 libavfilter/vf_hflip.c | 40 ++--- libavfilter/vf_transpose.c | 161 - 4 files changed, 185 insertions(+), 32 deletions(-)

[FFmpeg-devel] [PATCH v6 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-30 Thread Jun Li
Fix #6945 Rotate or/and flip frame according to frame's metadata orientation --- fftools/ffmpeg.c| 16 +++- fftools/ffmpeg.h| 3 ++- fftools/ffmpeg_filter.c | 28 +++- 3 files changed, 40 insertions(+), 7 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avutil/dynarry.h: fix comment grammar mistakes of FF_DYNARRAY_ADD

2019-05-30 Thread James Almer
On 5/30/2019 11:29 AM, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavutil/dynarray.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/dynarray.h b/libavutil/dynarray.h > index 034a9fedfe..3a7e146422 100644 > --- a/libavutil/dynarray.h > +++

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-30 Thread Reimar Döffinger
On 28.05.2019, at 12:48, Andreas Håkon wrote: > Hi, > > This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) > > A new (simpler and more robust) implementationof of the reinsertion of the > missing headers in the MPEG-2 bitstream from the HW QSV encoder. > > The problem

[FFmpeg-devel] [PATCH] avilter/avf_showwaves: switch to activate in showwaves filter

2019-05-30 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avf_showwaves.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index d85ebd9050..afe05fb504 100644 --- a/libavfilter/avf_showwaves.c +++

Re: [FFmpeg-devel] [PATCH v5] avformat/ifv: added support for ifv cctv files

2019-05-30 Thread Reimar Döffinger
On 29.05.2019, at 19:51, Swaraj Hota wrote: >> >> Entirely depends on the purpose. >> If the aim is to have a working demuxer, I think it is acceptable from what >> I looked at. >> I guess the only concern might be that not supporting piped input would be a >> bit of a regression from the

Re: [FFmpeg-devel] [PATCH] avfilter: add showspatial multimedia filter

2019-05-30 Thread Paul B Mahol
On 5/25/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 52 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/avf_showspatial.c | 384 ++ > 4 files changed, 438

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: Fix compilation for IOS < 11.0 and OSX, < 10.13

2019-05-30 Thread Rick Kern
On Fri, May 24, 2019 at 6:34 PM Thilo Borgmann wrote: > Am 22.05.19 um 14:27 schrieb Thilo Borgmann: > > Am 22.05.19 um 01:41 schrieb Jan Ekström: > >> Hi, > >> > >> On Tue, May 14, 2019 at 4:16 PM Thilo Borgmann > wrote: > >>> > >>> $Subject > >>> > >>> Tested compilation only, sanity test

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread Moritz Barsnick
On Wed, May 29, 2019 at 19:28:24 +0100, Derek Buitenhuis wrote: > +during configuration. You need to explicitly configue the build with ^ configure > +Sets the maximum qauntizer (floor) to use when using bitrate mode. ^ quantizer

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/30/2019 1:37 PM, Derek Buitenhuis wrote: > On 30/05/2019 17:27, James Almer wrote: >> All three options are important to get decent and/or fast encodings, so >> if you'd rather not add options for them, you should document what >> key=value combinations can be passed to rav1e-params, either

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread Derek Buitenhuis
On 30/05/2019 17:27, James Almer wrote: > All three options are important to get decent and/or fast encodings, so > if you'd rather not add options for them, you should document what > key=value combinations can be passed to rav1e-params, either in > encoders.doxy, or as a printed list like

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/30/2019 1:15 PM, Derek Buitenhuis wrote: > On 30/05/2019 15:51, James Almer wrote: >> You could add tile-columns, tile-rows, and speed options. > > I'm of two minds here. > > One one hand, it is convenient. > > On the other hand, you may end up with a crappy pile of stuff > like libx264.c

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread Derek Buitenhuis
On 30/05/2019 15:51, James Almer wrote: > You could add tile-columns, tile-rows, and speed options. I'm of two minds here. One one hand, it is convenient. On the other hand, you may end up with a crappy pile of stuff like libx264.c where everything has its own option or aomenc where new stuff

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread James Almer
On 5/30/2019 8:04 AM, Jing Sun wrote: > Signed-off-by: Zhengxu Huang > Signed-off-by: Hassene Tmar > Signed-off-by: Jun Zhao > Signed-off-by: Jing Sun > --- > configure| 4 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/libsvt_hevc.c |

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/29/2019 3:28 PM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > Changes since v2: > > * Removed 4:0:0 support; seems broken in rav1e (ref: >

[FFmpeg-devel] [PATCH] avutil/dynarry.h: fix comment grammar mistakes of FF_DYNARRAY_ADD

2019-05-30 Thread Steven Liu
Signed-off-by: Steven Liu --- libavutil/dynarray.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/dynarray.h b/libavutil/dynarray.h index 034a9fedfe..3a7e146422 100644 --- a/libavutil/dynarray.h +++ b/libavutil/dynarray.h @@ -23,7 +23,7 @@ #include "mem.h" /**

Re: [FFmpeg-devel] [PATCH] avcodec/qtrle: return last frame even if unchanged

2019-05-30 Thread Michael Niedermayer
On Thu, May 16, 2019 at 09:29:26PM +0200, Marton Balint wrote: > > On Wed, 15 May 2019, Michael Niedermayer wrote: > > >Fixes: Ticket7880 > > > >Signed-off-by: Michael Niedermayer > >--- > >libavcodec/qtrle.c| 27 +-- > >tests/ref/fate/qtrle-8bit | 1 + > >2 files

[FFmpeg-devel] [PATCH 1/4] swresample/swresample: Support unspecified sample rate when it is not needed

2019-05-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libswresample/swresample.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libswresample/swresample.c b/libswresample/swresample.c index 1ac5ef9a30..f1decb600a 100644 --- a/libswresample/swresample.c +++ b/libswresample/swresample.c @@ -164,6

[FFmpeg-devel] [PATCH 2/4] avcodec/qtrle: return last frame even if unchanged

2019-05-30 Thread Michael Niedermayer
Fixes: Ticket7880 Signed-off-by: Michael Niedermayer --- libavcodec/qtrle.c| 42 +++ tests/ref/fate/qtrle-8bit | 1 + 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c index 2c29547e5a..4add1aded6

[FFmpeg-devel] [PATCH 3/4] tests/ref/fate/nuv-rtjpeg: Preserve the original timestamps

2019-05-30 Thread Michael Niedermayer
The tests previously rounded the timestamps. Its better in a fate test to preserve the data from the demuxer and decoder. Signed-off-by: Michael Niedermayer --- tests/fate/video.mak | 2 +- tests/ref/fate/nuv-rtjpeg | 18 +- 2 files changed, 10 insertions(+), 10

[FFmpeg-devel] [PATCH 4/4] avcodec/nuv: Avoid duplicating frames

2019-05-30 Thread Michael Niedermayer
Fixes: Timeout (14sec -> 133ms) Fixes: 14843/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5661969614372864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/nuv.c | 35

[FFmpeg-devel] [PATCH, v2] lavc/vaapi_encode: grow packet if vaMapBuffer returns multiple buffers

2019-05-30 Thread Linjie Fu
It seems that VA_CODED_BUF_STATUS_SINGLE_NALU allows driver to map buffer for each slice. Currently, assigning new buffer for pkt when multiple buffer returns from vaMapBuffer will cover the previous encoded pkt data and lead to encode issues. Iterate through the buf_list first to find out the

[FFmpeg-devel] [PATCH v3] libavfilter: Add derain filter

2019-05-30 Thread Xuewei Meng
Remove the rain in the input image/video by applying the derain methods based on convolutional neural networks. Training scripts as well as scripts for model generation are provided in the repository at https://github.com/XueweiMeng/derain_filter.git. Signed-off-by: Xuewei Meng ---

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/tiff: Recognize DNG/CinemaDNG images

2019-05-30 Thread Paul B Mahol
On 5/30/19, velocit...@gmail.com wrote: > From: Nick Renieris > > Additionally: > - Renamed TIFF_WHITE_LEVEL to DNG_WHITE_LEVEL since it is specified > in the DNG spec. > - Added/changed some comments to be more precise in differentiating > between TIFF, TIFF/EP and DNG values. > > Related

[FFmpeg-devel] [PATCH v2 1/3] avcodec/tiff: Option to decode embedded thumbnail

2019-05-30 Thread velocityra
From: Nick Renieris Adds the "-thumbnail" option, that works like the current "-subifd" option, but only for non-full-sized images. This is particularly useful for DNG images (see next commit) that have SubIFDs that are not necessarily thumbnails. Signed-off-by: Nick Renieris ---

[FFmpeg-devel] [PATCH v2 2/3] libavcodec/tiff: Process SubIFDs tag with multiple entries

2019-05-30 Thread velocityra
From: Nick Renieris SubIFDs that were part of more than single-sized "SubIFDs" tags were being ignored due to existing code ignoring that case. This patch makes is so the first entry is read, which is not ideal but enough for some DNG images present in the wild to be decodeable More

[FFmpeg-devel] [PATCH v2 3/3] avcodec/tiff: Recognize DNG/CinemaDNG images

2019-05-30 Thread velocityra
From: Nick Renieris Additionally: - Renamed TIFF_WHITE_LEVEL to DNG_WHITE_LEVEL since it is specified in the DNG spec. - Added/changed some comments to be more precise in differentiating between TIFF, TIFF/EP and DNG values. Related to ticket: https://trac.ffmpeg.org/ticket/4364

[FFmpeg-devel] [PATCH v13 2/2] doc: Add libsvt_hevc encoder docs

2019-05-30 Thread Jing Sun
Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jing Sun --- doc/encoders.texi | 149 ++ doc/general.texi | 8 +++ 2 files

[FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 510 +++

Re: [FFmpeg-devel] [PATCH] avcodec/gdv: Check remaining output after decode 5/6/8/

2019-05-30 Thread Paul B Mahol
On 5/29/19, Michael Niedermayer wrote: > Improves: Timeout (355sec -> 97sec) > Improves: > 14709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_GDV_fuzzer-5704215281795072 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > --- >

Re: [FFmpeg-devel] [PATCH v2] libavfilter: Add derain filter

2019-05-30 Thread Paul B Mahol
On 5/29/19, Xuewei Meng wrote: > Remove the rain in the input image/video by applying the derain > methods based on convolutional neural networks. Training scripts > as well as scripts for model generation are provided in the > repository at https://github.com/XueweiMeng/derain_filter.git. > >

Re: [FFmpeg-devel] [PATCH 2/3] lavf/webm_chunk: Fix NULL dereference

2019-05-30 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The earlier version of the webm_chunk muxer had several bugs: > > 1. If the first packet of an audio stream didn't have a PTS of zero, > then no chunk will be started before a packet is delivered to the > underlying Matroska/WebM muxer, i.e. the AVFormatContext used to write

Re: [FFmpeg-devel] [PATCH] lavf/qsvvpp: avoid the double-free when working in sys memory mode

2019-05-30 Thread Li, Zhong
> vpp_qsv with system software path could reproduce this with mainline > version: > > ffmpeg -init_hw_device qsv=foo -filter_hw_device foo -v debug -f rawvideo > -pix_fmt nv12 -s:v 852x480 -i 852x480.nv12 -vf 'vpp_qsv=w=500:h=400' -f > rawvideo -pix_fmt nv12 qsv.nv12 > > This happens when the

Re: [FFmpeg-devel] [PATCH] avfilter/vf_gblur: add x86 SIMD optimizations

2019-05-30 Thread Song, Ruiling
> -Original Message- > From: Paul B Mahol [mailto:one...@gmail.com] > Sent: Thursday, May 30, 2019 3:24 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Song, Ruiling > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_gblur: add x86 SIMD > optimizations > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_gblur: add x86 SIMD optimizations

2019-05-30 Thread Paul B Mahol
On 5/30/19, Ruiling Song wrote: > For details of the implementation, please refer to the comment > inlined in the assembly code. It improves the horizontal pass > performance about 100% under single thread. > > Tested overall performance using the command(avx2 enabled): > ./ffmpeg -i 1080p.mp4

Re: [FFmpeg-devel] [PATCH] lavf/qsvvpp: avoid the double-free when working in sys memory mode

2019-05-30 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Thursday, May 30, 2019 13:15 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavf/qsvvpp: avoid the double-free >

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-30 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Håkon > Sent: Tuesday, May 28, 2019 6:48 PM > To: FFmpeg development discussions and patches > > Subject: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing > headers [v2] > > Hi, > > This patch