Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxdec: fix crop handling when multithreaded

2019-09-06 Thread Aman Gupta
On Fri, Sep 6, 2019 at 8:37 PM Rodger Combs wrote: > This was partially fixed by 233cd89, but it made changes to AVFrame fields > from within end_frame, which doesn't work consistently when multithreading > is enabled. This is what the post_process function is for. Looks good to me. > --- >

[FFmpeg-devel] [PATCH] lavc/videotoolboxdec: fix crop handling when multithreaded

2019-09-06 Thread Rodger Combs
This was partially fixed by 233cd89, but it made changes to AVFrame fields from within end_frame, which doesn't work consistently when multithreading is enabled. This is what the post_process function is for. --- libavcodec/videotoolbox.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-09-06 Thread Niki Bowe
As it turns out the last patch still lets a lot of jpegs get misidentified. This new version avoids the problem by checking for jpeg magic at the start. I also added a FATE test, and attached the jpeg for the test. On Tue, Aug 27, 2019 at 6:30 PM Niki Bowe wrote: > > > On Sun, Aug 25, 2019

[FFmpeg-devel] [PATCH v1] avformat/movenc: split empty text sample when duration overflow

2019-09-06 Thread Jun Li
Fix #7637 One empty/end sample is created and inserted between two caption lines when there is a gap. This patch is to split the sample into multiple ones when its duration is too long (>= INT_MAX). --- libavformat/movenc.c | 24 ++-- 1 file changed, 18 insertions(+), 6

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-06 Thread Limin Wang
On Fri, Sep 06, 2019 at 08:08:48PM +0200, Michael Niedermayer wrote: > On Sat, Jul 27, 2019 at 08:18:16PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_scale.c | 29 + > > 1 file changed, 25

Re: [FFmpeg-devel] [PATCH] Add option to log timing

2019-09-06 Thread Soft Works
> From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Friday, September 6, 2019 8:56 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] Add option to log timing > > On Wed, Sep 04, 2019 at 07:35:11PM +, Soft Works wrote: > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/qdm2: Check frame size

2019-09-06 Thread Paul B Mahol
Are you sure this is not band aid but actually real fix? On 8/29/19, Michael Niedermayer wrote: > Fixes: index 2304 out of bounds for type 'float [2304]' > Fixes: > 16332/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5679142481166336 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/qdm2: Check frame size

2019-09-06 Thread Michael Niedermayer
On Thu, Aug 29, 2019 at 09:46:32PM +0200, Michael Niedermayer wrote: > Fixes: index 2304 out of bounds for type 'float [2304]' > Fixes: > 16332/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5679142481166336 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 5/5] avformat/vividas: check for tiny blocks using alignment

2019-09-06 Thread Michael Niedermayer
On Sun, Sep 01, 2019 at 12:32:40AM +0200, Michael Niedermayer wrote: > Ask for a sample for these > Fixes: out of array access > Fixes: > 16624/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5762455661182976 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1_pred: Fix refdist in scaleforopp()

2019-09-06 Thread Michael Niedermayer
On Sun, Sep 01, 2019 at 12:32:37AM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 16601/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5656105392275456 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-06 Thread Andrey Semashev
Could someone take a look at this small fix, please? I'd like it to make it into 4.2.1. On 2019-09-02 13:54, Andrey Semashev wrote: Ping? On 2019-08-28 18:32, Andrey Semashev wrote: Because lavf_container is sometimes called with only 2 arguments, fate tests produce bash errors like this:   

Re: [FFmpeg-devel] [PATCH v1 2/3] avfilter/vf_showinfo: display GOP timecode side data

2019-09-06 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 12:17:59AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 6 ++ > 1 file changed, 6 insertions(+) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] swscale/output: fix some code indentations

2019-09-06 Thread Michael Niedermayer
On Thu, Sep 05, 2019 at 11:01:15AM +0800, Linjie Fu wrote: > Signed-off-by: Linjie Fu > --- > libswscale/output.c | 70 > ++--- > 1 file changed, 35 insertions(+), 35 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vorbisdec: fix FASTDIV usage for vr_type == 2

2019-09-06 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 12:47:47PM +0200, Michael Niedermayer wrote: > This reverts a hunk from f1ca40ee00402102046fc7e59606651930436b0e > > Fixes: out of array read > Fixes: > 16924/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5157893162139648 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH] Add option to log timing

2019-09-06 Thread Michael Niedermayer
On Wed, Sep 04, 2019 at 07:35:11PM +, Soft Works wrote: > > > Why this restriction? I think all log lines should be start with > > time/date if corresponding flag is present. This makes the log to be > > easy to parse by scripts. > > Initially I didn’t have this restriction, but it doesn’t

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-06 Thread Michael Niedermayer
On Sat, Jul 27, 2019 at 08:18:16PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_scale.c | 29 + > 1 file changed, 25 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_scale.c

Re: [FFmpeg-devel] [PATCH] avcodec/webp: avoid trying to decode trailing junk in bitstreams

2019-09-06 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 01:11:50PM +0200, Pascal Massimino wrote: > Michael, > > On Thu, Sep 5, 2019 at 6:20 PM Michael Niedermayer > wrote: > > > On Wed, Sep 04, 2019 at 07:43:15AM +0200, Pascal Massimino wrote: [...] > > > > i would guess its not a known chunk but rather hits the default > >

Re: [FFmpeg-devel] [PATCH 2/2] x86/vf_v360: use a faster horizontal add in remap4_8bit_line_avx2

2019-09-06 Thread James Almer
On 9/6/2019 12:40 PM, Paul B Mahol wrote: > LGTM > > On 9/6/19, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/x86/vf_v360.asm | 11 --- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/libavfilter/x86/vf_v360.asm

Re: [FFmpeg-devel] [PATCH v1 5/5] avcodec/v210enc: define DEFINE_V210_ENCODE_FUNC to remove duplicate code

2019-09-06 Thread Limin Wang
On Fri, Aug 30, 2019 at 08:11:17PM +0200, Michael Niedermayer wrote: > On Wed, Aug 28, 2019 at 11:45:16PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210enc.c | 171 > > +--

Re: [FFmpeg-devel] [PATCH 2/2] x86/vf_v360: use a faster horizontal add in remap4_8bit_line_avx2

2019-09-06 Thread Paul B Mahol
LGTM On 9/6/19, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_v360.asm | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/libavfilter/x86/vf_v360.asm b/libavfilter/x86/vf_v360.asm > index f49702b603..a0936eb6dc 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/2] x86/vf_v360: make remap{1, 2}_8bit_line_avx2 work on x86_32

2019-09-06 Thread Paul B Mahol
OK if tested. On 9/6/19, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vf_v360.c | 2 +- > libavfilter/x86/vf_v360.asm| 11 +-- > libavfilter/x86/vf_v360_init.c | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 2/2] x86/vf_v360: use a faster horizontal add in remap4_8bit_line_avx2

2019-09-06 Thread James Almer
Signed-off-by: James Almer --- libavfilter/x86/vf_v360.asm | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavfilter/x86/vf_v360.asm b/libavfilter/x86/vf_v360.asm index f49702b603..a0936eb6dc 100644 --- a/libavfilter/x86/vf_v360.asm +++

[FFmpeg-devel] [PATCH 1/2] x86/vf_v360: make remap{1, 2}_8bit_line_avx2 work on x86_32

2019-09-06 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_v360.c | 2 +- libavfilter/x86/vf_v360.asm| 11 +-- libavfilter/x86/vf_v360_init.c | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index

[FFmpeg-devel] [PATCH v2 1/2] avcodec/v210dec: removed the duplicated 'if' condition

2019-09-06 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/v210dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index 5a33d8c..6ce18aa 100644 --- a/libavcodec/v210dec.c +++ b/libavcodec/v210dec.c @@ -98,8 +98,7 @@ static int

[FFmpeg-devel] [PATCH v2 2/2] avcodec/v210dec: add the frame and slice threading support

2019-09-06 Thread lance . lmwang
From: Limin Wang The multithread is avoid one core cpu is full with other filter like scale etc. About the performance, the gain is very small, below is my testing for performance. In order to avoid the disk bottleneck, I'll use stream_loop mode for 10 frame only. ./ffmpeg -y -i

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-06 Thread Limin Wang
On Wed, Sep 04, 2019 at 12:07:32AM +0200, Michael Niedermayer wrote: > On Sat, Jul 27, 2019 at 08:18:16PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_scale.c | 29 + > > 1 file changed, 25

Re: [FFmpeg-devel] [PATCH v1 2/3] avfilter/vf_showinfo: display GOP timecode side data

2019-09-06 Thread Limin Wang
ping, please review and help to merge it, thanks. On Sun, Aug 25, 2019 at 12:17:59AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

[FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecdec_common: do not split input packets into multiple buffers in ff_mediacodec_dec_send()

2019-09-06 Thread Matthieu Bouron
MediaCodec expects exactly one incoming buffer with a given PTS, it is not valid to split data for a given PTS across multiple input buffers. See https://developer.android.com/reference/android/media/MediaCodec#data-processing > Do not submit multiple input buffers with the same timestamp ---

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodecdec_common: simplify ff_mediacodec_dec_send()

2019-09-06 Thread Matthieu Bouron
--- libavcodec/mediacodecdec_common.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index 1656cd6664..6c0a1212c1 100644 --- a/libavcodec/mediacodecdec_common.c +++ b/libavcodec/mediacodecdec_common.c

Re: [FFmpeg-devel] [PATCH] avcodec/webp: avoid trying to decode trailing junk in bitstreams

2019-09-06 Thread Pascal Massimino
Michael, On Thu, Sep 5, 2019 at 6:20 PM Michael Niedermayer wrote: > On Wed, Sep 04, 2019 at 07:43:15AM +0200, Pascal Massimino wrote: > > Hi, > > > > this patch break the decoding loop when invalid webp chunk is > encountered. > > We can still have a valid frame ready to be returned

Re: [FFmpeg-devel] [PATCH] doc/filters: correct range for contrast in eq filter

2019-09-06 Thread Sourabh Sharma
Thank you On Fri, 6 Sep 2019, 2:11 pm Gyan, wrote: > > > On 06-09-2019 01:23 PM, Gyan wrote: > > > > > > On 06-09-2019 08:28 AM, Sourabh Sharma wrote: > >> --- > >> doc/filters.texi | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/doc/filters.texi

[FFmpeg-devel] [PATCH 2/4] avcodec/alac: Fix invalid shifts in 20/24 bps

2019-09-06 Thread Michael Niedermayer
Fixes: left shift of negative value -256 Fixes: 16892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-4880802642395136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alac.c | 4

[FFmpeg-devel] [PATCH 4/4] avcodec/vorbisdec: fix FASTDIV usage for vr_type == 2

2019-09-06 Thread Michael Niedermayer
This reverts a hunk from f1ca40ee00402102046fc7e59606651930436b0e Fixes: out of array read Fixes: 16924/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5157893162139648 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 3/4] avcodec/smacker: Fix integer overflow in signed int multiply in SMK_BLK_FILL

2019-09-06 Thread Michael Niedermayer
Fixes: signed integer overflow: 238 * 16843009 cannot be represented in type 'int' Fixes: 16958/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5193905355620352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 1/4] avcodec/alac: fix undefined behavior with INT_MIN in lpc_prediction()

2019-09-06 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int' Fixes: 16786/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5632818851348480 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodec_surface: define and use FFANativeWindow to mimic NDK interface

2019-09-06 Thread Matthieu Bouron
On Thu, Sep 05, 2019 at 04:07:20PM -0700, Aman Gupta wrote: > From: Aman Gupta > > This will make it easy to switch to ANativeWindow_fromSurface > and ANativeWindow_release in the future. > > Signed-off-by: Aman Gupta > --- > libavcodec/mediacodec_surface.c | 11 --- >

[FFmpeg-devel] [PATCH 2/2] swscale: Add swscale input support for Y210

2019-09-06 Thread Linjie Fu
Make it possible to convert Y210 to other pixel format. Also add query support in fate. Signed-off-by: Linjie Fu --- libswscale/input.c | 47 libswscale/utils.c | 2 ++ tests/ref/fate/sws-pixdesc-query | 7 ++ 3 files

[FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add 4:2:2 10 bit pixel format Y210

2019-09-06 Thread Linjie Fu
Add support for packed 4:2:2 10 bit pixel format Y210. It is the format that VAAPI/QSV uses when coping with 4:2:2 10bit surfaces. Signed-off-by: Linjie Fu --- libavutil/pixdesc.c | 23 +++ libavutil/pixfmt.h | 4 libavutil/version.h | 2 +- 3 files changed, 28

Re: [FFmpeg-devel] [PATCH] doc/filters: correct range for contrast in eq filter

2019-09-06 Thread Gyan
On 06-09-2019 01:23 PM, Gyan wrote: On 06-09-2019 08:28 AM, Sourabh Sharma wrote: ---   doc/filters.texi | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 6c81e1da40..70ea16954f 100644 --- a/doc/filters.texi +++ b/doc/filters.texi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodecdec_common: log codec name during configure/start failures

2019-09-06 Thread Matthieu Bouron
On Thu, Sep 05, 2019 at 04:07:19PM -0700, Aman Gupta wrote: > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavcodec/mediacodecdec_common.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/mediacodecdec_common.c >

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/mediacodec_surface: guard against NULL surface

2019-09-06 Thread Matthieu Bouron
On Thu, Sep 05, 2019 at 11:27:30AM -0700, Aman Gupta wrote: > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavcodec/mediacodec_surface.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodec_surface.c b/libavcodec/mediacodec_surface.c >

Re: [FFmpeg-devel] [PATCH] doc/filters: correct range for contrast in eq filter

2019-09-06 Thread Gyan
On 06-09-2019 08:28 AM, Sourabh Sharma wrote: --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 6c81e1da40..70ea16954f 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -9538,7 +9538,7 @@ The filter

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/mediacodecdec_common: warn when PTS is missing

2019-09-06 Thread Matthieu Bouron
On Thu, Sep 05, 2019 at 11:27:32AM -0700, Aman Gupta wrote: > From: Aman Gupta > > MediaCodec decoders require PTS for proper operation. > > Signed-off-by: Aman Gupta > --- > libavcodec/mediacodecdec_common.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/mediacodecdec_common: propagate EOF immediately when signaled by decoder

2019-09-06 Thread Matthieu Bouron
On Thu, Sep 05, 2019 at 11:27:35AM -0700, Aman Gupta wrote: > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavcodec/mediacodecdec_common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/mediacodecdec_common.c > b/libavcodec/mediacodecdec_common.c > index

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: merge fmp4 and mpegts segment type m3u8 list AVIOConext

2019-09-06 Thread Steven Liu
hlsenc has been merge fmp4 and mpegts workflow before so it can merge m3u8 list AVIOContext now. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/mediacodecdec: warn when input buffers are not configured with proper size

2019-09-06 Thread Matthieu Bouron
On Thu, Sep 05, 2019 at 11:27:31AM -0700, Aman Gupta wrote: > From: Aman Gupta > > In rare circumstances, if the codec is not configured with the > proper parameters the input buffers can be allocated with a size > that's too small to hold an individual packet. Since MediaCodec > expects exactly

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/mediacodecdec_common: improve trace logging for end-of-stream

2019-09-06 Thread Matthieu Bouron
On Thu, Sep 05, 2019 at 11:27:33AM -0700, Aman Gupta wrote: > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavcodec/mediacodecdec_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecdec_common.c >