Re: [FFmpeg-devel] [PATCH] avformat/argo_asf: Use memcpy to copy string without its NUL

2021-09-25 Thread Zane van Iperen
On 26/9/21 1:09 pm, Andreas Rheinhardt wrote: This avoids a -Wstringop-truncation warning from GCC which takes issue with the fact that the destination might not be NUL terminated. Signed-off-by: Andreas Rheinhardt --- libavformat/argo_asf.c | 20 +++- 1 file changed, 7

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Sunday, 26 September 2021 01:00 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha > > > > > -Original Message- > > From:

[FFmpeg-devel] [PATCH] avfilter/elbg: Extend filter to include alpha values in the quantization procedure

2021-09-25 Thread Soft Works
Usage example: ffmpeg -y -loglevel verbose -i "..\fate-suite\apng\o_sample.png" -filter_complex "elbg=pal8=1:use_alpha=1" -frames:v 1 out.png Signed-off-by: softworkz --- doc/filters.texi | 4 libavfilter/vf_elbg.c | 25 - 2 files changed, 20 insertions(+),

[FFmpeg-devel] [PATCH] avformat/argo_asf: Use memcpy to copy string without its NUL

2021-09-25 Thread Andreas Rheinhardt
This avoids a -Wstringop-truncation warning from GCC which takes issue with the fact that the destination might not be NUL terminated. Signed-off-by: Andreas Rheinhardt --- libavformat/argo_asf.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git

[FFmpeg-devel] [PATCH] avfilter/palettegen, paletteuse: Extend the palette conversion filters to support palettes with alpha

2021-09-25 Thread Soft Works
Usage example: ffmpeg -y -loglevel verbose -i "..\fate-suite\apng\o_sample.png" -filter_complex "split[split1][split2];[split1]palettegen=max_colors=254:use_alpha=1[pal1];[split2][pal1]paletteuse=use_alpha=1" -frames:v 1 out.png Signed-off-by: softworkz --- doc/filters.texi| 8

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Saturday, 25 September 2021 22:47 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha > > On Sat, Sep 25, 2021 at 10:34:32PM

[FFmpeg-devel] [PATCH 3/3] avfilter/formats: Avoid reallocations for video in ff_all_formats()

2021-09-25 Thread Andreas Rheinhardt
Up until now, the list of pixfmts is reallocated every time an entry is added to it; there are currently 196 pixel formats, so this matters: It causes 5541704 calls to av_realloc_array() in a typical FATE run, which is the majority for said function (8095768 calls) and even a large chunk of the

[FFmpeg-devel] [PATCH 2/3] avfilter/formats: Make ff_formats_pixdesc_filter return AVFilterFormats*

2021-09-25 Thread Andreas Rheinhardt
Up until now, it has returned the AVFilterFormats list via an AVFilterFormats** parameter; the actual return value was an int that was always AVERROR(ENOMEM) on error. The AVFilterFormats** argument was a pure output parameter which was only documented by naming the parameter rfmts. Yet

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_swaprect: Use ff_formats_pixdesc_filter()

2021-09-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_swaprect.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/libavfilter/vf_swaprect.c b/libavfilter/vf_swaprect.c index 4a5f4a12a6..fff9b53dc4 100644 --- a/libavfilter/vf_swaprect.c +++

Re: [FFmpeg-devel] [PATCH] webp: fix transforms after a palette with pixel packing.

2021-09-25 Thread James Zern
On Mon, Sep 20, 2021 at 5:44 PM James Zern wrote: > > On Wed, Sep 8, 2021 at 6:46 PM James Zern wrote: > > > > On Mon, Aug 30, 2021 at 5:11 AM Maryla > > wrote: > > > > > > When a color indexing transform with 16 or fewer colors is used, > > > WebP uses "pixel packing", i.e. storing several

Re: [FFmpeg-devel] [PATCH 03/11] avcodec/tests/avcodec: Test AVCodec and AVCodecDescriptor consistency

2021-09-25 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Sep 24, 2021 at 06:37:11PM +0200, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/tests/avcodec.c | 11 ++- >> 1 file changed, 10 insertions(+), 1 deletion(-) > > This and also the other patches adding checks LGTM >

Re: [FFmpeg-devel] [PATCH 02/27] avformat/chromaprint: Add deinit function

2021-09-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Fixes memleaks in case the trailer is never written. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/chromaprint.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/chromaprint.c b/libavformat/chromaprint.c > index

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/siren: prevent getbitcontext overread

2021-09-25 Thread Michael Niedermayer
On Sat, Sep 18, 2021 at 08:01:38PM +1000, Peter Ross wrote: > --- > libavcodec/siren.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) probably ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Michael Niedermayer
On Sat, Sep 25, 2021 at 10:34:32PM +0200, Michael Niedermayer wrote: > On Sat, Sep 25, 2021 at 03:46:25PM +, Soft Works wrote: > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > Michael Niedermayer > > > Sent: Saturday, 25 September 2021 16:30 > > > To:

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Michael Niedermayer
On Sat, Sep 25, 2021 at 03:46:25PM +, Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Saturday, 25 September 2021 16:30 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re:

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_selectivecolor: reduce number of operations with r/g/b/a pointers

2021-09-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_selectivecolor.c | 41 +++-- 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_selectivecolor.c b/libavfilter/vf_selectivecolor.c index 9d789a6d8b..398d4bec0d 100644 ---

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_selectivecolor: refactor some repeating calculations

2021-09-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_selectivecolor.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_selectivecolor.c b/libavfilter/vf_selectivecolor.c index ebbba9157f..9d789a6d8b 100644 --- a/libavfilter/vf_selectivecolor.c +++

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Saturday, 25 September 2021 17:51 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha > > On Sat, Sep 25, 2021 at 5:46 PM Soft

[FFmpeg-devel] [PATCH v3 5/5] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-25 Thread quietvoid
Also fixes incorrect parsing of dv_bl_signal_compatibility_id, which was often set to zero instead of the actual value, for mpegts only. Signed-off-by: quietvoid --- libavformat/mpegts.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) diff

[FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-25 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 51 ++- 1 file changed, 10 insertions(+), 41 deletions(-) diff --git

[FFmpeg-devel] [PATCH v3 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-25 Thread quietvoid
When muxing to Matroska, write the Block Additional Mapping if there is AV_PKT_DATA_DOVI_CONF side data present. Most of the code was implemented by Plex developers. Since the type (dvcC/dvvC) can change depending on the caller, the logic was separated from ff_isom_put_dvcc_dvvc. In this case,

[FFmpeg-devel] [PATCH v3 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-25 Thread quietvoid
The parsing was implemented in a new dovi_isom file for the unification of the mov/mpegts DOVI parsing into one function, in a following patch. Most of the Matroska elements implementation was done by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +-

[FFmpeg-devel] [PATCH v3 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-25 Thread quietvoid
Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid --- libavformat/matroska.h| 7 +++ libavformat/matroskadec.c | 44 +-- 2 files changed, 49 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Paul B Mahol
On Sat, Sep 25, 2021 at 5:46 PM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Saturday, 25 September 2021 16:30 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Saturday, 25 September 2021 16:30 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha > > On Sat, Sep 25, 2021 at 10:23:56AM

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Michael Niedermayer
On Sat, Sep 25, 2021 at 10:23:56AM +0200, Hendrik Leppkes wrote: > On Sat, Sep 25, 2021 at 5:00 AM Soft Works wrote: > > > > > > > > > -Original Message- > > > From: ffmpeg-devel On Behalf Of > > > Soft Works > > > Sent: Friday, 24 September 2021 19:03 > > > To: FFmpeg development

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread lance . lmwang
On Sat, Sep 25, 2021 at 04:51:58PM +0300, Jan Ekström wrote: > On Sat, Sep 25, 2021 at 4:35 PM wrote: > > > > On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote: > > > On Thu, Sep 23, 2021 at 6:08 PM wrote: > > > > > > > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > >

[FFmpeg-devel] [PATCH v3 2/2] avcodec/libsvtav1: properly enforce CQP mode when set in wrapper

2021-09-25 Thread lance . lmwang
From: Limin Wang SVT-AV1 seems to have switched their default from CQP to CRF in February, so enforce the controlling option accordingly. Signed-off-by: Limin Wang --- libavcodec/libsvtav1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c

[FFmpeg-devel] [PATCH v3 1/2] doc/encoders: add available values for libsvtav1 options

2021-09-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/encoders.texi | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 8fccd73..8a7589c 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1750,12 +1750,30 @@

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread Jan Ekström
On Sat, Sep 25, 2021 at 4:35 PM wrote: > > On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote: > > On Thu, Sep 23, 2021 at 6:08 PM wrote: > > > > > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > > > > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa > > > > wrote:

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread lance . lmwang
On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote: > On Thu, Sep 23, 2021 at 6:08 PM wrote: > > > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > > > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa > > > wrote: > > > > > > > > On Sun, Sep 19, 2021 at 2:02 PM

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

2021-09-25 Thread lance . lmwang
On Sat, Sep 25, 2021 at 03:59:20PM +0300, Jan Ekström wrote: > On Sat, Sep 25, 2021 at 3:49 PM wrote: > > > > On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote: > > > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > > > > > From: Limin Wang > > > > > > > > Signed-off-by: Limin Wang > >

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/libsvtav1: Fix the max range for rc_mode

2021-09-25 Thread lance . lmwang
On Sat, Sep 25, 2021 at 03:14:34PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > Probably something like "avcodec/libsvtav1: fix value range for > rc_mode" is a bit better as a commit message? OK, will

Re: [FFmpeg-devel] [PATCH v2 4/6] avcodec/libsvtav1: Fix CQP mode doesn't work as expection

2021-09-25 Thread lance . lmwang
On Sat, Sep 25, 2021 at 03:06:23PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > Commit message should probably be something along the lines of > > """ > avcodec/libsvtav1: properly enforce CQP mode

Re: [FFmpeg-devel] [PATCH v2 3/6] doc: update for libsvtav1 encoder

2021-09-25 Thread lance . lmwang
On Sat, Sep 25, 2021 at 02:32:43PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > Hi, > > "doc/encoders: add available values for libsvtav1 options" > > would possibly be better as a commit message?

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

2021-09-25 Thread Jan Ekström
On Sat, Sep 25, 2021 at 3:49 PM wrote: > > On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote: > > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > > I'd prefer the wording "fix duplicate definition of caps_internal", > >

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

2021-09-25 Thread lance . lmwang
On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote: > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > I'd prefer the wording "fix duplicate definition of caps_internal", > but otherwise this patch is LGTM. No problem, will update

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread Jan Ekström
On Thu, Sep 23, 2021 at 6:08 PM wrote: > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa > > wrote: > > > > > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > > > wrote: > > > > > > > > > > > > > > > On Fri, Sep 17,

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/libsvtav1: Fix the max range for rc_mode

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- Probably something like "avcodec/libsvtav1: fix value range for rc_mode" is a bit better as a commit message? > libavcodec/libsvtav1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH v2 4/6] avcodec/libsvtav1: Fix CQP mode doesn't work as expection

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- Commit message should probably be something along the lines of """ avcodec/libsvtav1: properly enforce CQP mode when set in wrapper SVT-AV1 seems to have switched their default from CQP to CRF in

Re: [FFmpeg-devel] [PATCH v2 3/6] doc: update for libsvtav1 encoder

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- Hi, "doc/encoders: add available values for libsvtav1 options" would possibly be better as a commit message? > doc/encoders.texi | 44 > 1 file

Re: [FFmpeg-devel] [PATCH v2 2/6] avcodec/libsvtav1: make coded GOP type configurable

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Reviewed-by: Jan Ekström > Signed-off-by: Limin Wang I still hate how SVT-AV1 has no enum/defines for these, but so be it :) LGTM. Jan ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang I'd prefer the wording "fix duplicate definition of caps_internal", but otherwise this patch is LGTM. Good catch. Jan ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread Jan Ekström
On Sat, Sep 25, 2021 at 4:06 AM wrote: > > On Thu, Sep 23, 2021 at 09:45:48AM -0400, Christopher Degawa wrote: > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > > wrote: > > > > > > > > > > > On Fri, Sep 17, 2021 at 9:28 PM wrote: > > > > > >> From: Limin Wang > > >> > > >>

[FFmpeg-devel] [PATCH] avfilter/vf_avgblur: switch to faster algorithm

2021-09-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_avgblur.c | 311 +-- 1 file changed, 171 insertions(+), 140 deletions(-) diff --git a/libavfilter/vf_avgblur.c b/libavfilter/vf_avgblur.c index 3e222a43fa..a838285bb4 100644 --- a/libavfilter/vf_avgblur.c +++

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/siren: prevent getbitcontext overread

2021-09-25 Thread Peter Ross
On Sat, Sep 18, 2021 at 08:01:38PM +1000, Peter Ross wrote: > --- > libavcodec/siren.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/siren.c b/libavcodec/siren.c > index 2161b29a2c..3b0ad7b642 100644 > --- a/libavcodec/siren.c > +++ b/libavcodec/siren.c

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Hendrik Leppkes
On Sat, Sep 25, 2021 at 5:00 AM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Soft Works > > Sent: Friday, 24 September 2021 19:03 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] Scaling PAL8

Re: [FFmpeg-devel] Scaling PAL8 images with alpha

2021-09-25 Thread Paul B Mahol
On Sat, Sep 25, 2021 at 5:00 AM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Soft Works > > Sent: Friday, 24 September 2021 19:03 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] Scaling PAL8