-Original Message-
From: ffmpeg-devel On Behalf Of Wang, Bin
Sent: Monday, September 26, 2022 4:56 PM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v5] libavfilter/x86/vf_convolution: add
sobel filter optimization and unit test with intel AVX512 VNNI
-Original
Oct 7, 2022, 22:20 by andreas.rheinha...@outlook.com:
> Write-only since e7d977b446194649aa30f2aacc6c17bce7aeb90b
> (and local to ff_opus_rc_enc_end() before that).
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/opus_rc.c | 2 --
> libavcodec/opus_rc.h | 3 ---
> 2 files changed, 5
Hi,
On Fri, Oct 7, 2022 at 9:25 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> There is no MMX code for loop filters since commit
> 6a551f14050674fb685920eb1b0640810cacccf9, so use declare_func
> instead of declare_func_emms() to also test that we are not
> in MMX mode after
There is no MMX code for (add|put|put_signed)_pixels_clamped
since commit bfb28b5ce89f3e950214b67ea95b45e3355c2caf, so use
declare_func instead of declare_func_emms() to also test that
we are not in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/idctdsp.c | 2 +-
1
There is no MMX code for loop filters since commit
6a551f14050674fb685920eb1b0640810cacccf9, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/vp8dsp.c | 6 +++---
1 file changed, 3
There is no MMX code for diff_bytes since commit
230ea38de143368729ee1cce47b3a87fbafad8e4, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/llviddspenc.c | 4 ++--
1 file changed, 2
There is no MMX code for add_int16 since commit
4b6ffc2880e33d05ed1ab6bbc38e5a795f14b504, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/huffyuvdsp.c | 2 +-
1 file changed, 1
There is no MMX code for llviddsp after commit
fed07efcde72824ac1ada80d4af4e91ac4fcfc14, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/llviddsp.c | 16
1 file
There is no MMX code for pixblockdsp after commit
92b58002776edd3a3df03c90e8a3ab24b8f987de, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/pixblockdsp.c | 4 ++--
1 file changed, 2
There is no MMX code for audiodsp after commit
3d716d38abdae1982e84e30becb57458244656bd, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/audiodsp.c | 10 +-
1 file changed, 5
There is no MMX code for blockdsp after commit
ee551a21ddcbf81afe183d9489c534ee80f263a0, so use declare_func
instead of declare_func_emms() to also test that we are not
in MMX mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/blockdsp.c | 2 +-
1 file changed, 1
There is no MMX code for vc1_inv_trans_8x8 or
vc1_unescape_buffer, so use declare_func instead of
declare_func_emms() to also test that we are not in MMX
mode after return.
Signed-off-by: Andreas Rheinhardt
---
tests/checkasm/vc1dsp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
This fixes an issue where a timestamp attribute may have a valid zero
value (the UNIX epoch 1970-01-01T00:00:00), but is misinterpreted by
dashdec as being unassigned. This changes the logic that calculates
segment numbers and makes the stream undecodable by dashdec.
The fix originally posted to
Signed-off-by: Andreas Rheinhardt
---
libavcodec/opus_pvq.c | 4 ++--
libavcodec/opus_pvq.h | 3 +++
libavcodec/opus_pvq_template.c | 35 ++
libavcodec/opusenc_psy.c | 12 ++--
4 files changed, 30 insertions(+), 24 deletions(-)
Since commit 4fc2531fff112836026aad2bdaf128c9d15a72e3 opus.c
contains only the celt stuff shared between decoder and encoder.
meanwhile, opus_celt.c is decoder-only. So the new names
reflect the actual content better than the current ones.
Signed-off-by: Andreas Rheinhardt
---
The decoder currently only uses 72 bytes of 1376; furthermore,
the GetBitContext in OpusRangeCoder is unused by the encoder,
but its existence adds an unnecessary inclusion of get_bits.h
to the encoder-only files. So split OpusRangeContext;
also split opus_rc.c into an encoder- and a decoder-only
Signed-off-by: Andreas Rheinhardt
---
libavcodec/opus_pvq.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/libavcodec/opus_pvq.c b/libavcodec/opus_pvq.c
index 79101847af..d08dcd7413 100644
--- a/libavcodec/opus_pvq.c
+++ b/libavcodec/opus_pvq.c
@@ -366,6 +366,7 @@
Signed-off-by: Andreas Rheinhardt
---
libavcodec/opus_rc.c | 4 ++--
libavcodec/opus_rc.h | 5 ++---
libavcodec/opusenc_psy.c | 2 +-
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/libavcodec/opus_rc.c b/libavcodec/opus_rc.c
index 2061418e52..1a26d889b7 100644
---
Signed-off-by: Andreas Rheinhardt
---
libavcodec/opus.h | 6 +++---
libavcodec/opus_parse.c | 12 ++--
libavcodec/opus_parse.h | 4 ++--
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/libavcodec/opus.h b/libavcodec/opus.h
index 4d061cf5f8..f87b63aaca 100644
---
Signed-off-by: Andreas Rheinhardt
---
libavcodec/opusenc_psy.c | 5 -
libavcodec/opusenc_psy.h | 11 ---
2 files changed, 16 deletions(-)
diff --git a/libavcodec/opusenc_psy.c b/libavcodec/opusenc_psy.c
index 94c37fb8b1..5c768ae68e 100644
--- a/libavcodec/opusenc_psy.c
+++
Signed-off-by: Andreas Rheinhardt
---
libavcodec/opusenc.c | 2 +-
libavcodec/opusenc_psy.c | 2 +-
libavcodec/opusenc_psy.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/opusenc.c b/libavcodec/opusenc.c
index 7695e95884..280425c74f 100644
---
Write-only since e7d977b446194649aa30f2aacc6c17bce7aeb90b
(and local to ff_opus_rc_enc_end() before that).
Signed-off-by: Andreas Rheinhardt
---
libavcodec/opus_rc.c | 2 --
libavcodec/opus_rc.h | 3 ---
2 files changed, 5 deletions(-)
diff --git a/libavcodec/opus_rc.c b/libavcodec/opus_rc.c
Sent an updated version:
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7707.
1)
>>All of these should be size_t
The field type is still "int" according to James Almer's comment.
2) I placed the fields at the very end, according to a message from Timo
Rothenpieler.
3)
>>The semantics of
In webm specification, it supports cropping information.
(https://www.webmproject.org/docs/container/)
In ffmpeg, the implementation of webm is a subset of matroska. In
matroskadec.c, those cropping related four fields are forced to 0.
for the sample file with crop (crop_bottom =8,
Support both simple and receive_frame api
The container crop information is applied additional to frame crop information
---
libavcodec/codec_par.c | 30 +++---
libavcodec/decode.c| 14 ++
2 files changed, 33 insertions(+), 11 deletions(-)
diff --git
---
libavcodec/avcodec.h | 35 +++
libavcodec/codec_par.h | 8
libavcodec/options_table.h | 4
3 files changed, 47 insertions(+)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 7365eb5cc0..d28a7cc022 100644
---
fre 2022-10-07 klockan 14:33 +0200 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > fre 2022-10-07 klockan 12:38 +0200 skrev Andreas Rheinhardt:
> > > Tomas Härdin:
> > > > tor 2022-10-06 klockan 21:45 +1100 skrev Peter Ross:
> > > > >
> > > > > +static av_cold int vqc_decode_init(AVCodecContext *
Tomas Härdin:
> fre 2022-10-07 klockan 12:38 +0200 skrev Andreas Rheinhardt:
>> Tomas Härdin:
>>> tor 2022-10-06 klockan 21:45 +1100 skrev Peter Ross:
+static av_cold int vqc_decode_init(AVCodecContext * avctx)
+{
+ static AVOnce init_static_once = AV_ONCE_INIT;
+
fre 2022-10-07 klockan 12:38 +0200 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > tor 2022-10-06 klockan 21:45 +1100 skrev Peter Ross:
> > >
> > > +static av_cold int vqc_decode_init(AVCodecContext * avctx)
> > > +{
> > > + static AVOnce init_static_once = AV_ONCE_INIT;
> > > + VqcContext *s
Andreas Rheinhardt:
> Also improve the other headers a bit.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/ylc.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/libavcodec/ylc.c b/libavcodec/ylc.c
> index 3ea6749ffe..29c10f05da 100644
> ---
Andreas Rheinhardt:
> Forgotten after 2b9ab1d54a35f7d689b2396cfc59f9dbdcae391f.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/msmpeg4enc.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/msmpeg4enc.c b/libavcodec/msmpeg4enc.c
>
Andreas Rheinhardt:
> PixblockDSP does not use MMX functions any more since
> 92b58002776edd3a3df03c90e8a3ab24b8f987de and FDCTDSP
> since d402ec6be99dc82e263bad883e7c1c3d957343db.
> BswapDSP never used MMX, so that the emms_c() here
> is unnecessary.
>
> Signed-off-by: Andreas Rheinhardt
> ---
Tomas Härdin:
> tor 2022-10-06 klockan 21:45 +1100 skrev Peter Ross:
>>
>> +static av_cold int vqc_decode_init(AVCodecContext * avctx)
>> +{
>> + static AVOnce init_static_once = AV_ONCE_INIT;
>> + VqcContext *s = avctx->priv_data;
>> +
>> + s->vectors = av_malloc((avctx->width *
tor 2022-10-06 klockan 21:45 +1100 skrev Peter Ross:
>
> +static av_cold int vqc_decode_init(AVCodecContext * avctx)
> +{
> + static AVOnce init_static_once = AV_ONCE_INIT;
> + VqcContext *s = avctx->priv_data;
> +
> + s->vectors = av_malloc((avctx->width * avctx->height * 3) / 2);
> +
- Changelog update
- MAINTAINERS update
Signed-off-by: Dawid Kozinski
---
Changelog | 3 ++-
MAINTAINERS | 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/Changelog b/Changelog
index 14ba8ac874..ff3b9aebf1 100644
--- a/Changelog
+++ b/Changelog
@@ -44,6 +44,8 @@ version
- Added evc extension to the list of extensions for ff_mov_demuxer
Signed-off-by: Dawid Kozinski
---
libavformat/demux.c | 1 +
libavformat/mov.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/demux.c b/libavformat/demux.c
index 2dfd82a63c..f3ebe4d09b
- Changes in mov_write_video_tag function to handle EVC elementary stream
- Provided structure EVCDecoderConfigurationRecord that specifies the decoder
configuration information for ISO/IEC 23094-1 video content
Signed-off-by: Dawid Kozinski
---
libavformat/Makefile| 2 +-
- Added EVC decoder wrapper
- Changes in project configuration file and libavcodec Makefile
- Added documentation for xevd wrapper
Signed-off-by: Dawid Kozinski
---
configure | 4 +
doc/decoders.texi | 24 +++
doc/general_contents.texi | 10 +-
libavcodec/Makefile
- Added EVC encoder wrapper
- Changes in project configuration file and libavcodec Makefile
- Added documentation for xeve wrapper
Signed-off-by: Dawid Kozinski
---
configure | 4 +
doc/encoders.texi | 69 +
doc/general_contents.texi | 11 +
libavcodec/Makefile
- Provided AVInputFormat structure describing EVC input format (ff_evc_demuxer)
Signed-off-by: Dawid Kozinski
---
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/evcdec.c | 124 +++
3 files changed, 126 insertions(+)
- Provided AVOutputFormat structure describing EVC output format (ff_evc_muxer)
- Added documentation for EVC muxer
Signed-off-by: Dawid Kozinski
---
doc/muxers.texi | 6 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rawenc.c | 13
Signed-off-by: Dawid Kozinski
---
libavcodec/Makefile | 1 +
libavcodec/evc.h| 155 +
libavcodec/evc_parser.c | 725
libavcodec/parsers.c| 1 +
4 files changed, 882 insertions(+)
create mode 100644 libavcodec/evc.h
create
Added prerequisites that must be met before providing support for the MPEG-5
EVC codec
- Added new entry to codec IDs list
- Added new entry to the codec descriptor list
- Bumped libavcodec minor version
- Added profiles for EVC codec
Signed-off-by: Dawid Kozinski
---
libavcodec/avcodec.h|
43 matches
Mail list logo
