Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: fix missing SPS/PPS to IDR frames

2023-01-09 Thread Zhao Zhili
On Tue, 2023-01-10 at 07:41 +0100, Andreas Rheinhardt wrote: > Zhao Zhili: > > From: Zhao Zhili > > > > If there is a single group of SPS/PPS before an IDR frame, but no > > SPS/PPS after that, we will miss the chance to reset > > idr_sps_seen/idr_pps_seen. The result is missing SPS/PPS for all

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: fix missing SPS/PPS to IDR frames

2023-01-09 Thread Andreas Rheinhardt
Zhao Zhili: > From: Zhao Zhili > > If there is a single group of SPS/PPS before an IDR frame, but no > SPS/PPS after that, we will miss the chance to reset > idr_sps_seen/idr_pps_seen. The result is missing SPS/PPS for all > IDR frames except the first one. > > Signed-off-by: Zhao Zhili > ---

Re: [FFmpeg-devel] [PATCH] ffmpeg: apply discontinuity adjustment per-stream

2023-01-09 Thread Gyan Doshi
On 2023-01-07 09:50 am, Gyan Doshi wrote: On 2023-01-03 03:52 pm, Gyan Doshi wrote: At present, the offset for discontinuity adjustment is applied per-file but the check for discontinuity is intra-stream so the same discontinuity when seen in multiple streams with copyts, leads to

[FFmpeg-devel] [PATCH v3 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili --- v3: when target API <= 24 ==> when target API < 24 v2: add comments libavcodec/mediacodecdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index 11f655a9aa..21464900d1 100644 ---

[FFmpeg-devel] [PATCH v2 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/mediacodecdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index 11f655a9aa..6a28974d14 100644 --- a/libavcodec/mediacodecdec.c +++ b/libavcodec/mediacodecdec.c @@ -415,7

[FFmpeg-devel] [PATCH v2 1/2] avcodec/mediacodec_wrapper: get api level via NDK method

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili android_get_device_api_level() is a static inline before API level 29. It was implemented via __system_property_get(). We can do the same thing, but I don't want to mess up with __system_property_get. --- libavcodec/mediacodec_wrapper.c | 18 ++ 1 file changed,

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-09 Thread James Zern
On Thu, Jan 5, 2023 at 2:42 AM Dmitrii Ovchinnikov wrote: > > From: Dmitrii Ovchinnikov > > This change improves the performance and multicore > scalability of the vp9 codec for streaming single-pass encoded videos. The > current thread limit for ffmpeg codecs is 16 (MAX_AUTO_THREADS in >

Re: [FFmpeg-devel] [PATCH v2 2/2] ibavformat/mov: Add support for exporting poster time.

2023-01-09 Thread zhilizhao(赵志立)
> On Oct 5, 2022, at 22:25, Bryce Chester Newman wrote: > > From: Bryce Chester Newman > > Change demuxer option name from > poster_time_location > to export_poster_time_location. > > Export the poster_time_location if available. > The poster_time_location is calculated using > the

Re: [FFmpeg-devel] [PATCH v1 00/11] Add support for H266/VVC

2023-01-09 Thread Nuo Mi
Hi Thomas It works for me. BTW, I will send out a C version of VVC native decoder very soon. Please also help review and improve it. Thank you. On Tue, Jan 3, 2023 at 10:02 PM Thomas Siedel wrote: > On Thu, 15 Dec 2022 at 10:11, Thomas Siedel > wrote: > >> On Tue, 13 Dec 2022 at 07:19, Nuo Mi

Re: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls

2023-01-09 Thread Martin Storsjö
On Mon, 9 Jan 2023, Martin Storsjö wrote: Hi Rui, Long time no see! On Sat, 7 Jan 2023, Rui Ueyama wrote: It looks like compiler-generated code always uses `b`, `bl` or `blx` instructions for function calls. These instructions have a 24-bit immediate and therefore can jump anywhere between

Re: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-09 Thread Mark Thompson
On 09/01/2023 07:37, David Rosca wrote: On Mon, Jan 9, 2023 at 3:22 AM Xiang, Haihao wrote: On Do, 2022-12-29 at 22:20 +0100, David Rosca wrote: --- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c

[FFmpeg-devel] [PATCH] avcodec/v4l2_m2m: log both v4l2 and av pixel formats during negotiation

2023-01-09 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- avcodec/v4l2_m2m: log both v4l2 and av pixel formats during negotiation Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-47%2Ftmm1%2Fv4l2-dbg-v1 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg

Re: [FFmpeg-devel] [PATCH] libavcodec: v4l2m2m: allow lower minimum buffer values

2023-01-09 Thread Aman Karmani
On Fri, May 8, 2020 at 11:08 PM Andriy Gelman wrote: > On Thu, 07. May 09:18, Lukas Rusak wrote: > > There is no reason to enforce a high minimum. In the context > > of streaming only a few output buffers and capture buffers > > are even needed for continuous playback. This also helps > >

[FFmpeg-devel] [PATCH v4] avcodec/vaapi_encode_h26x: passthrough A53 CC data as H264/HEVC SEI

2023-01-09 Thread Aman Karmani
From: Aman Karmani Signed-off-by: Aman Karmani --- avcodec/vaapi_encode_h26x: passthrough A53 CC data as H264/HEVC SEI v4: updated deps in configure v3: fix build failure v2: add control via sei parameter Published-As:

Re: [FFmpeg-devel] [EXTERNAL] [PATCH v2 2/2] ibavformat/mov: Add support for exporting poster time.

2023-01-09 Thread Bryce Newman
Hi, Any possibility of getting this change into the next versioned release of FFmpeg? Thank you. Bryce Bryce Chester Newman | Principal Developer p: +12069255045 | From: Bryce Newman Date: Monday, November 28, 2022 at 7:11 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [EXTERNAL]

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: get api level via NDK method

2023-01-09 Thread Tomas Härdin
mån 2023-01-09 klockan 22:41 +0800 skrev Zhao Zhili: > > > From: ffmpeg-devel On Behalf Of > > Tomas Härdin > > Sent: 2023年1月9日 20:32 > > To: FFmpeg development discussions and patches < > > ffmpeg-devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: > > get

Re: [FFmpeg-devel] [PATCH v1] fate/imfdec: add audio test

2023-01-09 Thread Pierre-Anthony Lemieux
Quick ping. This adds an audio test for the IMF demuxer FATE suite, which currently only has image tests. On Thu, Dec 29, 2022 at 11:12 PM wrote: > > From: Pierre-Anthony Lemieux > > Adds an audio test for the IMF demuxer. > > FATE content at https://www.sandflow.com/public/countdown-audio.zip

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-09 Thread Tomas Härdin
mån 2023-01-09 klockan 21:14 +0800 skrev zhilizhao(赵志立): > > > > On Jan 9, 2023, at 20:34, Tomas Härdin wrote: > > > > tis 2023-01-10 klockan 00:36 +0800 skrev Zhao Zhili: > > > From: Zhao Zhili > > > > > > Signed-off-by: Zhao Zhili > > > --- > > >  libavcodec/mediacodecdec.c | 2 +- > > >  

Re: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls

2023-01-09 Thread Martin Storsjö
Hi Rui, Long time no see! On Sat, 7 Jan 2023, Rui Ueyama wrote: It looks like compiler-generated code always uses `b`, `bl` or `blx` instructions for function calls. These instructions have a 24-bit immediate and therefore can jump anywhere between PC +- 16 MiB. This hand-written assembly

Re: [FFmpeg-devel] [PATCH v6 0/3] ffmpeg: add video heartbeat capability to fix_sub_duration

2023-01-09 Thread Jan Ekström
On Mon, Dec 19, 2022 at 9:34 AM Jan Ekström wrote: > > Changes from v5: > - Rebased things on top of current master (option related code moved to >ffmpeg_mux_init etc). > - Added notes in the documentation regarding drawbacks of this option and >that it should not be utilized in cases

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2023-01-09 Thread Zhao Zhili
> From: ffmpeg-devel On Behalf Of Alessandro > Di Nepi > Sent: 2022年12月15日 22:16 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in > the decoder callback > > Ping on this, > Can I contribute somehow either to fix

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: get api level via NDK method

2023-01-09 Thread Zhao Zhili
> From: ffmpeg-devel On Behalf Of Tomas Härdin > Sent: 2023年1月9日 20:32 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: get api > level via NDK method > > tis 2023-01-10 klockan 00:36 +0800 skrev Zhao Zhili: > > From: Zhao

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-09 Thread zhilizhao(赵志立)
> On Jan 9, 2023, at 20:34, Tomas Härdin wrote: > > tis 2023-01-10 klockan 00:36 +0800 skrev Zhao Zhili: >> From: Zhao Zhili >> >> Signed-off-by: Zhao Zhili >> --- >> libavcodec/mediacodecdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 1/8] lavfi/vf_scale: allow passing options to swscale directly

2023-01-09 Thread Nicolas George
Anton Khirnov (12023-01-08): > Avoid using the dictionary mechanism, which is non-introspectable. As > this is the only user of AVFilter.init_dict(), this callback can now be > removed. Series looks good to me, thanks. Regards, -- Nicolas George

[FFmpeg-devel] [PATCH 5/5] avcodec/videotoolbox: don't use av_ prefix for local function

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/videotoolbox.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index a3d19c4c63..e42fea6f32 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -1173,8

[FFmpeg-devel] [PATCH 1/5] avcodec/videotoolbox: fix NULL pointer dereference

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili In the code path of av_videotoolbox_default_init/init2(), avctx->internal->hwaccel_priv_data is NULL and passed to decoder_cb.decompressionOutputRefCon. Then it will be dereferenced inside videotoolbox_decoder_callback(). Delay videotoolbox_star() until

[FFmpeg-devel] [PATCH 3/5] avcodec/videotoolbox: deprecate create AVVideotoolboxContext by user

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/version_major.h | 1 + libavcodec/videotoolbox.c | 35 --- libavcodec/videotoolbox.h | 12 3 files changed, 33 insertions(+), 15 deletions(-) diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h

[FFmpeg-devel] [PATCH 4/5] avcodec/videotoolbox: fix documents of AVVideotoolboxContext

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili Since those fields will be overridden by videotoolbox_start(), they should never be set by user, it can trigger memory leaks otherwise. --- libavcodec/videotoolbox.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/videotoolbox.h b/libavcodec/videotoolbox.h

[FFmpeg-devel] [PATCH 3/5] avcodec/videotoolbox: deprecate creating AVVideotoolboxContext by user

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/version_major.h | 1 + libavcodec/videotoolbox.c | 35 --- libavcodec/videotoolbox.h | 12 3 files changed, 33 insertions(+), 15 deletions(-) diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h

[FFmpeg-devel] [PATCH 2/5] avcodec/videotoolbox: prefer hw_frames_ctx/hw_device_ctx over hwaccel_context

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/videotoolbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index a18b49007d..acf0c79822 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -1181,7 +1181,8 @@

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-09 Thread Tomas Härdin
tis 2023-01-10 klockan 00:36 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- >  libavcodec/mediacodecdec.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: get api level via NDK method

2023-01-09 Thread Tomas Härdin
tis 2023-01-10 klockan 00:36 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > android_get_device_api_level() is a static inline method before API > level 29. It was implemented via __system_property_get(). We can do > the same thing, but I don't want to mess up with > __system_property_get. The

Re: [FFmpeg-devel] [PATCH 1/2] lavc/mediacodecenc: Probe supported pixel formats

2023-01-09 Thread Tomas Härdin
> > > In addition to the 'different MediaCodec backends support > > > different pixel format' issue, another concern of this method is > > > that > > > it's not > > > determinate, it can give different results at different > > > time/condition. > > > > > > MediaCodec can fail for all kinds of

Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

2023-01-09 Thread Paul B Mahol
On 1/9/23, Tobias Rapp wrote: > On 08/01/2023 15:45, Michael Niedermayer wrote: > >> On Fri, Jan 06, 2023 at 07:01:06PM +0100, Paul B Mahol wrote: >>> On Fri, Jan 6, 2023 at 6:25 PM Michael Niedermayer >>> >>> wrote: >>> On Thu, Jan 05, 2023 at 11:08:25PM +0100, Paul B Mahol wrote: > On

Re: [FFmpeg-devel] [PATCH v3] avformat/dvd: new dvd:// protocol for reading dvd folder/images

2023-01-09 Thread Stan I
Thanks for looking into this. On Mon, Jan 9, 2023 at 9:13 AM Nicolas George wrote: > > Stanislav Ionascu (12023-01-08): > > dvd:// protocol uses libdvdread for opening folders and/or disc-images, > > it then either identifies the longest title-set, or uses the title-set > > parameter. > > > >

Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

2023-01-09 Thread Tobias Rapp
On 08/01/2023 15:45, Michael Niedermayer wrote: On Fri, Jan 06, 2023 at 07:01:06PM +0100, Paul B Mahol wrote: On Fri, Jan 6, 2023 at 6:25 PM Michael Niedermayer wrote: On Thu, Jan 05, 2023 at 11:08:25PM +0100, Paul B Mahol wrote: On Thu, Jan 5, 2023 at 9:53 PM Michael Niedermayer <

Re: [FFmpeg-devel] [PATCH v3] avformat/dvd: new dvd:// protocol for reading dvd folder/images

2023-01-09 Thread Nicolas George
Stanislav Ionascu (12023-01-08): > dvd:// protocol uses libdvdread for opening folders and/or disc-images, > it then either identifies the longest title-set, or uses the title-set > parameter. > > After opening the dvd, it will read and output all VOBs, in sequence > defined by the program-chain.

[FFmpeg-devel] [PATCH] lavc/qsvenc_jpeg: accept YUYV422 and BGRA in system memory

2023-01-09 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_jpeg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/qsvenc_jpeg.c b/libavcodec/qsvenc_jpeg.c index 2469ef7c9f..2add12adc9 100644 --- a/libavcodec/qsvenc_jpeg.c +++ b/libavcodec/qsvenc_jpeg.c @@ -89,6 +89,8

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: fix missing SPS/PPS to IDR frames

2023-01-09 Thread Zhao Zhili
On Thu, 2022-12-29 at 01:20 +0800, Zhao Zhili wrote: > From: Zhao Zhili > > If there is a single group of SPS/PPS before an IDR frame, but no > SPS/PPS after that, we will miss the chance to reset > idr_sps_seen/idr_pps_seen. The result is missing SPS/PPS for all > IDR frames except the first

[FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/mediacodecdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index 11f655a9aa..6ef23d7369 100644 --- a/libavcodec/mediacodecdec.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: get api level via NDK method

2023-01-09 Thread Zhao Zhili
From: Zhao Zhili android_get_device_api_level() is a static inline method before API level 29. It was implemented via __system_property_get(). We can do the same thing, but I don't want to mess up with __system_property_get. Signed-off-by: Zhao Zhili --- libavcodec/mediacodec_wrapper.c | 7