Re: [FFmpeg-devel] [PATCH v2] avformat/segment: calculate segment durations correctly.

2023-01-14 Thread Gyan Doshi
On 2023-01-12 11:29 am, Gyan Doshi wrote: On 2023-01-07 05:37 pm, Gyan Doshi wrote: segment_time and segment_times are defined as duration specifications, not timestamps, so calculation of segment duration must account for initial timestamp. Fixed. FATE ref for segment-mp4-to-ts changed

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/eatgq: : Check index increments in tgq_decode_block()

2023-01-14 Thread Peter Ross
On Thu, Jan 12, 2023 at 12:54:27AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGQ_fuzzer-6743211456724992 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/wbmpdec: use remaining size not whole size

2023-01-14 Thread Peter Ross
On Fri, Jan 13, 2023 at 01:01:34AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WBMP_fuzzer-6652634692190208 > Fixes: > 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WBMP_fuzzer-6653703453278208 >

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

2023-01-14 Thread Stefano Sabatini
On date Saturday 2022-12-31 20:26:34 +0100, Stefano Sabatini wrote: > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > > For some samples the pkt->pts is always missing, use the pkt->dts > > instead. > > > > Fix trac issue http://trac.ffmpeg.org/ticket/4427. > > --- > >

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames

2023-01-14 Thread Stefano Sabatini
On date Saturday 2023-01-14 22:59:31 +0200, Jan Ekström wrote: > On Sat, Jan 14, 2023 at 10:03 PM Stefano Sabatini wrote: > > > > On date Tuesday 2023-01-10 23:19:48 +0200, Jan Ekström wrote: > > > --- > > > fftools/ffprobe.c | 15 +++ > > > 1 file changed, 15 insertions(+) > > > >

Re: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls

2023-01-14 Thread Martin Storsjö
Hi Rui, On Sat, 14 Jan 2023, Rui Ueyama wrote: On Sat, 7 Jan 2023, Rui Ueyama wrote: It looks like compiler-generated code always uses `b`, `bl` or `blx` instructions for function calls. These instructions have a 24-bit immediate and therefore can jump anywhere between PC +- 16 MiB. This

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames

2023-01-14 Thread Jan Ekström
On Sat, Jan 14, 2023 at 10:03 PM Stefano Sabatini wrote: > > On date Tuesday 2023-01-10 23:19:48 +0200, Jan Ekström wrote: > > --- > > fftools/ffprobe.c | 15 +++ > > 1 file changed, 15 insertions(+) > > Missing doc/ffprobe.xsd changes? > > LGTM otherwise. > I quickly checked

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add support for Ambient Viewing Environment side data

2023-01-14 Thread Stefano Sabatini
On date Friday 2023-01-13 18:35:36 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vf_showinfo.c | 15 +++ > 1 file changed, 15 insertions(+) LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-14 Thread Michael Niedermayer
On Sat, Jan 14, 2023 at 04:48:10PM +0100, Jerome Martinez wrote: > Before the patch: > - stored values were rounded to upper 16 multiple also for formats not using > macroblocks (should be st->codecpar->width and st->codecpar->height when not > MPEG formats; note that I found no other muxer doing

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames

2023-01-14 Thread Stefano Sabatini
On date Tuesday 2023-01-10 23:19:48 +0200, Jan Ekström wrote: > --- > fftools/ffprobe.c | 15 +++ > 1 file changed, 15 insertions(+) Missing doc/ffprobe.xsd changes? LGTM otherwise. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-01-14 Thread Ronald S. Bultje
Hi, On Sat, Jan 14, 2023 at 10:16 AM Nuo Mi wrote: > On Sat, Jan 14, 2023 at 10:28 PM Ronald S. Bultje > > How come vvcdsp has only 8/10 bits/component code but vvcpred has > 8/9/10/12 > > bits/component code? > > I will remove it. > Not sure how applicable this is, but for AV1 (dav1d), most

[FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height

2023-01-14 Thread Jerome Martinez
Before the patch: - stored values were rounded to upper 16 multiple also for formats not using macroblocks (should be st->codecpar->width and st->codecpar->height when not MPEG formats; note that I found no other muxer doing the rounding for AVC, only for MPEG-2 Video, but I find no reason in

[FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support

2023-01-14 Thread Jerome Martinez
The arbitrary short element codes are the ones used by another muxer ( files available at https://www.digitizationguidelines.gov/guidelines/MXF_app_sampleFiles.html#2022 ) The support of RGBA descriptor is added, mainly by disabling in the CDCI descriptor related code the elements not in the

Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-01-14 Thread Nuo Mi
Hi Ronald, Thank you for the detailed comment. You read code really quickly. On Sat, Jan 14, 2023 at 10:28 PM Ronald S. Bultje wrote: > Hi, > > On Sat, Jan 14, 2023 at 8:32 AM Nuo Mi wrote: > > > On Sat, Jan 14, 2023 at 9:13 PM Nuo Mi wrote: > > > I am happy to send out the first draft of vvc

Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-01-14 Thread Ronald S. Bultje
Hi, On Sat, Jan 14, 2023 at 8:32 AM Nuo Mi wrote: > On Sat, Jan 14, 2023 at 9:13 PM Nuo Mi wrote: > > I am happy to send out the first draft of vvc decoder. > > It's not ready for upstream yet, but it's a good base ground for review > > and future improvement. > > > > It has the following

Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-01-14 Thread Nuo Mi
On Sat, Jan 14, 2023 at 9:53 PM Paul B Mahol wrote: > On 1/14/23, Nuo Mi wrote: > > On Sat, Jan 14, 2023 at 9:13 PM Nuo Mi wrote: > > > >> Hi Experts: > >> I am happy to send out the first draft of vvc decoder. > >> It's not ready for upstream yet, but it's a good base ground for review > >>

Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-01-14 Thread Paul B Mahol
On 1/14/23, Nuo Mi wrote: > On Sat, Jan 14, 2023 at 9:13 PM Nuo Mi wrote: > >> Hi Experts: >> I am happy to send out the first draft of vvc decoder. >> It's not ready for upstream yet, but it's a good base ground for review >> and future improvement. >> >> It has the following features: >> * C

Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-01-14 Thread Nuo Mi
On Sat, Jan 14, 2023 at 9:13 PM Nuo Mi wrote: > Hi Experts: > I am happy to send out the first draft of vvc decoder. > It's not ready for upstream yet, but it's a good base ground for review > and future improvement. > > It has the following features: > * C only > + Fast. On a 4 cores laptop, it