[FFmpeg-devel] [PATCH 2/2] cbs_av1: Don't reject unknown metadata

2023-01-17 Thread Mark Thompson
Accept it and pass it through unchanged. The standard requires that decoders ignore unknown metadata, and indeed this is tested by some of the Argon coverage streams. --- Artificial test example: [trace_headers @ 0x5596dda6ed80] OBU header [trace_headers @ 0x5596dda6ed80] 0

[FFmpeg-devel] [PATCH 1/2] cbs_av1: Add tracing headers for metadata types

2023-01-17 Thread Mark Thompson
Make it a little easier to interpret metadata in trace output. --- libavcodec/cbs_av1_syntax_template.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index d98d3d42de..46f4c5a6b8 100644 ---

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Jeffrey Chapuis
On 17/01/2023 19:11, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >> I'm getting there, don't give up on me. >> >> Now 'limit_upscaled' become the variable used in filter_frame() and >> 'limit' is never change, unless by user >> We only have to update 'limit_upscaled' if 'limit'

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-17 Thread James Zern
On Tue, Jan 10, 2023 at 5:23 PM James Zern wrote: > > On Tue, Jan 10, 2023 at 2:47 AM myp...@gmail.com wrote: > > > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > > wrote: > > [...] > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > > index 9aa5510c28..0627e13973

[FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log

2023-01-17 Thread Prakash
libavutil/log: Support for logging timestamps in the log. Add 'time' flag to the -loglevel option to turn on timestamp logging. Useful for troubleshooting where time is spent from the log files. Signed-off-by: Prakash Duggaraju --- doc/fftools-common-opts.texi | 4 fftools/opt_common.c

[FFmpeg-devel] [PATCH v3] avformat: Add support for embedding cover art in Ogg files

2023-01-17 Thread Zsolt Vadász
Signed-off-by: Zsolt Vadasz --- libavformat/flac_picture.c | 132 +++ libavformat/flac_picture.h | 5 + libavformat/flacenc.c | 90 +--- libavformat/oggenc.c | 207 ++--- 4 files changed, 308 insertions(+), 126

[FFmpeg-devel] [PATCH] avcodec: Use preprocessors conditions

2023-01-17 Thread pawday-at-mail . ru
From: Pawday Thank you for showing me logic substitution issues. So, if you curious i am trying to substitute calling thread depending functions for unuptimized compiler where dead code illumination is not working and it couse linking error on my microcontroller toolchain without any thread

[FFmpeg-devel] [PATCH v2 3/3] avcodec/png: support cICP chunks

2023-01-17 Thread Leo Izen
This commit adds both decode and encode support for cICP chunks, which allow a PNG image's pixel data to be tagged by any of the enum values in H.273, without an ICC profile. Upon decode, if a cICP chunk is present, the PNG decoder will tag output AVFrames with the resulting enum color, and

[FFmpeg-devel] [PATCH v2 2/3] avcodec/pngdec: support decoding sRGB chunks

2023-01-17 Thread Leo Izen
If an sRGB chunk is present in the PNG file, this commit will cause the png decoder to ignore the cHRM and gAMA chunks and tag the resulting AVFrames with BT.709 primaries, and ISO/IEC 61966-2-1 transfer. If these tags are present in the AVFrame, pngenc.c already writes this chunk, so no change

[FFmpeg-devel] [PATCH v2 1/3] avcodec/png: use libavutil/csp.h for cHRM chunks

2023-01-17 Thread Leo Izen
The cHRM chunk is descriptive. That is, it describes the primaries that should be used to interpret the pixel data in the PNG file. This is notably different from Mastering Display Metadata, which describes which subset of the presented gamut is relevant. MDM describes a gamut and says colors

[FFmpeg-devel] [PATCH v2 0/3] Proper color support in PNG

2023-01-17 Thread Leo Izen
This series of patches fixes our incorrect cHRM handling in PNGs and properly supports sRGB and cICP chunks in PNGs as well. Leo Izen (3): avcodec/png: use libavutil/csp.h for cHRM chunks avcodec/pngdec: support decoding sRGB chunks avcodec/png: support cICP chunks libavcodec/pngdec.c

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Paul B Mahol
On 1/17/23, Jeffrey Chapuis wrote: > I'm getting there, don't give up on me. > > Now 'limit_upscaled' become the variable used in filter_frame() and > 'limit' is never change, unless by user > We only have to update 'limit_upscaled' if 'limit' really changes. probably ok

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Jeffrey Chapuis
I'm getting there, don't give up on me. Now 'limit_upscaled' become the variable used in filter_frame() and 'limit' is never change, unless by user We only have to update 'limit_upscaled' if 'limit' really changes.From 866ddedf0225582d1c82514463d0730d687d514c Mon Sep 17 00:00:00 2001 From: Ashyni

[FFmpeg-devel] [RFC PATCH 3/3] lavfi: add a new filtergraph parsing API

2023-01-17 Thread Anton Khirnov
Callers currently have two ways of adding filters to a graph - they can either - create, initialize, and link them manually - use one of the avfilter_graph_parse*() functions, which take a (typically end-user-written) string, split it into individual filter definitions+options, then create

[FFmpeg-devel] [RFC PATCH 1/3] lavfi/avfilter: export process_options()

2023-01-17 Thread Anton Khirnov
Also, replace an AVFilterContext argument with a logging context+private class, as those are the only things needed in this function. Will be useful in future commits. --- libavfilter/avfilter.c | 20 ++-- libavfilter/internal.h | 13 + 2 files changed, 23

[FFmpeg-devel] [RFC PATCH 2/3] lavfi/avfilter: track whether a filter has been initialized

2023-01-17 Thread Anton Khirnov
Refuse to link uninitialized filters or initialize a filter twice. --- libavfilter/avfilter.c | 12 libavfilter/internal.h | 4 2 files changed, 16 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 86b275dc4f..619b96f5ac 100644 ---

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Paul B Mahol
On 1/17/23, Jeffrey Chapuis wrote: > On 17/01/2023 15:29, Paul B Mahol wrote: >> On 1/17/23, Jeffrey Chapuis wrote: >>> On 17/01/2023 14:45, Paul B Mahol wrote: On 1/17/23, Jeffrey Chapuis wrote: > On 17/01/2023 13:34, Paul B Mahol wrote: >> On 1/17/23, Jeffrey Chapuis wrote:

Re: [FFmpeg-devel] [PATCH] avcodec: Use preprocessors conditions

2023-01-17 Thread Hendrik Leppkes
On Tue, Jan 17, 2023 at 3:36 PM wrote: > > From: Pawday > > Thank you Andreas Rheinhardt for review > > Here the fixes for runtime "else" conditions > > --- > libavcodec/avcodec.c | 16 +++- > libavcodec/decode.c | 11 --- > libavcodec/encode.c | 13 - >

Re: [FFmpeg-devel] GSoC 2023

2023-01-17 Thread Nuo Mi
On Mon, Jan 16, 2023 at 10:58 PM Jean-Baptiste Kempf wrote: > On Mon, 16 Jan 2023, at 14:53, Nuo Mi wrote: > > Seems too hurried for this time. Maybe next time > > I disagree: we can do (and should do) a small task for VVC dec in GSoC > 2023, like a fringe feature, not from the mainline. > Hi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Jeffrey Chapuis
On 17/01/2023 15:29, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >> On 17/01/2023 14:45, Paul B Mahol wrote: >>> On 1/17/23, Jeffrey Chapuis wrote: On 17/01/2023 13:34, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >> On 17/01/2023 12:52, Paul B Mahol wrote:

[FFmpeg-devel] [PATCH] avcodec: Use preprocessors conditions

2023-01-17 Thread pawday-at-mail . ru
From: Pawday Thank you Andreas Rheinhardt for review Here the fixes for runtime "else" conditions --- libavcodec/avcodec.c | 16 +++- libavcodec/decode.c | 11 --- libavcodec/encode.c | 13 - libavcodec/h264dec.c | 14 +++--- 4 files changed, 34

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Paul B Mahol
On 1/17/23, Jeffrey Chapuis wrote: > On 17/01/2023 14:45, Paul B Mahol wrote: >> On 1/17/23, Jeffrey Chapuis wrote: >>> On 17/01/2023 13:34, Paul B Mahol wrote: On 1/17/23, Jeffrey Chapuis wrote: > On 17/01/2023 12:52, Paul B Mahol wrote: >> On 1/17/23, Jeffrey Chapuis wrote:

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Jeffrey Chapuis
On 17/01/2023 14:45, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >> On 17/01/2023 13:34, Paul B Mahol wrote: >>> On 1/17/23, Jeffrey Chapuis wrote: On 17/01/2023 12:52, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >>> Le 10/01/2023 à 16:45, Paul B Mahol a

Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter

2023-01-17 Thread Helmrich, Christian
> just attach patch with proper authorship, made with git format-patch. Small update, replacing our own MAX( ) define with FFmpeg's existing FFMAX( ) and adding a v2 to the patch so that, hopefully, the fate pipeline is triggered now. Best, Christian Helmrich Fraunhofer HHI, Video Coding

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Paul B Mahol
On 1/17/23, Jeffrey Chapuis wrote: > On 17/01/2023 13:34, Paul B Mahol wrote: >> On 1/17/23, Jeffrey Chapuis wrote: >>> On 17/01/2023 12:52, Paul B Mahol wrote: On 1/17/23, Jeffrey Chapuis wrote: >> Le 10/01/2023 à 16:45, Paul B Mahol a écrit : >>> On 1/10/23, Jeffrey CHAPUIS

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Jeffrey Chapuis
On 17/01/2023 13:34, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >> On 17/01/2023 12:52, Paul B Mahol wrote: >>> On 1/17/23, Jeffrey Chapuis wrote: > Le 10/01/2023 à 16:45, Paul B Mahol a écrit : >> On 1/10/23, Jeffrey CHAPUIS wrote: >>> Hello, >>> I decided to

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Paul B Mahol
On 1/17/23, Jeffrey Chapuis wrote: > On 17/01/2023 12:52, Paul B Mahol wrote: >> On 1/17/23, Jeffrey Chapuis wrote: Le 10/01/2023 à 16:45, Paul B Mahol a écrit : > On 1/10/23, Jeffrey CHAPUIS wrote: >> Hello, >> I decided to continue on a simpler path without

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Jeffrey Chapuis
On 17/01/2023 12:52, Paul B Mahol wrote: > On 1/17/23, Jeffrey Chapuis wrote: >>> Le 10/01/2023 à 16:45, Paul B Mahol a écrit : On 1/10/23, Jeffrey CHAPUIS wrote: > Hello, > I decided to continue on a simpler path without 'reset/reset_count', it > was > only to experiment

Re: [FFmpeg-devel] [PATCH] avcodec: Use preprocessors conditions

2023-01-17 Thread Andreas Rheinhardt
pawday-at-mail...@ffmpeg.org: > From: Pawday > > --- > libavcodec/avcodec.c | 13 + > libavcodec/decode.c | 5 +++-- > libavcodec/encode.c | 8 > 3 files changed, 16 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c > index

Re: [FFmpeg-devel] [PATCH] avcodec/scpr3: Check bx

2023-01-17 Thread Michael Niedermayer
On Mon, Jan 16, 2023 at 11:14:33AM +0100, Michael Niedermayer wrote: > Fixes: Out of array access > Fixes: > 55102/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-4877396618903552 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Paul B Mahol
On 1/17/23, Jeffrey Chapuis wrote: >>Le 10/01/2023 à 16:45, Paul B Mahol a écrit : >>> On 1/10/23, Jeffrey CHAPUIS wrote: Hello, I decided to continue on a simpler path without 'reset/reset_count', it was only to experiment anyway, 'limit' is the main goal. 'limit' is

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-17 Thread Jeffrey Chapuis
>Le 10/01/2023 à 16:45, Paul B Mahol a écrit : >> On 1/10/23, Jeffrey CHAPUIS wrote: >>> Hello, >>> I decided to continue on a simpler path without 'reset/reset_count', it was >>> only to experiment anyway, 'limit' is the main goal. >>> 'limit' is added to the metadata to control that the result

[FFmpeg-devel] [PATCH] avcodec: Use preprocessors conditions

2023-01-17 Thread pawday-at-mail . ru
From: Pawday --- libavcodec/avcodec.c | 13 + libavcodec/decode.c | 5 +++-- libavcodec/encode.c | 8 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index a85d3c2309..1e24bdf333 100644 ---

Re: [FFmpeg-devel] [PATCH] configure: check for sysctl.h explicitly

2023-01-17 Thread Andreas Rheinhardt
Aman Karmani: > From: Aman Karmani > > HAVE_SYSCTL is used to guard #include , so make sure > we only define it when that header is present. > > In recent glibc, the header was removed: > https://sourceware.org/pipermail/glibc-cvs/2020q2/069366.html > > Signed-off-by: Aman Karmani > --- >

[FFmpeg-devel] [PATCH v3] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-17 Thread David Rosca
v3: pic_order_cnt steps by 2 --- libavcodec/vaapi_encode_h264.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index f15bcc6..de0951f 100644 --- a/libavcodec/vaapi_encode_h264.c +++

[FFmpeg-devel] [PATCH] mov: Reduce the verbosity of the warning about fragmented MP4 vs advanced edit lists

2023-01-17 Thread Martin Storsjö
Only warn if the advanced_editlist option is enabled (it is enabled by default though) so we don't print one warning for each track, and demote the warning to AV_LOG_LEVEL_VERBOSE; this message does get generated whenever parsing a fragmented MP4 file, regardless of whether the file actually uses

Re: [FFmpeg-devel] [PATCH v4] avformat/dvd: new dvd:// protocol for reading dvd folder/images

2023-01-17 Thread Nicolas George
Stanislav Ionascu (12023-01-15): > dvd:// protocol uses libdvdread for opening folders and/or disc-images, > it then either identifies the longest title-set, or uses the title-set > parameter. > > After opening the dvd, libdvdread-protocol will read and output all > VOBs, in the cell and pack