[FFmpeg-devel] [PATCH major bump 2/6] libavcodec/dynamic_hdr_vivid: fix start code check

2023-02-01 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/dynamic_hdr_vivid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/dynamic_hdr_vivid.c b/libavcodec/dynamic_hdr_vivid.c index f7a41ed2d5..4bc1cd3c70 100644 --- a/libavcodec/dynamic_hdr_vivid.c +++

[FFmpeg-devel] [PATCH major bump 1/6] libavutil/hdr_dynamic_vivid_metadata: fix AVHDRVividColorToneMappingParams

2023-02-01 Thread Zhao Zhili
From: Zhao Zhili There are two group of three_Spline params. Fix the struct definition and usecases inside libavcodec, libavfilter and ffprobe. Co-Author: Houxiang ZHU Signed-off-by: Zhao Zhili --- fftools/ffprobe.c | 14 -- libavcodec/dynamic_hdr_vivid.c

[FFmpeg-devel] [PATCH major bump 0/6] Fix HDR vivid support

2023-02-01 Thread Zhao Zhili
From: Zhao Zhili Only patch 1/6 needs to go with major version bump. Zhao Zhili (6): libavutil/hdr_dynamic_vivid_metadata: fix AVHDRVividColorToneMappingParams libavcodec/dynamic_hdr_vivid: fix start code check avcodec/dynamic_hdr_vivid: fix base_param_Delta

[FFmpeg-devel] [PATCH major bump 4/6] avcodec/dynamic_hdr_vivid: fix base_enable_flag control

2023-02-01 Thread Zhao Zhili
From: Zhao Zhili The base_enable_flag is parallel to three_Spline_enable_flag. The typesetting of the specification is very misleading. Signed-off-by: Zhao Zhili --- libavcodec/dynamic_hdr_vivid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH major bump 6/6] fftools/ffprobe: fix print_dynamic_hdr_vivid

2023-02-01 Thread Zhao Zhili
From: Zhao Zhili Don't print tone_mapping_param_num if tone_mapping_mode_flag is disabled. Signed-off-by: Zhao Zhili --- fftools/ffprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index a853c70f56..65e1db5b68 100644 ---

[FFmpeg-devel] [PATCH major bump 5/6] avcodec/dynamic_hdr_vivid: reindent after the previous commit

2023-02-01 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/dynamic_hdr_vivid.c | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavcodec/dynamic_hdr_vivid.c b/libavcodec/dynamic_hdr_vivid.c index 4ebcc3f4c1..710f9dd9c6 100644 --- a/libavcodec/dynamic_hdr_vivid.c

[FFmpeg-devel] [PATCH major bump 3/6] avcodec/dynamic_hdr_vivid: fix base_param_Delta

2023-02-01 Thread Zhao Zhili
From: Zhao Zhili It conflicts the comments. The operation based on Delta_enable_mode can be applied by user during tone mapping. Signed-off-by: Zhao Zhili --- libavcodec/dynamic_hdr_vivid.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/dynamic_hdr_vivid.c

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/vpp_qsv: add rate option

2023-02-01 Thread Xiang, Haihao
On Ma, 2023-01-30 at 09:37 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > This is used to control the output at frame rate or field rate when > deinterlace is expected and framerate is not specified. > > Signed-off-by: Haihao Xiang > --- > libavfilter/vf_vpp_qsv.c | 17 +++--

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix propagating durations and opaques

2023-02-01 Thread Xiang, Haihao
On Wo, 2023-02-01 at 02:59 +, Xiang, Haihao wrote: > On Di, 2023-01-31 at 14:14 +0100, Anton Khirnov wrote: > > input_image is freed by the time the output packet is constructed, so we > > need to store copies in VAAPIEncodePicture. > > --- > > Is this better? > > --- > >

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-01 Thread Leo Izen
On 2/1/23 14:32, Andreas Rheinhardt wrote: Leo Izen: These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. +} else if (s->gamma) { +/* + * these values are 10/2.2, 10/2.8, and 10/2.6 + *

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-01 Thread Andreas Rheinhardt
Leo Izen: > These chunks are lightweight and it's useful information to have when > running ffmpeg -i or ffprobe, for example. > > Signed-off-by: Leo Izen > --- > libavcodec/pngdec.c | 126 +-- > tests/ref/fate/png-icc | 8 +-- >

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for BONK

2023-02-01 Thread Michael Niedermayer
On Tue, Jan 31, 2023 at 12:45:25AM +0100, Michael Niedermayer wrote: > The decoder is quite slow with max n taps > Fixes: Timeout > Fixes: > 54063/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BONK_fuzzer-5087362407596032 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH v2 2/2] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-01 Thread Leo Izen
These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 126 +-- tests/ref/fate/png-icc | 8 +-- tests/ref/fate/png-side-data | 2 +- 3

[FFmpeg-devel] [PATCH v2 1/2] avcodec/pngenc.c: avoid writing cICP when inappropriate

2023-02-01 Thread Leo Izen
We parse the fallback cHRM on decode and correctly determine that we have BT.709 primaries, but unknown TRC. This causes us to write cICP where we shouldn't. Primaries without transfer can be handled entirely by cHRM, so we should only write cICP if we actually know the transfer function.

[FFmpeg-devel] [PATCH v2 0/2] PNG cICP improvements

2023-02-01 Thread Leo Izen
The first patch fixes a FATE issue with cICP and iCCP. The second patch was discussed on IRC. I got a LGTM from Kasper, but sending to ML here and applying in a few days if there's no objections. A few things discussed: 1) There's no need to expose the gamma table as another function as it's

[FFmpeg-devel] [PATCH 2/2] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-02-01 Thread Leo Izen
These chunks are lightweight and it's useful information to have when running ffmpeg -i or ffprobe, for example. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 126 ++-- 1 file changed, 75 insertions(+), 51 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/2] avcodec/pngenc.c: avoid writing cICP when inappropriate

2023-02-01 Thread Leo Izen
We parse the fallback cHRM on decode and correctly determine that we have BT.709 primaries, but unknown TRC. This causes us to write cICP where we shouldn't. Primaries without transfer can be handled entirely by cHRM, so we should only write cICP if we actually know the transfer function.

[FFmpeg-devel] [PATCH 0/2] PNG cICP improvements

2023-02-01 Thread Leo Izen
The first patch fixes a FATE issue. The second patch was discussed on IRC. I got a LGTM from Kasper, but sending to ML here and applying in a few days if there's no objections. A few things discussed: 1) There's no need to expose the gamma table as another function as it's only used here. 2)

Re: [FFmpeg-devel] [PATCH v5 04/10] avcodec: add MP4 to annexb support for H266/VVC

2023-02-01 Thread 赵志立
> On Jan 3, 2023, at 21:40, Thomas Siedel wrote: > > Add parser for VVC MP4 to Annex B byte stream format. > > Co-authored-by: Nuo Mi > --- > configure| 1 + > libavcodec/Makefile | 2 + > libavcodec/bitstream_filters.c | 2 + >

Re: [FFmpeg-devel] [PATCH] configure: add --disable-he-aac option

2023-02-01 Thread Jean-Baptiste Kempf
On Wed, 1 Feb 2023, at 15:56, Hendrik Leppkes wrote: > On Wed, Feb 1, 2023 at 3:33 PM Kristofer Björkström > wrote: >> >> Make it possible to disable HE and HEv2 support for AAC. To avoid >> patents in HE-AAC. >> > > I don't feel like this adds a good precedence to our codebase. We > generally

Re: [FFmpeg-devel] [PATCH] avcodec: add ACC_NON_HE decoder

2023-02-01 Thread Jean-Baptiste Kempf
On Wed, 1 Feb 2023, at 15:55, Kristofer Björkström wrote: >>What is the aim of this? Is it patents? > > To avoid patents in AAC HE Patents? Which patents? Which country does this apply? The whole FFmpeg is concerned probably with thousands of patents... I don't see here the gain. PS: There are

Re: [FFmpeg-devel] [PATCH] configure: add --disable-he-aac option

2023-02-01 Thread Hendrik Leppkes
On Wed, Feb 1, 2023 at 3:33 PM Kristofer Björkström wrote: > > From 6828ea418f0209dface9fbb23ff4657f66988f5e Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Kristofer=20Bj=C3=B6rkstr=C3=B6m?= > Date: Wed, 1 Feb 2023 15:15:14 +0100 > Subject: [PATCH] configure: add --disable-he-aac option >

Re: [FFmpeg-devel] [PATCH] avcodec: add ACC_NON_HE decoder

2023-02-01 Thread Kristofer Björkström
>Kristofer Björkström: >> As ACC decoder but with HE and HEv2 disabled. >> >> Signed-off-by: Kristofer Björkström > >> --- >> Changelog| 1 + >> configure| 1 + >> libavcodec/Makefile | 3 +++ >> libavcodec/aacdec.c | 21

[FFmpeg-devel] [PATCH] configure: add --disable-he-aac option

2023-02-01 Thread Kristofer Björkström
>From 6828ea418f0209dface9fbb23ff4657f66988f5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristofer=20Bj=C3=B6rkstr=C3=B6m?= Date: Wed, 1 Feb 2023 15:15:14 +0100 Subject: [PATCH] configure: add --disable-he-aac option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8

Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-02-01 Thread Nuo Mi
On Sat, Jan 14, 2023 at 11:52 PM Ronald S. Bultje wrote: > Hi, > > On Sat, Jan 14, 2023 at 10:16 AM Nuo Mi wrote: > > > On Sat, Jan 14, 2023 at 10:28 PM Ronald S. Bultje > > > How come vvcdsp has only 8/10 bits/component code but vvcpred has > > 8/9/10/12 > > > bits/component code? > > > > I

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Andreas Rheinhardt
Paul B Mahol: > +if (AV_RL32(par->extradata + 28) != MKTAG('f','m','t',' ')) > +return AVERROR_INVALIDDATA; > + > +av_channel_layout_uninit(>ch_layout); You do not need this; the channel layout of a freshly allocated stream is always blank. > +

Re: [FFmpeg-devel] [PATCH] lavfi: get rid of FF_INTERNAL_FIELDS

2023-02-01 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12023-02-01): >> PS: Upon rethinking, it is not only b) that contains undefined >> behaviour; it is b)-d) as well as the current code. The reason is that >> the type of AVFilterLink as seen in the files with FF_INTERNAL_FIELDS is >> not compatible with the

Re: [FFmpeg-devel] [PATCH] sws/utils.c: Do not uselessly call initFilter() when unscaling

2023-02-01 Thread Michael Niedermayer
On Tue, Jan 31, 2023 at 04:54:46PM +0100, Tomas Härdin wrote: > Passes FATE > > /Tomas > utils.c | 62 +++--- > 1 file changed, 31 insertions(+), 31 deletions(-) > 4d695be7739560358464400f1c7839b3646ff717 >

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Paul B Mahol
On 2/1/23, Tomas Härdin wrote: >> +if (avctx->extradata_size < 44) >> +return AVERROR_INVALIDDATA; >> +if (AV_RL32(avctx->extradata + 16) != MKTAG('R','I','F','F')) >> +return AVERROR_INVALIDDATA; >> +if (AV_RL32(avctx->extradata + 24) != MKTAG('W','A','V','E')) >> +

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Nicolas George
Tomas Härdin (12023-02-01): > This belongs in the demuxer. In fact it appears the decoder duplicates > code from the demuxer. Why? Because sharing code between demuxer and decoder is extremely annoying, because somebody decided the libraries must be separate even though all the technical reasons

Re: [FFmpeg-devel] [PATCH] Waveform Archiver decoder and demuxer

2023-02-01 Thread Tomas Härdin
> +if (avctx->extradata_size < 44) > +return AVERROR_INVALIDDATA; > +if (AV_RL32(avctx->extradata + 16) != MKTAG('R','I','F','F')) > +return AVERROR_INVALIDDATA; > +if (AV_RL32(avctx->extradata + 24) != MKTAG('W','A','V','E')) > +return AVERROR_INVALIDDATA; > +