[FFmpeg-devel] [PATCH] lavc/mediacodec: rescale pts before decoding for both hw and sw buffers

From: Aman Gupta <a...@tmm1.net> Replicates the logic used in the wrap_hw_buffer path to wrap_sw_buffer as well. This fixes decoding issues observed on AMLogic devices with OMX.amlogic.mpeg2.decoder.awesome, where the decoder would spit out a constant stream of "mPtsRecoveryCo

Re: [FFmpeg-devel] [PATCH] lavc: add mpeg2 decoder/hwaccel to mediacodec

On Fri, Jun 2, 2017 at 6:16 AM, Matthieu Bouron <matthieu.bou...@gmail.com> wrote: > Hi, > > On Fri, Jun 02, 2017 at 04:23:41AM -0400, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> > > > > Android TV and FireOS hardware supports m

Re: [FFmpeg-devel] [PATCH v3] lavc: add mpeg2 decoder/hwaccel to mediacodec

On Mon, Jun 5, 2017 at 1:22 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > Android TV and FireOS hardware supports mpeg2 hardware decoding via > MediaCodec. > I tested this patch on an NVIDIA SHIELD, FireTV gen1 and FireTV Sti

[FFmpeg-devel] [PATCH v3] lavc: add mpeg2 decoder/hwaccel to mediacodec

From: Aman Gupta <a...@tmm1.net> Android TV and FireOS hardware supports mpeg2 hardware decoding via MediaCodec. --- configure | 2 ++ libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 2 ++ libavcodec/mediacodecdec.c

Re: [FFmpeg-devel] [PATCH v2] lavc: add mpeg2 decoder/hwaccel to mediacodec

On Mon, Jun 5, 2017 at 1:29 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > Android TV and FireOS hardware supports mpeg2 hardware decoding via > MediaCodec. > --- > configure | 2 ++ > libavcodec/Makefile

[FFmpeg-devel] [PATCH v2] lavc: add mpeg2 decoder/hwaccel to mediacodec

From: Aman Gupta <a...@tmm1.net> Android TV and FireOS hardware supports mpeg2 hardware decoding via MediaCodec. --- configure | 2 ++ libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 2 ++ libavcodec/mediacodecdec.c

[FFmpeg-devel] [PATCH] lavc: add mpeg2 decoder/hwaccel to mediacodec

From: Aman Gupta <a...@tmm1.net> Android TV and FireOS hardware supports mpeg2 hardware decoding via MediaCodec. --- configure | 2 ++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 ++ libavcodec/mediacodecdec.c | 23 ++- 4 files c

[FFmpeg-devel] [PATCH] configure: jni no longer requires -ldl

From: Aman Gupta <a...@tmm1.net> this dependency was removed in 33d69a90085d30af8a292d9364b835a26565d6b9 --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index 5ae5227868..ba33241a45 100755 --- a/configure +++ b/configure @@ -

[FFmpeg-devel] [PATCH] avformat/utils: fix estimate_timings_from_pts duration calculation for mpegts files which contain a PMT update

From: Aman Gupta <a...@tmm1.net> For example: https://s3.amazonaws.com/tmm1/pmt-version-change.ts Before: Duration: 00:00:10.01, start: 1236.288878, bitrate: 16752 kb/s After: Duration: 00:00:19.59, start: 1236.288878, bitrate: 8563 kb/s --- libavformat/utils.

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

On Wed, Mar 15, 2017 at 2:06 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Wed, Mar 15, 2017 at 12:53:03PM -0700, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> > > > > includes a fate test, which requires > > https://s3

[FFmpeg-devel] [PATCH v2 2/2] avcodec/mpeg12dec: ensure a53_caption_size is reset on malloc failures

From: Aman Gupta <a...@tmm1.net> --- libavcodec/mpeg12dec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index cea8963..f71f207 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -

[FFmpeg-devel] [PATCH v2 1/2] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

From: Aman Gupta <a...@tmm1.net> includes a fate test, which requires https://s3.amazonaws.com/tmm1/ccaptions/scte20.ts to be uploaded as sub/scte20.ts --- libavcodec/mpeg12dec.c | 39 +++ tests/fate/subtitles.mak | 3 +++ tests/ref/fate/

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: parse A53 caption data embedded in SCTE-20 user data

On Sat, Mar 11, 2017 at 7:05 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Mon, Mar 06, 2017 at 10:23:14AM -0800, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> > > > > --- > > libavcodec/mpeg12dec.c | 38 +++

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264, videotoolbox: pass SPS changes into the VT decoder

5:56 +0100 > > > Michael Niedermayer <mich...@niedermayer.cc> wrote: > > > > > >> On Fri, Feb 17, 2017 at 07:02:10AM +0100, wm4 wrote: > > >> > On Thu, 16 Feb 2017 10:29:36 -0800 > > >> > Aman Gupta <ffm...@tmm1.net> wrote: >

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

On Thu, Mar 2, 2017 at 1:34 AM, wm4 <nfx...@googlemail.com> wrote: > On Tue, 21 Feb 2017 13:40:08 -0800 > Aman Gupta <ffm...@tmm1.net> wrote: > > > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje <rsbul...@gmail.com> > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Tue, Feb 21, 2017 at 1:48 PM, Aman Gupta <ffm...@tmm1.net> wrote: > >> diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c >> index 41c0964392..a0ae632fed 100644 &g

[FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

From: Aman Gupta <a...@tmm1.net> The way videotoolbox hooks in as a hwaccel is pretty hacky. The VT decode API is not invoked until end_frame(), so alloc_frame() returns a dummy frame with a 1-byte buffer. When end_frame() is eventually called, the dummy buffer is replaced with the actual d

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: fix use-after-free of AVFrame buffer when VT decoder fails

On Mon, Feb 13, 2017 at 6:04 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > The videotoolbox hwaccel returns a dummy frame with a 1-byte buffer from > alloc_frame(). In end_frame(), this buffer is replaced with the ac

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls_flags temp_file bug

On Tue, Feb 21, 2017 at 7:13 AM, Steven Liu wrote: > refer to ticket id: #6170 > > rename file from temp to origin name after complete current segment > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 40

[FFmpeg-devel] [PATCH 3/3] avcodec/videotoolbox: restart decompression session on bad data errors

From: Aman Gupta <a...@tmm1.net> On some platforms (observed on macOS Sierra with 12" macbook), the VT decoder will start returning errors when encountering an SPS change in the h264 bitstream. With this patch, the kVTVideoDecoderBadDataErr response from the decode

[FFmpeg-devel] [PATCH 2/3] avcodec/videotoolbox: cosmetic change to simplify code with early return

From: Aman Gupta <a...@tmm1.net> --- libavcodec/videotoolbox.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 1288aa5..9be7bee 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoo

Re: [FFmpeg-devel] aac_latm: SSR is not implemented

On Wed, Feb 1, 2017 at 9:12 AM Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2017-02-01 5:06 GMT+01:00 Aman Gupta <ffm...@tmm1.net>: > > I have a mpegts file with a HE-AAC audio track that cannot be decoded by > > ffmpeg. I have uploaded a sample at t

[FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: handle streams with multiple/changing PPS

From: Aman Gupta <a...@tmm1.net> The videotoolbox hwaccel only receives SLICE and IDR_SLICE NALUs. This works fine most of the time, but some streams fail to decode because changes in PPS are not propagated to the VT decoder. The failures in this case are incredibly annoying, as VTDecod

[FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: fix use-after-free of AVFrame buffer when VT decoder fails

From: Aman Gupta <a...@tmm1.net> The videotoolbox hwaccel returns a dummy frame with a 1-byte buffer from alloc_frame(). In end_frame(), this buffer is replaced with the actual decoded data from VTDecompressionSessionDecodeFrame(). This is hacky, but works well enough, as long as the VT d

[FFmpeg-devel] h264 bitstream corruption in videotoolbox encoder with a53cc=1

Last October, kernrj and I commited a series of patches to add a53cc support to the videotoolbox encoder. In using that feature over the past few months, I've discovered that the generated streams can sometimes contain random/intermittent errors. This only appears to occur on some Macs and not

Re: [FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

On Fri, Feb 3, 2017 at 3:04 PM, Michael Niedermayer <michae...@gmx.at> wrote: > On Wed, Feb 01, 2017 at 04:30:18PM -0800, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> > > > > Implements support for height/width expressions in vf_scale_vaapi, > >

[FFmpeg-devel] [PATCH] avfilter/scale: use int64_t for height/width calculation to address overflow

From: Aman Gupta <a...@tmm1.net> --- libavfilter/scale.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/scale.c b/libavfilter/scale.c index 50cd442..9725f1f 100644 --- a/libavfilter/scale.c +++ b/libavfilter/scale.c @@ -68,7 +68,7

[FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

From: Aman Gupta <a...@tmm1.net> Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete. This patch is similar in spirit to one used in Plex's ffmpeg fork, and allows a transcoding webserver to ensure inco

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

On Fri, Feb 3, 2017 at 12:19 PM, Mark Thompson <s...@jkqxz.net> wrote: > On 03/02/17 05:45, wm4 wrote: > > On Thu, 2 Feb 2017 09:29:13 -0800 > > Aman Gupta <ffm...@tmm1.net> wrote: > > > >> From: Aman Gupta <a...@tmm1.net> > >> > &

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_flag option to create segments atomically

On Wed, Feb 1, 2017 at 6:03 AM, Bodecs Bela <bode...@vivanet.hu> wrote: > > > 2017.01.31. 21:29 keltezéssel, Aman Gupta írta: > >> From: Aman Gupta <a...@tmm1.net> >> >> Adds a `-hls_flags +temp_file` which will write segment data to >> filename.t

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

From: Aman Gupta <a...@tmm1.net> Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00aff8a4 in vaTerminate () #1 0x00ae50ce in vaapi_device_free (ctx=) at libavutil/hwcontext_vaapi.c:882 #2 0x00ae1f9e in hwdevice_ctx_free (opaque=,

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

On Thu, Feb 2, 2017 at 9:29 AM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > Program terminated with signal SIGSEGV, Segmentation fault. > opts=opts@entry=0x0, flags=flags@entry=0) at libavutil/hwcontext.c:494 > Looks like my editor

[FFmpeg-devel] [PATCH] avutil/hwcontext_vaapi: fix SEGV in vaTerminate when vaInitialize fails

From: Aman Gupta <a...@tmm1.net> Program terminated with signal SIGSEGV, Segmentation fault. opts=opts@entry=0x0, flags=flags@entry=0) at libavutil/hwcontext.c:494 --- libavutil/hwcontext_vaapi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH v3] avfilter/scale: refactor common code for scaling height/width expressions

From: Aman Gupta <a...@tmm1.net> Implements support for height/width expressions in vf_scale_vaapi, by refactoring common code into a new libavfilter/scale.c --- libavfilter/Makefile | 8 +-- libavfilter/scale.c | 152 +++ libav

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

From: Aman Gupta <a...@tmm1.net> Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete. This patch is similar in spirit to one used in Plex's ffmpeg fork, and allows a transcoding webserver to ensure inco

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_flag option to create segments atomically

On Tue, Jan 31, 2017 at 12:29 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > Adds a `-hls_flags +temp_file` which will write segment data to > filename.tmp, and then rename to filename when the segment is complete > and before the file is

[FFmpeg-devel] [PATCH v2] avfilter/scale: refactor common code for scaling height/width expressions

From: Aman Gupta <a...@tmm1.net> Implements support for height/width expressions in vf_scale_vaapi, by refactoring common code into a new libavfilter/scale.c --- libavfilter/Makefile | 8 +-- libavfilter/scale.c | 152 +++ libav

[FFmpeg-devel] aac_latm: SSR is not implemented

I have a mpegts file with a HE-AAC audio track that cannot be decoded by ffmpeg. I have uploaded a sample at the link below, as requested by the decoder. Happy to help with a patch to fix this issue, if someone can point me in the right direction. FWIW, VLC is able to decode the audio without

[FFmpeg-devel] [PATCH] avfilter/scale: refactor common code for scaling height/width expressions

From: Aman Gupta <a...@tmm1.net> Implements support for height/width expressions in vf_scale_vaapi, by refactoring common code into a new libavfilter/scale.c --- libavfilter/Makefile | 8 +-- libavfilter/scale.c | 143 +++ libav

Re: [FFmpeg-devel] [PATCH] avfilter/scale_vaapi: add support for basic height/width expressions

On Tue, Jan 31, 2017 at 12:26 PM, Mark Thompson <s...@jkqxz.net> wrote: > On 31/01/17 19:14, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> > > > > Copied directly from vf_scale.c. > > > > Implements the same expression logic, how

[FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_flag option to create segments atomically

From: Aman Gupta <a...@tmm1.net> Adds a `-hls_flags +temp_file` which will write segment data to filename.tmp, and then rename to filename when the segment is complete and before the file is added to the m3u8 playlist. This patch is similar in spirit to one used in Plex's ffmpeg fork, and

[FFmpeg-devel] [PATCH] avfilter/scale_vaapi: add support for basic height/width expressions

From: Aman Gupta <a...@tmm1.net> Copied directly from vf_scale.c. Implements the same expression logic, however not all the variables were copied over. This patch was sufficient for my particular use-case `scale_vaapi=-2:min(ih\,720)`, but perhaps it makes sense to add s

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

On Sun, Oct 23, 2016 at 11:20 PM, Aman Gupta <a...@tmm1.net> wrote: > > > On Sunday, October 23, 2016, Richard Kern <ker...@gmail.com> wrote: > >> >> > On Oct 19, 2016, at 8:45 PM, Aman Gupta <ffm...@tmm1.net> wro

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Monday, September 19, 2016, Richard Kern <ker...@gmail.com> wrote: > > On Sep 10, 2016, at 10:33 PM, Aman Gupta <ffm...@tmm1.net > <javascript:_e(%7B%7D,'cvml','ffm...@tmm1.net');>> wrote: > > > > On Sunday, September 11, 2016, Richard Kern <ker...@gma

[FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

From: Aman Gupta <a...@tmm1.net> ff_videotoolbox_avcc_extradata_create() was never being called if avctx->extradata_size==0, even though the function does not need or use the avctx->extradata. This manifested itself only on h264 streams in specific containers, and only on iOS. I gue

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Mon, Oct 17, 2016 at 6:03 PM, Aman Gupta <ffm...@tmm1.net> wrote: > > > On Mon, Oct 17, 2016 at 5:51 PM, Richard Kern <ker...@gmail.com> wrote: > >> >> On Oct 17, 2016, at 8:47 PM, Aman Gupta <ffm...@tmm1.net> wrote: >> >> >> >&g

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Mon, Oct 17, 2016 at 5:51 PM, Richard Kern <ker...@gmail.com> wrote: > > On Oct 17, 2016, at 8:47 PM, Aman Gupta <ffm...@tmm1.net> wrote: > > > > On Mon, Oct 17, 2016 at 6:35 AM, Richard Kern <ker...@gmail.com> wrote: > >> >> On Sep 19, 20

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Mon, Oct 17, 2016 at 6:35 AM, Richard Kern <ker...@gmail.com> wrote: > > On Sep 19, 2016, at 10:30 AM, Aman Gupta <ffm...@tmm1.net> wrote: > > > > On Monday, September 19, 2016, Richard Kern <ker...@gmail.com> wrote: > >> >> On Sep 10, 20

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Monday, September 19, 2016, Richard Kern <ker...@gmail.com> wrote: > > On Sep 10, 2016, at 10:33 PM, Aman Gupta <ffm...@tmm1.net > <javascript:_e(%7B%7D,'cvml','ffm...@tmm1.net');>> wrote: > > > > On Sunday, September 11, 2016, Richard Kern <ker...@gma

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Sunday, September 11, 2016, Richard Kern <ker...@gmail.com> wrote: > > > On Sep 8, 2016, at 4:19 AM, Aman Gupta <ffm...@tmm1.net <javascript:;>> > wrote: > > > > From: Aman Gupta <a...@tmm1.net <javascript:;>

[FFmpeg-devel] [PATCH] lavf/hlsenc: add -hls_start_time to emit EXT-X-START:TIME-OFFSET

From: Aman Gupta <a...@tmm1.net> --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 5 + 2 files changed, 8 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index ccf8ea1..e179c5a 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -533,6 +533,9 @@ Emit @code{

Re: [FFmpeg-devel] [PATCH] avformat/segment: fix the duration error of use output_ts_offset

8:00 Steven Liu <lingjiujia...@gmail.com>: >> >>> >>> >>> 2016-09-09 16:10 GMT+08:00 Steven Liu <lingjiujia...@gmail.com>: >>> >>>> >>>> >>>> 2016-09-09 15:33 GMT+08:00 Steven Liu <lingjiujia...@g

Re: [FFmpeg-devel] [PATCH 1/2] avformat/segment: give a warning message for remove initial_offset option

11, out10.ts #EXTINF:0.200211, out11.ts #EXTINF:0.200211, out12.ts The TARGETDURATION as well as the duration of the segments themselves is incorrect. Aman On Thu, Sep 8, 2016 at 6:48 PM, Aman Gupta <ffm...@tmm1.net> wrote: > I tried to switch from -initial_offset to -output_ts_offset, but i

Re: [FFmpeg-devel] [PATCH 1/2] avformat/segment: give a warning message for remove initial_offset option

I tried to switch from -initial_offset to -output_ts_offset, but it does not work as expected. In Safari, the generated HLS stream stalls out and stops playing after the first segment. Aman On Thu, Sep 8, 2016 at 5:54 PM, Michael Niedermayer wrote: > On Fri, Sep 09,

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Thu, Sep 8, 2016 at 9:18 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-09-08 15:48 GMT+02:00 Aman Gupta <themastermi...@gmail.com>: > > On Thursday, September 8, 2016, Carl Eugen Hoyos <ceffm...@gmail.com> > wrote: > > > >> 2016-09-0

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

On Thursday, September 8, 2016, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-09-08 10:19 GMT+02:00 Aman Gupta <ffm...@tmm1.net <javascript:;>>: > > > +{ "a53cc", "Use A53 Closed Captions (if available)", > OFFSET(a53_c

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: implement initial_offset

On Thu, Sep 8, 2016 at 2:55 AM, Steven Liu <lingjiujia...@gmail.com> wrote: > 2016-09-08 17:46 GMT+08:00 Michael Niedermayer <mich...@niedermayer.cc>: > > > On Thu, Sep 08, 2016 at 10:47:42AM +0900, Aman Gupta wrote: > > > From: Aman Gupta <a...@tmm1.net>

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

From: Aman Gupta <a...@tmm1.net> --- libavcodec/videotoolboxenc.c | 76 ++-- 1 file changed, 67 insertions(+), 9 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 4345ca3..859dde9 100644 --- a/liba

[FFmpeg-devel] [PATCH] avformat/hlsenc: implement initial_offset

From: Aman Gupta <a...@tmm1.net> --- doc/muxers.texi | 4 libavformat/hlsenc.c | 13 +++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index fd7ee50..e88dbf8 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@

Re: [FFmpeg-devel] HLS Segmenter and the "hls_time" option

On Fri, Aug 26, 2016 at 2:06 AM, Steven Liu wrote: > 2016-08-26 16:58 GMT+08:00 Ibrahim Tachijian : > > > Thanks this actually does what I expected it to do. > > For me this option will help a lot, and we would really be interested in > > this

[FFmpeg-devel] [PATCH] avcodec/utils: only warn when passed invalid lowres value

From: Aman Gupta <a...@tmm1.net> This makes it easier to use the lowres option when dealing with input files in different codecs. If the codec doesn't support lowres=1 for instance, it will throw a warning and use lowres=0 instead of erroring out completely. --- libavcodec/utils.c | 5 ++

Re: [FFmpeg-devel] Change bitrate on-the-fly

I would find your patch useful and am looking forward to reviewing it. Using a socket isn't a bad way to do it IMHO- it's portable and allows easy integration from any language. Another option would be to extend the existing ffmpeg interactive mode to handle your new command. Currently ffmpeg

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

This patch should fix the assertion failure you see: https://github.com/FFmpeg/FFmpeg/commit/1087f0dc172a9adf779e41bf2dc82639fb04ebd4 Aman On Sat, Jun 18, 2016 at 8:43 AM Amancio Hasty <aha...@gmail.com> wrote: > > > On Jun 16, 2016, at 11:16 AM, Aman Gupta <ffm.

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

The patchset that was merged into libav is now available in ffmpeg as well: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/omx.c You can compile ffmpeg from the master branch with --enable-omx --enable-omx-rpi Aman On Thu, Jun 16, 2016 at 2:16 AM, Amancio Hasty

[FFmpeg-devel] [PATCH 5/5] avcodec/ccaption_dec: default rollup to row 10

From: Aman Gupta <a...@tmm1.net> This ensures that captions are written towards the bottom of the screen when tuning into mid-stream. The row will be reset on the receipt of the next PAC command. Row 10 was chosen as it corresponds to the value of "0" in a PAC (see row_m

[FFmpeg-devel] [PATCH 3/5] avcodec/ccaption_dec: implement positioning for closed captions

From: Aman Gupta <a...@tmm1.net> Positioning math is based on the guidelines in https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 --- libavcodec/ccaption_dec.c | 29 ++--- 1 file changed, 26 insertions(+), 3 del

[FFmpeg-devel] [PATCH 1/5] avcodec/ccaption_dec: change write_char() to void as return value is unused

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 3b15149..a6d879e 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 4/5] fate: update sub-cc tests for closed caption positioning

From: Aman Gupta <a...@tmm1.net> --- tests/ref/fate/sub-cc | 4 +-- tests/ref/fate/sub-cc-realtime | 60 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc index 0d5bc77..4

[FFmpeg-devel] [PATCH 2/5] avcodec/ccaption_dec: implement tab offset commands

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index a6d879e..0b4a061 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -713,6 +713,11 @@

[FFmpeg-devel] [PATCH 3/3] avformat/mpegts: include stream types for mpeg2 and aac

From: Aman Gupta <a...@tmm1.net> this removes the need to probe to discover mpeg2 and aac streams inside mpegts containers, thus speeding up initial playback. --- libavformat/mpegts.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 6

[FFmpeg-devel] [PATCH 1/3] avformat/mpegts: enhance logging in trace mode

From: Aman Gupta <a...@tmm1.net> --- libavformat/mpegts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 4d1bc6d..6acb797 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -446,7 +446,7 @@

[FFmpeg-devel] [PATCH 2/3] avformat/utils: in debug mode, print number of streams found before avformat_find_stream_info()

From: Aman Gupta <a...@tmm1.net> --- libavformat/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 25c9a1b..494379a 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3297,8 +3297,8

[FFmpeg-devel] [PATCH] avcodec/utils: ensure conversion from ass to ass_with_timings works with unknown durations

From: Aman Gupta <a...@tmm1.net> the eia_608 decoder with real_time=1 emits subtitles with an unknown duration, which were getting converted into ass incorrectly before this patch. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/uti

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

aha...@gmail.com> wrote: > Curious, > > Do these patches work with ffmpeg running on RPi? > > Thanks, > Amancio > > > On Apr 19, 2016, at 12:00 PM, Aman Gupta <ffm...@tmm1.net> wrote: > > > > On Thu, Apr 7, 2016 at 3:03 AM, Mark Thompson <s...@jkqxz.n

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/ccaption_dec: do not ignore repeated character commands

sample it appears that every command is repeated not twice (as is common in many streams for special character sets and other command, see http://hackipedia.org/ATSC/EIA-608%20samples/EIA-608%20character%20set%20test/README.TXT), but three times. Aman On Mon, Apr 18, 2016 at 1:01 PM, Aman Gupta &l

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/ccaption_dec: do not ignore repeated character commands

Please send me the sample and I will try to fix the issue. Aman On Mon, Apr 18, 2016 at 1:22 PM Thierry Foucu <tfo...@gmail.com> wrote: > Hi all > > On Sun, Feb 14, 2016 at 6:11 PM, Aman Gupta <ffm...@tmm1.net> wrote: > >> From: Aman Gupta <a...@tmm1.net> &g

[FFmpeg-devel] [PATCH v3 1/2] lavc/ccaption_dec: do not ignore repeated character commands

From: Aman Gupta <a...@tmm1.net> control codes in a cc stream can be repeated, and must be ignored. however, repeated characters must not be ignored. the code attempted to wipe prev_cmd in handle_char to allow repeated characters to be processed, but prev_cmd would previously get reset _

[FFmpeg-devel] [PATCH v3 2/2] lavc/ccaption_dec: implement special and extended character sets

From: Aman Gupta <a...@tmm1.net> character sets implemented as defined in https://en.wikipedia.org/wiki/EIA-608#Characters --- libavcodec/ccaption_dec.c | 152 +- 1 file changed, 149 insertions(+), 3 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH v2 2/2] lavc/ccaption_dec: implement special and extended character sets

From: Aman Gupta <a...@tmm1.net> character sets implemented as defined in https://en.wikipedia.org/wiki/EIA-608#Characters --- libavcodec/ccaption_dec.c | 152 +- 1 file changed, 149 insertions(+), 3 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH v2 1/2] lavc/ccaption_dec: do not ignore repeated character commands

From: Aman Gupta <a...@tmm1.net> control codes in a cc stream can be repeated, and must be ignored. however, repeated characters must not be ignored. the code attempted to wipe prev_cmd in handle_char to allow repeated characters to be processed, but prev_cmd would previously get reset _

[FFmpeg-devel] [PATCH 1/2] lavc/ccaption_dec: do not ignore repeated character commands

From: Aman Gupta <a...@tmm1.net> control codes in a cc stream can be repeated, and must be ignored. however, repeated characters must not be ignored. the code attempted to wipe prev_cmd in handle_char to allow repeated characters to be processed, but prev_cmd would previously get reset _

[FFmpeg-devel] [PATCH 2/2] lavc/ccaption_dec: implement special and extended character sets

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 151 +- 1 file changed, 148 insertions(+), 3 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 5fb2ec6..c22f939 100644 --- a/libavcodec/ccaption

Re: [FFmpeg-devel] DVB Teletext to HLS Wbvtt Subtitles

ffmpeg has a webvtt encoder and decoder already. You can use this command to convert mpeg2 closed captions into webvtt: ffmpeg -f lavfi -i 'movie=input.mpg[out0+subcc]' -map s out.vtt Aman On Mon, Jan 18, 2016 at 7:25 AM, Sébastien Cramatte wrote: > Hi, > > We are

[FFmpeg-devel] [PATCH v2 8/9] lavc/ccaption_dec: implement positioning for closed captions

From: Aman Gupta <a...@tmm1.net> Positioning math is based on the guidelines in https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 --- libavcodec/ccaption_dec.c | 29 + 1 file changed, 25 insertions(+), 4 del

[FFmpeg-devel] [PATCH v2 5/9] lavc/ccaption_dec: implement tab offset commands

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 8c913fe..50625df 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -558,6 +558,11 @@

[FFmpeg-devel] [PATCH v2 3/9] fate: add test for realtime ccaption decoder

From: Aman Gupta <a...@tmm1.net> --- tests/fate/subtitles.mak | 3 +++ tests/ref/fate/sub-cc-realtime | 42 ++ 2 files changed, 45 insertions(+) create mode 100644 tests/ref/fate/sub-cc-realtime diff --git a/tests/fate/subtitles.mak b/test

[FFmpeg-devel] [PATCH v2 9/9] fate: update sub-cc tests for subtitle positioning

From: Aman Gupta <a...@tmm1.net> --- tests/ref/fate/sub-cc | 4 +-- tests/ref/fate/sub-cc-realtime | 60 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc index 0d5bc77..4

[FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index ca497e5..a9dfc94 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH v2 4/9] lavc/ccaption_dec: default rollup to row 10

From: Aman Gupta <a...@tmm1.net> This ensures that captions are written towards the bottom of the screen when tuning into mid-stream. The row will be reset on the receipt of the next PAC command. Row 10 was chosen as it corresponds to the value of "0" in a PAC (see row_m

[FFmpeg-devel] [PATCH v2 7/9] lavc/ccaption_dec: implement musical glyph

From: Aman Gupta <a...@tmm1.net> This is the most commonly used character from the special north-american character set. All the non-standard charsets are "optional" according to the spec, and we currently implement none of them. This commit adds support for "♪" w

[FFmpeg-devel] [PATCH v2 2/9] lavc/ccaption_dec: implement real_time option

From: Aman Gupta <a...@tmm1.net> This new mode is useful for realtime decoding of closed captions so they can be display along with mpeg2 frames. Closed caption streams contain two major types of captions: - POPON captions, which are buffered off-screen and displayed only after EO

[FFmpeg-devel] [PATCH v2 6/9] lavc/ccaption_dec: clear all unused rows during rollup

From: Aman Gupta <a...@tmm1.net> Sometimes rollup captions can move around the screen. This fixes "ghost" captions from below the current rollup area from continuing to be captured when a rollup moves higher up on the screen. --- libavcodec/ccaption_dec.c | 8 +--- 1

Re: [FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

On Tue, Jan 12, 2016 at 5:42 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...@tmm1.net> > > --- > libavcodec/ccaption_dec.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/libavcodec/ccaption_dec.c b/libavcod

[FFmpeg-devel] [PATCH 1/2] lavc/ccaption_dec: flush context on seek

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index fc6431b..8bef771 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 2/2] lavc/ccaption_dec: implement real_time option

From: Aman Gupta <a...@tmm1.net> This new mode is useful for realtime decoding of closed captions so they can be display along with mpeg2 frames. Closed caption streams contain two major types of captions: - POPON captions, which are buffered off-screen and displayed only after EO

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

On Fri, Jan 8, 2016 at 2:50 AM, Anshul Maheshwari <anshul.ffm...@gmail.com> wrote: > > > On Thu, Jan 7, 2016 at 6:14 AM, Aman Gupta <a...@tmm1.net> wrote: > >> Probably should have written a longer commit message here. The EOC >> command stands for "end of

Re: [FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

Thus, it makes sense to reap the screen *after* flipping the active screen, not *before*. The previous behavior was simply wrong, but masked by other bugs also fixed in this patchset. Aman On Tue, Jan 5, 2016 at 11:41 PM, Aman Gupta <ffm...@tmm1.net> wrote: > From: Aman Gupta <a...

Re: [FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

n 6, 2016 at 2:37 AM, wm4 <nfx...@googlemail.com> wrote: > On Tue, 5 Jan 2016 23:41:35 -0800 > Aman Gupta <ffm...@tmm1.net> wrote: > > > From: Aman Gupta <a...@tmm1.net> > > > > new option defaults to true, to preserve existing behavior. by flipp

[FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to screen_changed to screen_reaped

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 6dff761..706da16 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption

[FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: in realtime mode, emit new ASS events every 200ms

From: Aman Gupta <a...@tmm1.net> --- libavcodec/ccaption_dec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 706da16..737c3f6 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

<    1   2   3   4   5   6   >