From: Jacob Graff
Resolves issues with some transparent gifs.
see https://trac.ffmpeg.org/ticket/7890
contribution by Jacob Graff
---
libavcodec/gif.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/gif.c b/libavcodec/gif.c
index 94c8b1af49..d7768b44
This patch should be attributed to Jacob Graff .
On Thu, May 9, 2019 at 10:37 AM Bjorn Roche wrote:
> From: Bjorn Roche
>
> ---
> libavcodec/gif.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/gif.c b/libavcodec/gif
From: Bjorn Roche
---
libavcodec/gif.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/gif.c b/libavcodec/gif.c
index 94c8b1af49..d7768b4426 100644
--- a/libavcodec/gif.c
+++ b/libavcodec/gif.c
@@ -136,7 +136,7 @@ static void gif_crop_translucent
On Tue, Feb 27, 2018 at 11:55 AM, James Almer wrote:
> On 2/27/2018 1:28 PM, Bjorn Roche wrote:
> > On Tue, Feb 27, 2018 at 10:34 AM, wm4 wrote:
> >
> > According to Carl Eugen Hoyos: "This is Clément's code, he has to review
> > your patch."
>
On Tue, Feb 27, 2018 at 10:34 AM, Paul B Mahol wrote:
> On 2/27/18, Bjorn Roche wrote:
> > On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote:
> >
> >> On Mon, 26 Feb 2018 17:15:26 -0500
> >> Bjorn Roche wrote:
> >>
> >> > Okay, thanks Nicolas.
&g
On Tue, Feb 27, 2018 at 10:34 AM, wm4 wrote:
> On Tue, 27 Feb 2018 10:25:17 -0500
> Bjorn Roche wrote:
>
> > On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote:
> >
> > > On Mon, 26 Feb 2018 17:15:26 -0500
> > > Bjorn Roche wrote:
> > >
> &g
On Tue, Feb 27, 2018 at 5:47 AM, wm4 wrote:
> On Mon, 26 Feb 2018 17:15:26 -0500
> Bjorn Roche wrote:
>
> > Okay, thanks Nicolas.
> >
> > I already submitted a patch to the mailing list a few months ago, I was
> > just hoping for an easier way to keep it fre
Okay, thanks Nicolas.
I already submitted a patch to the mailing list a few months ago, I was
just hoping for an easier way to keep it fresh since it's gone stale, and I
had some more fixes for it.
bjorn
On Mon, Feb 26, 2018 at 4:49 PM, Nicolas George wrote:
> Bjorn Roche (20
t;
I have a patch I'd like to submit -- can I submit a PR on GitHub, or no?
Thanks,
bjorn
--
Bjorn Roche
Sr. Video Pipeline Engineer
bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hey all,
I'm just reviewing this and noticing that the patch is stale and no longer
compiles. I am happy to update, but is there someone to review it if I do
so? I'd love to get this patch in. Thanks,
bjorn
On Thu, Dec 7, 2017 at 5:56 PM, Bjorn Roche wrote:
> Hey all,
>
>
Hey all,
Just wondering what else is needed to get this merged? Is there anything
else I can do?
Thanks,
bjorn
On Thu, Nov 30, 2017 at 12:33 PM, Bjorn Roche wrote:
> We've done a bit more testing on this and it looks good here.
>
> On Thu, Nov 30, 2017 at 12:26 PM, Bjor
We've done a bit more testing on this and it looks good here.
On Thu, Nov 30, 2017 at 12:26 PM, Bjorn Roche wrote:
>
>
> On Mon, Nov 27, 2017 at 7:12 PM, Carl Eugen Hoyos
> wrote:
>
>> 2017-11-28 1:07 GMT+01:00 Bjorn Roche :
>> > On Mon, Nov 27, 2017 at 5:
On Mon, Nov 27, 2017 at 7:12 PM, Carl Eugen Hoyos
wrote:
> 2017-11-28 1:07 GMT+01:00 Bjorn Roche :
> > On Mon, Nov 27, 2017 at 5:41 PM, Carl Eugen Hoyos
> > wrote:
>
> >> >> Does remuxing animated gif with transparency work with your patch?
On Mon, Nov 27, 2017 at 5:35 PM, Carl Eugen Hoyos
wrote:
> 2017-11-27 19:30 GMT+01:00 Bjorn Roche :
> >
>
> > The only way I can see is to move some functionality between the mixer
> and
> > the encoder. It's not a clear line between the codec and the container
On Mon, Nov 27, 2017 at 5:41 PM, Carl Eugen Hoyos
wrote:
> 2017-11-27 18:50 GMT+01:00 Bjorn Roche :
> > Sorry for the very delayed response, Carl:
> >
> > On Tue, Nov 21, 2017 at 6:55 PM, Carl Eugen Hoyos
> > wrote:
> >
> >> 2017-11-21 18:53
Thanks Moritz and Carl for your help with fate. This email was stuck in my
drafts :(
Comments below:
On Fri, Nov 3, 2017 at 8:11 PM, Carl Eugen Hoyos wrote:
> 2017-10-24 18:40 GMT+02:00 Bjorn Roche :
>
> > - I don’t know if/how to update the FATE tests.
>
> A quick way (that
Sorry for the very delayed response, Carl:
On Tue, Nov 21, 2017 at 6:55 PM, Carl Eugen Hoyos
wrote:
> 2017-11-21 18:53 GMT+01:00 Bjorn Roche :
> > Support for transparencies in animated gifs requires modifying both
> > libavcodec/gif.c and libavformat/gif.c because both the graph
> - I don’t know if/how to update the FATE tests.
Can anyone comment on this? Do I update the tests in the same patch or
separate that?
--
Bjorn Roche
Sr. Video Pipeline Engineer
bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-de
On Sat, Oct 28, 2017 at 11:18 AM, Clément Bœsch wrote:
> On Mon, Oct 23, 2017 at 07:12:57PM -0400, Bjorn Roche wrote:
> > This patch enables paletteuse to identify the transparency in incoming
> > video and tag transparent pixels on outgoing video with the correct
> > i
On Thu, Oct 26, 2017 at 11:21 AM, Carl Eugen Hoyos
wrote:
> 2017-10-26 17:16 GMT+02:00 Bjorn Roche :
> > Hey there,
> >
> > Has anyone been working on this ticket: https://trac.ffmpeg.org/
> ticket/4907
>
> Given that the ticket has seen no activity for two y
s a problem with the codec or the muxer? Is something wrong with the
underlying library? Which files should I look at first? Any idea/guess
about what the problem might be?
Thanks so much!
bjorn
--
Bjorn Roche
Sr. Video Pipeline Engineer
bj...@giphy.com
__
On Tue, Oct 24, 2017 at 8:56 PM, Michael Niedermayer wrote:
> On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote:
> > Support for transparencies in animated gifs requires modifying both
> > libavcodec/gif.c and libavformat/gif.c because both the graphics
> > contr
On Tue, Oct 24, 2017 at 4:24 PM, Carl Eugen Hoyos
wrote:
> 2017-10-24 18:40 GMT+02:00 Bjorn Roche :
>
> > This patch assumes paletteuse has already been patched to support
> > transparency. (e.g. lavfi/paletteuse: fix to support transparency)
>
> Which should - imo - be
On Mon, Oct 23, 2017 at 7:17 PM, Bjorn Roche wrote:
> On Sat, Oct 21, 2017 at 4:00 PM, Clément Bœsch wrote:
>
>> On Sat, Oct 21, 2017 at 09:47:47PM +0200, Carl Eugen Hoyos wrote:
>> > 2017-10-21 21:43 GMT+02:00 Clément Bœsch :
>> > > On Sat, Oct 21, 2017 at 0
Support for transparencies in animated gifs requires modifying both
libavcodec/gif.c and libavformat/gif.c because both the graphics
control extension (handled by libavformat/gif.c) and the raw frame data
(handled by libavcodec/gif.c) must be changed. This is because
transparencies in GIF can be us
eant to be used for the frame-diff system it could become a
> problem.
>
There is a bug in the GIF encoder. I have a fix for that issue as well.
In the meantime, I have submitted another patch to address the concerns
that are specific to this fix.
bjorn
--
Bjorn Roche
Sr. Video Pipeline Engineer
bj...@giphy.com
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This patch enables paletteuse to identify the transparency in incoming
video and tag transparent pixels on outgoing video with the correct
index from the palette.
This requires tracking the transparency index in the palette,
establishing an alpha threshold below which a pixel is considered
transpa
The palettes generated by palettegen include one transparent color.
This patch enables paletteuse to identify the transparency in incoming
video and tag transparent pixels on outgoing video.
This requires tracking the transparency index in the palette,
establishing an alpha threshold below which a
On Tue, Oct 17, 2017 at 5:27 PM, Carl Eugen Hoyos
wrote:
> 2017-10-17 3:16 GMT+02:00 Carl Eugen Hoyos :
> > 2017-10-10 23:41 GMT+02:00 Bjorn Roche :
> >
> >> +{ "trans_threshold", "set the threshold for alpha values avoce
> which they are consider
On Mon, Oct 16, 2017 at 9:16 PM, Carl Eugen Hoyos
wrote:
> 2017-10-10 23:41 GMT+02:00 Bjorn Roche :
>
> > +{ "trans_threshold", "set the threshold for alpha values avoce
> which they are considered completely opaque", OFFSET(trans_thresh),
> AV_OPT_
The pallettes generated by palettegen include one transparent color.
This patch enables paletteuse to identify the transparency in incoming
video and tag transparent pixels on outgoing video.
This requires tracking the transparency index in the palette,
establishing an alpha threshold below which
On Tue, Oct 10, 2017 at 5:56 PM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> On 10/10/2017 10:41 PM, Bjorn Roche wrote:
> > Partial fix for https://trac.ffmpeg.org/ticket/4443
> > (Animated GIFs are incorrectly optimized, so they still won’t be
Partial fix for https://trac.ffmpeg.org/ticket/4443
(Animated GIFs are incorrectly optimized, so they still won’t be output
correctly).
---
libavfilter/vf_paletteuse.c | 210
1 file changed, 132 insertions(+), 78 deletions(-)
diff --git a/libavfilter/v
On Sat, Oct 7, 2017 at 9:53 AM, Carl Eugen Hoyos wrote:
> 2017-10-06 23:23 GMT+02:00 Carl Eugen Hoyos :
> > 2017-10-06 22:59 GMT+02:00 Bjorn Roche :
> >
> >> libavfilter/vf_paletteuse.c | 175
> >
> > Works fine for me
>
> I had tested with the sample
ot;
> >
>
> Sorry, "lavfi", not "lavf".
>
> Also, can you add the trac ticket reference for this?
>
>
Do you mean this bug?
https://trac.ffmpeg.org/ticket/4443
I'm not sure I consider this a fix, since animated gifs
On Sat, Oct 7, 2017 at 7:48 AM, Clément Bœsch wrote:
> > Subject: Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support
> transparency
>
> "lavf/paletteuse: add support for transparency"
>
> On Fri, Oct 06, 2017 at 04:59:55PM -0400, Bjorn Roche wrote:
>
On Fri, Oct 6, 2017 at 5:23 PM, Carl Eugen Hoyos wrote:
> 2017-10-06 22:59 GMT+02:00 Bjorn Roche :
>
> > libavfilter/vf_paletteuse.c | 175
>
> Works fine for me, passes fate, needs a review from Clément.
>
> Do you think an option to set the value of the transparent
&g
e on Mac O
SX 10.11.6 with Apple LLVM version 8.0.0
> (clang-800.0.42.1).
>
I see this too. Did not see it a few days ago.
OS X 10.12.6
Apple LLVM version 9.0.0 (clang-900.0.37)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
--
Bjorn Roche
---
libavfilter/vf_paletteuse.c | 175
1 file changed, 112 insertions(+), 63 deletions(-)
diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c
index ffd37bf1da..4203543843 100644
--- a/libavfilter/vf_paletteuse.c
+++ b/libavfilter/vf_
On Wed, Oct 4, 2017 at 2:50 AM, Clément Bœsch wrote:
> On Mon, Oct 02, 2017 at 01:24:32PM -0400, Bjorn Roche wrote:
> [...]
> > Bjorn Roche (7):
> > First pass at fixing paletteuse
> > Fix for dithering.
> > Removing some debugging
> > First pass at
On Tue, Oct 3, 2017 at 4:02 AM, Carl Eugen Hoyos wrote:
> 2017-10-03 1:52 GMT+02:00 Bjorn Roche :
>
> > Attached is a patch for paletteuse only.
>
> I tested the following with and without your patch:
> $ ffmpeg -i fate-suite/lena.pnm -vf palettegen pal.png
> $ ffmpeg -
On Mon, Oct 2, 2017 at 4:19 PM, Carl Eugen Hoyos wrote:
> 2017-10-02 20:44 GMT+02:00 Bjorn Roche :
> > I submitted a complete patch separately
>
> No.
>
> What I wrote in my last email was (please
> do not top-post here):
> >> Instead please merge your paletteu
I submitted a complete patch separately (
http://ffmpeg.org/pipermail/ffmpeg-devel/2017-September/216793.html), but
this is how git-email formatted things. How would you like me to proceed?
On Mon, Oct 2, 2017 at 2:13 PM, Carl Eugen Hoyos wrote:
> 2017-10-02 19:24 GMT+02:00 Bjorn Ro
From: Bjorn Roche
---
libavcodec/gif.c | 14 +-
libavformat/gif.c | 2 +-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/libavcodec/gif.c b/libavcodec/gif.c
index 3838aa7592..3ced6d4d45 100644
--- a/libavcodec/gif.c
+++ b/libavcodec/gif.c
@@ -265,7 +265,7
From: Bjorn Roche
---
libavcodec/avcodec.h | 6 ++
libavcodec/gif.c | 177 +--
libavformat/gif.c| 16 -
3 files changed, 193 insertions(+), 6 deletions(-)
diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 5c84974e03
addition, the side channel data has to change to support this, so the
automated tests must be updated. I don't know how to do this. I give further
explination of that here:
http://ffmpeg.org/pipermail/ffmpeg-devel/2017-September/216863.html
Bjorn Roche (7):
First pass at fixing paletteuse
From: Bjorn Roche
---
libavcodec/gif.c | 131 +--
1 file changed, 78 insertions(+), 53 deletions(-)
diff --git a/libavcodec/gif.c b/libavcodec/gif.c
index db2193a718..3838aa7592 100644
--- a/libavcodec/gif.c
+++ b/libavcodec/gif.c
@@ -80,7
From: Bjorn Roche
---
libavcodec/gif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/gif.c b/libavcodec/gif.c
index 3ced6d4d45..758e16b83d 100644
--- a/libavcodec/gif.c
+++ b/libavcodec/gif.c
@@ -80,7 +80,7 @@ static int is_image_translucent(AVCodecContext
From: Bjorn Roche
---
libavfilter/vf_paletteuse.c | 65 -
1 file changed, 11 insertions(+), 54 deletions(-)
diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c
index abee1b3735..21870c22f5 100644
--- a/libavfilter/vf_paletteuse.c
From: Bjorn Roche
Dithering doesn’t work, and only iterative and brute force color
mapping work.
---
libavfilter/vf_paletteuse.c | 265 +++-
1 file changed, 185 insertions(+), 80 deletions(-)
diff --git a/libavfilter/vf_paletteuse.c b/libavfilter
From: Bjorn Roche
---
libavfilter/vf_paletteuse.c | 52 -
1 file changed, 18 insertions(+), 34 deletions(-)
diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c
index e62503c8ea..abee1b3735 100644
--- a/libavfilter/vf_paletteuse.c
On Mon, Sep 25, 2017 at 4:03 PM, Carl Eugen Hoyos
wrote:
> 2017-09-25 20:49 GMT+02:00 Bjorn Roche :
>
> > In the meantime, I've attached the patch if anyone wants to look at it.
>
> Can you explain why you had to patch the gif encoder?
> I thought it is able to encod
On Mon, Sep 25, 2017 at 3:12 PM, James Almer wrote:
> On 9/25/2017 3:49 PM, Bjorn Roche wrote:
> > Hi there,
> >
> > I have a patch for this issue:
> >
> > https://trac.ffmpeg.org/ticket/4443
> >
> > However, when running the automated ("fate&qu
oks like this:
https://ffmpeg.org/ffmpeg-formats.html#framecrc-1. (I don't know what the
S=X. means, so I am not sure what it's telling me has changed, if
anything.)
In the meantime, I've attached the patch if anyone wants to look at it.
bjorn
--
-
Bjorn Roche
b
oking for is a
hint (if anyone has one) about if this is an issue with writing gifs, or if
I've still got something wrong in my palettes modifications, or something
else.
Thanks,
bjorn
--
-----
Bjorn Roche
bjornroche.com
@
55 matches
Mail list logo
