Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-21 Thread Caleb Etemesi
>> Please separate struct renaming into a separate patch Will do in the next patch >> Corresponds to µ_start, right? Not sure what µ_start here relates to, but this is the zero bit plane information in *B.10.5* of the jpeg2000 spec (ITU Rec. T.800 (06/2019)) >> Could also be called Lcup and

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-09 Thread Caleb Etemesi
On Fri, 9 Sept 2022, 19:52 Caleb Etemesi, wrote: > Will address in the next iteration > > On Fri, 9 Sept 2022, 18:46 Michael Niedermayer, > wrote: > >> On Thu, Sep 08, 2022 at 11:49:53PM +0300, etemesica...@gmail.com wrote: >> > From: caleb >

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-10 Thread Caleb Etemesi
oughts? For the circular reference, I forgot about inclusion guards, sorry about that. Regards, Caleb On Sat, Sep 10, 2022 at 12:34 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Caleb Etemesi: > >> This is unneeded for the encoder > >> mayb

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-09 Thread Caleb Etemesi
Will address in the next iteration On Fri, 9 Sept 2022, 18:46 Michael Niedermayer, wrote: > On Thu, Sep 08, 2022 at 11:49:53PM +0300, etemesica...@gmail.com wrote: > > From: caleb > > > > Rebased this patch on master branch > > --- > > libavcodec/Makefile|2 +- > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-22 Thread Caleb Etemesi
M Tomas Härdin wrote: > tor 2022-09-22 klockan 07:07 +0300 skrev Caleb Etemesi: > > There is one with way better performance on its way, especially with > > images > > with magnitude refinement passes. > > > > here @https://github.com/etemesi254/FFmpeg/tree/my-p

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000: Add support for High-Throughput JPEG 2000 (HTJ2K) decoding.

2022-09-21 Thread Caleb Etemesi
There is one with way better performance on its way, especially with images with magnitude refinement passes. here @https://github.com/etemesi254/FFmpeg/tree/my-profile And the associated runtime profile from running `perf record -g -F 999 ./ffmpeg_g -i ~/jpeg2000/meridian.ht.j2c -v 32

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-08-07 Thread Caleb Etemesi
Also apologies for a really late reply, Still learning about mail threads Kind regards. Caleb On Sun, 7 Aug 2022, 22:51 Michael Niedermayer, wrote: > On Sun, Aug 07, 2022 at 07:46:51PM +0300, Caleb Etemesi wrote: > > caleb is fine. > > ok will apply > > thx > > [..

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: Fast fail if HTJ2K codeblocks are present.

2022-08-07 Thread Caleb Etemesi
caleb is fine. On Sat, May 7, 2022 at 11:35 AM Michael Niedermayer wrote: > Hi > > before applying this > > Author: caleb > > If you want your full name there please resend this with your full name > so its in git with your full name. It cannot be > changed later if its pushed like this > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Add support for HTJ2K decoding.

2022-12-02 Thread Caleb Etemesi
Hi For bit-reading, 1. The spec has some chunks read from back to front,I didn't see that functionality present in get_bits.h(which I assumed contained the bit reading API). 2. It doesn't handle unstuffing correctly. 3. Doesn't handle EOB correctly, the spec has some arrays when there are no more

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Add support for HTJ2K decoding.

2022-12-02 Thread Caleb Etemesi
Also thanks for reviewing On Fri, Dec 2, 2022 at 10:34 PM Caleb Etemesi wrote: > Hi > > For bit-reading, > 1. The spec has some chunks read from back to front,I didn't see that > functionality present in get_bits.h(which I assumed contained the bit > reading API). >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Add support for High Throughput HTJ2K decoding.

2022-12-16 Thread Caleb Etemesi
> > -cblk->coord[1][1] - > cblk->coord[1][0], > > -bandpos, comp->roi_shift); > > + > > +if (s->is_htj2k) > > +ret = ff_jpe

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Move decoder structs to header files.

2023-02-21 Thread Caleb Etemesi
Ping on this On Fri, 6 Jan 2023, 18:46 Tomas Härdin, wrote: > ons 2022-12-28 klockan 23:20 +0300 skrev etemesica...@gmail.com: > > From: caleb > > > > --- > > libavcodec/jpeg2000dec.c | 88 +--- > > libavcodec/jpeg2000dec.h | 121 > >

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/mjpegdec: fix non-subsampled RGB JPEGs

2023-04-20 Thread Caleb Etemesi
if the problem you are trying to solve is upsampling, the agreed samples are usually 422,444 and 420 (Y,Cb,Cr order) but there can be files with sampling factors like 242, since the jfif spec isn't to restrictive on what sampling factors are allowed,libjpeg(and it's cousin libjpeg-turbo) support

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000htdec: Check for invalid magref length.

2023-06-07 Thread Caleb Etemesi
will send updated patch with changes in a few On Tue, 6 Jun 2023, 19:20 James Almer, wrote: > On 6/5/2023 3:04 PM, etemesica...@gmail.com wrote: > > From: caleb > > > > --- > > libavcodec/jpeg2000htdec.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Caleb Etemesi
Looks good, for the other two, I may need to check with a problematic sample I had to see if it works Kind regards, Caleb Etemesi On Thu, 3 Aug 2023, 23:58 Pierre-Anthony Lemieux, wrote: > On Thu, Aug 3, 2023 at 1:50 PM Tomas Härdin wrote: > > > > tor 2023-08-03 klockan 17

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000htdec: Check for invalid magref length.

2023-06-19 Thread Caleb Etemesi
Ping on this? On Wed, Jun 7, 2023 at 10:35 AM wrote: > From: caleb > > --- > libavcodec/jpeg2000htdec.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/jpeg2000htdec.c b/libavcodec/jpeg2000htdec.c > index 51cd96e0f1..4c4e54710d 100644 >